From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1472CC35274 for ; Tue, 19 Dec 2023 01:46:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BDB46B0074; Mon, 18 Dec 2023 20:46:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 66E146B0078; Mon, 18 Dec 2023 20:46:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55C6E6B007B; Mon, 18 Dec 2023 20:46:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 482626B0074 for ; Mon, 18 Dec 2023 20:46:26 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 168B51C137A for ; Tue, 19 Dec 2023 01:46:26 +0000 (UTC) X-FDA: 81581877972.06.95A94B9 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) by imf14.hostedemail.com (Postfix) with ESMTP id 2B771100012 for ; Tue, 19 Dec 2023 01:46:23 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=QRLUDXo8; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702950384; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5dSq+xskUzFPW1/3n5Hbgu39SffXVNAv8XTfz69lcCQ=; b=nUxzInrhu3B7jPbEwsEa0cBwmdPaIlbcA77yrqY/NMi62bZ/7c0SQgvqTgbH5W+fzTX9Yz KJp9InC4ZRRJM1IYqUKywpg33DI92b4n2fhGtTZN0m+qFhk/vunI8z1wzuqDoZmSeZ1huY i0oo0culYOlh/xJDDgiGn+hykAk9xP0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=QRLUDXo8; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702950384; a=rsa-sha256; cv=none; b=F2HmDYxeg+X+9fT0plp2C++FmbSZS74qTFVPCvckDHvgBqJ0fH/dMnwu+LjXha/FKJUMtE OlLamiCJ4614lfemZufl33REQMIzgCLP6q/Vslje7fgHQCFxFzrJNpNO/4bj306FM6rIE4 e767Y/u19Z1iuZ4+6ym8XZaYk4+dBRE= Date: Mon, 18 Dec 2023 20:46:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1702950382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5dSq+xskUzFPW1/3n5Hbgu39SffXVNAv8XTfz69lcCQ=; b=QRLUDXo8kJiL1Gog5CeF8oYKcr9jV1OIVFaza6OHEb8UDxa+NyQ7dG1QZp7b2WB14ckqUd Y+vw8yTRiTstd53R1q/L+kprd/itBhNn4KDap2f2sfcMc/+YQkVzv1YebOVJI/o5+FISLh /T4mHhnyxlPABPRwqqawGvlqFXWyaG0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Waiman Long Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 19/50] locking/mutex: split out mutex_types.h Message-ID: <20231219014617.dulwl3mdro6zyblt@moria.home.lan> References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216032651.3553101-1-kent.overstreet@linux.dev> <20231216032651.3553101-9-kent.overstreet@linux.dev> <7066c278-28e0-45eb-a046-eb684c4a659c@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7066c278-28e0-45eb-a046-eb684c4a659c@redhat.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2B771100012 X-Stat-Signature: 4xjndwtw8jfnp7i5bfj14n7k6kzogg63 X-HE-Tag: 1702950383-885664 X-HE-Meta: U2FsdGVkX1+w3e66reGqgoSa+Xrn+HQUFvs7FIRXJgwXmdhPHmHeMLfMA+vMt1E1XqpMwg3STjzTWTYhswqAfLismAsWxt/kebYmmLSXI2WYFc4Txv/8NFCQohVurUiIv4U4iDuMYMz0mrvFdxT+UKUd4QW3K4fs0tGQD0c7QmhIG83YCFIGh6m4fSQfJF5rVeIr2jTNWg+EfbtT+UJvAxV8fhhaWsgcq3UUVypqKCJ7xvh3dMPSTposeWHQFMmA8jtAMuq/yhRm8KWsSe4kA+ev11rGbJgWiDLXXppE610m3GTuhVxSPlTcKlrAhCOiC6E0UQgaBNk1OxehVJyU1Up+KchWr8rhjfwMfW2Xzq3E84apPBDUVyDPNVyFKCN4WOwHhvOPzaWalp5sCjQ2AjceoFdF+sjpCkXiiSwm4K6aJaxYzVnXk/gMTZSepappDowEXQSC4jieK/1c0UuW/Mm8DC8OYsLzNAbnK+NnWhxz9rohbM2evcoSgGfD9G1koVm9blaCTFs8SrFC9JJQ5gxYFVFHn3iNaU3+mXTZ0WWAK/aJa0CwlH6MpyvyUgGcWqdjJWcBZpfNHAV/sfri1u/6xVK0VU1zSPaf0hTXLT9GFVSDFvZ4v9bqAhrD/465jAurKCYSIMqR70WajW2LBIK/FDG9Rex5mWg0/ldflb+wp3rMV4HKC9tjYpttn7g15Fcdjfb25QdHMVryI+W5DRerLQiUkE3VJbAJ9EuMd+CBPL+b9yFzp35upDtnZFDTbRgJ7z7as0/5eN2q+gfzjdKk/vS7QDyn7QBSBD8jGt9jkg7fdA6IE1kEZ8x7wPlLjeucGUTtsplwmplODuQb1KX0jH0W7Vk1NfdB0+u5PPBEyVVEXkREpQIgC8PEvDkPmwdGLxUcecBspGPjVJpZEEG7lSAUdGIPvDhX9G/lHWDukOY4kd2OgmzDbxlYfYFNVqP0jweOtXPbpiNmu9r Qq981Vm7 Zp6+jzR/xbdvkLrdSGrGsbf3TGksS6TXFb5DUmEHaN3xNbVR+uI9o5MD/utOyudgeDLBBT8Izw4peyz0FAFMHi69ysAa5ERGQGIod2eSnru6qHhtE62YzE6FvIDGGQlmwe4usWj0YxQNdhBK0+78bDVyIviawrljzNqBYGeqczy1cKBQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 18, 2023 at 11:53:08AM -0500, Waiman Long wrote: > On 12/15/23 22:26, Kent Overstreet wrote: > > -#include > > Including rtmutex.h here means that mutex_types.h is no longer a simple > header for types only. So unless you also break out a rtmutex_types.h, it is > inconsistent. good observation, I'll have to leave it for the next round of cleanups though since the merge window is approaching and I'll have to redo all the testing. > Besides, the kernel/sched code does use mutex_lock/unlock calls quite > frequently. With this patch, mutex.h will not be directly included. I > suspect that it is indirectly included via other header files. This may be > an issue with some configurations. I've now put it through randconfig testing on every arch that debian includes a compiler for (excluding sh and xtensa, which throw internal compiler errors) and that one hasn't come up yet. could still be included indirectly though - I haven't checked for that one specifically yet.