From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D25A1C46CCD for ; Mon, 18 Dec 2023 11:00:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 625B66B0082; Mon, 18 Dec 2023 06:00:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D42B6B0087; Mon, 18 Dec 2023 06:00:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49CE66B0088; Mon, 18 Dec 2023 06:00:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 347CC6B0082 for ; Mon, 18 Dec 2023 06:00:06 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0E3841C1249 for ; Mon, 18 Dec 2023 11:00:06 +0000 (UTC) X-FDA: 81579644412.07.CFCA450 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by imf16.hostedemail.com (Postfix) with ESMTP id 03900180015 for ; Mon, 18 Dec 2023 11:00:02 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kroah.com header.s=fm2 header.b=WilBptd2; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=wriK9Y1+; dmarc=pass (policy=none) header.from=kroah.com; spf=pass (imf16.hostedemail.com: domain of greg@kroah.com designates 66.111.4.26 as permitted sender) smtp.mailfrom=greg@kroah.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702897203; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DhJuFyKeI5xdQm8Pua0VofKhhE351ohYbJVIzzUIEi4=; b=Q6ZguCCXUbsOsS0juv8TceEXF4M7DY7wmrO7kc90StpBz3nTQsoUsgz3DIo5K92NbMrVqx /32ukJTthdw203LjThrK9MYXnOPtcQ4JE4jGoHyoEuOnYK7RVLIFSm1QXjZKpCqDfYnolT VdaQvdP1Bt3CZWQzQA+j8sAEQB7yvQ8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kroah.com header.s=fm2 header.b=WilBptd2; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=wriK9Y1+; dmarc=pass (policy=none) header.from=kroah.com; spf=pass (imf16.hostedemail.com: domain of greg@kroah.com designates 66.111.4.26 as permitted sender) smtp.mailfrom=greg@kroah.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702897203; a=rsa-sha256; cv=none; b=aVBJm/Qs/0Sd0B9JVr0y6sqaqyxyVmNW6xUlW3LaXmPYXa23B+kws0F1wfV8tj8fjrZa7s HxEtdkof3Juge5b/Y+GMaqOLALGkgZLrpAdyjMq6Co4lsgf/WPlqnefwV7dyfn2hAS5yOK bEbgdrHGBUtRcKnGOTkntyjtdriiFzA= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id AAB6D5C0109; Mon, 18 Dec 2023 06:00:00 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 18 Dec 2023 06:00:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1702897200; x=1702983600; bh=DhJuFyKeI5 xdQm8Pua0VofKhhE351ohYbJVIzzUIEi4=; b=WilBptd2KY3wYkNR+dcC6HKzBF M/iKlNojY1Zo3MIWsFUsnce6zS9ZGLHV0SgfmaDAMoOk8CnRuvgw+rO2Kgg5GZ5k D454PbdqLMmv+zwXodoO+q9xWo2QFpKpLyjjK1SbWAa3SfY8POAJdjEthSQ0Afs3 a2UtpzIuoHNk+9TTMUaH4D+kXAKZYQgCcM0DTf6Olu6ynvaKd7/xxELRGf82nlur ny0ITnHI+9UDAdtR5Shhj8iIxVZ4B9bNB9ck3p9lEkqf9x8IW5rYNfR4aPP2cWsD EEc3qgu7r1DNra1s0fKMXnNUMupZmsv7C2BahG+WgeRbNyyfsNzaLJRwIqig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1702897200; x=1702983600; bh=DhJuFyKeI5xdQm8Pua0VofKhhE35 1ohYbJVIzzUIEi4=; b=wriK9Y1+6TAMgj5hg6iJd4T4zEJfpkCsRvlp+3Zwnd7c ds9bJ2Qpy2QOn8AGgkWK7E5B7ZHkuUgoyoIR1Gym1baSNbuRa41VmVYF4jPNn+up EbG8WBPHR6e9NlNOIKSzgB4aH90iYz8fHvnCOLEhinq/VNfMFykUZtlLHyNOWaOI DhmqnJr8+Q/JetrYRD/0Nuvr4Uo2thl52CVrkYUpcfHCHTQPawon0uZYLRLjF1/g akUM5d3iqKhVa6laulVol+P0GOsfSA8ze0p+29+BL4iYoPefzQGZElEEGVitJXtD vQ07ezINcpdTHNqPkaCOYs/MvK4pOqy0Wq5I5IrinA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtkedgvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepheegvd evvdeljeeugfdtudduhfekledtiefhveejkeejuefhtdeufefhgfehkeetnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Dec 2023 05:59:59 -0500 (EST) Date: Mon, 18 Dec 2023 11:59:58 +0100 From: Greg KH To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, maple-tree@lists.infradead.org, akpm@linux-foundation.org, willy@infradead.org, liam.howlett@oracle.com, zhangpeng.00@bytedance.com, stable@vger.kernel.org Subject: Re: [PATCH 6.6.y] maple_tree: do not preallocate nodes for slot stores Message-ID: <2023121847-cope-surviving-26bf@gregkh> References: <20231212195255.219624-1-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231212195255.219624-1-sidhartha.kumar@oracle.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 03900180015 X-Stat-Signature: m937y5qqfoodayd818b87up6p4sbir46 X-HE-Tag: 1702897202-329496 X-HE-Meta: U2FsdGVkX18y1Fy3rzkLSRi9Zc1ujHkREgneUXrSr6pJJSaBGMuuO45qsxVAifoje8fAbgnNomnFfCkQNG/YMhw++CwJ3Yi18R+J0YsSv00+Y0eiBW4tUYpLBS3MDtH/2iT2tMiXT1w5+COg45MBTCwvphj6sRIeoZM8E9JFAgJf29kpezW8pqjXBtbbcvdpTHNuxcakpTzq9NGZdFsUPj41cKcI+gQjMkubzeTd9mAuDBx5Buhm6H5icWBXk6Gur24XsjbHTBGTsAXtfFgJ4ecOYscBoCVR0XjwDuS1vaaDVC6Clqa9GVk6IaiO9GWO3kmDnypOwOR9zIqzWclQPZnKJO5WB5HRky8PLwCd4BjF7zls/XaFNqL9zs0xEstccyiugO02g5kMd2T1WqcO2dn9tpddScmrApT18dMNKFPxGBIcd/nxAre2fZo7ZwvYcxJ4cBG6P1YMdVRmNviK358aXUpIkc+M1n6EzlkPBVfdTrQsZdfrEpwHDWM7ic+Vw6Z7AoUiuswd0WlXmScnpgnUFOpriZ0jaOYMJUFk3l+MlJqjtOPUkmF705un5Vt/hzJ/9uW1GD7t0TXOdx169du1Ayh5WSOLl1KpHfSA6kpY09nnOVgU+MkxV/DxFHPT/vzAx+ECP+U4KvWkXqou5RL1Szfubrrb7baraX9DAKH3K6FVBNc0caprt6qX2tsfBCtIKqjmGLOlHoQDJJokjTQw0WUMWn0JYo/eq9z8O/Z44YtmWtIqm75TUEef41HF8Hq07FjN6WogjrHzzxYZrzNAPzxLL9wobjTRNc6L/fta7G1hkjJrdi2BJbHS2oM0mjtJy2+Wpk4CP5Xz2UgEZD/Ls+9B9iJ0oct+nPiCyedBw8U9lt01DRHAeBXdDSVFagM7JhFqmNFu88t7vFJ/lYXY6yOhMR5YVKjslvsfi1z2Kd/l/6V7DUPd8Fe3SCwTCNlif4r+8YPSSybNSVt m7IoDkMZ EVsTmHLZ4BIwAoD1UFU/yl16zDN1+SfoiNLZPZl2JCDkN4M0rMNU0bY77IDiVJ8loRkCsADHDwm0nkgWmNEIXEKem5Tev4zWtl0BrL35gCK53KXWWrCvct7WRUjoqQfYzazzCEKqr99b9CNnA8lCfk/Nacq/bsrjk5uL6QN/1SYdehpvmOgAPtFFW2p8lJTXIM6IDnRgOsYCdnjqIqU9caDgi5+iaI9D0wXJFckNDHCDNXTG6F9mK80KT5K5e18Jlkdqu39eDPholyzftYA7CX83YHotawk/0dT2gw9YDtBBYWXwnzlYoUD+W7qTekwIESy3zhZiMFj06ZNWmwJ5T2mHhjSEXktZFwbiaRzBrOwJYY22+gGyBq7zX8A87PKPcCk54i+krbWYfNl8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 12, 2023 at 11:52:55AM -0800, Sidhartha Kumar wrote: > mas_preallocate() defaults to requesting 1 node for preallocation and then > ,depending on the type of store, will update the request variable. There > isn't a check for a slot store type, so slot stores are preallocating the > default 1 node. Slot stores do not require any additional nodes, so add a > check for the slot store case that will bypass node_count_gfp(). Update > the tests to reflect that slot stores do not require allocations. > > User visible effects of this bug include increased memory usage from the > unneeded node that was allocated. > > Fixes: 0b8bb544b1a7 ("maple_tree: update mas_preallocate() testing") > Cc: # 6.6+ > Signed-off-by: Sidhartha Kumar > --- > This is a modified backport as the patch to fix this in upstream does not > apply to 6.6 because the node_end field was moved from the ma_wr_state to > the ma_state after 6.6. What is the git commit id of this change in Linus's tree? thanks, greg k-h