From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C865BC35274 for ; Mon, 18 Dec 2023 14:45:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62E746B007E; Mon, 18 Dec 2023 09:45:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DE126B0089; Mon, 18 Dec 2023 09:45:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47E5D6B008C; Mon, 18 Dec 2023 09:45:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 346E56B007E for ; Mon, 18 Dec 2023 09:45:33 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 03ADD80792 for ; Mon, 18 Dec 2023 14:45:32 +0000 (UTC) X-FDA: 81580212546.01.5133831 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by imf10.hostedemail.com (Postfix) with ESMTP id 9DBD3C001B for ; Mon, 18 Dec 2023 14:45:30 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fUvM0aSF; spf=pass (imf10.hostedemail.com: domain of lkp@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702910731; a=rsa-sha256; cv=none; b=WMDf1ShuFU8rFhlvPsT9FaC4x+dN81ihSQhIL++hhMbueQ3AiZFT80pCc66Y23MMTrSy84 iOyGUSO+I7anIrG+k9BG1AmU3mY+RMmp2JiDnxSPMCkX5JbUIgDPif/lcKw6SEksUP5baO zYlgHfeRuzJQdSbJhfzF7aXvGhbRUyk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fUvM0aSF; spf=pass (imf10.hostedemail.com: domain of lkp@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702910731; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=Osb8kDzkRaxdUaf+yMwE1R/JiD7anYUeuOTpiN+BvDU=; b=MWqhW+mZBrthuZ4RmsTxgZypzNhnutXVt5XUL6VagN59FGhMVRHuIBDbo8sRdJUaMCBqJT NFVfF7TiOlEQVy/JBVGC1IPLXqkiOE81ai6FbQyzVN1iEgA0jfzOPmUPlBdbZzKtYgIG+y gpGroRrhn7wnvd3YkM3xIHCZpWqQJwE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702910731; x=1734446731; h=date:from:to:cc:subject:message-id:mime-version; bh=ln3IukuEpuxBWX0S8EkgJAQQfwl4bE3qF9acRnbEcao=; b=fUvM0aSFxvAkjG8YSxwzT9WmiX1616H2ivomnIwksbdPbkzjLnIY26DV Hnr+/I5o8iGeblzPeqkXwmF+9w7l2HQk1XzcvsKqKpcw10eapdJSvOCFe H8aJimLyeRCbVn0AlTAXnnIVA7AoIiNEHn8HTIBcME2RvAc4AWirUWGwo 7MoW+vnTzbaiuKQWN/7MHePFN07FFW0qVvdmdFuoe8b6A9njAFqGVrlX8 jcCf7siekI6bdybJrk0LKT8D7YsiMuWXbvtE1It4e/K2dtBdzuayKmJ2e Y9cDkOee5JgOZogq8TdEZIgPuznOtCnNkPC+VCoHb6kL9eI6YuBrJFlbF w==; X-IronPort-AV: E=McAfee;i="6600,9927,10928"; a="17073140" X-IronPort-AV: E=Sophos;i="6.04,285,1695711600"; d="scan'208";a="17073140" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2023 06:45:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10928"; a="809862271" X-IronPort-AV: E=Sophos;i="6.04,285,1695711600"; d="scan'208";a="809862271" Received: from lkp-server02.sh.intel.com (HELO b07ab15da5fe) ([10.239.97.151]) by orsmga001.jf.intel.com with ESMTP; 18 Dec 2023 06:45:27 -0800 Received: from kbuild by b07ab15da5fe with local (Exim 4.96) (envelope-from ) id 1rFEs1-0004CX-0g; Mon, 18 Dec 2023 14:45:25 +0000 Date: Mon, 18 Dec 2023 22:45:00 +0800 From: kernel test robot To: Yosry Ahmed Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrew Morton Subject: [linux-next:master 8322/9113] mm/zswap.c:644:9: error: too few arguments to function 'mem_cgroup_flush_stats' Message-ID: <202312182206.dlCV0jBv-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9DBD3C001B X-Stat-Signature: zw5mkr83cnaa1sw9pqy3qxzbwcbzofcw X-Rspam-User: X-HE-Tag: 1702910730-340879 X-HE-Meta: U2FsdGVkX19pW4rURSRzO3x8ZgpnhkQaqyjmmwePhAjCebb0c6pTE9u0IIid66ZFJqs8Uy78fBpVT8hSyaVgvb+LL1CoNZa+R4kbtz5uoJZtfArRxJDuRZB0xAPEuM3dChDLLt7+eyrYyoY+X5hm+VtLPcBqQ8TSKBXZwG54EyAd7QOZ8m1NokzCYHEcNaS3NaJaQwd1lXS84+3oMziGIwNCjQUGPcKweYIrZ67E+hhJoq1VhzSKXcIeEgeMdTDV8Wal2r4RANRIrgg7kQzy6pIrPV5CRRWRtlkROtS/gFEx/9sRjcaK5obA03iM9HR2rXKwN9TZIvvZrZKw8Ey8c0cpab/YSZxkGWQg/rIO3fyiGt0+t633nFxEMCPQlRzeu4OQ6muqoJx4LOWE6uGWobw7Lo7eCD9Q8tDsm7DlwwtjHOQZCQtwnWlZIChBuLyNnbOBQyofdcBRa/hgj3BWzdxo2V57+Cqi7fG+ldQQLA5oT6TXZ3EIG8WbyPku+Wq1ixJq4UqBXeGhVrzjZdKdpPjOzTNNxQ1LGSVR81Dw1x+0tw9D4u29+8EZJutdzL1NKL/bQpgrfZj4jNFChgTTNeJDznEHnw88Tpe1tq1mOGu/3Fb/ET2TrBJd3Y6s6w6zRU6L4oe/dE1R5z12jxOrPbJDpL44rM76sxtq6L2CYd/UzTJ1epGmhNiTZiyYxXqIHxogWWmpwtz7JyiyZVqoFLpCZMU3FC8hU3+RJRfVfwORt4k1njzWVAjJdMByCM6ssSxPsA4tLeqK+YppZpD7D+Zfrh5rIUbKqPHclZe8jI49Bhgfc+5mQgGZPEBliz7jMQbspgcjTjHhFVHuEXlhmbt3RM3R1xkAnsZMchMOlk3OuNkwmeGESP00VGHtTqV4cOxxzK6kNIMOtBk642htZe9jpAfbPPpBjuluSMNkdHEre9vAL1cBRJ8BKmLxMeQFY3qBSYFW34nIr6xSraC vK82JEH7 XqjtuVhv7SY7A8OhI+lxwgg5fVUk+KBZrwcRJxkIQsmFWWjPC0aplkSNjae0J/5EDWb8Hoh/8dWu6ocV67GtoQfkB2OJG0o6/+wtgkuEzO4mNhxevxTxPjSxc5Tqc4BKx0wuSFeDj+QMqYGJk6zvKahOP/Q9W1jqudgWVOrhlnkNbllcFjLKj+l8PLBuqiC5O6IETTumFWSYYbjEFc0b5nOJD6HYEMd2p7+3dKNrW8AlGxWoz3sXXj3ppv1bhR6aGkrMMD5z6al7nvQDxPkGWcJqz1KB5+M/5z3aWzCryHc9ABWq458uQ7BlE/DgVg6ecqn+B5rIxR8nmdoIspDZeOYwhbohzpXiq2V1bmruyFYOvWD3SBr0ItzVdfHyNVPTEX0/xGShtXo0Bt3BAjzM+KeHteB4sdcxPLF4ZHkPR/vE6lMZmcWCxJSxAhg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: ceb2fe0d438644e1de06b9a6468a1fb8e2199c70 commit: 3e66d585be0b60d7cbf5cdb391dfeb5452040b5a [8322/9113] mm: memcg: restore subtree stats flushing config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20231218/202312182206.dlCV0jBv-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231218/202312182206.dlCV0jBv-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202312182206.dlCV0jBv-lkp@intel.com/ Note: the linux-next/master HEAD ceb2fe0d438644e1de06b9a6468a1fb8e2199c70 builds fine. It may have been fixed somewhere. All errors (new ones prefixed by >>): mm/zswap.c: In function 'zswap_shrinker_count': >> mm/zswap.c:644:9: error: too few arguments to function 'mem_cgroup_flush_stats' 644 | mem_cgroup_flush_stats(); | ^~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/swap.h:9, from mm/zswap.c:24: include/linux/memcontrol.h:1054:6: note: declared here 1054 | void mem_cgroup_flush_stats(struct mem_cgroup *memcg); | ^~~~~~~~~~~~~~~~~~~~~~ vim +/mem_cgroup_flush_stats +644 mm/zswap.c b5ba474f3f5187 Nhat Pham 2023-11-30 631 b5ba474f3f5187 Nhat Pham 2023-11-30 632 static unsigned long zswap_shrinker_count(struct shrinker *shrinker, b5ba474f3f5187 Nhat Pham 2023-11-30 633 struct shrink_control *sc) b5ba474f3f5187 Nhat Pham 2023-11-30 634 { b5ba474f3f5187 Nhat Pham 2023-11-30 635 struct zswap_pool *pool = shrinker->private_data; b5ba474f3f5187 Nhat Pham 2023-11-30 636 struct mem_cgroup *memcg = sc->memcg; b5ba474f3f5187 Nhat Pham 2023-11-30 637 struct lruvec *lruvec = mem_cgroup_lruvec(memcg, NODE_DATA(sc->nid)); b5ba474f3f5187 Nhat Pham 2023-11-30 638 unsigned long nr_backing, nr_stored, nr_freeable, nr_protected; b5ba474f3f5187 Nhat Pham 2023-11-30 639 b5ba474f3f5187 Nhat Pham 2023-11-30 640 if (!zswap_shrinker_enabled) b5ba474f3f5187 Nhat Pham 2023-11-30 641 return 0; b5ba474f3f5187 Nhat Pham 2023-11-30 642 b5ba474f3f5187 Nhat Pham 2023-11-30 643 #ifdef CONFIG_MEMCG_KMEM b5ba474f3f5187 Nhat Pham 2023-11-30 @644 mem_cgroup_flush_stats(); b5ba474f3f5187 Nhat Pham 2023-11-30 645 nr_backing = memcg_page_state(memcg, MEMCG_ZSWAP_B) >> PAGE_SHIFT; b5ba474f3f5187 Nhat Pham 2023-11-30 646 nr_stored = memcg_page_state(memcg, MEMCG_ZSWAPPED); b5ba474f3f5187 Nhat Pham 2023-11-30 647 #else b5ba474f3f5187 Nhat Pham 2023-11-30 648 /* use pool stats instead of memcg stats */ b5ba474f3f5187 Nhat Pham 2023-11-30 649 nr_backing = get_zswap_pool_size(pool) >> PAGE_SHIFT; b5ba474f3f5187 Nhat Pham 2023-11-30 650 nr_stored = atomic_read(&pool->nr_stored); b5ba474f3f5187 Nhat Pham 2023-11-30 651 #endif b5ba474f3f5187 Nhat Pham 2023-11-30 652 b5ba474f3f5187 Nhat Pham 2023-11-30 653 if (!nr_stored) b5ba474f3f5187 Nhat Pham 2023-11-30 654 return 0; b5ba474f3f5187 Nhat Pham 2023-11-30 655 b5ba474f3f5187 Nhat Pham 2023-11-30 656 nr_protected = b5ba474f3f5187 Nhat Pham 2023-11-30 657 atomic_long_read(&lruvec->zswap_lruvec_state.nr_zswap_protected); b5ba474f3f5187 Nhat Pham 2023-11-30 658 nr_freeable = list_lru_shrink_count(&pool->list_lru, sc); b5ba474f3f5187 Nhat Pham 2023-11-30 659 /* b5ba474f3f5187 Nhat Pham 2023-11-30 660 * Subtract the lru size by an estimate of the number of pages b5ba474f3f5187 Nhat Pham 2023-11-30 661 * that should be protected. b5ba474f3f5187 Nhat Pham 2023-11-30 662 */ b5ba474f3f5187 Nhat Pham 2023-11-30 663 nr_freeable = nr_freeable > nr_protected ? nr_freeable - nr_protected : 0; b5ba474f3f5187 Nhat Pham 2023-11-30 664 b5ba474f3f5187 Nhat Pham 2023-11-30 665 /* b5ba474f3f5187 Nhat Pham 2023-11-30 666 * Scale the number of freeable pages by the memory saving factor. b5ba474f3f5187 Nhat Pham 2023-11-30 667 * This ensures that the better zswap compresses memory, the fewer b5ba474f3f5187 Nhat Pham 2023-11-30 668 * pages we will evict to swap (as it will otherwise incur IO for b5ba474f3f5187 Nhat Pham 2023-11-30 669 * relatively small memory saving). b5ba474f3f5187 Nhat Pham 2023-11-30 670 */ b5ba474f3f5187 Nhat Pham 2023-11-30 671 return mult_frac(nr_freeable, nr_backing, nr_stored); b5ba474f3f5187 Nhat Pham 2023-11-30 672 } b5ba474f3f5187 Nhat Pham 2023-11-30 673 :::::: The code at line 644 was first introduced by commit :::::: b5ba474f3f518701249598b35c581b92a3c95b48 zswap: shrink zswap pool based on memory pressure :::::: TO: Nhat Pham :::::: CC: Andrew Morton -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki