From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5212C46CCD for ; Mon, 18 Dec 2023 13:58:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B626D8D0006; Mon, 18 Dec 2023 08:58:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B12B88D0001; Mon, 18 Dec 2023 08:58:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98C868D0007; Mon, 18 Dec 2023 08:58:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 783DF8D0001 for ; Mon, 18 Dec 2023 08:58:48 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 49618140122 for ; Mon, 18 Dec 2023 13:58:48 +0000 (UTC) X-FDA: 81580094736.23.E04B83D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 8F5C940007 for ; Mon, 18 Dec 2023 13:58:46 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=MRN9fROQ; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702907926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lk4ShxhGVru3Bk7ei2k86xrh9E3OhTWS1/aDPPIk7O8=; b=l+W0RYVeqg6upajLa1/ZGqm4gF7qIzCQJZklo6qMzgGd38uspTCTTVA45y4TDnsod74Yh9 f2/ik2n+pRJvzk3jI0Cw1xTrNhoHmN6fsngvOMHjC7x7fNrj48iQNJ0eJC8FdFheOop0FW l+07hyrZHglqlitqfomsCiSV502zeB4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=MRN9fROQ; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702907926; a=rsa-sha256; cv=none; b=Szl8pgTt/WR8XH8NMhwZxTRR7hG0HavYLcfckVpU3idUIycp84ni2E1tJ9208ZUFk2l5pG 7AIcqqJ/5QnE60OyN+pQX+83aVGJJYLdbUsGu5z7Yr69RrgF/GdSpYFEyKrEbPI7eEEdYj UiEvzpLhPy+MMRq7tUH4C9U3iVMsIWA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=lk4ShxhGVru3Bk7ei2k86xrh9E3OhTWS1/aDPPIk7O8=; b=MRN9fROQ5pLlJRCR4KlgWLhKPg wdR5cGTZGP2N6uvHx24BwIKWTO5Qu4mmAE0Yl8zDP4JcDnWomX3F3XSDI1hTJOwchkpQjljgLaVJP LKJnH8i5pwqcYKW3GiAJsxA8vRrx5anMYlOARSITjSxOB2XvQWc98C2vICOHDCmA9XnVDzXzs8CC6 BjOMaA7g+wU4Xdl/V2XwnGGD1YJnnpoIntlYiyS4+qZwpcgr+trJqf3SHwiLBvImUVNdWVf5Hf8xr 5EDPy15+9WjPSgITT4Mgut90Bl18Wtsiid0W2P3LNv3rL4TJvF1Zf8Wtsr8TB0IPpJN/clCNkaXgc a47ii+Cg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rFE8l-00DtCQ-Hx; Mon, 18 Dec 2023 13:58:39 +0000 From: "Matthew Wilcox (Oracle)" To: Andrew Morton Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, Naoya Horiguchi , Dan Williams , stable@vger.kernel.org Subject: [PATCH 3/3] mm/memory-failure: Cast index to loff_t before shifting it Date: Mon, 18 Dec 2023 13:58:37 +0000 Message-Id: <20231218135837.3310403-4-willy@infradead.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20231218135837.3310403-1-willy@infradead.org> References: <20231218135837.3310403-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 8F5C940007 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 44no3ekqafquyj79g7e3u8gz59qg4u3c X-HE-Tag: 1702907926-231570 X-HE-Meta: U2FsdGVkX1/d3Sjn71fHB3KccLhgoM+Tv0LshOyESqLxuut1np42IKeXNpPCBFJQDVNzziRDiE/L6wCIj1oToYkzQ6pmVs2Q1WQJPaCni8pRrHz4lfPYh4LDf4bNvNWuLo7VoPyvVGG7QD8/S4m4hzcqQz4USw2wA9bWLOKZ2A4l+DeK3kyMFZPXLlHRwYq/Mb3nYv12URcA8XxiB1ix+BJ1ONGy05FgJ1rSjjPB1Og/NWSyKN2AQyFw0X7Jq42DJNa/LECKZ6YHzdTrRvgMY/BtV8aYqxnfKOxnI2QjkC41UhjTnB+6rK+9L6r6eQheQh35NCRSCvamIxRj/RF0CbYl0YqdaIxRMrtPqPqe8bOfjcNU7nP4igP56b7FfA7iquJ5x1GYfY0X3awFGX7xxwRdgrO0kOiiAOVnCQW+CKbA+e+JRFA50ua9+Jo5gHbgjyuwQlqrLJynMmJBfITyoNxA/bfpUIbsld4WwIdMXVFj4fbxRSFyT3f6UmzBxfBP9WFS5aY2L8+RTVanKUz3DkdAQmRJeUVxLZT3j5Y6tIk/QXu7/bsVdfxRCvgP3hw1GCbVwAUiPV9tL7gHBGH85K1gdL6ACcMZjG5TAg/vWFtD5TTzM6ivVLx0RnJ7rMlOXDIiugOsxSp0bIRnvtYnwTIwRVmmwaiP8fD+ElBwlf9QfAsMeO9lalKVplF4vNhljBLC3OGr28SHdMxF66Ny/waajn9tBO7AZe/v0J5TejGIefc2FX19AcjJFMXbEpsEdqbRf2ZJyymvIfqebxfoVhDRuhkjRz/zRuW6WSe+G0dvzFBW0qE9CacFKK8Ik2Zqu/5gRXs+UEeDO3q1hi/0Ci1Hpo9HO3tTGKE8nPhqSmT22XbbuzslMp9XKyOA8hKfGK3mzrGRYvh+lqzrt6t7OO7T6LIPYRbdvYU7aCGYu+ycr7H6c2JRABxSzD8G2qaPyhHqp8a7TVOCN9RuMFi ingTxvIC UInF1dYR//yNBQXcUPh2ElIWJmOsgL11ecSmumnsXimaLidVR0tzEhCi64UCNkjWFlNONlFlduutLHUipmKfrixkZqcsguAat59zHKfVbKxVDs+hjaU0JVoQYtt0TErmUhcFqomgdzN8ldFEb0hXWGzmzYHL05IR58Njt+xF5Px5H+FTOIBozqyGiCtsCWvuv+BG5YAVsogZu/wt3yB3A2RrfTqjgCSbSyWsHdx31N10xjUIDNFZe1ddjcdWICCEzFMYB6LRutNkO0uwvqFH+P7myJKveg0dGrEsH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 32-bit systems, we'll lose the top bits of index because arithmetic will be performed in unsigned long instead of unsigned long long. This affects files over 4GB in size. Fixes: 6100e34b2526 ("mm, memory_failure: Teach memory_failure() about dev_pagemap pages") Cc: stable@vger.kernel.org Signed-off-by: Matthew Wilcox (Oracle) --- mm/memory-failure.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 82e15baabb48..455093f73a70 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1704,7 +1704,7 @@ static void unmap_and_kill(struct list_head *to_kill, unsigned long pfn, * mapping being torn down is communicated in siginfo, see * kill_proc() */ - loff_t start = (index << PAGE_SHIFT) & ~(size - 1); + loff_t start = ((loff_t)index << PAGE_SHIFT) & ~(size - 1); unmap_mapping_range(mapping, start, size, 0); } -- 2.42.0