From: Kartik <kkartik@nvidia.com>
To: <thierry.reding@gmail.com>
Cc: <akpm@linux-foundation.org>, <andy@kernel.org>, <arnd@arndb.de>,
<christophe.jaillet@wanadoo.fr>, <frank.li@vivo.com>,
<jonathanh@nvidia.com>, <keescook@chromium.org>,
<kkartik@nvidia.com>, <linus.walleij@linaro.org>,
<linux-hardening@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>, <linux-tegra@vger.kernel.org>,
<pdeschrijver@nvidia.com>, <petlozup@nvidia.com>,
<pshete@nvidia.com>, <robh@kernel.org>, <stefank@nvidia.com>,
<ulf.hansson@linaro.org>
Subject: Re: [PATCH v7 0/8] soc/tegra: fuse: Add ACPI support
Date: Mon, 18 Dec 2023 16:15:59 +0530 [thread overview]
Message-ID: <20231218104559.3286-1-kkartik@nvidia.com> (raw)
In-Reply-To: <ZXyCOydl9VOfwKp-@orome.fritz.box>
On Fri, 2023-12-15 at 17:43 +0100, Thierry Reding wrote
> On Thu, Dec 14, 2023 at 06:43:47PM +0000, Arnd Bergmann wrote:
> > On Thu, Dec 14, 2023, at 17:08, Thierry Reding wrote:
> > > On Tue, Oct 17, 2023 at 10:53:14AM +0530, Kartik wrote:
> > >> This series of patches add ACPI support for Tegra194 and Tegra234 in
> > >> Tegra fuse and apbmisc drivers. It also adds support for Tegra241
> > >> which uses ACPI boot.
> > >
> > > Applied, thanks.
> >
> > I'm still a bit puzzled by this series, can you provide some more background?
> >
> > Why does an ACPI based system require access to SoC drivers? Shouldn't
> > this all be abstracted by the BIOS in some form so the device drivers
> > can work standalone rather than calling into this driver?
>
> This driver exposes a couple of things such as SoC family and SKU
> information that is not otherwise available. It also exposes FUSE
> data which can be used to calibrate certain devices. Most of the
> region that contains the fuses is in the keep-out, so perhaps they
> aren't needed on Tegra241.
>
> I suppose things like SoC family and such could be exposed differently.
> Not sure if ACPI has other ways to expose that.
>
> Let's see if Kartik can shed some light on this.
>
> Thierry
Hi Thierry, Arnd,
Although the keep-out contains most of the FUSE region. The driver still
expose FUSE data with tegra_fuse_readl(), which can be used by drivers to
get the required calibration data. Hence the reason to add ACPI support.
The keep-out region is only used by nvmem interface, which allows reading the
FUSE data from userspace as well as kernel modules. Currently on Tegra241,
there are no users needing this information via nvmem interface.
Regards,
Kartik
prev parent reply other threads:[~2023-12-18 10:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 5:23 Kartik
2023-10-17 5:23 ` [PATCH v7 1/8] mm/util: Introduce kmemdup_array() Kartik
2023-10-17 5:23 ` [PATCH v7 2/8] soc/tegra: fuse: Use dev_err_probe for probe failures Kartik
2023-10-17 5:23 ` [PATCH v7 3/8] soc/tegra: fuse: Refactor resource mapping Kartik
2023-10-17 5:23 ` [PATCH v7 4/8] soc/tegra: fuse: Add tegra_acpi_init_apbmisc() Kartik
2023-10-17 5:23 ` [PATCH v7 5/8] soc/tegra: fuse: Add function to add lookups Kartik
2023-10-17 5:23 ` [PATCH v7 6/8] soc/tegra: fuse: Add function to print SKU info Kartik
2023-10-17 5:23 ` [PATCH v7 7/8] soc/tegra: fuse: Add ACPI support for Tegra194 and Tegra234 Kartik
2023-10-17 5:23 ` [PATCH v7 8/8] soc/tegra: fuse: Add support for Tegra241 Kartik
2023-12-14 17:08 ` [PATCH v7 0/8] soc/tegra: fuse: Add ACPI support Thierry Reding
2023-12-14 18:43 ` Arnd Bergmann
2023-12-15 16:43 ` Thierry Reding
2023-12-18 10:45 ` Kartik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218104559.3286-1-kkartik@nvidia.com \
--to=kkartik@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=arnd@arndb.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=frank.li@vivo.com \
--cc=jonathanh@nvidia.com \
--cc=keescook@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=petlozup@nvidia.com \
--cc=pshete@nvidia.com \
--cc=robh@kernel.org \
--cc=stefank@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox