From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EADB3C46CA2 for ; Mon, 18 Dec 2023 18:34:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4936B6B00A0; Mon, 18 Dec 2023 13:34:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4425F6B00A1; Mon, 18 Dec 2023 13:34:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30A0D6B00A2; Mon, 18 Dec 2023 13:34:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1C0A06B00A0 for ; Mon, 18 Dec 2023 13:34:57 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E28EB120268 for ; Mon, 18 Dec 2023 18:34:56 +0000 (UTC) X-FDA: 81580790592.16.458BCBF Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf18.hostedemail.com (Postfix) with ESMTP id EB6AB1C0024 for ; Mon, 18 Dec 2023 18:34:54 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OFAOk4uT; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702924495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zxDpoW0D/ZFWHlH7wYw/CRG+4Ydwmzzbnuab89sUj/I=; b=RvMofkmQgB1rKEGWIb/ryUP0VXv2scJw/+Lvf/FgvzbGDlx68tiHfQJpUtLbzY+z8nUnXn Suphm54nfcOHnB6NXpmqzpC2kXK/AVP+2zK7jllDO+T8ICy4HEqqhM0W0gmN6pPVpx9ebq TyezWZBz6TdkAVq5SVccXrHL4cVXJD8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702924495; a=rsa-sha256; cv=none; b=uYKp0RnP4oomYZgtFmO18ZzPaFbz1QCqhdpYH/GkP5Gqk5fhbmJLCunKH54mCiq1+hyo5M e1KoWlR7zkFvi9+s3D49IH6x+yVv9sTHwFm896Y9F8i6ga3luYA6fTVr8uOD4VCaqyNVXA 3uYpP3R6aUqIxHTWPIvBOXHfrr9Vq9M= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OFAOk4uT; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 62AECB810A4; Mon, 18 Dec 2023 18:34:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A66AC433C9; Mon, 18 Dec 2023 18:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1702924492; bh=R8E9Jtlsqt8xzpQU+VNhIFpl9LPBRWEq/uhF/vIh4Eg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OFAOk4uTTm7+/sDv5vWackXx3jFb9hlSiNPx58DjPcBfoZm1pAP8qehW+ME1WZhuU L23YLEpa6nZz2T/9m5G/e61D0H9sjy3wK/PA0Va+RWpUb3IhoXCtYwJlDhoBRoW01n i/j1kylwOZENGtXjkzu344j0GPuqVx4hmyNCtbWs= Date: Mon, 18 Dec 2023 10:34:51 -0800 From: Andrew Morton To: Kevin Hao Cc: linux-mm@kvack.org, "Rafael J. Wysocki" , Pavel Machek Subject: Re: [PATCH] mm/khugepaged: Remove unnecessary try_to_freeze() Message-Id: <20231218103451.fd11a2179a01d622cea01858@linux-foundation.org> In-Reply-To: <20231216114341.2281852-1-haokexin@gmail.com> References: <20231216114341.2281852-1-haokexin@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EB6AB1C0024 X-Rspam-User: X-Stat-Signature: g5y8eiipajyjkogb97j5t8xihggksduk X-Rspamd-Server: rspam03 X-HE-Tag: 1702924494-164939 X-HE-Meta: U2FsdGVkX18moz2hdGqWOHgKplmYWHj8ipokzJOIKpNIFUWtLPi58cI3k31Ryf1YDm+VrWjv+ZRVgGuCAxA4s4Du4ncgm2DwqmmVythdXuvYqIU/YdxFI3TAA7Hn671QY5FlAAS9KA0BkQLmbKPMOxytLH/0Sxett6KTTb+oXs+BsRK0mlI3rLKcbgxUFwLxS82nv212YfD0IvgpzZmcK1dZg+W+/KN0D8e7YZoAXbuDSr8d9UUSjbJiJXF8IVY3D2HzM7W2F35XglmZmvi0dsrepg7dXwHOGjF4TAoAh/eCdFKgubxRbtJHP1iC2ZEfqAp6yoIesHsE3nBS+aTe20lyJO7NtNwckxa1kO0zvUuWprFS5ff+wYD/k3oM/6s5J+xr5kJtWs68pktgfwSfYbsW8voPdYetli/wTuSaStfGf7bs4CSHbvTOhcBxA3gVRWH1hBwLXyH09L6dFy8gXdmNVAJ0YtO1JTzZygfov/gaqelv30S8qmuRGZmPS/Z1rqCVMMGuv/VblFT2i2JJRz12A26PNmWMeLq6Sc4LZhA5WfB8ezO6NyHVpZoqUnuSUzaVvgYtv4VlIhHnkrwSSw65PEN74LvfBLDz+E40aosDv6MKRe+qG8g/YMbR1RYqMp/2qMWYLRTPqWOB4gQ0q95lcTCqXvgQwFNIZqo3MGZj6HY7CioXwLZypgArfo54aU8bzE1SGgVxBG6msjcLWMKUXwe8Cko/sjuHm6wgSvNpksjHOo6GTqDuKweLAnqCqreOkbYWCEo3HZYsbA620x3hNihtpJIBrQG7dwRtl2Vsz5qkrJr8Av+0QB558PdC2HLu342HXWO5bxAlLULdr0tbm+bBgzEis0mzo+sHpAfghjGRtzCJzTEisT43SWqO+fgaF2BGT8IFI/z6cin3f8xgStkBI3sDpw+rfUFkyGO81GOBmybF4unAJHJ3LOWljc9Mon1XaTaraveQTdf 7enkPh4z nqVPBYUpALHYz1ppPJFVKn43La6IRYwdyiSis8BR7atPcGp41A2o9fnQxnSJqgwVINftgNXU/K56gXRAyVkNOkNCwyW2lQcIK5c64tZP3TZmOxiXS2OCmFbZWcsLaNzgqvhr40utYvQETAWnEnCsfbu4HSCM8htz/rom82BGIWJ8zUPyBhkDdYvTECliEygJySSczqwFPavsiMooLk4PHa0se8aT26L6zZlTxGNXdPnkUvkFtVe36Nl7Jk9Qn3ec71K/NkXvyZwcR/B8CKYCT2QRd/XfrzuWVedh89J1Z2A5i6CM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 16 Dec 2023 19:43:41 +0800 Kevin Hao wrote: > A freezable kernel thread can enter frozen state during freezing by > either calling try_to_freeze() or using wait_event_freezable() and its > variants. However, there is no need to use both methods simultaneously. > The freezable wait variants have been used in khugepaged_wait_work() > and khugepaged_alloc_sleep(), so remove this unnecessary > try_to_freeze(). > Looks OK to me, but this will increase freezing latencies. How significant is this? Also, we already have a patch from you with this same title. Please try to use different titles for different patches.