From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D54C35274 for ; Mon, 18 Dec 2023 10:24:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 124838D0005; Mon, 18 Dec 2023 05:24:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D5488D0001; Mon, 18 Dec 2023 05:24:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDEC18D0005; Mon, 18 Dec 2023 05:24:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DCAE48D0001 for ; Mon, 18 Dec 2023 05:24:51 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AF649160AEF for ; Mon, 18 Dec 2023 10:24:51 +0000 (UTC) X-FDA: 81579555582.25.AD40A5D Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf15.hostedemail.com (Postfix) with ESMTP id AB5EDA0004 for ; Mon, 18 Dec 2023 10:24:49 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=jyDBqdNM; spf=pass (imf15.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702895090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+qd2C9CoTRT8YdE7RLTwVb7qNN/yqYEkDFQLfrBIgLE=; b=d5ZPN9Pc/mP40T2f8WxLNiKAqyApOyiaAiRAHfr1wzEAeej/JsF4iLn/LxhB3uOmZ5V7lL WD0dqY1XBbnIjN0YiEED2TcncU1IyeOk+rOsY7wv6pZiv0MtJ/cd6xGiyoqi0RZ61oZ5rC xcKN4KjHLetvoOK3LxcB8ifkwH5Dla0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=jyDBqdNM; spf=pass (imf15.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702895090; a=rsa-sha256; cv=none; b=PMKXLWvfElntocrROzMmsVocs9Hp4Hg7r5+kz1m+HmyZKQTOqJ416IvFacSrPLPZ4AZv32 T09BBgBCagwBitvZFbNiMQ+RVAJGImzzvpNquAcp9Ksq7GaNZJ+lbC5OBuqNuf7Qnl4q+2 c2VNm+6/niWrE7y0v9kxA1Sj0fPgxgE= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 8D96440E0030; Mon, 18 Dec 2023 10:24:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VU4bhOjEhgIz; Mon, 18 Dec 2023 10:24:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1702895084; bh=+qd2C9CoTRT8YdE7RLTwVb7qNN/yqYEkDFQLfrBIgLE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jyDBqdNMXR+jZLcCyXJ4YR2GJc9LKFzUfKQU3+hzFPr2OQcmEZmCb/QfiQ9fGD0J9 eQYwFxWWXMCvdmIB+F0qxZDDtmSCXC0qZbY41Wjb2pXH1THKaSUAfgZ58i5kPY7QSL WSWSVpxOHcPCd6xS9yGOuh+n+HxUm53a+/piNO0RL9Zjvu9V7zukW0vt81gfS74Dcx aA0wUPFu+W3LkrEt1Wkc3fLEPFALNemjO22dBaz2Q4T8BrzSeI3Sng4aozUlUX2EEu SaEz5M3ODAere1yfS09GTlW6/kVi5rIfYwk1LD7QVs7lPCFolNwcpGcIOB2HSzfaTV MItf1qGYtHgocHKjCn9euwhsyDZmnBVeKMziA0/hLgGbE9u1G/VD3PToB4mKfWlf4X xxtCVWvGGRgUqIkgt6yT/Ri7odTlfxrE3BL0M94Zk3Eykmmnkm+C+OnN/HG0Gv1sVR I9GjsRFtMrl3xUHXPjp2MZ9curGgNAmGbHh88r3Y9Ec13kZ6HaS+iBgpwvIhDmpiIo i5uFIBoZ/R/BFQVomO/iT/1hireFV74sUd2IBJb95rD/0LsCqfzRzG1Hdc0Bodjwff BEfsF00lawewiDqL8njMUlKG1PHYVIQ7lZulWHIFedIHeyLzkmsUsdx/uARXly9hqc hy9nZw4cu/qb4T4O6GAl8IY0= Received: from zn.tnic (pd95304da.dip0.t-ipconnect.de [217.83.4.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E8A8140E00CB; Mon, 18 Dec 2023 10:24:03 +0000 (UTC) Date: Mon, 18 Dec 2023 11:23:57 +0100 From: Borislav Petkov To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh Subject: Re: [PATCH v10 22/50] KVM: SEV: Add GHCB handling for Hypervisor Feature Support requests Message-ID: <20231218102357.GPZYAdvfG5jNyajyu6@fat_crate.local> References: <20231016132819.1002933-1-michael.roth@amd.com> <20231016132819.1002933-23-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231016132819.1002933-23-michael.roth@amd.com> X-Rspamd-Queue-Id: AB5EDA0004 X-Rspam-User: X-Stat-Signature: wyzd8hnxjgb9j73r1568otfuft41xnsn X-Rspamd-Server: rspam01 X-HE-Tag: 1702895089-688614 X-HE-Meta: U2FsdGVkX1/SMg2W43zCrN8Abn665yyxJVPufaDEWr0qMhkgLv/CdbhvVtHHqYGdT1Ftddml4UiuWqwLN4+T6VAMkp1RmNOzT/GGGFEyFX2jHd0xc5x193Mrlyr/eVbcfQh3XM98ZENFm4rAwxsC0UDA487ADWEUqqbE9YyXeeeZks7wWGVtQaVyO57A8JXR+rFvAxvmc4RNskLaa0xkNhLjA3GMMT6TV+N308yHyLyHlWs/XTR6wpztVYHZtgPc0m6fIolk68VU/huFSIPT0zCRfZEcgq7ZteYza3xRZoeogmjuagt2yswJgC6S7wiYiCo7AaSZhZFy0h1RzcY2si7cOLOCh8mtyf4rAzMw9H5e+4hz0Oc4lHDyWzvNwdAJli7V1O3vqWIQu/FNBYm++LpTuRRJCa6pgzbJKaSutYle0ANYTdY9M0LyinfHlg7jIBLk+RWQ8o7z6GhRs+U3khp39iVoga0rxe2YY3P4JLTAHfl54Up43F0Rj1Ev14OICAb4ryuaDcfxzAw8Usf0KaNkRTBil7Y6IZcaTZ6AwwY2BZTsKw1gwGfdJVHJFwUQIzVzun/WfVbzXv0HfszGDvt5uSiffb1+kKkVDlkWTOReU6Kh4NChQlVzV795vFh8w8BzRVAkIgtsk6gOxV+EClNPLbUDqhvdANZ0NGi8pOubcCwMwASqjuoZ8Jd8k0P94BfkjJiNyAIYLUjLARIVUGNw/xbQWHhNmO2EVsJn7ijyolzq7KWYi9t4yxy/tBZwd6g6Tu6JfXTIEX8iR4FfrH9ITyBXJqTjei7fyaUzrJb1ccu0PWK22iFiBEd171C7IILSdxZAnSBrcHqqSgZ1gRU5FTBZrs2i/D47KEVv1gPeG86RrqfqD3uXJ3EaM1t4QQIO7MdpW2euBtEqRJUibJy9EYXz2mfZxGd1auv5qHof1WOSsh8r2Y4bsY+HS2shW6qZWNnGTO/qCnsTpZS W7eC/fL6 GZn1B31CbX5AKLp6tCUoPfv68fd5CKIP3JBgQtkx96JxL1aknUQA8742FbQ3jkCWfrQqrsgLqATlVozG9f4xS4vvmTrxbZ7kZcTOpE/yJmOTedXT0ImzfZdKiJ07t5CAjDBvApJFmVshomuw1Bh8OzGgBd+VRS+guGiVqZarJO8YM4EeM7bB3tLGTtj62SaXfLQvkxnRa375jJHQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 16, 2023 at 08:27:51AM -0500, Michael Roth wrote: > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c > index 4f895a7201ed..088b32657f46 100644 > --- a/arch/x86/kvm/svm/sev.c > +++ b/arch/x86/kvm/svm/sev.c > @@ -2568,6 +2568,7 @@ static int sev_es_validate_vmgexit(struct vcpu_svm *svm) > case SVM_VMGEXIT_AP_HLT_LOOP: > case SVM_VMGEXIT_AP_JUMP_TABLE: > case SVM_VMGEXIT_UNSUPPORTED_EVENT: > + case SVM_VMGEXIT_HV_FEATURES: > break; > default: > reason = GHCB_ERR_INVALID_EVENT; > @@ -2828,6 +2829,13 @@ static int sev_handle_vmgexit_msr_protocol(struct vcpu_svm *svm) > GHCB_MSR_INFO_MASK, > GHCB_MSR_INFO_POS); > break; > + case GHCB_MSR_HV_FT_REQ: { ^^^ No need to have a statement block here. Neither below. > + set_ghcb_msr_bits(svm, GHCB_HV_FT_SUPPORTED, > + GHCB_MSR_HV_FT_MASK, GHCB_MSR_HV_FT_POS); > + set_ghcb_msr_bits(svm, GHCB_MSR_HV_FT_RESP, > + GHCB_MSR_INFO_MASK, GHCB_MSR_INFO_POS); > + break; > + } > case GHCB_MSR_TERM_REQ: { > u64 reason_set, reason_code; > > @@ -2952,6 +2960,12 @@ int sev_handle_vmgexit(struct kvm_vcpu *vcpu) > ret = 1; > break; > } > + case SVM_VMGEXIT_HV_FEATURES: { ^^^^ > + ghcb_set_sw_exit_info_2(svm->sev_es.ghcb, GHCB_HV_FT_SUPPORTED); > + > + ret = 1; > + break; > + } > case SVM_VMGEXIT_UNSUPPORTED_EVENT: > vcpu_unimpl(vcpu, > "vmgexit: unsupported event - exit_info_1=%#llx, exit_info_2=%#llx\n", -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette