From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56D0FC35274 for ; Mon, 18 Dec 2023 06:54:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6CF96B0087; Mon, 18 Dec 2023 01:54:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E1D496B0088; Mon, 18 Dec 2023 01:54:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE4D96B0089; Mon, 18 Dec 2023 01:54:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BE7E26B0087 for ; Mon, 18 Dec 2023 01:54:19 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 89BD6C0ABC for ; Mon, 18 Dec 2023 06:54:19 +0000 (UTC) X-FDA: 81579025038.14.B03EAA4 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf27.hostedemail.com (Postfix) with ESMTP id 759824000C for ; Mon, 18 Dec 2023 06:54:17 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=TEZZF3xe; spf=pass (imf27.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702882458; a=rsa-sha256; cv=none; b=uvncj55aA8Yxk0pH3VVd3A8Go1fiYxSgMuxUtPSvs51kWP2izDkDXsv6KMGuqCvOVFfICl gU+AdxDf9zreTnDdm1wV1EdZawYG2ODLXoV/2eG8LwEyb2GNoyl+kGlrtEL7dfAj6woNq7 Fe2wRbOoJARxZ+snorPPqhzYYupqK88= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=TEZZF3xe; spf=pass (imf27.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702882458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ooBu2GeZi9lyJ1h1Vz+NcYi3BWhSuP/Z5vNgPFkWa48=; b=CTWd6PqwR90K3nw0ncMz0eQGCzm/oAacsxJeIQoYmZ3pKc4HFcMMmxTGIClKVBGjMqO0+1 G1qVN5MGU1y9ltcvwrlWDgx8DJPQhQPwQrAtF3kj/s5IGZSnPZg/nibstfSpI5AGFDkg1n uNs+V6kLrZhtl+dCf8GOVAg3d8Fee7E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5AE39CE0EE7; Mon, 18 Dec 2023 06:54:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2041BC433C7; Mon, 18 Dec 2023 06:54:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1702882452; bh=AwnwLeZjuA8ssS4thTHCovTIbXMTSmXprhrXHbecjl8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TEZZF3xekE0G2AF/ZrrBlozkVu5GPmdfy2ImhsFGKGa0e3JF7U61gp3gkTBE6zDdL pqjHX0POMD4J9dp7bMHagTdUFtHCkfxIIcfF0CwCySNqqgMWFiwefj0jSLktvXXcrJ FHBo1derxaHMUe6g90afkJyeWSOYDKZzQiAooalY= Date: Mon, 18 Dec 2023 07:54:10 +0100 From: Greg KH To: Shuai Xue Cc: bp@alien8.de, rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, will@kernel.org, jarkko@kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, stable@vger.kernel.org, x86@kernel.org, justin.he@arm.com, ardb@kernel.org, ying.huang@intel.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com Subject: Re: [PATCH v10 3/4] mm: memory-failure: move memory_failure() return value documentation to function declaration Message-ID: <2023121805-wrongness-whinny-8f41@gregkh> References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20231218064521.37324-4-xueshuai@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218064521.37324-4-xueshuai@linux.alibaba.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 759824000C X-Stat-Signature: ic5po5qmbf6g7assadxc7y86wm6z6qo7 X-Rspam-User: X-HE-Tag: 1702882457-128742 X-HE-Meta: U2FsdGVkX18bj0xvpoAelv976g8Z55Adv5grz/s02322hyWau2xcI6AtntmpwDCc+OqxwIDe+snrE7loBt7yU7GCTCk1aRO6mRehxwENkmq3+6HrmklanKxaH8qY/7UZAXeH41NjsOMBIuldeTt1ULd64B6u014cry7agWTgq6ZC1/aqYRpCq/zPvdgL/4qdo6XSaLNEFwGAvcLHbVPTIlBMyXGUfryqQWISpptFfRJI4h3/8zqQLy/bNpC23ljin4Mn/5vy5GmZ8ZRvpmXzlqVbyWua/LsMTwCXHAMt9fVa41bY9ZULXoyX6APhAKyP5iR2KdC5MqlyBTK4hr+M+hnKDP39WUFeq2LsKE3PoUwjWoXTQW1yQ8U6OmwEVWkdgYdLUkJ5vbCop3ewTbzW3w1gnhF1/IM1ZODnkqn7gH25iPKtWDK8x8+399jmN7GGZn8I2qxnPgjGvysO+bjDEePOPy2N35wrHO3Ai/QvCRxs1Pl8PYomDI2vIPghhKJuYl0znrw8yPl7hxHdZhoAxHNPFbnNLPLrVEQ/PYo3vxAyvQJVJEAt0daivd6hdBMcG/bmD4MdIvqo7CWZnwCAkS7i+f0jJdkK+gxyd5/fYe4//4t+VMGAoRxGCByj6Vi3001YKhtzgsyIb+ZukFGcAVS9jhi14YtAj2Kif3PPLh3JaYKYbwlzDxUtkw7B950rQ2wEJCoTDzlYXKM3fLIcPX/z1iN50KAdj88gllndyP0wkAr0P4rSMCd+rYHKlECLGpzRdXVbBcA3lZ84qSCnsL3lIY1ojmpLGyBQcucux+9QlFun1PWhZXbEGeZzAbn2abgYpRAP1DCJyQWYILEtrMlGrsqBxboE/swsPNMtM0zuNU1Nv9t8HboIOVCELkSeu1gvINrJy4AAVqAUSyZIYgJdFMvwINEYghbgxbVJm4YGhELVYgWfhp2XG+8U+SRNI/7x4LHfD6ozUKnWTXB mVlpZJFM 01rY8yHpIX69xsuc/ixK1lJ0Oi4Pj51KhMmgyB/id6WwBDXSQinphn6ubxfLsPeJL50GhLqClNTrn+yHMWmoldeoyWYrcr26pSNq9k2pFEegTEKrc7eGmC1V8SoMee/HM7D8eN5VVPnLgcOme6T7ejvVEFhLav3gFpUWb7ZaMBnegUmBrVj087dDVdG2qagbHVb1WJqsrO5QzIArFshE2cNdBGLLPX4lGLz96YjZ6WcBDVZABnTPa0P1O7czjo+5PKu3k/fJla0kXmhSrfQUdtG7mQK4Luvs2Hz+Yg0knoRBDTImCFAt1SOJakZj+YTYfyQGU6oXvOx18R8Rtb88fpLnF0sTP6oNYpcu69uAlD9gT1C04ZOrqKI+8RWZ8UWhIWJY5RGs01Kz+yEisEcK+4CnDdNLWa9jIhOlU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 18, 2023 at 02:45:20PM +0800, Shuai Xue wrote: > Part of return value comments for memory_failure() were originally > documented at the call site. Move those comments to the function > declaration to improve code readability and to provide developers with > immediate access to function usage and return information. > > Signed-off-by: Shuai Xue > --- > arch/x86/kernel/cpu/mce/core.c | 9 +-------- > mm/memory-failure.c | 9 ++++++--- > 2 files changed, 7 insertions(+), 11 deletions(-) > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.