From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 660B2C35274 for ; Mon, 18 Dec 2023 11:04:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 083076B0085; Mon, 18 Dec 2023 06:04:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 00B236B008C; Mon, 18 Dec 2023 06:04:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E15976B0092; Mon, 18 Dec 2023 06:04:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D31AA6B0089 for ; Mon, 18 Dec 2023 06:04:53 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 66DCEC117D for ; Mon, 18 Dec 2023 11:04:53 +0000 (UTC) X-FDA: 81579656466.19.9CC01E9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id B43C51A0010 for ; Mon, 18 Dec 2023 11:04:51 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="E4Chd/co"; spf=pass (imf19.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702897491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0qV1+gUtWFO+Uqnjw8dewbYrbEMJEJZx6HsAZRCHSCY=; b=f3ofIHOIMn96y3zfDMMkGOEAqOkXtRtyEQjyZj7gcmUctxW7fwBLgCctmxRxDtUJNbv/hM fisLrjTobaghe8BylDmjy3EUonIJvLGYo+HeeugYQU4I2zFf+v0QKNLs0joHPlGAafEF2k 1cuPPu8RuQr3XS0dsl+/NkH719c/1Ek= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="E4Chd/co"; spf=pass (imf19.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702897491; a=rsa-sha256; cv=none; b=pb9I90O5GxDP9sj5Qn04bxf/a7MuhNnJNSLnIIThGzhKyBPW0F4N7FNCx2Q/Irn2r8TY8A TTOHFVVG9GX8TfIV4fZvndnMEi7B6MSv3+m5cI3vxG4HhOVXjQ4Ruz9UDxj/ljQKH+nRSQ TQuesxP22g/yfkGQ8QMoQTuUrSYzFoY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D94E060F23; Mon, 18 Dec 2023 11:04:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74418C433C7; Mon, 18 Dec 2023 11:04:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702897490; bh=X7AmpNy7nTx85EVWdcqkSZ3s+USJadxyg/pD9mVPUtI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E4Chd/co1bkcX+6Ux9mSS5u04qiUN/xoB4/VehY7U+0raPSN2/tLYM3utCFXSEgUj f+QRR+7PbxpcIbcoRVtbfhwaebVDMqmV223WCWOZX7Y/ytdxdqXNCLB+j9qp6kgpwE V1051YmrdFbmAoSQIHyQtO0YQdZvchUcPKVktV7I+ExjCPI3tYEt2oKQtoFPOPnmw7 VL3XE20JLdl/M3FnRxrEI21y+lZ7VJwudVZtV8gXsKwLElwGyPUR+oxRUH6wrKPLtV vQf7A33ZSnwD4sxIOlhzP16izYBUxnFureNgEjznMfsyIw1rO5vjKwvpzJoOiOOysN EbqVN6r0jZyuA== Date: Mon, 18 Dec 2023 12:04:43 +0100 From: Christian Brauner To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, Andy Lutomirski , Will Drewry Subject: Re: [PATCH 22/50] pid: Split out pid_types.h Message-ID: <20231218-weswegen-geleugnet-f8c0d66ca848@brauner> References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216032957.3553313-1-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231216032957.3553313-1-kent.overstreet@linux.dev> X-Rspamd-Queue-Id: B43C51A0010 X-Rspam-User: X-Stat-Signature: zjqe4tftgifnswa8hx11zy4brduzihk5 X-Rspamd-Server: rspam01 X-HE-Tag: 1702897491-738185 X-HE-Meta: U2FsdGVkX18c2nh7XwR0uIZsZmZGmjYN7euRW5J2uZSWRtAwg//6+LnQD4O5CrhVrd93uhWdzJcjohi+A/YBLd7ym5NIAfv6mkIdwbKaDo1o+3iCHN0cJIOA6ALUXBod7Zyqlmpd7XR+khFbbjgl4IyBpiCHmcySSRtxPp2Fckk+6f81MM/ph4C/2bLclxYNxuwIAVkH3Oh31Cdm596MJAErn9gVAUe29bIF8s6HS3ILAGB6AxzfClEn8JgAnffNRvVVLPsA6xPb3U/QB10LPKGmItLnI+mr12qHNpSEVOP6p8k4mHRkeGZx0ozGeKHpWfugUIyEkIgJfvrzBW6FhSAXL5SN6Kdp5LMz7/UTvIvK7MDvWA8tfDHLQr8BXCiYQBW7sEJvyi52GQS5Lw2sXTFZ4Vt8CpMTMN2UZgaJ3kyCO5JALNikQHJiCSDidWphKdA0cXaRR/2w+c+jTSnLzj5hTzBOSbVJpryqvRr9y03CvkuODUjOQiYxUva6POZ92BidSvCMfhTeT3bYqSqlO0XDmtMU1p0Q+RqbZGejuPrpp110kW0fP7rN29lZNZxPu9/mVfQWLICiyvFFwZH+8HcmK4r59Ao5NOITzzJv3g7ZtUPpz8jlAJRy5zEkcT1gsr7E32APTux/IqMYL9M5kV96awlOJLsqYZ7Rbll29LwfV/LDp0FpnbdLGrD3nOVyM8uhapEG6N+hguaXefEOl0WcGsucowrhEickMSrRniq/VuWUvx/DneglXA7hp58+4Vebq/VlBpYzXDKvbHWCnQnFxFgiZsDdHLVnsDqqpjt1Z1UdzSueoiZDGUBdUfm2okaT0mGrFDgQEQpa/2xQYXE4tJC88aQXCU8dtVP67n7G5HvWKmI1CAe9bJU7d7FrKddXKK8PBL504C+x18wHvmxrIH7dfVthToQnH1I5nBmwCdXsOKZEZYXgz0DELBzTrwEd1Xbc3v782Ec071d Ls1wdxya YXinFeM6y7WLj6/Ug05f7KkfTilBdgh+yvwR+Y+oZVokgKiCO0xKd7br+lIft35886RT35WzQ/2HjfnDIFNCQ8wlWU5783jnKPE4qSQ+GOt9nIPMkzG4TNByK9MCEr28A5Ile5UO7b6s46ZAPnBEwCfgF0i3UjZMgbYzdnQh3LfjavTsEbnAneczjyCPIqlt0S90hnbonKNngoQgLk0wgbt0RsByR1IchiSD8uABCHjBG36TkFWdHR06dWrTPNFpkgZLIYnTuvUs/wXsNdIoQhE9FUNLdcOB5KgHozRpHEqXHQ3npH+9dm0tDIUY/RQvRkUNlkOYwKh27uFw4Mo//7jlRzz6FjkudP1W8Mic334fh2e+ZhIDEIWyqzCBoAy3Evi4j4LqNm3Kilq6Ebqx0Ux5f5cSV5Oq4orld+1yml8i0mho= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 15, 2023 at 10:29:28PM -0500, Kent Overstreet wrote: > Trimming down sched.h dependencies: we dont't want to include more than > the base types. > > Cc: Kees Cook > Cc: Andy Lutomirski > Cc: Will Drewry > Signed-off-by: Kent Overstreet > --- Hm, ideally the struct upid and struct pid definitions could also be moved and then included in pid.h? > drivers/target/target_core_xcopy.c | 1 + > include/linux/pid.h | 15 ++------------- > include/linux/pid_types.h | 16 ++++++++++++++++ > include/linux/sched.h | 2 +- > include/linux/seccomp.h | 2 ++ > 5 files changed, 22 insertions(+), 14 deletions(-) > create mode 100644 include/linux/pid_types.h > > diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c > index 91ed015b588c..4128631c9dfd 100644 > --- a/drivers/target/target_core_xcopy.c > +++ b/drivers/target/target_core_xcopy.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/include/linux/pid.h b/include/linux/pid.h > index 653a527574c4..f254c3a45b9b 100644 > --- a/include/linux/pid.h > +++ b/include/linux/pid.h > @@ -2,18 +2,10 @@ > #ifndef _LINUX_PID_H > #define _LINUX_PID_H > > +#include > #include > -#include > #include > - > -enum pid_type > -{ > - PIDTYPE_PID, > - PIDTYPE_TGID, > - PIDTYPE_PGID, > - PIDTYPE_SID, > - PIDTYPE_MAX, > -}; > +#include > > /* > * What is struct pid? > @@ -110,9 +102,6 @@ extern void exchange_tids(struct task_struct *task, struct task_struct *old); > extern void transfer_pid(struct task_struct *old, struct task_struct *new, > enum pid_type); > > -struct pid_namespace; > -extern struct pid_namespace init_pid_ns; > - > extern int pid_max; > extern int pid_max_min, pid_max_max; > > diff --git a/include/linux/pid_types.h b/include/linux/pid_types.h > new file mode 100644 > index 000000000000..c2aee1d91dcf > --- /dev/null > +++ b/include/linux/pid_types.h > @@ -0,0 +1,16 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _LINUX_PID_TYPES_H > +#define _LINUX_PID_TYPES_H > + > +enum pid_type { > + PIDTYPE_PID, > + PIDTYPE_TGID, > + PIDTYPE_PGID, > + PIDTYPE_SID, > + PIDTYPE_MAX, > +}; > + > +struct pid_namespace; > +extern struct pid_namespace init_pid_ns; > + > +#endif /* _LINUX_PID_TYPES_H */ > diff --git a/include/linux/sched.h b/include/linux/sched.h > index 436f7ce1450a..37cc9d257073 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -11,7 +11,7 @@ > > #include > > -#include > +#include > #include > #include > #include > diff --git a/include/linux/seccomp.h b/include/linux/seccomp.h > index 175079552f68..1ec0d8dc4b69 100644 > --- a/include/linux/seccomp.h > +++ b/include/linux/seccomp.h > @@ -126,6 +126,8 @@ static inline long seccomp_get_metadata(struct task_struct *task, > > #ifdef CONFIG_SECCOMP_CACHE_DEBUG > struct seq_file; > +struct pid_namespace; > +struct pid; > > int proc_pid_seccomp_cache(struct seq_file *m, struct pid_namespace *ns, > struct pid *pid, struct task_struct *task); > -- > 2.43.0 >