From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6377BC41535 for ; Sun, 17 Dec 2023 00:20:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFDDB6B0075; Sat, 16 Dec 2023 19:20:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EACD16B007B; Sat, 16 Dec 2023 19:20:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9C1A6B007D; Sat, 16 Dec 2023 19:20:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BBB526B007B for ; Sat, 16 Dec 2023 19:20:35 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8EF8A1206DD for ; Sun, 17 Dec 2023 00:20:35 +0000 (UTC) X-FDA: 81574404030.10.C898A45 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) by imf27.hostedemail.com (Postfix) with ESMTP id BCF2D4000C for ; Sun, 17 Dec 2023 00:20:33 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=rBxTo1zm; spf=pass (imf27.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702772433; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GwR937qpDoZqrlCJRYeBs8v4+5rmEpvwdjbzX+VHs9A=; b=LPmQRaMywYw4tTuWCV8rE8YrYMHteJwXyz1z8cwprD8zZMf9kO4dXUlvElolpbbzkuObRW eS/Cns5vIOT09P9W0Wt7tdAHwHtiwBBxouH+eedcXXRU/Ir/smsXELfGjtN5djttEsez/0 97mEmGvb+fYcn/poz2lxNFvAXKJDu84= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702772433; a=rsa-sha256; cv=none; b=w7aEkrikemSbI2u9PBbw/2GDwTOTrGoyCDX0t2VjoFGChKOCK6CGiJfX9dxQHBA/QCGwdV HFRMnj01s9ExVU+yryQSmqVI+nA1oWiMOf68QikF+MDJHyt2RwU3Kv6HgBYAeBjEnhvapU 5dI2ADK6biIhkqV246jhu9RGIwZ4Zdg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=rBxTo1zm; spf=pass (imf27.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Sat, 16 Dec 2023 19:20:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1702772432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GwR937qpDoZqrlCJRYeBs8v4+5rmEpvwdjbzX+VHs9A=; b=rBxTo1zmPfHj3/6AVJZywQWcFReUJaxEC22ptYEKo/K/hf+g+YVJIHgDvHbTEweZ86kAKh gAIBEb/5TWtiu2pd3VF4HiEc60ZhPfa2HNJfnXAZGJZRwgX17s8aZMb+0qkmprB5IUuxdV rcgv+auqQORTEcZg+YG1cyyB5OAZXv0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Matthew Wilcox Cc: Randy Dunlap , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 46/50] preempt.h: Kill dependency on list.h Message-ID: <20231217002028.shjg6p7wa2cmtkq2@moria.home.lan> References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216033552.3553579-1-kent.overstreet@linux.dev> <20231216033552.3553579-3-kent.overstreet@linux.dev> <20231216223522.s4skrclervsskx32@moria.home.lan> <82ed43c2-2a9d-4c5e-8ccd-8078397b7953@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: BCF2D4000C X-Rspam-User: X-Stat-Signature: znxmrt47bdpsk7jotm7ntjwz5j16rd38 X-Rspamd-Server: rspam03 X-HE-Tag: 1702772433-277468 X-HE-Meta: U2FsdGVkX19zWGgHg078ekEtByNqEv5zxdNTkst9g0Xs3uAKRZNqRhryI8kR+/vStpUsM7lslTJsCbUmnEbBM13Kuqpa2rj4mw6DWwXgcd8ktts+vjvKunWbgWhIwDv4ecdf62Pg6DUkQN3qo2ecNOwD/NP/Nec9RMBbIPtrXsGP0vMuYAKrxIBevUyoAtcnp+6uQsi5H3Fyq6MGIcziyNYSFukcnYshWrD7ft0CWrU5EppDSb43hjeUNvJuOcIDFfIiUzWmTKjv2mPp64EoPkYFTNytltzm/YEj6Mtp7ZXFEa9+HFgf1BmFiMiloGLLshf+sZqRa0Vp633lqW8vzzYxdDj8BsJQY1LIHPaEorgFA0sq4AIf9Q3qIRnz9a3N+gd2WMMSlYdVs6iPjnS7cbMWHHhJz2tFaxXELbok+E5qB7Yk+0YeVkk+BWCITk23R48PsgUSkYDcOIJhpkX7ju2xE/zhA8ksoQh6UTIJ4hpXqXdRR8tVVZ6+NRnCv6yHOpbIK8WTG2XM8z8kIgTrZ8V9VWl2AmIbuygxroNv9nZDCgoEVe/CC+aokIKj9zO6/mhEfF/pPhkJpi1nzPwvdNKwgppCNboOxeHKpMIBk1bS7Sfelriylf0ZvvLKb1JAKtlBzyjEO/8+Zk04BMrMF2RSquAR+ga7mx3q9CcgdduQhASOCJ728NfMklINp1MBItjaN5wcFstLnoIWhEUClBJYCJFcdd5cW//BvS7tekwc4xjFJ8LOAuQItc3YlwYkmyAckst0ejSgBw6yXvMqOnRRrvnoAMlsifkn/wPynpyWcVxgwt3GY1bMsZdjIK5BSPYIeUussYVwm2RZI5U8kqnqx68D8W2l6qjemGBONbz9ThzmD9t9Kh5XgO4uC8oJrsCUf3YXDi+3C23EOlOMNNDYCDC30kOHXvfExPpWLZoOA/lcqNZITEHjpljxILM4dzdkpR+90o2Qxhtb4Kx kTirbwHj INRHVyQ6oIVv/ghfnskUOes3S2Aalu8NWdcULZs+on7qL0dRvpY0lgRf1JFmx5pS6W9ODCRliVUa7rvxsxn14kHo5DgYQUy2A7osKrBpaSY1ZrZZV26B5bcHXfw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Dec 17, 2023 at 12:18:17AM +0000, Matthew Wilcox wrote: > On Sat, Dec 16, 2023 at 04:04:43PM -0800, Randy Dunlap wrote: > > > > > > On 12/16/23 14:35, Kent Overstreet wrote: > > > On Sat, Dec 16, 2023 at 06:13:41AM +0000, Matthew Wilcox wrote: > > >> On Fri, Dec 15, 2023 at 10:35:47PM -0500, Kent Overstreet wrote: > > >>> - INIT_HLIST_NODE(¬ifier->link); > > >>> + /* INIT_HLIST_NODE() open coded, to avoid dependency on list.h */ > > >>> + notifier->link.next = NULL; > > >>> + notifier->link.pprev = NULL; > > >> > > >> Arguably INIT_HLIST_NODE() belongs in types.h -- we already have > > >> RCUREF_INIT() and ATOMIC_INIT() in there. > > > > > > I think I'd prefer to keep types.h as minimal as possible - as soon as > > > we start putting non type stuff in there people won't know what the > > > distinction is and it'll grow. > > > > > > preempt.h is a bit unusual too, normally we'd just split out a _types.h > > > header there but it's not so easy to split up usefully. > > > > > > > I don't feel like I have NAK power, but if I did, I would NAK > > open coding of INIT_HLIST_HEAD() or anything like it. > > I would expect some $maintainer to do likewise, but I could be > > surprised. > > There is another solution here (although I prefer moving INIT_HLIST_HEAD > into types.h). The preprocessor allows redefinitions as long as the two > definitions match exactly. So you can copy INIT_HLIST_HEAD into > preempt.h and if the definition ever changes, we'll notice. I like it.