From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AB14C41535 for ; Sun, 17 Dec 2023 00:18:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11A286B0078; Sat, 16 Dec 2023 19:18:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C9746B007B; Sat, 16 Dec 2023 19:18:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAEE66B007D; Sat, 16 Dec 2023 19:18:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DB2AD6B0078 for ; Sat, 16 Dec 2023 19:18:58 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AC942A0750 for ; Sun, 17 Dec 2023 00:18:58 +0000 (UTC) X-FDA: 81574399956.19.86155D7 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) by imf22.hostedemail.com (Postfix) with ESMTP id 9FBEDC000A for ; Sun, 17 Dec 2023 00:18:56 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lpDqV4f9; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.184 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702772337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GHhOxXFtGpDl4qK2SBVIKyrWsCibjLmY7kB9hT6fac4=; b=cE++l4UIYKeL9K5epHUrShmMQpqc1bcYIYpfpDoCmf+6ZaEvS2SjShOS9pk4/sIr7UO1La yAMmV/Fe0EvIJ2gTtAtNQBJTJcaRec7yig4vURKxuIYzwdu6mPqfERpUbP2BJWVcNfdwwy OBlcsN32ynX5NkshiTOg7bxA1/qYsls= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lpDqV4f9; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.184 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702772337; a=rsa-sha256; cv=none; b=7lKzhOVY9PE3He/hcL4WMtg8UzsGmm+U69DoAxsdhc5Fi8Y4jFv8JiwAyvbM8UeebgYqO0 2yGXL7HFYNMFhzoqOpS6ggbjEpb9Myuw8QMrCyfvqyE/RrCvG2rvtxiiGKmyP+/hiveQ+O HGVBBvK9EHnen+/VWixY2291r7iKUe0= Date: Sat, 16 Dec 2023 19:18:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1702772334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GHhOxXFtGpDl4qK2SBVIKyrWsCibjLmY7kB9hT6fac4=; b=lpDqV4f96Yla/WX6tu2uOH466Isjo3Sw82OP0xo72YHAmSn557tvbngf7sa5iU/L/qnqWJ H+frcO/hJ1WvIaEBFuvq6rTogC9Xt2Mb7JCnXw1C2VdEHnwm5qCAA7c9JpzM62puGQ9o4K 3C638NdjC4CKVp6xIuAW75RSWwe8PJQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Randy Dunlap Cc: Matthew Wilcox , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 46/50] preempt.h: Kill dependency on list.h Message-ID: <20231217001849.hmilfx63q44tv3vj@moria.home.lan> References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216033552.3553579-1-kent.overstreet@linux.dev> <20231216033552.3553579-3-kent.overstreet@linux.dev> <20231216223522.s4skrclervsskx32@moria.home.lan> <82ed43c2-2a9d-4c5e-8ccd-8078397b7953@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82ed43c2-2a9d-4c5e-8ccd-8078397b7953@infradead.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 9FBEDC000A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 376yc8pcm8p5mwyum9mybu396xy4u7su X-HE-Tag: 1702772336-491224 X-HE-Meta: U2FsdGVkX18XBMIOF9utxVue/y8xqPNaGWRGdTytTAKRLaAe8aCQ6s0IRJzTqFus9t58GgJLMuaCo1YFoXagbHms0BRhHVCzUjnaCQ+PPkZZRDewEUuxVfJXUQyYWjm1KUTQzUpubFA+eIiWRaTcNE0UWUD7x1g2BEZOR/XCnE/RNsOxEkHyalfoVb5Unjn32ys/aO5oSn+MXv25KZn37g1mLdmyGxvlJ6YRP+rfDni4A+f+JgwO0P7ISBONeeE49uOH99UCQDHlV99xG2FnSvPpDh8YN65Uu7LukDrnvTbIgDDpdR1Pry1GzlikgX1VEGBjw2Bn7PogU6NaC44pUMfIz1uQhRoDX2qdqQ9ZFXmsgsLcYJvywp0DPVIYvZRlVRFf2VWRFlpxlhOaJd6PARGNUUZ9v32fARWzHy4jQOOHiPt9sI2nCqa4r5DXXRe1E958tQS8rjRkhWEM6PBhqEP/4/YsSbcfeW4iYLXlcDDyrki46tYfFRzbpoWy5iDwFLpRIi2sWdo5nWp23lqKTSHJYl5PzskWTc9SiRfSeeWx78llzOc34IDeu/PGCcOTQJ84hvIZ6jI/+crsfaCHioVtyhEB0SX/BiON8PLgUDit1xeiLhVVcxbLC5anM8ijvRagtjoOiz9ieeXZrtR/KPqG8VDDnW/oP+4AZe5uz1EjsU1diyEk7U2RBid+i7dBz6NkkJj9+ZoRD7NBNwpmkeSJN6lpOjdxnae2BUZy7kL6uoxOUsWihHM7TpP6Abej2LE24ELwWN8aEir0ZCGydiZmOAM9ZxOgioYxK02l5cjrjy9DSP2jDPm+H+rWWtOLgsOPS58UaFI6/2MEzyrAfeC65hXJZPHzIPJA2l6GjsI886wiG/hYQZ1W8vMtoG11BRScMEMbk7P0+snXJI1V4ESve7doSwN3zXK0EHIyWoPB3TLLgDMJDrhGu1phpxY57dn7XejnUvtiKuwlZ8s zoPm9JwU tRVL/1Yq/MqDJpJ+whsu8iPPeUPnNgalNKRO/llt0dWIFtiMo2pfeEfuJyCUOqrs6xXmqYkRA6/1hwJHoZ8iWcD2ofUDSoRrhkcDp+GLKKCwHEg6FW83yp0CILw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 16, 2023 at 04:04:43PM -0800, Randy Dunlap wrote: > > > On 12/16/23 14:35, Kent Overstreet wrote: > > On Sat, Dec 16, 2023 at 06:13:41AM +0000, Matthew Wilcox wrote: > >> On Fri, Dec 15, 2023 at 10:35:47PM -0500, Kent Overstreet wrote: > >>> - INIT_HLIST_NODE(¬ifier->link); > >>> + /* INIT_HLIST_NODE() open coded, to avoid dependency on list.h */ > >>> + notifier->link.next = NULL; > >>> + notifier->link.pprev = NULL; > >> > >> Arguably INIT_HLIST_NODE() belongs in types.h -- we already have > >> RCUREF_INIT() and ATOMIC_INIT() in there. > > > > I think I'd prefer to keep types.h as minimal as possible - as soon as > > we start putting non type stuff in there people won't know what the > > distinction is and it'll grow. > > > > preempt.h is a bit unusual too, normally we'd just split out a _types.h > > header there but it's not so easy to split up usefully. > > > > I don't feel like I have NAK power, but if I did, I would NAK > open coding of INIT_HLIST_HEAD() or anything like it. > I would expect some $maintainer to do likewise, but I could be > surprised. It's INIT_HLIST_HEAD(), there's approximately zero chance of the implementation changing, and there's a comment.