From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B94A2C46CA2 for ; Sat, 16 Dec 2023 22:35:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 365D46B0080; Sat, 16 Dec 2023 17:35:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3164C6B0081; Sat, 16 Dec 2023 17:35:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DD916B0082; Sat, 16 Dec 2023 17:35:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0E9B56B0080 for ; Sat, 16 Dec 2023 17:35:31 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D91F61C0F8E for ; Sat, 16 Dec 2023 22:35:30 +0000 (UTC) X-FDA: 81574139220.10.00F1B15 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) by imf22.hostedemail.com (Postfix) with ESMTP id EF1F5C000A for ; Sat, 16 Dec 2023 22:35:28 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=l7KLHLKb; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702766129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YNhwxr//DvDx0kBLO5uKoX7FVv1oXGMRs2iGooscwac=; b=Q8Sf7yaqoUo9xD63pW9fEFSmAOuRJibUxHZOL3xH0cq1Kigu+BvfeIX1KDbx8p8hbaRNKp NqviCZrL63M6sjG1xOx02Cp59xQ08b3IDvLR51BWoC+jy56VgNP8cq2dxUWADb7cFZsUHd agFossYIbfJCAFHbRa09A5p0ybRFLxI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=l7KLHLKb; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702766129; a=rsa-sha256; cv=none; b=gyernCy18/J+k44kEpSc/hnqXheGyNMt8jGu8UInqoDr4sZ/g+DnT9ffV0i1iuzMthcqbE c/QXmiw72szrXShMiookeHzEqUtzY8Q72jKB2Dc05vBFPiTp0LA2L8YKswgsz1XckstJ+n HEX1+oF7Qbp0yqhYN8Mx6zyMItPZGG0= Date: Sat, 16 Dec 2023 17:35:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1702766126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YNhwxr//DvDx0kBLO5uKoX7FVv1oXGMRs2iGooscwac=; b=l7KLHLKbQ7OlWriopR5AOIiJC0EWGfPpCc4eICxOm2t1SfU3m4EsjUY6/Niuy4yjTJwYAx W2m0oenm/WZCN+4doY2TZ2MnPc3fT9C4avDHe4Dp7ztBMrlUsF6SMvWxjMcMeenhbNB0uU LRYHKfhYXuSNjZXn6TbW74+3uNX9arM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 46/50] preempt.h: Kill dependency on list.h Message-ID: <20231216223522.s4skrclervsskx32@moria.home.lan> References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216033552.3553579-1-kent.overstreet@linux.dev> <20231216033552.3553579-3-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: EF1F5C000A X-Stat-Signature: 96c6k67o7eh459pmqas6wjp5kmbhfb7m X-Rspam-User: X-HE-Tag: 1702766128-245886 X-HE-Meta: U2FsdGVkX1/NZTGcbjPuzoomaotnaOKRAy/F25f8drPNPSBcZ4uyFPbTcyOqe3dyC68useDuVEMjB8HnPrYQkigS3debZmSVB0a6WGKXE4+9YYZRA1cC2Z1xjesKaNRxQf0vfcGo2CvcizIJoymX8yAdO0pHEG3aBRc99qVqPkfDC54o4XkJTUESKfbapp4shbaq8p+JbPbhqdGnmdh3n+VyP71gYMXSbSNIOt9nYXsBvwYw1z3HLp5qCxlmfjzX7Y4ovxVIUiySiB+s2qvBgClDm3fV6bhkPqLHEbz2zsg6gDY65nugHwsrGxRpypfdDHoW4eVjYuWCeTAYiblGlalGlLNxtsVFG+qMN85VKGHEOfof7FAWXzMgqZaiZY5TyzFCfuP208nS05jQG2kBEh2vVzfOUS45SvcKTyaPh/P6/rqySyNIMH7ppu5awd1CUyNmxKNiTpEk+EVzQe2pfTDGrrV0cNsFwiumQ3n3LoFjvwLhVehXjqgphgwJZX8ZPHiLX0BuATuPOXTYRobp6hpPOruDdveuOosDfNS7oySgNrUca5wVBub8pwtjAIQ6XnbNPI4uk0Hg6iRjbcIcJgR1JD7PHvlSDELOnzEA79WJ2o7rspaH9r5xdMkJ59Q26UVQapWps+L9aLleY+OzuRMM+1+52/esAzFsVt/X/rje3rF6uVdmVreAHOlQmvpelI7ofdpwVPbK+nBwrVVUp8Wkv3HwdnwUOfaaQm3rlaiItDmOCu5zK78kg+5bys0kgsHZXuWp5rBg/zPGh9vt6/xSkt2xYYI5hi4kYTM5TPob8EX3afx5rk41e67mG4otLh7EHsB1Ucwcu0Pw5zYw1vQ4p82IMtgZZUTQkawcVZmApYr2zRpfHS4TQ30ywS6DU+8T3KhydbbvCql5H/5Q8MtXkYQFph1PxwHDWlXOLklSY7InFPsbE+Upjzs0ku761/AIbfck/Ct2/TCo0i/ MkZJdWak 5hn+cnsDJvTLJvnQ9yx8Ij9wFqWdpsguiGCIMeGdXJNJnR2phpFlVTdiP+JnQ+PMF+EwjGkUAz+Gn+Zxs+Ib62HUy+SXP8E/X1DCTEZdducohWXnBtXYVdl/i+6m9i3QAd9i1kzNQAzarFWhtA54VDfkTIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 16, 2023 at 06:13:41AM +0000, Matthew Wilcox wrote: > On Fri, Dec 15, 2023 at 10:35:47PM -0500, Kent Overstreet wrote: > > - INIT_HLIST_NODE(¬ifier->link); > > + /* INIT_HLIST_NODE() open coded, to avoid dependency on list.h */ > > + notifier->link.next = NULL; > > + notifier->link.pprev = NULL; > > Arguably INIT_HLIST_NODE() belongs in types.h -- we already have > RCUREF_INIT() and ATOMIC_INIT() in there. I think I'd prefer to keep types.h as minimal as possible - as soon as we start putting non type stuff in there people won't know what the distinction is and it'll grow. preempt.h is a bit unusual too, normally we'd just split out a _types.h header there but it's not so easy to split up usefully.