From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CF04C41535 for ; Sat, 16 Dec 2023 19:10:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 785DD6B0075; Sat, 16 Dec 2023 14:10:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 70EF26B0078; Sat, 16 Dec 2023 14:10:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AFA56B007B; Sat, 16 Dec 2023 14:10:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 485226B0075 for ; Sat, 16 Dec 2023 14:10:03 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 12AD1C06A0 for ; Sat, 16 Dec 2023 19:10:03 +0000 (UTC) X-FDA: 81573621486.21.46ECFD3 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 27523C000E for ; Sat, 16 Dec 2023 19:10:00 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=aBwkrMxh; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702753801; a=rsa-sha256; cv=none; b=UNgz7b3Yv1SpZZtXaf0BANS2BioT4dCOhH/PtEnFsVJj5UUY90O7tFyUyWm43iwfP5MobU TdCFFEfK6dgI65c9mKNzRtYv7HKfddYtp+jNmxzanhOE/ZmmYE5fC4MUzzXA49xymQ9CCx Tx03M0dXAO1AqJU4aA5XGoWs37Hvcvw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=aBwkrMxh; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702753801; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7Jo4OhEjD0Gr3HR0mQmqnLOLQJfzNTqGMFbzQ8sCI58=; b=me44Ghx69cksA+yxEKonVyCGGAtqKH13YnDcGUbbJf/M5YYZc2bQlf5vRnxQJv4jXtv1zG Xbm033TuWek7aVUl5E6Km+dQB2YIgnTXEVtag72u7aRoAkOsxTK2sH7BxqCtxOzTc/H2BU zQagb24fRhUyYKQuZCrVbhpGKO+8A+A= Date: Sat, 16 Dec 2023 14:09:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1702753798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7Jo4OhEjD0Gr3HR0mQmqnLOLQJfzNTqGMFbzQ8sCI58=; b=aBwkrMxhYp1Gh3yrZD+TnzIcXfKJ2M6qkWjg+iLI5SvesFaws5G/8umhhgX94FqR9Byi8q vJSS5lQihW3+1+YRLnOg/Fl6E5R34Egaz26tKoCFx+WK/gGR0vYsu9599liGo5FpGe6FHu 1p6n7YkWtHn7GhIxJ8rA/FzqX1Wq3AU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org Subject: Re: [PATCH 26/50] rslib: kill bogus dependency on list.h Message-ID: <20231216190954.vjcgab7ttfrqk522@moria.home.lan> References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216032957.3553313-1-kent.overstreet@linux.dev> <20231216032957.3553313-5-kent.overstreet@linux.dev> <5a5daf77-ba00-49db-a963-e343a0b2b8cf@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5a5daf77-ba00-49db-a963-e343a0b2b8cf@infradead.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 27523C000E X-Stat-Signature: gy1qawinxo39kysfxpywqyu3r3apzwic X-Rspam-User: X-HE-Tag: 1702753800-34570 X-HE-Meta: U2FsdGVkX19ivCM8LEV+O9G9avwxmmNzZ5mnVp59hfApmVW9o5HbFKEqQhUbTZvlVtwreu8B8mD59SNJ83qqWaQopeqtF5jrZKbTRl0r7g5V5U6wY/l3Zrm7xAZol168i/o4agkX/5ICKJkHz8y66ug/8raxAITCoI1cLRmcwfv7kBBl+/U03sZt9NOMIfZhvNsoMXhnoJGtdiUiMAQVUz4jkD68oXtEcK2d9h2q/DH4/NB3kjoQ7UwM9Ahubm7d8/r5eNcPOZHY5n4JmEKN/2mg1DIcmslv6CHDKLTHB+IEY2EByPR1fFSwMhUMd3wUqr1nA/U99EtbE74qV4GEZwYeuP+73Z1z/DAZvpEcWupkJLQQhQN3Rpq9LbNvnlIPlr3GvC6msnl/AWvC/N4WOxXrxxGx9XojmFdIU3wEpUPAp7iX2GMTvoKYrVSPA2jYbarKL42QehtwOXT6HDH+irYKIsSFIIKhD8kxFoWSgE3rTirCFi4OptLO6n0SnPMWA1iH96Mzu0jXnK+ZJl6/F7/nbFDU6lVYWHQ56SbPUgPwytncxmzLNLscbO2mKDbsOlhR61X9MdqBgEdGSIEKHi5rUYS4H58eC+zC3R4SJWl26B2BdnY9BveOQvOpgVLwIfqFvcCtWTgqaHFM8Tahk0RDjsIu8v3dSSlQ7kUaqOITwTFsGbMiiXr0d5UzIbkQ5VB51qZDxqIyNUCzldtDCDRUr9k0QYKlgO5ty+6vSgBJGnc2BZfbF0z++HPQbpQdARcclI1fb1MRsJqwFBRdyPXZiM8xfSqyQZuv7Ens8ML1CT8C4q8WsQtEfQDb2zb6WrgorvX0Y590sT+rIm+ou3Krv4dFMqi1WDcBdz6hb6dqbqrCoQI/R8UsNUvgn1I51EWW/lhVatUyJfjcl63f/sUKm+jLDgQ/+r5QyWqWn7rGSIUEJI3FIX6DwdClFiSD61OqR1X4LdKwnfNg/bm 7Uec+XY6 P2Gacmup4U/z0v9jwMciXolxduP45E8LZDSrAruIquC/1P4G7B4Ag7FNEwmCkH2XUa15Umj4+cUDM7tKcrFxPHkb8ZyV+oxfHmMbXhCaR2zMcdWBt0A/wLrst4Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 16, 2023 at 11:05:08AM -0800, Randy Dunlap wrote: > > > On 12/15/23 19:29, Kent Overstreet wrote: > > list_head is defined in types.h, not list.h - this kills a sched.h > > dependency. > > > > Signed-off-by: Kent Overstreet > > --- > > include/linux/rslib.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/include/linux/rslib.h b/include/linux/rslib.h > > index 238bb85243d3..a04dacbdc8ae 100644 > > --- a/include/linux/rslib.h > > +++ b/include/linux/rslib.h > > @@ -10,7 +10,6 @@ > > #ifndef _RSLIB_H_ > > #define _RSLIB_H_ > > > > -#include > > #include /* for gfp_t */ > > #include /* for GFP_KERNEL */ > > > > What about line 47? > > 47 struct list_head list; It's in types.h.