From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 553B0C4167B for ; Sat, 16 Dec 2023 04:51:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65F4B6B00A5; Fri, 15 Dec 2023 23:51:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 60CE36B00A6; Fri, 15 Dec 2023 23:51:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D6AC6B00A7; Fri, 15 Dec 2023 23:51:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3AF606B00A5 for ; Fri, 15 Dec 2023 23:51:37 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0E8B81A049F for ; Sat, 16 Dec 2023 04:51:37 +0000 (UTC) X-FDA: 81571458234.23.5514CEE Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf23.hostedemail.com (Postfix) with ESMTP id 1BC2614000B for ; Sat, 16 Dec 2023 04:51:33 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702702294; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F8aRBee6ofYH0thREJ1IJA30XF3fHiVnWOuxEWFzAzA=; b=BsD1S61ZkRPDMzfTGMmuX1lh42oOu8hRUjWSOBqYUHSsNA3OlZFCgyMmfRctFjGoHOy14z r1iRdy+05S0phaisIqGMdslkd8FwLOSHI3DWxcPtdmUEwtwOhaFM4QQkogm1ORePVCqtpe W/vTDOt9PtrdFx1nNVnPxoVghDD8eEc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702702294; a=rsa-sha256; cv=none; b=IDd3m/1E8wvdTCJeyfaNxvqVg+Ylf+fOfdpd7SkwFjH7d9GxkJOxkjcGCT0tbcKNI23Nqh 6ji0BSsIQJjydQ3+lllbwD9hjGUu2Y5WubFbDjEPPl4YuE5PSd+S/3HWAa4mP7Bd5NOVez gqsJyU8df//wGty15JWLumnBzTdwR+Q= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none Received: by verein.lst.de (Postfix, from userid 2407) id 4DFE368B05; Sat, 16 Dec 2023 05:51:29 +0100 (CET) Date: Sat, 16 Dec 2023 05:51:29 +0100 From: Christoph Hellwig To: Brian Foster Cc: Christoph Hellwig , linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , David Howells Subject: Re: [PATCH 09/11] writeback: Factor writeback_iter_next() out of write_cache_pages() Message-ID: <20231216045128.GA9679@lst.de> References: <20231214132544.376574-1-hch@lst.de> <20231214132544.376574-10-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: t1b787nrnmtsdompzucq68tacxx9aokg X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1BC2614000B X-Rspam-User: X-HE-Tag: 1702702293-22252 X-HE-Meta: U2FsdGVkX1/Hrwb+RW2/k6U0S9GdR60sQo5f8WXQA2nj0bgs2mbFPsYBd6rZXLKjiZHPSRG7JgFj/16DR8+x72UsBMXwthUgiYuT9ExEgexiTxeY7PqCr0aTlYu8uRWVFI+VSbutFH0ypgppEmEnn3e58O6/UnntaqmwBog9CvoD5JbNQn82pIv0bU5zgQJ5jJ5d+pFIGHCAswx3p+2aDNGdrN7zFhpRgUxfeDJBvhrYuvZXukgQn5NY+URtz4kWNDE1kvRonPvSAk+BGQe9F3nTlp68OrXQ0Ao6FQCjN+pSCyXSfw5D74ULeCMeO0IIAUMbf+ETg0qq9wP8d+eeAP0Q0oOm7Kg5zYWfOmN33cRPxouUXdZyvIkDbFYkW6wrRA9Nq6Rq/KC3Vfl3Bee/0Pu5k4zQNr8waWIXwXAnHrniSj23XzJXV5Cm7Ufcnsqw1dKMTJes9edaxD5eVqcNqfAEtfixb1j8xwfpVvnazRAktv2JNhlEv1skNDx+QSLcJ/vNVQ4O0by9OAhAeOM+PfOn/zUYXOi0kCe4gFzjYgkMOve2kIjTjWhR33VwMGoMy9FKXjVbP3q8Q/EdB2ce1Ur64kJ+r3nnd5P6BkkA6dm7ixyhj9XiiAJNz6VGqWL29QxY/NJEN+NAbwFq7trICZd66h8JgpmiBU7RL86VDt9gY47FkI3AjfjEsoNvstaOVi7C+FquWB//4jjgqIidj7hvz3d/2BpzEn6eP/MY+KqOk8ktA+p5h8P1+9mSe3B0cONpg6WYxG+2X6tjrxWlX/Tg5K8XYJGNzx4KdtaVLTCBefOlEnq+M8S1+fZcXwUw28YCRj5HObXNGjOOJ0srtZbCG4ftwTdqLkbD3+l+zfBiCQl+W4wct1iQVytLJurxDixchPQKDKMeWCEZ9CXa1pDBz45+235aKHVlp/iHbYEgwXurKXpr4CivEb0kSaZUWdJMMkt1yc4BCDMWzfg CWyhulM1 /fuQfoC7RT/CethEZM7+L5uxP7dpi0dqtRzz0xJ9xweSc4ZOxK7a2mXr7QwmE/OXSVnTi2UOnijHP1cV0Ot8f0/akPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 15, 2023 at 09:17:05AM -0500, Brian Foster wrote: > + while ((folio = writeback_get_next(mapping, wbc)) != NULL) { > wbc->done_index = folio->index; > folio_lock(folio); > if (likely(should_writeback_folio(mapping, wbc, folio))) > break; > folio_unlock(folio); > } > > + if (folio) > + trace_wbc_writepage(wbc, inode_to_bdi(mapping->host)); > return folio; I posted a very similar transformation in reply to willy's first posting of the series :) I guess that's 2:1 now and I might as well go ahead and do something like that now :)