From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34670C4332F for ; Fri, 15 Dec 2023 17:53:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88FA96B05C8; Fri, 15 Dec 2023 12:53:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 840066B05C9; Fri, 15 Dec 2023 12:53:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7074C6B05CA; Fri, 15 Dec 2023 12:53:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6093B6B05C8 for ; Fri, 15 Dec 2023 12:53:22 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 30DC41C189E for ; Fri, 15 Dec 2023 17:53:22 +0000 (UTC) X-FDA: 81569799444.11.5077290 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf20.hostedemail.com (Postfix) with ESMTP id CE4881C0022 for ; Fri, 15 Dec 2023 17:53:18 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=n1HNiIs7; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf20.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702662799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EA5bCuP5bQE+M6LMBG9odszWdaXjVZquesmQp5Vuknk=; b=mmXbIfcW02Q/BugQe0VZECy54dk6Eu3hOWAxbbyVn3FWZNkUHVzH0KlvGcYlTsmj+Fr8EA jQHSbHetiylSrhag5F65glq6QTQVmvTGw2/E8lb20QdfDGxK+XDlc8gh6FvQcA5C0efWZs prNO381Jaoo6Dsv1dH79jaPYYb76hHU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=n1HNiIs7; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf20.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702662799; a=rsa-sha256; cv=none; b=pXcVbflEdFxoOTJ/kOACpHtIAII/rU9bITipD/iPZ9eBeRKKL5W/LzTzrt2TAYXBtyqRLT d0JeXoWxZKGnkHfxQFEFrucUkitOLcwCkV2jDJn+wYf1ZF7aA43EllQ16QRLfi3H99E/r0 JQ6CTMwCeq3VXBzmc8bqw/5aT3y4pFw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 00A9ECE3047; Fri, 15 Dec 2023 17:53:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7E78C433C7; Fri, 15 Dec 2023 17:53:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1702662794; bh=bCeZYjdKbAsjH+3ZnxxwoKFd5W+uxUmvZZXD9LOmVAI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n1HNiIs70ftZwmIX3BAKT7HlQFwEbubiqSnRfQqpa9/Sfl3TuxPsso5m19okbZO5v nw9dM7Vsy5Kt7w2PbsH6hj2ArcNdwxExg5KAlYr2dArzus0yDJByYdefDdLnKtFEDf kPAtGPf4l5SHoWFNvuAQILAgH9gaflnt5pWNgKU8= Date: Fri, 15 Dec 2023 18:53:11 +0100 From: "gregkh@linuxfoundation.org" To: "Verma, Vishal L" Cc: "Williams, Dan J" , "david@redhat.com" , "joao.m.martins@oracle.com" , "Jiang, Dave" , "akpm@linux-foundation.org" , "osalvador@suse.de" , "linux-cxl@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dave.hansen@linux.intel.com" , "Huang, Ying" , "nvdimm@lists.linux.dev" , "linux-mm@kvack.org" Subject: Re: [PATCH v6 2/4] dax/bus: Use guard(device) in sysfs attribute helpers Message-ID: <2023121517-flammable-ragweed-d42e@gregkh> References: <20231214-vv-dax_abi-v6-0-ad900d698438@intel.com> <20231214-vv-dax_abi-v6-2-ad900d698438@intel.com> <2023121515-litigate-finished-76dd@gregkh> <657c89c16d5f5_269bd294bd@dwillia2-mobl3.amr.corp.intel.com.notmuch> <89ea0a46cd1cf22393c6b05a50cd3e719ab6a4ba.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <89ea0a46cd1cf22393c6b05a50cd3e719ab6a4ba.camel@intel.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CE4881C0022 X-Stat-Signature: b89g15s6ct5ojxr8wdn667arbxjo6g6g X-HE-Tag: 1702662798-97886 X-HE-Meta: U2FsdGVkX1/p4C/vZOM/6Rx6enKTLFd/Vv8paqUnqxQcgPSlGhW8xXzFgannndQaHZtS6y3f/2ls/lfz6UczAjwd6WPUkVZY7h3qksOfKpVGgTpc9fqb3p0cTRAvQ81knXl7jJG6KlbDaQApPdEwQoqPjh6fFGKGg5mXWQvn06hb+JLFkwChsN1kmLzdVYN/bQRTSsF55dDbwMpLtg9sIk/qJUQchuU8HLG/ByH0Nkq+rpaVQ2meS5ad7vkgioiEwrdu0NHhzpfD3p76ASBZyyz0FvygiwJIdT8kC67/Gjw8MzdwvFl2aJzjKIXnaiEgTbwIFj/PRUYBAx5PwRlM1dmmJm5EtNPEgIMXK/gLlt6LM9C67HYlXCZS8w9ZjllxsidO598zZWPF422LQzpIFzUw+//IeEUQ9HCDd0GSDrHzWiNmEPdB3S+dVbcOfnmUVUR64+EWRXeNz7ttKVX5u0OZWRVrRYkYj8hXWfU5kZjGP3H/Ehigcs4zbE6OJ4cCBKkCtLJbQ/GX3OPpAdXVtePEr3aLOfcAnUEHGfLQK/Qt62nQ3iku7w9puq2E2uXKPxuGH1zPo2HYRyBzx2dFkdOqLYn57088kZRfPjX0vJNckhcQhh+k3c9Bsh6cDrHXMbSeMC4bctT6JgH45gXsFWSntmiaxy87RqUSDMco6X/rQsEh6ags7y3Q36MOgbkIPbCdN+C8ebBLW35HXcEkQA4TTg2AULuH+5mBLaJoAGL+FgfppO3eW5/ajYGQNcOLixm9OtHWR/7N7dhmfaA62YSQ+LEo97RwOsHka1gng9SFz1jKAlz/cPYt5C/+pEqrxyGnA5iUi9OgLB80u8f6eqXrJ5HjILNshXpjjtW5LEaKarPGiJHAnt8DjwT4/7cMXd982MH2pOI2Xn+R1ildBIHZTVUnzjgxcXsOdsEBh2Q+ntwi/FYZG34G7mqx3LqTDs97oUpPMgZgcR12O0a fqsoPklz CHZicb84E7anz9VBe4SLcj9WQ6B2NQOfYBGxuhAM3VOznCtahTjZHrpW6hAvVDmCNsowit6Bo/59lZSQI880jnJZ2pch/1I87+2h/F8ZO9+iyRFJfLz9Tixk1WG+3+1A9wS6800XSfwBaL801YY2Q4uqqSCi3ZOc0lMl/yG2/pq9cPWwd+oxNZtkB/LjHIAJjcclz453oGpRUSY03PhJHOX5A9fqgBPwHS6vo1P1mWxOtpql6fc7comlDaO0Fvrt5/ko5CivM7YNaNCrySyf3sM9ajN+BsAiM5gkWJa31npYObo/UpWYR/S1dFw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 15, 2023 at 05:32:50PM +0000, Verma, Vishal L wrote: > On Fri, 2023-12-15 at 09:15 -0800, Dan Williams wrote: > > Greg Kroah-Hartman wrote: > > > On Thu, Dec 14, 2023 at 10:25:27PM -0700, Vishal Verma wrote: > > > > Use the guard(device) macro to lock a 'struct device', and unlock it > > > > automatically when going out of scope using Scope Based Resource > > > > Management semantics. A lot of the sysfs attribute writes in > > > > drivers/dax/bus.c benefit from a cleanup using these, so change these > > > > where applicable. > > > > > > Wait, why are you needing to call device_lock() at all here?  Why is dax > > > special in needing this when no other subsystem requires it? > > > > > > > > > > > Cc: Joao Martins > > > > Cc: Dan Williams > > > > Signed-off-by: Vishal Verma > > > > --- > > > >  drivers/dax/bus.c | 143 ++++++++++++++++++++++-------------------------------- > > > >  1 file changed, 59 insertions(+), 84 deletions(-) > > > > > > > > diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c > > > > index 1ff1ab5fa105..6226de131d17 100644 > > > > --- a/drivers/dax/bus.c > > > > +++ b/drivers/dax/bus.c > > > > @@ -294,13 +294,10 @@ static ssize_t available_size_show(struct device *dev, > > > >                 struct device_attribute *attr, char *buf) > > > >  { > > > >         struct dax_region *dax_region = dev_get_drvdata(dev); > > > > -       unsigned long long size; > > > >   > > > > -       device_lock(dev); > > > > -       size = dax_region_avail_size(dax_region); > > > > -       device_unlock(dev); > > > > +       guard(device)(dev); > > > > > > You have a valid device here, why are you locking it?  How can it go > > > away?  And if it can, shouldn't you have a local lock for it, and not > > > abuse the driver core lock? > > > > Yes, this is a driver-core lock abuse written by someone who should have > > known better. And yes, a local lock to protect the dax_region resource > > tree should replace this. A new rwsem to synchronize all list walks > > seems appropriate. > > I see why _a_ lock is needed both here and in size_show() - the size > calculations do a walk over discontiguous ranges, and we don't want the > device to get reconfigured in the middle of that. A different local > lock seems reasonable - however can that go as a separate cleanup that > stands on its own? Sure, but do not add a conversion to use guard(device) here, as that will be pointless as you will just use a real lock instead. > For this series, I'll add a cleanup to replace the sprintfs with > sysfs_emit(). Why not have that be the first patch in the series? Then add your local lock and convert everything to use it instead of the device lock? thanks, greg k-h