From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CD03C4332F for ; Fri, 15 Dec 2023 16:54:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A3A68D0135; Fri, 15 Dec 2023 11:54:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 61A1B8D0121; Fri, 15 Dec 2023 11:54:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CDBE8D0135; Fri, 15 Dec 2023 11:54:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 218B38D0121 for ; Fri, 15 Dec 2023 11:54:27 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E2ECE140E68 for ; Fri, 15 Dec 2023 16:54:26 +0000 (UTC) X-FDA: 81569650932.26.734B991 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf04.hostedemail.com (Postfix) with ESMTP id D421B4001C for ; Fri, 15 Dec 2023 16:54:24 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702659265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HfZm3GrLNqRcr1stP3C0OQ9Y9vvH12bwjhTLNTmIqcc=; b=AFY8lzo67oWPbqRf94jg7b1rj3tegXRvyQHmIhOqafgf+JQz5NITV9ByE4wI7MYGsVgVH2 fbOpLDYkJCY3sUMPoaMvcwHZKlz3/tBwzazEmgHjtEaRhOyW2FdOP1G0jCjZrn3hoZBUaD CgmIrG70B3MhsEZp73Kej/BUtA5jzE0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702659265; a=rsa-sha256; cv=none; b=LXNMTjU3wwtqPhwv1werHFKLRTGsui1pdh/dQ5HimEDnNey+CkFB+/eQMlioTddGE9q6uT FA/pfUx3WuwAo6BiaE1prVxzhbvgFOdIxnuNRzK0a2vlSj8/lJV201xcBJed2PeXqIDFcd eLl95yjqHmj32SaFGzaL8jZ4St68hrc= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none Received: by verein.lst.de (Postfix, from userid 2407) id 4E8A168B05; Fri, 15 Dec 2023 17:54:20 +0100 (CET) Date: Fri, 15 Dec 2023 17:54:19 +0100 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , David Howells Subject: Re: [PATCH 01/11] writeback: Factor out writeback_finish() Message-ID: <20231215165419.GA3175@lst.de> References: <20231214132544.376574-1-hch@lst.de> <20231214132544.376574-2-hch@lst.de> <20231215132639.ftis3fhmcqkhrpzo@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231215132639.ftis3fhmcqkhrpzo@quack3> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: tes76z6r1mbtoo9dmjssudo5htkz5bff X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D421B4001C X-Rspam-User: X-HE-Tag: 1702659264-359779 X-HE-Meta: U2FsdGVkX19oTW7CTncuYB9fi2OMszz+vorpliBxLvFb6vWpLywV+tPi8ppq6oCDwEEfoVypiYasMoRnyXFL0oiKxEU1GyLm9H+eNBdeO61LPgNuhro4juxyOttcupDHbQzJyr1AtiAkFmF2aQT48XiPzMd0RBsP5IQSOR0iie6WqKXerj6I+PSbo6asu60V8C2PeiW4kVc7nPD4vvzRKWx7ri/DsIh+JHFZkIDfrs6JqlAuPZdFTlF6OZ/BTIT9UvO3PN+5b9dzAA99uWzmhq/VWC7teycGrwy8FWMzY/pYXXEJhRajuNKNE5XOGBY0FDGKGJ699LVa2bkA7+sFjrSHzpsKy1pv6yNfJm+qy3XVPPElHMFxWUdOL1ZY2VO1/cb0zP99dZ6DyfZDD7EBn+K0AaNuwEtyhDAQ1h03FYbcHBRlfITexsNJzmBiH9Vvm/xMc20OTvs8v1SjZFoaKBX18R7Ndzrvbm5ffAzC4w+eV0DrGFMkUdAGbtLRYdx2XdX+QbAjjvBw0LxOvimpuGtv7Ntd4wMHVhDWMDz8244bY3b3KzA/UNkO8G4pgT0IOf+lKJ3nJBc13z4NZPBsS7ZNQHxgmE01FmKFz5zykB61v8/XNCHtO0FRY19TP82tRZcrYZmc9pT+7r1PEUI22AEIpyxrPJTSG/qPMMQHY5QffWXI7e+H8ad6PukG8RjYHMZtx7LxljxYIr5l8b2qNaLqXW47/qV81+A6YLIMfF7tVxtot3O+2uLNF4t9cKpsPCdOsXIl4MJKQIloKUTQmZZeqdRSeWI7Ad9EO6re1LaWwnSxwpLEliQajhxjnezsqQ9a5MrrPorqdh4c7wjn9lJzl4LPSNjh9tCOhSLTb0I93CQTe+xDoLsJqYDX7uS5TnYbvJIAM4XJdMw02AqdgncMJJr6xkYRv5NGbsjK7xjF9wPrU0Pf3uw5AGoCPPnbutN5Yu54M8CNSyhGEE4 IparMB9k 5pRpmvjGUXlX8fLITCsj0T52phbQUh1mfxpwC/cta7iZFZ9c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 15, 2023 at 02:26:39PM +0100, Jan Kara wrote: > > + /* internal fields used by the ->writepages implementation: */ > > + struct folio_batch fbatch; > > + pgoff_t done_index; > > + int err; > > + unsigned range_whole:1; /* entire file */ > > Do we really need the range_whole member here? It is trivially derived from > range_start && range_end and used only in one place in writeback_finish(). Yes, as nothing modified range_start and range_end this should be easily doable.