From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91485C46CC5 for ; Fri, 15 Dec 2023 10:59:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CAFCA8D0128; Fri, 15 Dec 2023 05:59:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C39BA8D0121; Fri, 15 Dec 2023 05:59:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD9818D0128; Fri, 15 Dec 2023 05:59:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 999918D0121 for ; Fri, 15 Dec 2023 05:59:46 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 732DF1603C7 for ; Fri, 15 Dec 2023 10:59:46 +0000 (UTC) X-FDA: 81568757172.11.45C12E2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id B10FC100017 for ; Fri, 15 Dec 2023 10:59:44 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ho64YXa4; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702637984; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3fP304Wq/YPzSN9GthH0mbpuLLv3QBh4NFHF7pyIESo=; b=4PFQEpSSzOgnaOOuK6NPsMXd7itH/1fhNCludMDj4Cw8dI+R+t0z2GDmd94khoj19P46OU /rh0JIBQ4sGev5qrXxYQRJjIofVXagNg7ctz0eLMvKpuJkivS2TNdGN58I4NDHjSH1AYJA k3FbrfowgLlF9XRVRkyXW0ia8gaDg54= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ho64YXa4; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702637984; a=rsa-sha256; cv=none; b=5pB+S68LxxvzOuLwdhCzbonjlhP8TTkDiPggvUmjEBh1v4qcVlIllXlURYOZF7LL9Iv3+a flWskj0Yw+01aQprYntT9mVO3FhMqma1efyoJKfLXlF2K6GYS0rCXdNBw5aZ01OR67m66G UDj5MqSs/i/cLFi8JvEpECmDWyHOggs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D29756258F; Fri, 15 Dec 2023 10:59:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D609C433C8; Fri, 15 Dec 2023 10:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702637983; bh=uVJe/DTjd8KQzGT75ENPY5rY557S9U+xVVo21+MUWRk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ho64YXa4J0j5IN/OXDI+PqoCnLRNHzJ37iR3IM91OtCvs+V+BzOBIVogw7EGmomo+ 0flnx6RBmP6oJzBqPgCf5Hfr42l9adpEkzjVeYKwd2CGqevKc6dYczirngVTRTieGf 9eymHer16CCD3BghBPVT/gkbQ9q4FIS/KHsWy7wx7d+gu8EpgZon7oipgD7uGUCGz+ c336oRnLff/rUQKMni9+7AEQk4qL4k7ZiTQhchtF7kuUrzUC2vkeBvNEwsRc8FeLGq JCQUqgQQPSbu4mz4yRzTMHfYlBmKSJMlMcMgmFtVhaNTIOTJNqa6pNXcdPmQ1IlqR7 ZmO9LYK30DKQg== Date: Fri, 15 Dec 2023 12:59:33 +0200 From: Mike Rapoport To: Muhammad Usama Anjum Cc: Andrew Morton , Shuah Khan , James Bottomley , kernel@collabora.com, "kernelci.org bot" , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: secretmem: Floor the memory size to the multiple of page_size Message-ID: <20231215105933.GO636165@kernel.org> References: <20231214101931.1155586-1-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214101931.1155586-1-usama.anjum@collabora.com> X-Rspamd-Queue-Id: B10FC100017 X-Rspam-User: X-Stat-Signature: e1j3pgfo4a8kcicgwgnbkymxhyxhw6uz X-Rspamd-Server: rspam01 X-HE-Tag: 1702637984-645884 X-HE-Meta: U2FsdGVkX1/eLQ/0YE+234PrWEA2CofcIVD7VQMCOgAHcDBbESHQoTQtcKc4k3FdljQNXJs5H+rTfKhDUz4TAx5NY7m4CYny/4BjLiEUFAF3afCBcRGDFwCzFJhgB7Dw1hpbbtDvMlrbCxXBKIbnH6quwN/1l94/m4/tenRON7nIdZAluiITHN2jY1w0LvKx/eK9u/V/4TtlNtpmY60VsEXyerdjCrxKKlAuZ6y2zIXP9edLBuTyIETQLr0xb1GrwJqc/0z658acIVDr8GJXjOJgygGvg0vIl+ZlmWGP5pTSPTgPcGNy97CHTH2+RbV83FvvZoR9iEMsky2U+IYcIeDXvBdF1Qn1CYCLZwLfD4tX/scEESB92hkyRlo+ZPMjgC3FtsUOJlrtgmDY+rfF2eljKoCIvX3jonInk9V5PNliltjMRHPa6dNijo6BqAI2lR9F91h4mEGwq3rKISbaEjzl14fHYvRNVO2tG2pfV887Pj3dujZNsJyI6eVf8stuwzcODMHR3UeNboQM/u76CmEPtmK6rCu9NEVjNl2xhwk7amfZyo+z1wc53KG/BcVnJ66XcB29WgbYBvgmk6U9XqNt+DnAElv9i56trAD6E0qIrCZCJSybR7Wrr5rrmPai3a56m3a6wd3ZZXmRv/fu2/kDgqAtrvA5muIgC/povjyq7l3cNz1chJt81qCjnWm5ycDMJEyopr94welhKAkrOH+uJBujrdKyuCUUW83oGPG2VScn0o53pHTUuRRbq4tebWqT44ExtB0UUnftZFdh52LMXpyC3/8pNHsJv87+rmS6AJuE6ZyKOoOTxuyA1mvEIpFRTJOxQJSC3IKXWUM8WGmMDVh2pvmzELXhAvTEg2o1jhEAVM0x74KJUOSv17eB2GhS+Hx+SIn0GhCu8EtAU9kpsJiVS2tIP6AYBXoNJQpS+UvgA0KvSa1WavQPfVrHPgauNJyrbz0Qdw9I0jK yibcvbs0 veAKlbGP8ReWiHoRLBl5qx6iCHcSNYzeO3wP0xAfsP/udOuTXL4q5B68IgzZrLScqgUPmJt7zE9Vdi91j/X/nOGu9tJnD8hnw5c3IEkOs32vfId66+wMS6LVYGngCjuYAVTvZFQfM7gHF8UuBXv6fJNye7ID38zt1TC/gFXVR12pAyhac9Zgo9wPdHGgTLLfSOpWjez9hzP/nETsNp8BjJeVhYIycxddwuWZRnPRCH6fTLTJ1rn3fz0rWRvKBqJg6ZvZUtvCZbNm06HhZsg+KYtsmBigIMNP64wWE6Ytx9NNwbLK8eKzpMsuA1420zH6mncY+06PgT43P+Ki/jyO/C7P4w22eARU8knTV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 14, 2023 at 03:19:30PM +0500, Muhammad Usama Anjum wrote: > The "locked-in-memory size" limit per process can be non-multiple of > page_size. The mmap() fails if we try to allocate locked-in-memory > with same size as the allowed limit if it isn't multiple of the > page_size because mmap() rounds off the memory size to be allocated > to next multiple of page_size. > > Fix this by flooring the length to be allocated with mmap() to the > previous multiple of the page_size. > > Fixes: 76fe17ef588a ("secretmem: test: add basic selftest for memfd_secret(2)") > Reported-by: "kernelci.org bot" > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/mm/memfd_secret.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/testing/selftests/mm/memfd_secret.c b/tools/testing/selftests/mm/memfd_secret.c > index 957b9e18c729..9b298f6a04b3 100644 > --- a/tools/testing/selftests/mm/memfd_secret.c > +++ b/tools/testing/selftests/mm/memfd_secret.c > @@ -62,6 +62,9 @@ static void test_mlock_limit(int fd) > char *mem; > > len = mlock_limit_cur; > + if (len % page_size != 0) > + len = (len/page_size) * page_size; > + With mlock limit smaller than a page we get zero length here and mmap will fail with -EINVAL because of it. In this case I think we can just skip the first mmap and only check that mmaping more than mlock limit fails. > mem = mmap(NULL, len, prot, mode, fd, 0); > if (mem == MAP_FAILED) { > fail("unable to mmap secret memory\n"); > -- > 2.42.0 > -- Sincerely yours, Mike.