From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDF83C4167B for ; Thu, 14 Dec 2023 08:31:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E0976B04F1; Thu, 14 Dec 2023 03:31:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 28F286B04F2; Thu, 14 Dec 2023 03:31:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17E026B04F3; Thu, 14 Dec 2023 03:31:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 046456B04F1 for ; Thu, 14 Dec 2023 03:31:19 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C54B3A224C for ; Thu, 14 Dec 2023 08:31:18 +0000 (UTC) X-FDA: 81564754236.05.93C6B4A Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf02.hostedemail.com (Postfix) with ESMTP id B14FB80008 for ; Thu, 14 Dec 2023 08:31:16 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Kk+AZ+DV; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf02.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702542677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k6/bNpZRbnXZm8PZxnPNOVowJ7rquMzKmQyEojny3X0=; b=opwUMSGkCJ7tCwtquSFuCvp6KecMeEb7QRb5rVzwlheq7j1U6RURQvxpw7cR43Qcb3qWJ7 f8qt9inIgYRYL9OYZo5XtQc0lYh+cNyFjLF67y4fgjinwuht9awYqqB+I2ZvqFUimWV4RK 3GQdCWqQ/F2Bb7t8cXPZj20mBaQ9VXY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Kk+AZ+DV; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf02.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702542677; a=rsa-sha256; cv=none; b=0blwUHvA4pBvqOIJS3QySLdVtulwyE5gPRrg2OQyGPp2vTogC20XZVgJqDvy2YxQ5fum/2 giYbLzmCOVaRRaVutkTWpGDxpa26zVGIwmiWxKNdOMVzz+KfISP7mPBOyDyxFhsrA9tuBN I8SGV2PdpC5rVeVgScpSMMwlm5HcGVc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 9E835CE203A; Thu, 14 Dec 2023 08:31:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B431C433C8; Thu, 14 Dec 2023 08:31:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1702542670; bh=XhtXMTLrB7TaL4OGwCq1/5AnWLeypq+BMzyNEqR5H9A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Kk+AZ+DVVomEJXbQK/IGA23dG4WisCKhVO6q/x+A8aiuX4YFdzwJtFgPHS/E2cJIK /QDsWd4xgu5UuGhEXCmjVkOjVqZUiygkwA10BRlV00oZLJKvAP4CSEsygOj30LXQxU ZPUuEX4HqOK/bucObq8W7oUoD5kusVE/ub0N7oKk= Date: Thu, 14 Dec 2023 09:31:07 +0100 From: Greg Kroah-Hartman To: Vishal Verma Cc: Dan Williams , Dave Jiang , Andrew Morton , Oscar Salvador , linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, David Hildenbrand , Dave Hansen , Huang Ying , linux-mm@kvack.org, Li Zhijian , Jonathan Cameron Subject: Re: [PATCH v5 4/4] dax: add a sysfs knob to control memmap_on_memory behavior Message-ID: <2023121453-tiling-banshee-5acd@gregkh> References: <20231214-vv-dax_abi-v5-0-3f7b006960b4@intel.com> <20231214-vv-dax_abi-v5-4-3f7b006960b4@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214-vv-dax_abi-v5-4-3f7b006960b4@intel.com> X-Rspamd-Queue-Id: B14FB80008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: oi9w5ux4986z1n1cwzhkkwzyhfmf7w13 X-HE-Tag: 1702542676-608156 X-HE-Meta: U2FsdGVkX1+WD3ZvC3fnsyLLzg7u83gmv1NKhYB2/Ftt/HbPWIJPnEvteTCLUliYIRPCQghGP5mefANfTVR+AV/cZKG3rvaCkcIGu2vlJ0CbM3Gwuxt/84Th6nxbiQg/CPHiDn+KYlM31Q6OeAT9kKSrplQ87d7QwymV0TTw+CroGkic5+N0ACwL3+U0pZSej28cHiDg6Y6P6bGUZQOx0dvxPQv6vD+7sLijfYtHApBf9lYjL+sBKcTOq9cXx3pkn2WfUcHMb7NFdpSxrJMNpid+nYzLEYDhRi1qpgaSpxZhDx/J5r6Z3A8INmNEjvXjIj4xUmlgcFW89XBEcxHl6cIpvDq/12Hu/8s+54UljhOtbGrDFF6VfcIjn1ErV4Rab0nOSQyd1mUQ0SSOliomksJYF34CjqTL1ctK3OXT9RuhXLYTpTF0lxX5TU1IepB/fQA0KSkkYoMADn++YW1dV2JqOho8r8mERYSnDtAVgz0o3YKynL0z0ENxVfZUFWmuD8GyWnTYHET++yTWKIh/qs4LeQTkfLGLUkMeNLbj5eD/MwgSgv8Du+x3+0Dt5zesKzIN0SifXtbjcZv0OkuynLJOVsAhyk6NFr3Zh1TLoPjYF1zaS4lqjr97iiJUbmTrm5msRRnklY0RJ/UMAWotkkAukvf/YaL4hfRkd8ZdbNv5W1/rUETgwSVaQa8Qc97yQDwhRwJhNrzRw6O1azbpK/RSdNcMXtYUetG3s9JUBkdIwG9socKV4tFdlcDaU6hTtAwMgEfq/4EcCfYlX6GcUtk7pOMHaqLr/wtWw+mpmybOpPxJZEWMJFAfhhqld9ExG3Svxjiu1PisarVOegwDBz4tXumYdRUZH+oTMCbRi0lh4LGhDSGQ+Z6PqlmoOjUer2eIf+84a8xcUL9CHF+/oOhFuFjupAx4iik70u/37NSwI63nCzTMz3dOWRR+05RHnkCJ3N0EYs1b6lU55rm nj7g4oFY T5eWu54qE9Fw162H9makJUOXo1DfZi11Y4xsCUbLEZTCyZyzA6KLqfalHwStSUAWoU3/fk+UZbqfnCqHum+uEZ6lu6I8m+/KiBL6TL2QzX74VgvGf0aHkiI85AKeNySz8hrVnKXO04zSlQfNTneYN+CXcyHSni+g8rAEcnvfoEROWJWm0nQwFoqWgPeNYomwTUahybvtlC1PSPt9sRKpewDCScIRVO3oXq/jDoW06rC2P08BKCViDWe8j2LsZ9MRgPiLkeBSv347jO8sCXT0jr/fwB7Th++DBtCup X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 14, 2023 at 12:37:57AM -0700, Vishal Verma wrote: > +static ssize_t memmap_on_memory_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct dev_dax *dev_dax = to_dev_dax(dev); > + > + return sprintf(buf, "%d\n", dev_dax->memmap_on_memory); checkpatch should have noticed that this should be sysfs_emit(), right? If not, please make the change anyway. > diff --git a/Documentation/ABI/testing/sysfs-bus-dax b/Documentation/ABI/testing/sysfs-bus-dax > index 6359f7bc9bf4..40d9965733b2 100644 > --- a/Documentation/ABI/testing/sysfs-bus-dax > +++ b/Documentation/ABI/testing/sysfs-bus-dax > @@ -134,3 +134,20 @@ KernelVersion: v5.1 > Contact: nvdimm@lists.linux.dev > Description: > (RO) The id attribute indicates the region id of a dax region. > + > +What: /sys/bus/dax/devices/daxX.Y/memmap_on_memory > +Date: October, 2023 It's not October anymore :) thanks, greg k-h