From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A254DC4332F for ; Thu, 14 Dec 2023 17:26:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37C108D00D4; Thu, 14 Dec 2023 12:26:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 32BE88D00C7; Thu, 14 Dec 2023 12:26:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CDD58D00D4; Thu, 14 Dec 2023 12:26:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 085CC8D00C7 for ; Thu, 14 Dec 2023 12:26:27 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DB546402F5 for ; Thu, 14 Dec 2023 17:26:26 +0000 (UTC) X-FDA: 81566102772.11.71C8D42 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf07.hostedemail.com (Postfix) with ESMTP id 06C6140023 for ; Thu, 14 Dec 2023 17:26:24 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YQdKEOYs; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of rymcclel@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=rymcclel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702574785; a=rsa-sha256; cv=none; b=ECjK5t3mPcsb/lNSBcWNInf0iDnhR4j/FIp0nrPZ9X9BC4HUUlZpRzRHrcPP0qJAfehenx iqIllyAIfPkpvbkUKGIy4tB7oa1hVAA36WGn9ET0VLRi9lSRlO95L9ciBjYW2h9VCKnhNM AStVsJ002/OwsopBNs//HdXhJSWRds0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YQdKEOYs; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of rymcclel@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=rymcclel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702574785; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H+Ka8wxIsA35NAcpj2VpTkHi729lxrpm9tFastxUpXM=; b=0/aUssc+N+R7YfiN2RfxnWgFAw/DIHgNJguXLwMwg/05KyBa2l88UPzoww+6vBIeOzYjw9 HWDxKbnZvGoCq536MM9G/omSThgZn0btw16JzJ90phdRAaVRwXgi6p9UJtGr+ALLjF07pE cBehJ+WAtonUmk8He5ygbMVtMWBQqms= Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-28aeb049942so1858402a91.2 for ; Thu, 14 Dec 2023 09:26:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702574784; x=1703179584; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H+Ka8wxIsA35NAcpj2VpTkHi729lxrpm9tFastxUpXM=; b=YQdKEOYsfjoUaCVQ3gQWYNtYlI/R4jUVV3RjpOd55copIMs7tVKpkyFnMxzc7a2UYM Rj90xcxJ+jbEjkrem+CGqZQmblo8GPTtdnshBNpRre5TVNgK0S5+3AGVgKRlWccYo/nK hJWXRJ9xdleYHMgRlOjjxz/B8k8Esv4v1+2OAnboAAsC4HnWug3KU0oWMrtNG/cPzOrl sKS7osWr/OgdRy4YfwyYxWZQZdM9JSYSJEbhS/UzVGFaNg1I7f2ttGAN/T3pv+auF0ti uGdkKY5C/1TlVSzTDeqvJH1cCfvOpauTavVvGGrmdNo7wa1DPks7HT1zVEmwGEWKHAnV lYTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702574784; x=1703179584; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H+Ka8wxIsA35NAcpj2VpTkHi729lxrpm9tFastxUpXM=; b=kBeRMJNbbARceZlXClP+59IIJUJjqx1YasFHOEj5ev6IN9G53hiHtNS5oWsmNUpBP5 T/AZeWeGTGSDwbJYEMlWn0+8HSltUlkaM0EasSi4isaWW/tdlSma4NNuHIyQDh+3liaS 6X7szDMDX5dTFooJD3//b3FuB2+AOzyS/KHDuNUupG/p2DDHEEshrbuf66FZc1gsMliA 8gxXlJfYPQ0wx28Y3inZN/8cj2/d2oGb5fxiUwVe6VGjeDX/bse+INILI00zjv5nybTM GAGdK8Emkmyv/RSrjo0UNzNLapg3Uj2GbrCcziBX8DKL0SpgiaalsmaT9dgSA61PBYQ9 aO/w== X-Gm-Message-State: AOJu0YwO17jkdzQ9tYVLyntDHxirupg3lrNxyCk7PSmyAJTHJhU9z3Ho 7Uok9rR87DgqWlwzenNbjzQ= X-Google-Smtp-Source: AGHT+IHph1vaHVKrOP37Hvn4W8QinnzVQ9xW4IJ0io8VW9WP+ukmvN0XRG+NZNUtxhpdWi9wmOYmog== X-Received: by 2002:a17:90a:f0ce:b0:286:9cc1:a10 with SMTP id fa14-20020a17090af0ce00b002869cc10a10mr8036911pjb.8.1702574783701; Thu, 14 Dec 2023 09:26:23 -0800 (PST) Received: from localhost.localdomain ([50.47.187.252]) by smtp.gmail.com with ESMTPSA id p17-20020a170903249100b001cfbe348ca5sm12688645plw.187.2023.12.14.09.26.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 09:26:22 -0800 (PST) From: Ryan McClelland To: lkp@intel.com, linux-input@vger.kernel.org Cc: jkosina@suse.com, linux-mm@kvack.org, oe-kbuild-all@lists.linux.dev, djogorchock@gmail.com, benjamin.tissoires@redhat.com, jikos@kernel.org, Ryan McClelland Subject: [PATCH] HID: nintendo: fix initializer element is not constant error Date: Thu, 14 Dec 2023 09:25:41 -0800 Message-Id: <20231214172541.48370-1-rymcclel@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <202312141227.C2h1IzfI-lkp@intel.com> References: <202312141227.C2h1IzfI-lkp@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 06C6140023 X-Stat-Signature: nfifxgikdxojw3xg15mpefxxae9zffau X-HE-Tag: 1702574784-375721 X-HE-Meta: U2FsdGVkX1+xSR6T5RSu1vgUiyESMudumuAZ30EWBo7rVGL6kiz+CtO6CdqM3+ng5i1PoQGsYIbeckFRFS4hq4TogBIN4sfk+7JJEgepF+IA/gfOl8V+S4TTn6UisC0u+agpurk0nNcarULor3TXNpBkHKAxytYdwAt3TxAc7NOqpG4aVSqeyDcyRpKsCjG9aiuoaXRLmuBZIot6F3zcuGPZALF2oQGgTVxi/Ix4x8PFyR7Dmz9H36fILeiSVZiPSBnlSmbjxuwyLUIxr50FxxDJM6m2k9X4vqS7Dc7SBEpmjiXcs4IZBY2kl8zbESrgE+8U1mm9zAYZrX+WdT/Va59wTAu0wDfhiCa/0117BAAmaZgl8SQEJdAgpJ5d7o6rVfqQjx9oMYOZFiO3RCxjALLBex3JN58e1glsn9W98ibCi8SvvamceFIXMbwTVunTpdIY1aQ25BGIew3tKLkoruRtMgK8VlVipaeRzNI40LJfZsWBu0TNEY9zU2I2zXDFM1LWBRdCV89V9zjDDNEjOPbC6056u3NOXrWPg7oeX+q1RSdtevS/EZ/e3ZuUs+rvU5G6HPx/wSe1t80Ltk9/JEyIjnXukQ7sw+BwdqdTV+dcGz4M+wsz3rJIPqajeyFzJNRTcHIVhoGxzTeWBT+Vt+PBhnfCWGCMmOxIXPaSzPlhtxTQvjxm5CtGGNG2V+WJeqwtZoHftLhgBLO9lO/BsD05vb8/i4U2UW7l8+skNXYYW2fcFCjC6w5570icWGGP93EwbwOFINH1ZWmpfvAtMAYMYCkrQ8CnbEbruvDo6EFb+6NcOe1tOt8+LYbPZFH8zR38JRZNqN0uwXTmcPyzoQ4OIXeBIqbYJJMJKC6jJoSyg+lldUkg3/AqfrZobuOi+I58UCpf5IgkHw9gNRiKllJpXRckFAWwEYmuN3abwOkFgd8guTlGE6fi7B4JHIWZlJABIBt3fOuT5rykImy nE7C5GvY iXvZOsMS+icsA6DP0NGj3cIAjG6aySGDLU1MG/BUpsfK0iyIbEn36NxZA9DmRZ+LvtMblF8pGCBzRM0MyObp5MPEJ+zpWPT/i/Iik+WTCh5TH5nd7M/AF2WY80VB7qnr63LGEUCRxOe07Zc74KQxGW2/tk6tjG/1kQp8I2U9a7PT5z5jIrX10j67/pHYXRwzDGz6WPwgY76kJHoLY5KBeLwqh1c5pk/uv/OumVAJL4tRiK5IusGWR2F6/Lu3kEhMeRo9txVXSzur5tfYjVE92brGiqcspz9gnoCOouFvJWMSZI38GUt74elwWR4utTTyHylPInyBHPKBwbEbS8Ckgyq3rijKpda7anZMSRAyy7JNLKa1n/1UUfoqanUf5b5YDDnYWFNANnqJ+Z4Ogm9INOOckFEcndCh/YOSgYD5KI1QzNbpLwk65Xb4OabCHtzmJPhMR/hQH/Yq7gYubSrvRkeKLsX/FPH8pZdZBE2gp2JcqBmd3bY+Y5HJ+IwNFx2TFv8+XVDXAaICwOF8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: With gcc-7 builds, an error happens with the controller button values being defined as const. Change to a define. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312141227.C2h1IzfI-lkp@intel.com/ Signed-off-by: Ryan McClelland --- drivers/hid/hid-nintendo.c | 44 +++++++++++++++++++------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c index 47af111ef3a2..2987083785f9 100644 --- a/drivers/hid/hid-nintendo.c +++ b/drivers/hid/hid-nintendo.c @@ -336,28 +336,28 @@ struct joycon_imu_cal { * All the controller's button values are stored in a u32. * They can be accessed with bitwise ANDs. */ -static const u32 JC_BTN_Y = BIT(0); -static const u32 JC_BTN_X = BIT(1); -static const u32 JC_BTN_B = BIT(2); -static const u32 JC_BTN_A = BIT(3); -static const u32 JC_BTN_SR_R = BIT(4); -static const u32 JC_BTN_SL_R = BIT(5); -static const u32 JC_BTN_R = BIT(6); -static const u32 JC_BTN_ZR = BIT(7); -static const u32 JC_BTN_MINUS = BIT(8); -static const u32 JC_BTN_PLUS = BIT(9); -static const u32 JC_BTN_RSTICK = BIT(10); -static const u32 JC_BTN_LSTICK = BIT(11); -static const u32 JC_BTN_HOME = BIT(12); -static const u32 JC_BTN_CAP = BIT(13); /* capture button */ -static const u32 JC_BTN_DOWN = BIT(16); -static const u32 JC_BTN_UP = BIT(17); -static const u32 JC_BTN_RIGHT = BIT(18); -static const u32 JC_BTN_LEFT = BIT(19); -static const u32 JC_BTN_SR_L = BIT(20); -static const u32 JC_BTN_SL_L = BIT(21); -static const u32 JC_BTN_L = BIT(22); -static const u32 JC_BTN_ZL = BIT(23); +#define JC_BTN_Y BIT(0) +#define JC_BTN_X BIT(1) +#define JC_BTN_B BIT(2) +#define JC_BTN_A BIT(3) +#define JC_BTN_SR_R BIT(4) +#define JC_BTN_SL_R BIT(5) +#define JC_BTN_R BIT(6) +#define JC_BTN_ZR BIT(7) +#define JC_BTN_MINUS BIT(8) +#define JC_BTN_PLUS BIT(9) +#define JC_BTN_RSTICK BIT(10) +#define JC_BTN_LSTICK BIT(11) +#define JC_BTN_HOME BIT(12) +#define JC_BTN_CAP BIT(13) /* capture button */ +#define JC_BTN_DOWN BIT(16) +#define JC_BTN_UP BIT(17) +#define JC_BTN_RIGHT BIT(18) +#define JC_BTN_LEFT BIT(19) +#define JC_BTN_SR_L BIT(20) +#define JC_BTN_SL_L BIT(21) +#define JC_BTN_L BIT(22) +#define JC_BTN_ZL BIT(23) struct joycon_ctlr_button_mapping { u32 code; -- 2.25.1