From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6B9EC4332F for ; Thu, 14 Dec 2023 22:17:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 454878D00F0; Thu, 14 Dec 2023 17:17:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 403928D00C7; Thu, 14 Dec 2023 17:17:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F2588D00F0; Thu, 14 Dec 2023 17:17:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 202008D00C7 for ; Thu, 14 Dec 2023 17:17:06 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E74911A0C9C for ; Thu, 14 Dec 2023 22:17:05 +0000 (UTC) X-FDA: 81566835210.27.4CF1A04 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 2C9D0180025 for ; Thu, 14 Dec 2023 22:17:03 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=WX7H+Zrw; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702592224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DOndnH0lG18vvOVhppdwTo3ViPA7l5XEHJHxXEXV2X8=; b=Lib/NAM9pGkF5cfti2xxDBeNIpT7EDbZ7KttugrBJff1MWcuWDwigPaA9ba3W2UXGWdxnJ uFD2HU5LUgncWQbbHFxzmUiGItI8dqp0rzouKgE+1bu3tFXIl3cam8TqAdf/yGNTtOkq/G l9htk1K6N6HNDhGGjwPLycoPrzgn6/I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702592224; a=rsa-sha256; cv=none; b=zfiHspfdCzvQboJ7G9FmDjWsKV1oFMTQ6JXVQPioqRKCqqvaNsHGFsWFJjHxsjxwCx/jiQ nF5WppcJhNlMWxlfrbk26JVhdniftvpl7TBeehoKG7lxGia3lRSa6DlPXjecJN2TArYVPq w2c3bjBi7FygX1W9RItKE48HWsma4iI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=WX7H+Zrw; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 340DB60ED4; Thu, 14 Dec 2023 22:17:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F662C433C8; Thu, 14 Dec 2023 22:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1702592222; bh=2D9nG2KNudL+10rZMcKkKt/VtIVyh9wWPQJtsj2OmR8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WX7H+ZrwBVrU3L1JS5De2zQh+c0BePlKvIWJc5LefMj36TYdyIPyIw3K38DgoEEWG jYwV2WvZdxeUat7eT0WhN8zQgD6v9xD/u3ern3xb7nSLxsDB09A3d7PKyyJPtJBmVA S4g5xo9qcSqYFX6zN/b7RpYjvP7M4VPQ73X3aRZc= Date: Thu, 14 Dec 2023 14:17:01 -0800 From: Andrew Morton To: Barry Song <21cnbao@gmail.com> Cc: Mel Gorman , baolin.wang@linux.alibaba.com, linux-mm@kvack.org, david@redhat.com, hannes@cmpxchg.org, huzhanyuan@oppo.com, linux-kernel@vger.kernel.org, shikemeng@huaweicloud.com, v-songbaohua@oppo.com, willy@infradead.org Subject: Re: [PATCH] mm: compaction: avoid fast_isolate_freepages blindly choose improper pageblock Message-Id: <20231214141701.29aef9815d3e743645786c1e@linux-foundation.org> In-Reply-To: References: <20231206110054.61617-1-v-songbaohua@oppo.com> <20231213130231.ksban2ovad4q4rxj@techsingularity.net> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 2C9D0180025 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: gs8ozu4eja6t16i7t93uee76p65ej8wz X-HE-Tag: 1702592223-976957 X-HE-Meta: U2FsdGVkX1+H97doFc3sCcBfq51wzryhPLOv2z5FNpkapM7ickqLHrtjd7/MGoEmcHXY3+ssc+cPNO9DXf9gUY4f2W7PopP/VV1mO6APm7VfJVSk6dQZ+DHgH56rzQuez3PgORry+9GxQ8R/jODosIGS2LZffkq/G/AE/cSERlG722orBmBz47j9d+5xep0ec0I1QSUU10GOs4DPZZ0taNnTtk6RPz0BRtK43e6r9b+W6U8BzmI/1QpLQ1sX5VGz+eSjZ69GoKAG0JJwebUn/KUEnSHEV0AbFFmDSEUtLRiIwHfrLfxiqPMnH1g32yD+g+mpRYUeEk4aaVRNmLTwTpxkGXnmNNbuwgEaFJOxXFlPGhp2bjeV99r9fbMSSgp0PdRhw5rRivTtr0HdK0HFkWF4eLBv0plOR7D0I2zDIfSEsyW0uPmxs+KnjjdwZ+8qk4EcHSzPMpskXV8Ypcv/uV66CxrGcntTsSHcZ7uJpVvQcYK2AAeBi/vdm0ZGmMlkfZcUtFHgw0rMjgd7Njf8dfswO1iMKWJB4TBiaF7Nq7g8dUZzjajQ98FKzH1OLoQPePaO2a0InoLGlZW63NNpHNdKN0H/akniUfjKqZiyWYgzbXjYrH8IokSrL4H1JgK/mntd3YxIG5P/qnNPR2G4CX+PqhH6QkT/wb7Mq2X0tyGUu+biwzKgrRqsm9dN4I+gp3UO8Nfgz42XKm+nDAYb5XkprQi/3JTnLPyuAkuvgfZy4P0mTTF/K6SZ16+xwcbxw+w/Dylg8lu2+I0EMFOQNVS/w0rLR6zGas/+rwPb5C3orLyso6/aog/oOytpqtn47EgIMWAbftdXmmZNTl8Ktc01wPlt+n6/HvM0zlySqaWWT5bB1KQeQHOLodmbIR02OXHg8okjqbW3S5PPCCSTwBwLEsasLgevsdUlOPIV9+SY77PkaG0uLvdiKdRe7O7dI3Fc39ZxXLxpoM96uXs +jN/wGGl qD6OOdZ/Fu7sQ/dIFf+hBjg+8dVtndnwo9tK9s5uNPQCK6c1OgvvSNqSjk2CGkjnJc9jCiHjW0ARRyboAAjNyZ/8oV4wRMu/32DUGFUStH3jirilouY9JuxhgP/Qaw95rAlV7g88bf3bZ6IXXS3t+oB1iXHszIk/YJOLvu4O45AarcvbGjN62zbjOg4kqKcGGuXB4CiwdB9A9HZsV0nUPiDVFivG+yVESAgVxzmpAzkn2Xkx/zqSNqjFlQsxCTbHjc/Eh2fLEzCDEXiYRtAYk+cGcfimPmByHkihJIC2bOlbe4rH+j3BKaNDqGGKPX7oG0PJA/EgUW1FUTibyjBjWEbmvMtVbrULSiLpIGXOrsEpaL5QqNYxO5TIAtbzQgzcq+Bd9Mw0DoZV59jH5H5ot5G+wwC8mJCNXI/uGNWRmM23Qdkh0niJzTLLUWqcdDDrtXEwVZXC+jfaRwOQnWdDJQ/na5XVyq2pXqF0Z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 14 Dec 2023 09:34:35 +0800 Barry Song <21cnbao@gmail.com> wrote: > > > Reported-by: Zhanyuan Hu > > > Signed-off-by: Barry Song > > > > Acked-by: Mel Gorman > > Hi Mel, > Thanks! > > Hi Andrew, > Given this patch has been in mm-stable, > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-stable&id=d19b1a1797 > does it still have a chance to collect Mel's tag？ That would require a rebuild of mm-stable, which is also a rebase. I don't think I've had to do that before - I'll occasionally rebase, but just to drop things - not a full rebuild from the quilt patches. If I end up having to do that then I'll somehow try to remember to make this change.