From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ED4FC4332F for ; Thu, 14 Dec 2023 19:41:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C6A18D00E2; Thu, 14 Dec 2023 14:41:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8280C8D00C7; Thu, 14 Dec 2023 14:41:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C9678D00E2; Thu, 14 Dec 2023 14:41:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 566ED8D00C7 for ; Thu, 14 Dec 2023 14:41:01 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 26639160BA6 for ; Thu, 14 Dec 2023 19:41:01 +0000 (UTC) X-FDA: 81566441922.19.C78D8CD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 6773340011 for ; Thu, 14 Dec 2023 19:40:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZBJ4R2IZ; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702582859; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yk9ycaohZvV71WmWBk2GdElDFnXfiIpBClEjuDcahDE=; b=0MCETCC5KHpdQvYRctDmpbv5eX/JvobBGJtdXfh/WOVq2K2wg1E3UdONfN4BhFl4Yv9YdD xMwI8xsF9WDKcRkGgnhKDA+P2s+0kN1lvDTRJPwWJnfaE510vrcFqUNOI8PwAzDBuB0FaT Tc7fmg9wLLfT+G5BYyfwZZzoA2hvXk8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZBJ4R2IZ; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702582859; a=rsa-sha256; cv=none; b=TtWVDSh17o5ood3ObXqLmy0dM03Rzcj9KeTu3Xx71C+titrAEtn4eyFQxuHayBHg5JmC1g jFo3541IOQMbx6Mh9i0txqI/ItTaxmTdUoMfZGwDU3zRliMMAwgQPx/d7tMr4zVo/ExnSR RPebx/FX9cGZereHD/CaUZXVXEqbpYs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 50DC262304; Thu, 14 Dec 2023 19:40:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB018C433C7; Thu, 14 Dec 2023 19:40:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1702582858; bh=K9B2txQTgSN99zWiymlTobnzZROd0qplmIqjISRpvQw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZBJ4R2IZRRRmCnfDh77WXtFkNC4CWWem9aaV9bQ/gtkE1e1KAqpTBTvDniPwCLNWq y1AS5HkupWrkEZ48wVv+Lct/2IKsYS7w+iab947cADM689VNdCBaPr/NxKIRWU4jTC +ELPAKemP2y9hD2EbUWxZFECFBe8sqKJYLOUprVI= Date: Thu, 14 Dec 2023 11:40:56 -0800 From: Andrew Morton To: Muhammad Usama Anjum Cc: Shuah Khan , Mike Rapoport , James Bottomley , kernel@collabora.com, "kernelci.org bot" , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: secretmem: Floor the memory size to the multiple of page_size Message-Id: <20231214114056.ec687939a411961db10e73df@linux-foundation.org> In-Reply-To: <20231214101931.1155586-1-usama.anjum@collabora.com> References: <20231214101931.1155586-1-usama.anjum@collabora.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6773340011 X-Rspam-User: X-Stat-Signature: jn988n463squdoqfmniw5r765w4pupac X-Rspamd-Server: rspam01 X-HE-Tag: 1702582859-472978 X-HE-Meta: U2FsdGVkX1/f+eFjZxdt0Pe+P1u4C6rkhPItaIW8T66U+5CK0fPNB/J9dSOfSAtxvNVFLEvCjCnOpBfqf3LFwm0eFKVEfcEFr2ILInL7A2jo6ZC4O1DQkCnX+J3kAuFEiYvoI+nIJu2DxAp8aaNYs7edRklCjAnIwT6/FHnjjsOjA1M3psrYblJWQdXGeiyGyW2ZOOmDYMe0qSGN00LNHDAPLzp3xECpwSMCw993C7hoT1misdCyx4ZazALczQVjaPOQdHOIrmTUEct67IOpcT8k4pyPQBLFtA8X8tpxZ5YpcLimof1Mo4E7ALDEY95YoqtDnsQaX2eWX7wy3ID4lERjGyJVEfvMFpgVqlaZgVDlz3d7Ybv/QvxVX4Q3Me0fb6UcCeHGu0jUoYQyaCyGZ5u9RSDJSCWVPziHdp22h9IVH2o0nbk/wq9g2XWv5BzVPDePsUay39odE1+rqkqpB7DW1E7aanmq2lOh92clJiu5afaWV6mYn9YHiMn0CAOP41eRkSRNQpWKVPKqXgGFyOSqC6wCbhgJdhq7B8pVryoXiWf9mynFTcFZs6Fg8rOkpio1utl5RCdOV/IVaOg2J7zIY+W5nqHgr5MgkKZXpKiHGuExB+9OfIfEckW1uw72dm1gO15KxZRIcxfoePAECEsWNkhFaqn7yk4JThrwhYxqKYUQGIZXxaTfc92to5lztEAayp1cUpdxp1jk3lvYaFT67OxL8asUovl5rn7d3AXvglgDT3KtFQ7iw2/FHz4g83xXpIj7MDlHatS51OFKZXH1XgseFR5L8ZiLonuO+ZHd6j4p2qdWeF0e5VKQ3OokEYAf2s7lb29VR1AVI8YJD0/YimWYbEyANLIpDcUqVRNDO5pGgs0GoBQ+NSN3c03u0Yl8lOrx2cwIT5O3xvmvDMJWPDrC/Nnu+yXOaHnfDXOo8BAms5UOZIqxSW8ODjLuGBFj5JHTjT9ru7XIAGb fT8hDdPW GN0NaZIHo0XOMDUuX9uG57l7SnPja8KM0MXhfxk4Orcm7l0V/nvncxPwFfohuwJXzP8SSmCUYSSDOVRwkiszY91J4J1labWXNCPrRMRUSHXEMnsXFTmZFNSt1QKWOjspuDXZZuebOPVvkg3SLPteyzIYpraPs9okzEH4i0QCihbG+ReyfUdr20UpKgeQaOQx7ufFUYsh3bLghambdvgXuidOuZ6ECnoyGyycpviHTIJGCh0fGmy3WbCm5rRylrKNjCNHzzv7aS9Y/9NVug7KA6QmSx1yc4TrJOrBR1BqUBypzxR+cxZoMlOmCSyjIuxe6uHY5Cxio/U3suHsoKTEUonyTibn9sa88dQAaAAGqAgicxB50MjKuM4WowQTjggw3QsGMbyj9Ac2w6UCBdAgmLaooFQTRlCGwYNGu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 14 Dec 2023 15:19:30 +0500 Muhammad Usama Anjum wrote: > The "locked-in-memory size" limit per process can be non-multiple of > page_size. The mmap() fails if we try to allocate locked-in-memory > with same size as the allowed limit if it isn't multiple of the > page_size because mmap() rounds off the memory size to be allocated > to next multiple of page_size. > > Fix this by flooring the length to be allocated with mmap() to the > previous multiple of the page_size. I'd like to understand how this was noticed, what the ongoing effect might be, etc. To help decide which kernel version(s) need the patch. > Fixes: 76fe17ef588a ("secretmem: test: add basic selftest for memfd_secret(2)") > Reported-by: "kernelci.org bot" Which is one of the reasons we're now placing a Closes: tag after a Reported-by:.