From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34D38C4332F for ; Thu, 14 Dec 2023 05:56:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 118216B0551; Thu, 14 Dec 2023 00:56:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A0DE6B0552; Thu, 14 Dec 2023 00:56:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE6FA6B0553; Thu, 14 Dec 2023 00:56:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C47906B0551 for ; Thu, 14 Dec 2023 00:56:53 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9C8111C108D for ; Thu, 14 Dec 2023 05:56:53 +0000 (UTC) X-FDA: 81564365106.22.272726A Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf15.hostedemail.com (Postfix) with ESMTP id 5B8E2A0004 for ; Thu, 14 Dec 2023 05:56:51 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=NofoJehk; spf=pass (imf15.hostedemail.com: domain of nicholas@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=nicholas@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702533411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4DZJYxEc4SZaDH8SYYalzXsdURynFs6mETQ32ZgpxKM=; b=8SBWueYPDFTsgP0Zd3pwMnvB4n0LTW2uO06f7gGOXULvEiWNusEOJk75yUW06FKcKCf/1U NPbUrL4L+Q+ynB5Cl/mpnjNLR//7YdqL4GbN1SRDmFe6ORqlHMqWO6gywhi2dXRHIfbS0L 3u34lG2VEteeCD+7aSP/1OGEl1Az6xE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702533411; a=rsa-sha256; cv=none; b=BkqQv8He4tN8NeXH8N8lGEFs6W21YNXi1nK4b+CTRX69JX/k24UrX6yq51CB5mF4vc+Unn TGCfz/pdEa2iPPhc3/8tBwny38o4uY0FOJabIggupYZVOnqzS4L9uenYuAm5hAPPVsCoeo 33ZyFIZCAErPPdGqXSMvpkr6QqhgSmM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=NofoJehk; spf=pass (imf15.hostedemail.com: domain of nicholas@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=nicholas@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3BE4nXMv016537; Thu, 14 Dec 2023 05:56:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=4DZJYxEc4SZaDH8SYYalzXsdURynFs6mETQ32ZgpxKM=; b=NofoJehkG1v/7XaD8ddU4a9rDfQnzy2vmJvYbu4KLssINrMmUNK+dBwynu4IIDfR7jxe Z6dgfJBLj4deEfuoUGLDvSmE/ytgfcAN+UV605pid6wBflOtIeFsNkQ2k9KogspsQBVT 1B8TczXry1rFjNEBlj0DAkGRpnVnB58yTfncgX3dy9ag/wtqUQKG6VC3YbMkTa4zWX1n 7IdO51h04/dgXxvW/CNpOIIBvWJkzHQyeOleH2LbHf73oVBtSphRnpRLNjz5HTT4UyAI ZaUlJWtmX9csugzao7RpVO04trbjfNkcI+HQpldS+IC3sVpH2VW75r64rS6avBfNnM6g ig== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uyu0ys81t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Dec 2023 05:56:45 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3BE5M76w005673; Thu, 14 Dec 2023 05:56:44 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uyu0ys7xe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Dec 2023 05:56:44 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3BDNcC4M014824; Thu, 14 Dec 2023 05:56:26 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3uw42kggr4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Dec 2023 05:56:26 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3BE5uOeY55116242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Dec 2023 05:56:24 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 020E52004E; Thu, 14 Dec 2023 05:56:24 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 87ABE20043; Thu, 14 Dec 2023 05:56:23 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 14 Dec 2023 05:56:23 +0000 (GMT) Received: from nicholasmvm.. (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 8575F606E7; Thu, 14 Dec 2023 16:56:19 +1100 (AEDT) From: Nicholas Miehlbradt To: glider@google.com, elver@google.com, dvyukov@google.com, akpm@linux-foundation.org, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: linux-mm@kvack.org, kasan-dev@googlegroups.com, iii@linux.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Nicholas Miehlbradt Subject: [PATCH 07/13] powerpc/kprobes: Unpoison instruction in kprobe struct Date: Thu, 14 Dec 2023 05:55:33 +0000 Message-Id: <20231214055539.9420-8-nicholas@linux.ibm.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231214055539.9420-1-nicholas@linux.ibm.com> References: <20231214055539.9420-1-nicholas@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 3Us5CtheJoZjlpslVofjgPDJzZ6Fl4Vu X-Proofpoint-ORIG-GUID: rBBFY_dP7t41UbfjaY26lzdS7EmDxzzd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-14_02,2023-12-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 bulkscore=0 suspectscore=0 mlxlogscore=711 priorityscore=1501 impostorscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312140035 X-Stat-Signature: wp7odjb7k5q4sad67855d4bmsfzt6b63 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5B8E2A0004 X-Rspam-User: X-HE-Tag: 1702533411-100062 X-HE-Meta: U2FsdGVkX1+LaatO0Cw3/b2UW0m97Y/J7jKAmT+DkPp3fHPu15R8KVJHCNSqxsoXJdmOWDytVNPEVhxCtRfORtX6wYWiJ5OMuxI1WifY5af2YK0hAZpHW950qfYo1yUPN8LCTYBe/PsP4PbDZ7Vud55+hD2i1KAQ5DnAasJfUC8jmXVA9Euwf2S/FhelsB0XS1mSiQPFT/jWozhdpIXxhXWDdVxqjdYzzURhRXgc84NCXDwJlZaxzkea73qbo69XS4NNkgl2U5ev6pkpdads/R6ZtXuT/fYS4kRf2exuB2WBhWxMryZD3scCEcpS8EXIpG31ldKeiioQTAyzD6mWmjD9tkfRpHV9KSGP70uH5gdZqism0QoMbqk05ZbahdMYyqENqK7lYuXKpxJwq70MvaIvgSWdTVQuAbOGvjMPpEn05lQvC2qv+HXTvshrXDCuPNBxH+iZdfdrNQlKHVE18erTeV7PrPZG8whm1KI6dVzlt2ivJYfcIRnwAmbu6RZ5f6+QRKWXISFngp0eQK8hYTbr680UBI+jAloaq7XN+8MhC183zjg7YB+gR6iMoeLIqXS5Ex6oT2cF+yrW/4qc9xo3pMYaKPettSeWheA2U9bxwGMK6+2MtJV0ACWMu1X/j/pDU6yUPsQygbVV40so63BUh1erNCY1A2/jhphBVy3VXAC+lKL41idkOg/gwLCWWIJ5JfP7Z10TW/tN3bnpSAD37XkKi3K1oMKm7iZR1rISncT0wPAIxXhV93D5St29wgmI/HZJ71Wfywe/W2/bCad9ylRHc+LHyApctEv2+1P6zoVF8ZwndMIQaAnK8VnvOmRucEJtSYVEESnLA4W0Yvp+qe90Kb2ISZi6MlDB1QlsbGxUONG9mDvgmuA+v2YeCuziNaEPxs5oG2W+kjJHWtjYb950ze40DKER2e5r5ZZge/dnfk7OucM6ryDkZmBQ+qCg95E71m4PS9Pu0uK j1VjZ0y6 8VDeLmmJpcpMMV+CNXbrfh83h+omvFnZYg2CHxYq5x6MBZ4GvcxtqfmSKYQXgRrSg1csgqWjCzBtIQcJFtZuNl7u6BACRXPqNu70cQRG7PP1QGhD41iO6G1PAeE4GVxLXWYcmPxwvNFoj+jW7SKjeVHUIGO+o6LsTK4D156k454WDk8P0wp02z772gOYZaAeQMgbLtWQhQXC39zLP8fUFLt+Y+MLnSsuFEP1TxGVpm+FJS8dJMJ1OxFReMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: KMSAN does not unpoison the ainsn field of a kprobe struct correctly. Manually unpoison it to prevent false positives. Signed-off-by: Nicholas Miehlbradt --- arch/powerpc/kernel/kprobes.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powerpc/kernel/kprobes.c index b20ee72e873a..1cbec54f2b6a 100644 --- a/arch/powerpc/kernel/kprobes.c +++ b/arch/powerpc/kernel/kprobes.c @@ -27,6 +27,7 @@ #include #include #include +#include DEFINE_PER_CPU(struct kprobe *, current_kprobe) = NULL; DEFINE_PER_CPU(struct kprobe_ctlblk, kprobe_ctlblk); @@ -179,6 +180,7 @@ int arch_prepare_kprobe(struct kprobe *p) if (!ret) { patch_instruction(p->ainsn.insn, insn); + kmsan_unpoison_memory(p->ainsn.insn, sizeof(kprobe_opcode_t)); p->opcode = ppc_inst_val(insn); } -- 2.40.1