From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1F81C4167B for ; Thu, 14 Dec 2023 05:56:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B0498D0097; Thu, 14 Dec 2023 00:56:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 33A1D8D0083; Thu, 14 Dec 2023 00:56:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1161D8D0097; Thu, 14 Dec 2023 00:56:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E8D398D0083 for ; Thu, 14 Dec 2023 00:56:37 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B6128120480 for ; Thu, 14 Dec 2023 05:56:37 +0000 (UTC) X-FDA: 81564364434.01.4A60F1F Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf06.hostedemail.com (Postfix) with ESMTP id 5507618000D for ; Thu, 14 Dec 2023 05:56:35 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=HviIdLMX; spf=pass (imf06.hostedemail.com: domain of nicholas@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=nicholas@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702533395; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/mQKPh+Q/+oVqTYrm5JhFDCdjY5bZbTlHx3Tfk9a0cM=; b=TXRmtR2IRlIL/JZrVdaoKgNxYeVzwMZ38V5bnFJ9fUMqxS2qe+Hyir8H0Lpfn8XhqXLygn d0hxDZLY6SEGszQkLreyRaaG2qUJtcmipz9MwfY9u/lgqWstI/S2JX4Hw6YG6Pg9MtiWhq XGm8n7jTBIbEi1qFidQ674jjVd8KtNc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702533395; a=rsa-sha256; cv=none; b=1jDhBsO/Piq5cmDubfYf/qY3Txo6vsBO7jadg1BW1BH8n5nb03Mwv8dQFXskRJAlA/YYI0 107/z0wiZechuYsk0EPQoRMhnj5+MjtJhFpMXxs0XZor1Y7hDU61clT7/KER7bU59N+cxT 3Ipu6v7TFsEH405b7Rv81932Q4LcGvg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=HviIdLMX; spf=pass (imf06.hostedemail.com: domain of nicholas@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=nicholas@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3BE2Uej9022139; Thu, 14 Dec 2023 05:56:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=/mQKPh+Q/+oVqTYrm5JhFDCdjY5bZbTlHx3Tfk9a0cM=; b=HviIdLMX+gGsWGnJUfcgJ1zEBu48XMwnVfecoXiEmf6Tv6qT4swY5ic30eZT4ZCJaK7F 2tVgJWOTwb1EQta+JtuvXkYe+n0LoOzO0x4ze5EeVexeEV/A7fH+4kL6KDkGSsOgKjCj n3tZsn8S9GAuTnCSmmgcNu1Cjo17RPYnwC/nKQ8EkuxfFKe8TLi/BQ2ZF1BYfO2gJBt2 kK3hoq2EcfsjQfS67rq0cjnQe2/6PR3IwJUEIKI3IFGLHTIqHrioiAHQmyNZO+BxFiWr NcMVBwL3zgCKwv09Az1XFXvrpqEHElxwIXHgRZHZXQQqOjeTyQYS5IB1vpQm9hJaNkfS LA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uyjg3cj8s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Dec 2023 05:56:27 +0000 Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3BE5r8A1026718; Thu, 14 Dec 2023 05:56:27 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uyjg3cj7a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Dec 2023 05:56:27 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3BE5cXLZ013892; Thu, 14 Dec 2023 05:56:26 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3uw592dwf3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Dec 2023 05:56:25 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3BE5uOb944237272 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Dec 2023 05:56:24 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2C18920040; Thu, 14 Dec 2023 05:56:24 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B55CF20043; Thu, 14 Dec 2023 05:56:23 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 14 Dec 2023 05:56:23 +0000 (GMT) Received: from nicholasmvm.. (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 92302606DB; Thu, 14 Dec 2023 16:56:19 +1100 (AEDT) From: Nicholas Miehlbradt To: glider@google.com, elver@google.com, dvyukov@google.com, akpm@linux-foundation.org, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: linux-mm@kvack.org, kasan-dev@googlegroups.com, iii@linux.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Nicholas Miehlbradt Subject: [PATCH 09/13] powerpc: Disable KMSAN checks on functions which walk the stack Date: Thu, 14 Dec 2023 05:55:35 +0000 Message-Id: <20231214055539.9420-10-nicholas@linux.ibm.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231214055539.9420-1-nicholas@linux.ibm.com> References: <20231214055539.9420-1-nicholas@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: bbcuSHGLeoKEVuj7srCG-ZCZayTjEdOS X-Proofpoint-GUID: KH91wVFkQGDFAZOFPfyiwzBaXkKHaRsA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-14_02,2023-12-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 priorityscore=1501 suspectscore=0 spamscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312140035 X-Stat-Signature: r67wqnh713se8p7wqpxi6unjk6ehdr9k X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5507618000D X-Rspam-User: X-HE-Tag: 1702533395-127619 X-HE-Meta: U2FsdGVkX193Ody7AHhENyJl5HCVr7o+gxAYZbY8yN7ClNIiMDQc0vxngUTJux8C6KQh89fWc/HhWJKxpWJMNz81Nr7qWLUg4Rcn45J2v4767/Jy84Rdp3l4n67xGgtspQn+mfjrBGx/Oxm6iSSuGXrcDVq3cHErRxmkCZXNIezmOj8AVaid65OYEwzOoaCoT+g5K85eikLarXpptwRrDs+YhUCH82GHbrAcGSK9pJYD8TBX9xatxKVUN6JmfdutWrkoTKT2fRmeXWiC/bG8P/6SCuIGnERWYMs68e8ZRo0UNV1Dbl/2fkyEtghWMFhEQ2OnOPccepYpqy9ThEZtiuFONa7FZOEIe1uL7/AKdUEXouV4ZfezFzEiZpwouDAGGR4P8k7W9LT5HLuP/HaK5AiSXMv6VYRSg4rajxqoOH5GgZuD0sABZ7s4j76LbWamRCXcOmkaybX4N3X1JB0qrKVVhz6DRylDvqr84aQXykPNeJPh5gML6a2eve2G/4N1KC8jq2l0SISKxl9Ri/8vB7oaS2X1TsbirQh5INNQQqJ0sKZOmXcUEhuteBfasVgvH9UIsf0n35lyJ1w0t6fUXWuFx/mQxHT7zOkgRVV5SDgaLbEQlrQLp77eN6Fuxr5hH1HllYlsliyqtn0dUjZFq8UeDHNqVaFRZSFfpBhjga+LdOAVjUnbuzM11yQzNU448fD/UEJAtoDR9l4KBRd5z0zlwgfRwX+0bq3deO2vHu8qnCMiIZbQBCfoVLgdCZm0R/0RM1Pn8/xO5wJduw1HkGYm+8Vse7KeIfXeIRGiTRjgoX0wp5h50w7L/OVeEZ9oju55CdqJShQWlLSjQAzvk+F29z/pXQomKPuSvzrf5CuLb5xBi2qkc2JmtcWQR+mj6YI+tduy3iUAPYDiVDNzxOWi4is1neavWGc2WKK4eh9K9uzep/z5puQd3tuZDKeJk2J2jjYrNDaKpYE4Z1b feEh44ye AwunEsSdbx5vfK3CfgXtc+kGFvzbyqUX+LMxRk7urNYt+Zec2x8eHKYYZQTi3WVHVvfSMGXFHoHo7f709s1KuTmyZ/EyeX6me/JSTLjERqrX5XztpOiZUi7Qaxvuw8NUubfOotyc6mL11ATMIhLn8HXb7fwgozGzVe/ElJ56S83N5F+szVkxdqOHsd7iwnBs8W0bggn3H/sdzTXXAIRm5Z33PMnl3ZX/iLzyQkobfRPgrpKmXuU7wyNAqtzeB8yAoORiwzxg15r57/T1NAjLtT26rhA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Functions which walk the stack read parts of the stack which cannot be instrumented by KMSAN e.g. the backchain. Disable KMSAN sanitization of these functions to prevent false positives. Signed-off-by: Nicholas Miehlbradt --- arch/powerpc/kernel/process.c | 6 +++--- arch/powerpc/kernel/stacktrace.c | 10 ++++++---- arch/powerpc/perf/callchain.c | 2 +- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index 392404688cec..3dc88143c3b2 100644 --- a/arch/powerpc/kernel/process.c +++ b/arch/powerpc/kernel/process.c @@ -2276,9 +2276,9 @@ static bool empty_user_regs(struct pt_regs *regs, struct task_struct *tsk) static int kstack_depth_to_print = CONFIG_PRINT_STACK_DEPTH; -void __no_sanitize_address show_stack(struct task_struct *tsk, - unsigned long *stack, - const char *loglvl) +void __no_sanitize_address __no_kmsan_checks show_stack(struct task_struct *tsk, + unsigned long *stack, + const char *loglvl) { unsigned long sp, ip, lr, newsp; int count = 0; diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c index e6a958a5da27..369b8b2a1bcd 100644 --- a/arch/powerpc/kernel/stacktrace.c +++ b/arch/powerpc/kernel/stacktrace.c @@ -24,8 +24,9 @@ #include -void __no_sanitize_address arch_stack_walk(stack_trace_consume_fn consume_entry, void *cookie, - struct task_struct *task, struct pt_regs *regs) +void __no_sanitize_address __no_kmsan_checks + arch_stack_walk(stack_trace_consume_fn consume_entry, void *cookie, + struct task_struct *task, struct pt_regs *regs) { unsigned long sp; @@ -62,8 +63,9 @@ void __no_sanitize_address arch_stack_walk(stack_trace_consume_fn consume_entry, * * If the task is not 'current', the caller *must* ensure the task is inactive. */ -int __no_sanitize_address arch_stack_walk_reliable(stack_trace_consume_fn consume_entry, - void *cookie, struct task_struct *task) +int __no_sanitize_address __no_kmsan_checks + arch_stack_walk_reliable(stack_trace_consume_fn consume_entry, void *cookie, + struct task_struct *task) { unsigned long sp; unsigned long newsp; diff --git a/arch/powerpc/perf/callchain.c b/arch/powerpc/perf/callchain.c index 6b4434dd0ff3..c7610b38e9b8 100644 --- a/arch/powerpc/perf/callchain.c +++ b/arch/powerpc/perf/callchain.c @@ -40,7 +40,7 @@ static int valid_next_sp(unsigned long sp, unsigned long prev_sp) return 0; } -void __no_sanitize_address +void __no_sanitize_address __no_kmsan_checks perf_callchain_kernel(struct perf_callchain_entry_ctx *entry, struct pt_regs *regs) { unsigned long sp, next_sp; -- 2.40.1