From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C5FFC4167D for ; Wed, 13 Dec 2023 23:39:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C25396B05AB; Wed, 13 Dec 2023 18:39:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B842B6B05A9; Wed, 13 Dec 2023 18:39:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A00906B05A6; Wed, 13 Dec 2023 18:39:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 83F486B05A3 for ; Wed, 13 Dec 2023 18:39:35 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5AAD4160AB3 for ; Wed, 13 Dec 2023 23:39:35 +0000 (UTC) X-FDA: 81563414310.22.C2C1FB1 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf05.hostedemail.com (Postfix) with ESMTP id 04DA3100023 for ; Wed, 13 Dec 2023 23:39:32 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Rss4RCOr; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf05.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=iii@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702510773; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0tC4Q68qibnNxZ7EGQhqKNfW/oX4pAJGU/AeYW+RHN4=; b=UQ5s1irHb1UH9a5q8pARfRmKSs6w0lUD/zPnmfd8jzz1tqeggN4l4RK8SmkMeDBrgGhYCk QFfe/c5VMh9ol5ZtqCkXPQ3ItK3bos/Of4eQaZ3zwNdn0qP56PAkFlpnLzMispPPtblKoj kKBfgO6DzAG1ff1lInm11Y+qFzrEzfE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Rss4RCOr; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf05.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=iii@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702510773; a=rsa-sha256; cv=none; b=cH7imIPyLBXOtmxTIvpyZArnUhOCxXOciLABDO7hXBlqv+f9qsuZuyyIBuiiy8YT2TjAbi 7JtkJSqvrO8Nfk3jXQowoPA21IzFnWtKYTNTDpMYa5gOeGJp6VZcYHkRqAb8I/pVQpr8UY /tUhf19c0lt4F8Ngi+FAhtarehspuEA= Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3BDKglgr015451; Wed, 13 Dec 2023 23:39:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=0tC4Q68qibnNxZ7EGQhqKNfW/oX4pAJGU/AeYW+RHN4=; b=Rss4RCOrgoAMSvzDDBKNQmOKsMQpX2JZRwsnRmSbpLlGDcGLiQeVxLfRsbiqgS9GwzYm XOiP840M3jtAvF4d08X8CfHGgWwVd002Z5mfNbmUbXgylUMlNGtf1cnGmkCrz96eHf1x YLtu1/qex5P6XL6kHHBZ8G4SCs9Qu5B6qniYV7axaRAq6Njpys/vPe4YQNw+buOoIdYy kjs5439plVXELppWOzBApGE3+QsJ0Uxv+eNquISmqyraK+aBZ446u9tpwM9z/9KaTFzc gX8Gmfvs3M4ETfqusc9ypmhRzst1jdpnLx43/sTDo1FptzCCQmYWFzfsqlFDnefbsP8P eQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uykvmuvrj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Dec 2023 23:39:25 +0000 Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3BDMfmvh022983; Wed, 13 Dec 2023 23:39:24 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uykvmuvg3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Dec 2023 23:39:24 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3BDM0FVa012620; Wed, 13 Dec 2023 23:36:20 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3uw3jp4n7t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Dec 2023 23:36:20 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3BDNaHKZ31916778 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Dec 2023 23:36:17 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B934120043; Wed, 13 Dec 2023 23:36:17 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 53B7F20040; Wed, 13 Dec 2023 23:36:16 +0000 (GMT) Received: from heavy.boeblingen.de.ibm.com (unknown [9.171.70.156]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 13 Dec 2023 23:36:16 +0000 (GMT) From: Ilya Leoshkevich To: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka Cc: Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle , Ilya Leoshkevich Subject: [PATCH v3 05/34] kmsan: Fix is_bad_asm_addr() on arches with overlapping address spaces Date: Thu, 14 Dec 2023 00:24:25 +0100 Message-ID: <20231213233605.661251-6-iii@linux.ibm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213233605.661251-1-iii@linux.ibm.com> References: <20231213233605.661251-1-iii@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 8zwUI59DJyquKUco1wEpNP13PakX9rLY X-Proofpoint-ORIG-GUID: EAgeeP8DOV5nEsx3Wa0hsknLXVRnE7My X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-13_14,2023-12-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 mlxscore=0 adultscore=0 spamscore=0 mlxlogscore=891 clxscore=1015 priorityscore=1501 suspectscore=0 impostorscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312130167 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 04DA3100023 X-Stat-Signature: ots19sgs7txpc8dixo3d7ekjjumtpyxc X-Rspam-User: X-HE-Tag: 1702510772-830471 X-HE-Meta: U2FsdGVkX18Azkeip8v1r1tkWeZCHlRHcgN0ukm9hFzZcojYku40vKMWQv45e+dbnUBaht459w3Asf/XZ9bQ1PK/tjNWhkJLxFTm7WT9oz50EH/TXCZxpTWeNWd0KurBtjkcYyeHzyVACyXscWsWb9OPXEbW0jG0aSkc5VIPOdFdKZUVHC59iKvd4Qz3sD2xSItlFUQ05zyvD63dvybR5GL70sDW1VMtQzsg1M9J0RtedviIXFrl1OuiJrNIK9h5O9cmBv74UWl0T79NvTXko+9S0t/sna1iGhNfYa46KykKMXvwYHlI0P7SfPfAIyMkYU+Eo3BjXuKluo7wVnoG2VgoLj6eXirPabo/WbaPmjq1bnx8wKl06j9UBlvWyFPVbzF6FBeUeXPiUhqLOpH6Kj/GZc7eGlxqs9hh3YN0h0EDBIgLGogWtR2VvEThZzcFV4Xq0R4LVd2z5ApFfubg8Seq4HWxiPtKULr0k8BTC4Rybx6VMGkbQW2TktcdQq6w/px+hqT8e58LyUt33BaY/mdBRFQrHDMSbzCdR2y8wCS/ymZQzyPgNQG32Q7OCyQ7JgLK+bHXH0eRkx7AYpeUaGlyxuFybnDkngSi47A7Ktv8qBG636DpXSbv3qtVbDdfLduF+wzMw193xWjJKklrlrvOxRVLvzGmv2NyQzZaqEco4wNJrzFODofCBvqScaZaN4wZq/yZJwYD+acO1AGuK1e3x/WTxEqay5uPrcCxUmxM7ji4DdojE94bNCCOvBrMMZOxMazxWgPfbR12aWas+6pCFBpU7xQyD7FSWwccFqt4H6/+/IvV2jC0kFL5o89NN9Pt/wImkTuosqyfTgaIHrxaAybVdXMOJAfqCx03aaQpwyM7oJ1emPROGLbGc8hX+srb4ytsQ9Y4VFdYS7m3vlKbRp9/i62W2HF4lAgEq+20rZmmfsq8IyXJliRh1cQ8lQbG4z7F9NgNZIreyxC KRyKZPGE eQ4gk+hOUxqaT89P4uzLcxt6JQgu8cYL5fzRIccS2JYyKx+15/53slaA3L/MLMtbIdpyul/4hrubYxI7z6KR7/pEMu6wWIR8bA4/JmyJEmtD98cq3tU1048Phr4cVjnlSxtZCV9DOjoKDg7+7gpIHhJwG/mPVgZXl/Ns06ooeY/G6v0soYzEDu1GVtfe4AFjnE0+UWX0qFVYQpaYrr+nxcIaXyiiWN7w+eL+LgbqmbbnMZe+CONt4ZfEyXpv/3FeJ10stCjKLnTSQYPvXBtVI1sm074tO5QpbhvEw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Comparing pointers with TASK_SIZE does not make sense when kernel and userspace overlap. Skip the comparison when this is the case. Reviewed-by: Alexander Potapenko Signed-off-by: Ilya Leoshkevich --- mm/kmsan/instrumentation.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/kmsan/instrumentation.c b/mm/kmsan/instrumentation.c index 470b0b4afcc4..8a1bbbc723ab 100644 --- a/mm/kmsan/instrumentation.c +++ b/mm/kmsan/instrumentation.c @@ -20,7 +20,8 @@ static inline bool is_bad_asm_addr(void *addr, uintptr_t size, bool is_store) { - if ((u64)addr < TASK_SIZE) + if (IS_ENABLED(CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE) && + (u64)addr < TASK_SIZE) return true; if (!kmsan_get_metadata(addr, KMSAN_META_SHADOW)) return true; -- 2.43.0