From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>,
Alexander Potapenko <glider@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
David Rientjes <rientjes@google.com>,
Heiko Carstens <hca@linux.ibm.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Marco Elver <elver@google.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Pekka Enberg <penberg@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Vasily Gorbik <gor@linux.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>,
Dmitry Vyukov <dvyukov@google.com>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-s390@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Sven Schnelle <svens@linux.ibm.com>,
Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH v3 28/34] s390/mm: Define KMSAN metadata for vmalloc and modules
Date: Thu, 14 Dec 2023 00:24:48 +0100 [thread overview]
Message-ID: <20231213233605.661251-29-iii@linux.ibm.com> (raw)
In-Reply-To: <20231213233605.661251-1-iii@linux.ibm.com>
The pages for the KMSAN metadata associated with most kernel mappings
are taken from memblock by the common code. However, vmalloc and module
metadata needs to be defined by the architectures.
Be a little bit more careful than x86: allocate exactly MODULES_LEN
for the module shadow and origins, and then take 2/3 of vmalloc for
the vmalloc shadow and origins. This ensures that users passing small
vmalloc= values on the command line do not cause module metadata
collisions.
Reviewed-by: Alexander Potapenko <glider@google.com>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
arch/s390/boot/startup.c | 8 ++++++++
arch/s390/include/asm/pgtable.h | 10 ++++++++++
2 files changed, 18 insertions(+)
diff --git a/arch/s390/boot/startup.c b/arch/s390/boot/startup.c
index 8104e0e3d188..e37e7ffda430 100644
--- a/arch/s390/boot/startup.c
+++ b/arch/s390/boot/startup.c
@@ -253,9 +253,17 @@ static unsigned long setup_kernel_memory_layout(void)
MODULES_END = round_down(__abs_lowcore, _SEGMENT_SIZE);
MODULES_VADDR = MODULES_END - MODULES_LEN;
VMALLOC_END = MODULES_VADDR;
+#ifdef CONFIG_KMSAN
+ VMALLOC_END -= MODULES_LEN * 2;
+#endif
/* allow vmalloc area to occupy up to about 1/2 of the rest virtual space left */
vmalloc_size = min(vmalloc_size, round_down(VMALLOC_END / 2, _REGION3_SIZE));
+#ifdef CONFIG_KMSAN
+ /* take 2/3 of vmalloc area for KMSAN shadow and origins */
+ vmalloc_size = round_down(vmalloc_size / 3, _REGION3_SIZE);
+ VMALLOC_END -= vmalloc_size * 2;
+#endif
VMALLOC_START = VMALLOC_END - vmalloc_size;
/* split remaining virtual space between 1:1 mapping & vmemmap array */
diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h
index 601e87fa8a9a..d764abeb9e6d 100644
--- a/arch/s390/include/asm/pgtable.h
+++ b/arch/s390/include/asm/pgtable.h
@@ -107,6 +107,16 @@ static inline int is_module_addr(void *addr)
return 1;
}
+#ifdef CONFIG_KMSAN
+#define KMSAN_VMALLOC_SIZE (VMALLOC_END - VMALLOC_START)
+#define KMSAN_VMALLOC_SHADOW_START VMALLOC_END
+#define KMSAN_VMALLOC_ORIGIN_START (KMSAN_VMALLOC_SHADOW_START + \
+ KMSAN_VMALLOC_SIZE)
+#define KMSAN_MODULES_SHADOW_START (KMSAN_VMALLOC_ORIGIN_START + \
+ KMSAN_VMALLOC_SIZE)
+#define KMSAN_MODULES_ORIGIN_START (KMSAN_MODULES_SHADOW_START + MODULES_LEN)
+#endif
+
/*
* A 64 bit pagetable entry of S390 has following format:
* | PFRA |0IPC| OS |
--
2.43.0
next prev parent reply other threads:[~2023-12-13 23:40 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 23:24 [PATCH v3 00/34] kmsan: Enable on s390 Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 02/34] kmsan: Make the tests compatible with kmsan.panic=1 Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 04/34] kmsan: Increase the maximum store size to 4096 Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 05/34] kmsan: Fix is_bad_asm_addr() on arches with overlapping address spaces Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 06/34] kmsan: Fix kmsan_copy_to_user() " Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 08/34] kmsan: Remove an x86-specific #include from kmsan.h Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 10/34] kmsan: Export panic_on_kmsan Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 11/34] kmsan: Allow disabling KMSAN checks for the current task Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 14/34] mm: slub: Let KMSAN access metadata Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 15/34] mm: slub: Unpoison the memchr_inv() return value Ilya Leoshkevich
2024-01-02 16:10 ` Vlastimil Babka
2023-12-13 23:24 ` [PATCH v3 16/34] mm: kfence: Disable KMSAN when checking the canary Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 17/34] lib/zlib: Unpoison DFLTCC output buffers Ilya Leoshkevich
2023-12-22 11:35 ` Alexander Potapenko
2023-12-13 23:24 ` [PATCH v3 18/34] kmsan: Accept ranges starting with 0 on s390 Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 19/34] s390: Turn off KMSAN for boot, vdso and purgatory Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 20/34] s390: Use a larger stack for KMSAN Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 21/34] s390/boot: Add the KMSAN runtime stub Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 22/34] s390/checksum: Add a KMSAN check Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 23/34] s390/cpacf: Unpoison the results of cpacf_trng() Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 24/34] s390/cpumf: Unpoison STCCTM output buffer Ilya Leoshkevich
2023-12-20 11:04 ` Alexander Potapenko
2024-01-02 14:38 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 25/34] s390/diag: Unpoison diag224() " Ilya Leoshkevich
2024-01-02 14:56 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 26/34] s390/ftrace: Unpoison ftrace_regs in kprobe_ftrace_handler() Ilya Leoshkevich
2024-01-02 14:56 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 27/34] s390/irqflags: Do not instrument arch_local_irq_*() with KMSAN Ilya Leoshkevich
2023-12-22 11:27 ` Alexander Potapenko
2023-12-13 23:24 ` Ilya Leoshkevich [this message]
2023-12-21 12:14 ` [PATCH v3 28/34] s390/mm: Define KMSAN metadata for vmalloc and modules Alexander Gordeev
2024-01-02 15:05 ` Heiko Carstens
2024-01-04 10:03 ` Alexander Gordeev
2024-01-04 11:34 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 29/34] s390/string: Add KMSAN support Ilya Leoshkevich
2024-01-02 15:05 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 31/34] s390/uaccess: Add KMSAN support to put_user() and get_user() Ilya Leoshkevich
2023-12-13 23:24 ` [PATCH v3 32/34] s390/unwind: Disable KMSAN checks Ilya Leoshkevich
2024-01-02 15:09 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 33/34] s390: Implement the architecture-specific kmsan functions Ilya Leoshkevich
2023-12-20 11:27 ` Alexander Potapenko
2024-01-02 15:14 ` Heiko Carstens
2023-12-13 23:24 ` [PATCH v3 34/34] kmsan: Enable on s390 Ilya Leoshkevich
2024-01-02 15:15 ` Heiko Carstens
[not found] ` <20231213233605.661251-31-iii@linux.ibm.com>
2024-01-02 15:06 ` [PATCH v3 30/34] s390/traps: Unpoison the kernel_stack_overflow()'s pt_regs Heiko Carstens
[not found] ` <20231213233605.661251-2-iii@linux.ibm.com>
2024-01-02 15:17 ` [PATCH v3 01/34] ftrace: Unpoison ftrace_regs in ftrace_ops_list_func() Steven Rostedt
2024-06-12 15:37 ` Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213233605.661251-29-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=42.hyeyoo@gmail.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@linux.ibm.com \
--cc=cl@linux.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=rostedt@goodmis.org \
--cc=svens@linux.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox