From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AFEDC4332F for ; Wed, 13 Dec 2023 23:36:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C22356B059D; Wed, 13 Dec 2023 18:36:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BAA198D006B; Wed, 13 Dec 2023 18:36:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95FE16B059E; Wed, 13 Dec 2023 18:36:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 663168D0072 for ; Wed, 13 Dec 2023 18:36:48 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 40AFD16035A for ; Wed, 13 Dec 2023 23:36:48 +0000 (UTC) X-FDA: 81563407296.10.7F8E5AA Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf18.hostedemail.com (Postfix) with ESMTP id F3BAB1C0013 for ; Wed, 13 Dec 2023 23:36:45 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=rQjQFy0w; spf=pass (imf18.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=iii@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702510606; a=rsa-sha256; cv=none; b=gM2jRRmGyrrwtxLqgfS+5VE1yyDmFu7zAUkN/7pEs55P25YgG7dhvNs4orUxLw8IgteHIo zY3f7aUQHPPD0djaOcPdWfTAuhXeNbeXCv1q1xZZGj3oxYv80wEvmLrafIrtjUI47REyIA NQ84x+vjB+/KMgpwz6PNAzFQSk51aKo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=rQjQFy0w; spf=pass (imf18.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=iii@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702510606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VOrBlHsfakvcZe1XK7OFH4H3N77vpLrrwB2MGspTrGw=; b=i9HYY/aTy/68CbiSmvzCDB+Pp7qE2vDFXsZNdy1p8fCjcPO6eNl3FJocGNGodqW8i0MXri AiTLvysDPy1YaDGROC/9hS0bOINvfWtwbgExDpoX7cSYQqTp1WHA2+fmCxGDBA6coQ7lw/ BnuIMFO5lDvkoCoAC1ydF3lgzcYlV14= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3BDKrAPv021496; Wed, 13 Dec 2023 23:36:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=VOrBlHsfakvcZe1XK7OFH4H3N77vpLrrwB2MGspTrGw=; b=rQjQFy0wPuUwau2ppdq++EV6noT4UNw7RODVhrwnRKuOTNNPcaYXY8qDYRLsiPxvzvwr YADUDpoNYoPEn1KoAjxGiJ1L/mjeBJACAh20x9PXS4BfwEgpxhX1HTl/Sf+jv40NvuBk PQ540BjKBkBgIdxYHuDztQYjf/H1avsFfP+RnpSResmI+H4q3oXKic9uXpYq8QXheP/+ 6mVD+S+SCOUU+viTuR/NcNKmuw6ZnD4PDyfdwaBhN/2NwYUiKup05BnlhfD362I8yz/M cu8ZGCW/OnXVRbQdvqI2X9/bflvGaWIfI1zDp0UsCsvekt3R7tKUXpM+qvsQgVQB8WqH qw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uym1sbn7n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Dec 2023 23:36:39 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3BDNQea8021795; Wed, 13 Dec 2023 23:36:38 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uym1sbn7b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Dec 2023 23:36:38 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3BDMk9JC005049; Wed, 13 Dec 2023 23:36:37 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3uw4skm9wh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Dec 2023 23:36:37 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3BDNaYD814156344 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Dec 2023 23:36:35 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D0AF520043; Wed, 13 Dec 2023 23:36:34 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 693A220040; Wed, 13 Dec 2023 23:36:33 +0000 (GMT) Received: from heavy.boeblingen.de.ibm.com (unknown [9.171.70.156]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 13 Dec 2023 23:36:33 +0000 (GMT) From: Ilya Leoshkevich To: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka Cc: Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle , Ilya Leoshkevich Subject: [PATCH v3 16/34] mm: kfence: Disable KMSAN when checking the canary Date: Thu, 14 Dec 2023 00:24:36 +0100 Message-ID: <20231213233605.661251-17-iii@linux.ibm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213233605.661251-1-iii@linux.ibm.com> References: <20231213233605.661251-1-iii@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: doTRKEg5slH34q2wsmPW_bB7RNQCjFCQ X-Proofpoint-GUID: qah957R2REyygwz3vVTu7gxw-sNw3M3- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-13_14,2023-12-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 mlxlogscore=999 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312130167 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: F3BAB1C0013 X-Stat-Signature: missm8wjczu7djiww7dbytwxk51hryb7 X-Rspam-User: X-HE-Tag: 1702510605-349544 X-HE-Meta: U2FsdGVkX1/HkelrxNOYeOf9RN6ZKlL+qahFozZfV3kd+BE2T+8Akjt37EZIdbkLbNCAAF8+JUAODRoe+Xop2CqgetoHRhg8mPV73UjaNyHTwkkbAy/J7WxBX3Qh5WFBNgxQoHLrJ4PSXcBEq+WyhlBrDwJ6zNoYgFckK9ltUQpx7WyxDcDhCOzU7u8/5oJnwCqTQ2e6EBQ35LDQntJCmi7lpIRZhWqhD0k7VYkrCjPU/Tm8D/is37BsXg6bcbBbdwCsuWsIXnkHgIWyDLdzbt/gcibOYhtb86RbSHdDDF0ZE5uZLnTC72RFFI7zRLSXnk9F+eLdA9T9qH4GGexi3aYUuSwG2UqMVHTq0XzznVJ76q2g/JNiSNGDkS/MfALdfQq8gjqq5M01pfHQJdm2Z554gx4xx0SI/Ua8fcAXS7V9su4s6cwuxYG1pk3MrrzPDlGSmBgGDQOrz6nXy3vR5R6dMkPIyMJxJeXDy+isEFEr/YofxSCPxRVQJ4JsGlizCn74AJIPeT4MRayIAyF0K+3vRWgcJNVXBolYRXjVVnmpGhMUPF3aqGaPNV6O6mSyQOP890xR08EcpAQ5yiKSyGzHqERGm2/P/SrE9t4ghNtGULFygq4NA8zr/gtbEvGaBxJ0s7yTBk/6qNHpPTd0UwqTZAIkKAyh/CtEejE2GzDQwV6lYrjgMY6GO1L2+OgK95L67VXIrFZVjKguxzIMeff6u+c/aRtTYwHozOt9tflYhGzQkgK3YbodoUDaOIyL1omzQrePGLxrQYDUC7z1x7ZLQwHGs+Ybi1I7JsGsexINyKVDKNZptalqBgLneRSGsggw0i/ORrNUWFjq/a/d9uwnSbI9oGscQ9tjBTP6nYCBRxJFLRhYg2pnX7roopbgO3PYm1/GqqKM7sqedVIA+s7rJ2Xen049BBbP8weiHCKP2/szibDx3AbZoizNkuuUDEavRUdCq6bfeR9VnoK MDQwUfeg VgaH4cnyI3a4tkLkJBxVfncBPc8keD/fOnkF6t40k2kvbEwXuby3l6Gmf3UPCXgtjfA+ijlZO9aoKZOO6v0pXValPTzbO46b2tjgN7Alen2pe1XtNyPUMybJOrQLITWNKeiKB/sv1LWm2jQrpfJfyQfvEJotnyEcW8tgBGp/UmmDIqk+TG3sYQunrtuBojyfSY+ciVrGelfpz03zUdEykqruOmV4CNiGzhqfNMCrYvsSDzkbYwttf8ZogBSzE5SkV6tugd/fxybAogQgXjHppg5AbRB4pqSSXIDGOnF628m/QY81GUyM3nGM8RRUjwf9jzldJ5V0mNuRUBAQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: KMSAN warns about check_canary() accessing the canary. The reason is that, even though set_canary() is properly instrumented and sets shadow, slub explicitly poisons the canary's address range afterwards. Unpoisoning the canary is not the right thing to do: only check_canary() is supposed to ever touch it. Instead, disable KMSAN checks around canary read accesses. Reviewed-by: Alexander Potapenko Tested-by: Alexander Potapenko Signed-off-by: Ilya Leoshkevich --- mm/kfence/core.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/mm/kfence/core.c b/mm/kfence/core.c index 3872528d0963..96138e704c5a 100644 --- a/mm/kfence/core.c +++ b/mm/kfence/core.c @@ -305,8 +305,14 @@ metadata_update_state(struct kfence_metadata *meta, enum kfence_object_state nex WRITE_ONCE(meta->state, next); } +#ifdef CONFIG_KMSAN +#define CHECK_CANARY_ATTRIBUTES noinline __no_kmsan_checks +#else +#define CHECK_CANARY_ATTRIBUTES inline +#endif + /* Check canary byte at @addr. */ -static inline bool check_canary_byte(u8 *addr) +static CHECK_CANARY_ATTRIBUTES bool check_canary_byte(u8 *addr) { struct kfence_metadata *meta; unsigned long flags; @@ -341,7 +347,8 @@ static inline void set_canary(const struct kfence_metadata *meta) *((u64 *)addr) = KFENCE_CANARY_PATTERN_U64; } -static inline void check_canary(const struct kfence_metadata *meta) +static CHECK_CANARY_ATTRIBUTES void +check_canary(const struct kfence_metadata *meta) { const unsigned long pageaddr = ALIGN_DOWN(meta->addr, PAGE_SIZE); unsigned long addr = pageaddr; -- 2.43.0