From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B540C4332F for ; Wed, 13 Dec 2023 22:41:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD0A06B0417; Wed, 13 Dec 2023 17:41:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D0A9D6B041A; Wed, 13 Dec 2023 17:41:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B10036B041C; Wed, 13 Dec 2023 17:41:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 914716B0417 for ; Wed, 13 Dec 2023 17:41:27 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 620C1A21B3 for ; Wed, 13 Dec 2023 22:41:27 +0000 (UTC) X-FDA: 81563267814.15.743DDBA Received: from mail-yw1-f195.google.com (mail-yw1-f195.google.com [209.85.128.195]) by imf15.hostedemail.com (Postfix) with ESMTP id 64A94A0017 for ; Wed, 13 Dec 2023 22:41:25 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=f+laYvkX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of gourry.memverge@gmail.com designates 209.85.128.195 as permitted sender) smtp.mailfrom=gourry.memverge@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702507285; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SvF8XP3toqTj9OsWUmBPBjL8Vx7rS+7EittbCVzs1w4=; b=zCdAUlwElp7R99iJNcMoFdPtIyhEJbFVqhVF2VLGk3uf9F5aHr9d+15WpIeaKqCHNIbfVB jvLGR7xIQkZBZcjvOqJNwdL+rCaI5y6/7q3PULLW11PqqN8Bxrilj1aY1fuQ+GAV5H8g6R Nx7bwxZHQ+RHCwdIGO/sdeAuH1nSpY0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=f+laYvkX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of gourry.memverge@gmail.com designates 209.85.128.195 as permitted sender) smtp.mailfrom=gourry.memverge@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702507285; a=rsa-sha256; cv=none; b=VChPmPa0RutWHUXj/7suMSiJw0pE6Y4Jb7zlxGAVnm63cNDHuBkbwFwlNBG7GqJnxNq5ee wWyRst7ILRYXHnS1N3aQtNzxHc5gzSsh+2k0JD6nhGUd+9aALjKcKfdZokTN0ky7/xuctd /fyuIjl2jawQ0ZFwLb3fIOuhuOX7Oxg= Received: by mail-yw1-f195.google.com with SMTP id 00721157ae682-5d6b9143782so68126697b3.0 for ; Wed, 13 Dec 2023 14:41:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702507284; x=1703112084; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SvF8XP3toqTj9OsWUmBPBjL8Vx7rS+7EittbCVzs1w4=; b=f+laYvkXwFCLm83ysEO21zXdavFw+Mi6MI0EifCXPd09809+IK2G3Q8MGrA92WSaxv qch66blNjZ7Bi2OR32EV30SeP6Sp+kA6Fpmbu2HqGVtqUDIbsPVhgd+KgUOtdZ7fCGFg CfQTS/2jFNeJRrzo4VxHl3Yp02hLp3lwZNGKFXFT96wG2iCW8rKF8zya7KJpEGFP3KFS GtSojEDSt3lM54TUNMMPLREAoCw1I/Yzcbe/qts7Xlhu39R1eOY1o06IYy70PQI/db/j hvlUOQhWL5O4BIbhVEvlB873YKeM7MzrdreXKLkcYVc1vMVuhs02tRlZO6JnfUEB35f/ ShIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702507284; x=1703112084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SvF8XP3toqTj9OsWUmBPBjL8Vx7rS+7EittbCVzs1w4=; b=j/IgCT07nNTfa2OakDGtrLKWfThECyc7WoHEg+yl+VR1Mxc8gH4zBMHkNAeR9bNtQy j07nZHcFwXTjEffXyqUDe3KWrI30yz3uuWp4KpQRF5JfOVWu5zhZjAbqfchu9f3kl6Mj UyQSrjWJMKSkVjfkIQswlKIkRdue3xJKU5aT5eDOwWhzufd+7fa7LvE6j8yMEfIoqVmD uXyfjUHGziGpFrp/4wWTk+bM3XBWyYbHjuzjWGuBfTNwlklxjF3BusjHM5DixGxF7Pzh 6iUjroN2UTVGAE1s9SYNpGoV7ezZBlilxYi1bsHMmcx1q7Ix4aNygTsHNRdrXJMibv4P r1hA== X-Gm-Message-State: AOJu0Yye2EUeTbopvUhqzwNxabrYy1fT3Vazc313XZ+imEF0+kVyDv7U /G9RD7eU7acqGxxtPnOv4DWnO5FNcZqI X-Google-Smtp-Source: AGHT+IFlmStwxigHm34C0TZtRXyNvC2pOZtDqxjEvfnM76EBY13SftV96kVUouIoklqHelxIbJeuVA== X-Received: by 2002:a81:8410:0:b0:5d7:1940:7d67 with SMTP id u16-20020a818410000000b005d719407d67mr7001727ywf.62.1702507283960; Wed, 13 Dec 2023 14:41:23 -0800 (PST) Received: from fedora.mshome.net (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id v4-20020a818504000000b005d9729068f5sm5050583ywf.42.2023.12.13.14.41.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 14:41:23 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price To: linux-mm@kvack.org Cc: linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, x86@kernel.org, akpm@linux-foundation.org, arnd@arndb.de, tglx@linutronix.de, luto@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mhocko@kernel.org, tj@kernel.org, ying.huang@intel.com, gregory.price@memverge.com, corbet@lwn.net, rakie.kim@sk.com, hyeongtak.ji@sk.com, honggyu.kim@sk.com, vtavarespetr@micron.com, peterz@infradead.org, jgroves@micron.com, ravis.opensrc@micron.com, sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com, seungjun.ha@samsung.com Subject: [PATCH v3 01/11] mm/mempolicy: implement the sysfs-based weighted_interleave interface Date: Wed, 13 Dec 2023 17:41:08 -0500 Message-Id: <20231213224118.1949-2-gregory.price@memverge.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231213224118.1949-1-gregory.price@memverge.com> References: <20231213224118.1949-1-gregory.price@memverge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 64A94A0017 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 9hkg6s5hioeqwtsdc9xhzn7r9gso169q X-HE-Tag: 1702507285-836038 X-HE-Meta: U2FsdGVkX1+iVDrakl4QFFtsaAB/DSWo4z/4Amv7NrBK6aOyk5No4vNH+xAfjiHNmrhavrVR4fUCpqodR32ZHdt0ngbbpoGNtngMYKx9CrB3HVmV6QEn3ghxlr3TJakunz2DEIwG65XcvhfzpvD53vCJArsCDVVLlQePcnAWvhc4WWKfeYh6NC7zHYkoiMQ8Thyylno5xrJ4do0cRzHi1dfMy3aGxRKtcp0sgOIVgPJ/2dFWB2XA4pUWXxL+kaDjnNIVWbWotu6fhCFaFan5E1Kc7xsiDjJbgFGao3Cx5zmV+psCYt7G2TfQVQiluxE8L/KNkzjWIWlzkiYw4dCJh9pOMGblt4/fCmOySnT7kuU6mTcPa4k7pHCzfmc6qRjnJ+hBLl/TtWImuPpWmiFNjmGCsf9iPnvyzgg7hiRkDScyyS/v7QQ44aA7mjHn5RRCYqO/5Np2tFj3D3nxDMmedJ58d/9qqYmEKnkfzGwqg81g5E4p//l1GxR32EwA5iomCNVqmblq5OpVR1j4louZdS31LpgvIOBEsAKu6E0QcuAOttix2DdUr3V4YTQZv1nEjn83U7bmD6S60oOYD90DQKhg7wWUwYKvF65PptrPx1mILP7TmARwsoPs4P9ijzR9NTFvj0szPovy0vdwi8aN8Vx9LQjOU2uEy2lsx5Z4c5nPw/mD3WsnjPKgP7aNje8c0OrmjCem4EBbw8XMMzk5YKofyuVI8b35S3tKot56Dsxz+3EqrH9LGW0VhbF7HhFAWqjlCpGJld/8e5t/JDJU4dMYYLMhPzH/bHaJ9bzEoxXigh0QKRKpyhtT2oqrn99VGAuHwQBo6yiWP3fEujxrSXhcYbcCLlLSmbgds0rTYX4C2g8uDnuJD5gnL7B1njFxnOSpGu26Pz2+gVifn0YVKj2GMqngSGTM2qX5DhacEByN28CrZTEgccYVPnV/5d+v2ZM6jfQidmWY13tJr0H k+u0jIVq kse0kEAps6Pb4AEZjFUZG813C65dfjd0DtgGRlQzjfaotR05pRJb2W308dGpTtcN2GrPMAMXyIUlNI0dfLRF7hsLY64TBMdyDVuRV2Bh6gj8503B1tvX9GV3WTiPVWUy7poVLgsacjnfiVL4D7yvyqEyrXxS9JMHYTc4DFfhnqTiHgRA8+Sp4YeLpe7gsFebgHyAxgQ2pu6rnAnt+ZjIQIkYPH8ZDqNgjLwLln5j3IKoT2CXcrlJg62dNtQvTPHzuG6NZSPt9XyTaiDsyVU1sQViYHRR5q896Zzo9ThGNXb6Oohrny3uW2y960+mhEXlQ9DBWibu8sO773IbKwany+lWDVXEfP4mG5SFe9GaJpNslkOOj52o+kfssTmSQYxUTDcUexRdBug463pY7zo5pd5mEj3fTDH0dSQYYVI21HuVXOpfopSqvX9N8WRiTuPQIXey6wEtY5+cawiH6d+8Ob6uFgcJrdUH+f4OFmaNhsHnA9ycjZJF6+ezhT26ZqT4f6ngLUA8Zd9S8YRadsz8rlPBdR+isiFXIG6ZSa6WOjwcYiG2JI32YwtSs3HX6iJUaRiIOf9A0j7vDaSc5zCxuq/bfr/Tw3gVdGBIzcbH1wUlr2mARx+zk+ouuddhQTRRkHoCFCW7BgR8pMuwyas/walJHS/o3V2gdLuH6hcCY7wECSA8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Rakie Kim This patch provides a way to set interleave weight information under sysfs at /sys/kernel/mm/mempolicy/weighted_interleave/nodeN The sysfs structure is designed as follows. $ tree /sys/kernel/mm/mempolicy/ /sys/kernel/mm/mempolicy/ [1] └── weighted_interleave [2] ├── node0 [3] └── node1 Each file above can be explained as follows. [1] mm/mempolicy: configuration interface for mempolicy subsystem [2] weighted_interleave/: config interface for weighted interleave policy [3] weighted_interleave/nodeN: weight for nodeN Signed-off-by: Rakie Kim Signed-off-by: Honggyu Kim Co-developed-by: Gregory Price Signed-off-by: Gregory Price Co-developed-by: Hyeongtak Ji Signed-off-by: Hyeongtak Ji --- .../ABI/testing/sysfs-kernel-mm-mempolicy | 4 + ...fs-kernel-mm-mempolicy-weighted-interleave | 22 +++ mm/mempolicy.c | 143 ++++++++++++++++++ 3 files changed, 169 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-kernel-mm-mempolicy create mode 100644 Documentation/ABI/testing/sysfs-kernel-mm-mempolicy-weighted-interleave diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-mempolicy b/Documentation/ABI/testing/sysfs-kernel-mm-mempolicy new file mode 100644 index 000000000000..2dcf24f4384a --- /dev/null +++ b/Documentation/ABI/testing/sysfs-kernel-mm-mempolicy @@ -0,0 +1,4 @@ +What: /sys/kernel/mm/mempolicy/ +Date: December 2023 +Contact: Linux memory management mailing list +Description: Interface for Mempolicy diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-mempolicy-weighted-interleave b/Documentation/ABI/testing/sysfs-kernel-mm-mempolicy-weighted-interleave new file mode 100644 index 000000000000..aa27fdf08c19 --- /dev/null +++ b/Documentation/ABI/testing/sysfs-kernel-mm-mempolicy-weighted-interleave @@ -0,0 +1,22 @@ +What: /sys/kernel/mm/mempolicy/weighted_interleave/ +Date: December 2023 +Contact: Linux memory management mailing list +Description: Configuration Interface for the Weighted Interleave policy + +What: /sys/kernel/mm/mempolicy/weighted_interleave/nodeN +Date: December 2023 +Contact: Linux memory management mailing list +Description: Weight configuration interface for nodeN + + The interleave weight for a memory node (N). These weights are + utilized by processes which have set their mempolicy to + MPOL_WEIGHTED_INTERLEAVE and have opted into global weights by + omitting a task-local weight array. + + These weights only affect new allocations, and changes at runtime + will not cause migrations on already allocated pages. + + Writing an empty string resets the weight value to 1. + + Minimum weight: 1 + Maximum weight: 255 diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 10a590ee1c89..5310021181ab 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -131,6 +131,8 @@ static struct mempolicy default_policy = { static struct mempolicy preferred_node_policy[MAX_NUMNODES]; +static char iw_table[MAX_NUMNODES]; + /** * numa_nearest_node - Find nearest node by state * @node: Node id to start the search @@ -3067,3 +3069,144 @@ void mpol_to_str(char *buffer, int maxlen, struct mempolicy *pol) p += scnprintf(p, buffer + maxlen - p, ":%*pbl", nodemask_pr_args(&nodes)); } + +struct iw_node_attr { + struct kobj_attribute kobj_attr; + int nid; +}; + +static ssize_t node_show(struct kobject *kobj, struct kobj_attribute *attr, + char *buf) +{ + struct iw_node_attr *node_attr; + + node_attr = container_of(attr, struct iw_node_attr, kobj_attr); + return sysfs_emit(buf, "%d\n", iw_table[node_attr->nid]); +} + +static ssize_t node_store(struct kobject *kobj, struct kobj_attribute *attr, + const char *buf, size_t count) +{ + struct iw_node_attr *node_attr; + unsigned char weight = 0; + + node_attr = container_of(attr, struct iw_node_attr, kobj_attr); + /* If no input, set default weight to 1 */ + if (count == 0 || sysfs_streq(buf, "")) + weight = 1; + else if (kstrtou8(buf, 0, &weight) || !weight) + return -EINVAL; + + iw_table[node_attr->nid] = weight; + return count; +} + +static struct iw_node_attr *node_attrs[MAX_NUMNODES]; + +static void sysfs_wi_node_release(struct iw_node_attr *node_attr, + struct kobject *parent) +{ + if (!node_attr) + return; + sysfs_remove_file(parent, &node_attr->kobj_attr.attr); + kfree(node_attr->kobj_attr.attr.name); + kfree(node_attr); +} + +static void sysfs_mempolicy_release(struct kobject *mempolicy_kobj) +{ + int i; + + for (i = 0; i < MAX_NUMNODES; i++) + sysfs_wi_node_release(node_attrs[i], mempolicy_kobj); + kobject_put(mempolicy_kobj); +} + +static const struct kobj_type mempolicy_ktype = { + .sysfs_ops = &kobj_sysfs_ops, + .release = sysfs_mempolicy_release, +}; + +static int add_weight_node(int nid, struct kobject *wi_kobj) +{ + struct iw_node_attr *node_attr; + char *name; + + node_attr = kzalloc(sizeof(*node_attr), GFP_KERNEL); + if (!node_attr) + return -ENOMEM; + + name = kasprintf(GFP_KERNEL, "node%d", nid); + if (!name) { + kfree(node_attr); + return -ENOMEM; + } + + sysfs_attr_init(&node_attr->attr); + node_attr->kobj_attr.attr.name = name; + node_attr->kobj_attr.attr.mode = 0644; + node_attr->kobj_attr.show = node_show; + node_attr->kobj_attr.store = node_store; + node_attr->nid = nid; + + if (sysfs_create_file(wi_kobj, &node_attr->kobj_attr.attr)) { + kfree(node_attr->kobj_attr.attr.name); + kfree(node_attr); + pr_err("failed to add attribute to weighted_interleave\n"); + return -ENOMEM; + } + + node_attrs[nid] = node_attr; + return 0; +} + +static int add_weighted_interleave_group(struct kobject *root_kobj) +{ + struct kobject *wi_kobj; + int nid, err; + + wi_kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL); + if (!wi_kobj) + return -ENOMEM; + + err = kobject_init_and_add(wi_kobj, &mempolicy_ktype, root_kobj, + "weighted_interleave"); + if (err) { + kfree(wi_kobj); + return err; + } + + memset(node_attrs, 0, sizeof(node_attrs)); + for_each_node_state(nid, N_POSSIBLE) { + err = add_weight_node(nid, wi_kobj); + if (err) { + pr_err("failed to add sysfs [node%d]\n", nid); + break; + } + } + if (err) + kobject_put(wi_kobj); + return 0; +} + +static int __init mempolicy_sysfs_init(void) +{ + int err; + struct kobject *root_kobj; + + memset(&iw_table, 1, sizeof(iw_table)); + + root_kobj = kobject_create_and_add("mempolicy", mm_kobj); + if (!root_kobj) { + pr_err("failed to add mempolicy kobject to the system\n"); + return -ENOMEM; + } + + err = add_weighted_interleave_group(root_kobj); + + if (err) + kobject_put(root_kobj); + return err; + +} +late_initcall(mempolicy_sysfs_init); -- 2.39.1