From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01E3EC4332F for ; Wed, 13 Dec 2023 18:56:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81A496B055F; Wed, 13 Dec 2023 13:56:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C9BA6B0560; Wed, 13 Dec 2023 13:56:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B8CE6B0561; Wed, 13 Dec 2023 13:56:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5D9486B055F for ; Wed, 13 Dec 2023 13:56:36 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2D6BC1602A8 for ; Wed, 13 Dec 2023 18:56:36 +0000 (UTC) X-FDA: 81562701192.25.868127F Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by imf07.hostedemail.com (Postfix) with ESMTP id 6F49840021 for ; Wed, 13 Dec 2023 18:56:34 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=sKKi+idO; dmarc=pass (policy=none) header.from=linux.microsoft.com; spf=pass (imf07.hostedemail.com: domain of skinsburskii@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=skinsburskii@linux.microsoft.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702493794; a=rsa-sha256; cv=none; b=ofIdWLFIqLxIHy8/lOQyoVFKHZcHFsAtCtBR3tVPVL18gKjZIYEn6SwPc0eYlea9Wu2OoE wqowC3xTjWbvnZUsV/JC7hxyeKJIw/lC+JCCOakE8lzGuNdG1ga5Sq846NvfOYa15yAhia Rnvznume/62lBQKPHTWiOtDIY3dBjRY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=sKKi+idO; dmarc=pass (policy=none) header.from=linux.microsoft.com; spf=pass (imf07.hostedemail.com: domain of skinsburskii@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=skinsburskii@linux.microsoft.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702493794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=txIReIOWTRs39u8OW5af/PT5Nn7b+8jE2eqzUZ8XWC0=; b=oTQqiLl2bOHJwvvPYaoLSHYx8NwvfgBoLNaY+penHizQwHDCBAnORFBBcIGnL5XvBB6UJY eqMi4YwcFllg/nx9Q8U1vAKD/6LTampYwbd3EKnWpXB8z9BUfvXEGCH99w29PsvuZ7GgVb 2iSxDv2u6y56e2jZSruD1x/eyj0cQWk= Received: from skinsburskii. (c-67-170-100-148.hsd1.wa.comcast.net [67.170.100.148]) by linux.microsoft.com (Postfix) with ESMTPSA id 74A6A20B74C0; Wed, 13 Dec 2023 10:56:32 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 74A6A20B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1702493793; bh=txIReIOWTRs39u8OW5af/PT5Nn7b+8jE2eqzUZ8XWC0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sKKi+idOLhnITF/wkGrqC9FTWsyho05pam4Ov+NiMJUNOG9wdoVWzvhAzzVVbi0fM iq0Sk46HTEoSPfC26F5n/XR5paRCRmarYFa0kFuxc1gAWLfNan2s1/Q+8P81MaF2gS dZCAJ3GCca9aPvSLzvGvcG/K17vyv+y4Qc5dMZio= Date: Wed, 13 Dec 2023 10:56:31 -0800 From: Stanislav Kinsburskii To: Alexander Graf Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kexec@lists.infradead.org, linux-doc@vger.kernel.org, x86@kernel.org, Eric Biederman , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Rob Herring , Steven Rostedt , Andrew Morton , Mark Rutland , Tom Lendacky , Ashish Kalra , James Gowans , arnd@arndb.de, pbonzini@redhat.com, madvenka@linux.microsoft.com, Anthony Yznaga , Usama Arif , David Woodhouse , Benjamin Herrenschmidt Subject: Re: [PATCH 04/15] kexec: Add KHO parsing support Message-ID: <20231213185631.GA14708@skinsburskii.> References: <20231213000452.88295-1-graf@amazon.com> <20231213000452.88295-5-graf@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231213000452.88295-5-graf@amazon.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6F49840021 X-Stat-Signature: yfk1g7r4kw94fuonjxqj3tp6ct6zw47b X-HE-Tag: 1702493794-998648 X-HE-Meta: U2FsdGVkX18LTj+HeZhmQr+5Zudbm3Aid+jXvIYez/m/7v41fH4rkX/EuW9WIJjJpbf1GwKPH7/GqqwVunknTi6gWwmbTuvuE16mXUlzd/LUUrb7EXGDSlYiidZWtJjGJf6eSOGv3BUhK+BQ/B2sK/DZ6fFpMHbfnp+TBaUtVrsR2Lg01VFNjS+LXY0a0y+U29bplofkOku3KqlxxxKDfPn8U4+Ei77XiP/h2SU1H7U6ppbtaZArgc17onOWf2xocqZE0+y7NupGj7drYMaYQaFIdR0WtMrv3vVz/N6cNc2F1r+WsmfcrXa5cQO2CZvIX8vUnhd8/yYaT5bfhsncBliABB87cX8Rj2gv7G8P0dzgvvAyeKQz0rxECbnGCr4X1C6QdZud4zViDLJ4wwNtkFIRSqPcRCSSMODrG7xgyEP+qrnOB9t3fqU41I6VwkqL/5N9cFVIzENuUd+IOejw0JHw5LoszEttbIj8d5velIPaiSPhg/c3Y18H1+PSToeLSgl0YSLuCNeqDi+kwvc2a4IyQ8NpCYo4R57WBDfjwDmhnFWEBmTddBtVyPHNr1OlnsYLjsmBDD0HmmMSKdeacx7y6S3AWWahGQc+Pyh0BliKV+BDB/6e/qWU25ZR9ED7uvIpBxRumJ+BPo7Ne4n6nOP5VxkWnJ3clHx38RME8hHunlmlDg5lbZRegsRK/Is5IRVwbjoBG8JYyfdGL2CXQM4SmAbkFHz4SmFSw2ieWSH0XSYsa+lGhj06CpgRRcbe4oKvLBO1fSYBjkYxrVxJLMzqylN3iIHZXOCYxS3T6zUbEVC2UMxnEdADxsAS4d5ZRRFqP/wqCDZ9Nz8pcXnkhqbGJ09Vz1qxtNnGC/LERvPy7U2g5iqwWvfRk3FW6ugqSejNrDgwhmNASB5SXVkA12nqEyS3iWj4hF1eDLyElHBocdeRpUz40KlfA7e34mzU/kwpQSGvoF3OeHu08my Zv2gb3Nj we00qEMzvm0KudVMr8Na19AiKU0embUEpPPMvm2wXAkdylsuQCxBrehBS81bj4jfli6i1V2PX+dlWcDHhv1Fr0iU8er5YsjFkj4Ox3f068TwA9ff00wlE8mkr7MPvckEKV+lkSB3RlSjjYvTA/Kq47p7N6ZZazimhNJbGGGJpkUiFeCTTiQWmUtE73FkH4rylZWdEgOpohZ6pVY44Xwm4SE5kc1oliHKkGDfGHK4u4dKztJmpMiJ52PiQtKqBxvDldXSn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 13, 2023 at 12:04:41AM +0000, Alexander Graf wrote: > +void *kho_get_fdt(void) > +{ > + return fdt; > +} > +EXPORT_SYMBOL_GPL(kho_get_fdt); > + Same question here (and in other places of this code): shouldn't this facility be provided to non-GPL drivers as well? Also a minor nit: "const void *" looks like a cleaner prototype here.