From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33A20C4167D for ; Wed, 13 Dec 2023 18:27:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AE2C6B0500; Wed, 13 Dec 2023 13:27:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 40FC46B0502; Wed, 13 Dec 2023 13:27:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C52E6B0503; Wed, 13 Dec 2023 13:27:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0197C6B0500 for ; Wed, 13 Dec 2023 13:27:48 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C3110801AE for ; Wed, 13 Dec 2023 18:27:48 +0000 (UTC) X-FDA: 81562628616.22.FE415FA Received: from 66-220-144-179.mail-mxout.facebook.com (66-220-144-179.mail-mxout.facebook.com [66.220.144.179]) by imf11.hostedemail.com (Postfix) with ESMTP id 4171640023 for ; Wed, 13 Dec 2023 18:27:46 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=neutral (imf11.hostedemail.com: 66.220.144.179 is neither permitted nor denied by domain of shr@devkernel.io) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702492066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=XiESXIOKxmbcHfM9lo7L8GEdPq4HkaF4j61dsOXpT8c=; b=oN5h22pRSaZsPRrUaMWsrZ+NanmB04eo2gejNykIRNHCtdQoxGfYqdIlYRXVP3sBeKCd4n GxSntACP++nCbupTleqryX22OBK9O4dnirrI9wHY4Y/+tz41h33BOJJJfMG6mCY+nSutyf tzV1jJCoyO+TfOyjaB8HrF5CZWSml9k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702492066; a=rsa-sha256; cv=none; b=MvWTW88s8ougHWS7slxzu3fMLLTZlnHsOYJGlLZR1QQb8hAfzYUNCMaKCgvGukqvP3RuUt jdAhTtwl53Tb6UEa37KWWKFWMd4mlhAWpS4oh4gjt+TDdTGxPhDIImbndGNQYN2IDRXI1G I5O5LWSvTXGDxc2YzeASbpTK9UMqpm8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=neutral (imf11.hostedemail.com: 66.220.144.179 is neither permitted nor denied by domain of shr@devkernel.io) smtp.mailfrom=shr@devkernel.io; dmarc=none Received: by devbig1114.prn1.facebook.com (Postfix, from userid 425415) id 9918D10CFA721; Wed, 13 Dec 2023 10:27:33 -0800 (PST) From: Stefan Roesch To: kernel-team@fb.com Cc: shr@devkernel.io, akpm@linux-foundation.org, david@redhat.com, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v4 0/4] mm/ksm: Add ksm advisor Date: Wed, 13 Dec 2023 10:27:25 -0800 Message-Id: <20231213182729.587081-1-shr@devkernel.io> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: waiphqdxf3eeeumbnydkfn5nzferwcre X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4171640023 X-Rspam-User: X-HE-Tag: 1702492066-287191 X-HE-Meta: U2FsdGVkX198zaHulzD6sqD3OCxbym5eI5EIiDmMNMyiKNnSRi6W0gPImJ65eXCqdNhM1FTP900y1x0MI4rXbW26sYsTqfh7NsDOrupOflUAzZiZKovZ+KaNplwSr2ZkhKhMyJm3CN0QvqbWCWvh7BPlPUysTzVcLmkkfdCibHtvp+jon5oTZmVPt8MHJDJhD/olbME4Njbaka3mlV/0fYWwg7bAv3axsw/Kzc2OxML/jSyL1DNxx/tko25QkJmoaqKVCLTFE039ArcRPuh8j8Aa7/Rb/xdoCQz489fc8rpD5oCvh/dgoaMXorX2xoPmT+FPDZPXmIHMEPBYwLo9bXobsdZnn0g4I99wqs9MkekWsPVQBMgwiHhlFDYLu0/CYFCV4/eozxG8jgnDEKAInr6hSRR8IaE69AwU+NYYf6joY1tpRb4Tz13qccNAXrVBAozCAnift+gUVHqaa0BUUoF3dZGZBGd6niMA4cc5GSHnsoXiypSeFn7bi/x8FI21g326FYhLMxNLnXBUBBVTn9RRoMbqV1SqHyK7ZIYfU2ihShwOOU0tG/d6b3TpwNiGtWBTVbMQc7KuVO7GehYrs3ppZ+OjSURQqkwZDJOjnRGXCHYC1dE0f9kbx3jpmHZjVaqWYt34aGMuIsx5kwfCLRqh/29xAsJi9A4Zomynsdrs6CLtCM6dbdDZFRentLUWo2fNCjKs1bk7d0Wake1RCGpq1GiCqdO1K5UV+GAFBrzlR2DiVAiRtbM1W6CyeeWq5H4uE2DeExbY6h6DHGPjIQFcSA2i8fbidPINP2GIZZjYb5gOhVCVkIJ0vsDo4d5Dkv5KMwUSZv5lci3SvvoAXPQhggwkpd9Ns0gTLC475ITnyNKZoxWADPJdHPMSFYvVLpSLUcAYwlr82EZm5JG7Kq2q6oLzI8TL89YSuQ7cx+oyrPKrcaSDbajBbeU0jxk1T8WsnTYaPlfJDXXBn2F TqSXQ8Dz ITaFmCMw0IBKUraU0D2Wece2VqayfQW4mJc5gA+VykESAGhM1QtdTRuVXDjUwMiWSPZKPxx2Jf0yJgl45By8LAWQCSPH8vwb3fpdk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: What is the KSM advisor? =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D The ksm advisor automatically manages the pages_to_scan setting to achieve a target scan time. The target scan time defines how many seconds it should take to scan all the candidate KSM pages. In other words the pages_to_scan rate is changed by the advisor to achieve the target scan time. Why do we need a KSM advisor? =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D The number of candidate pages for KSM is dynamic. It can often be observe= d that during the startup of an application more candidate pages need to be processed. Without an advisor the pages_to_scan parameter needs to be sized for the maximum number of candidate pages. With the scan time advisor the pages_to_scan parameter based can be changed based on demand. Algorithm =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D The algorithm calculates the change value based on the target scan time and the previous scan time. To avoid pertubations an exponentially weighted moving average is applied. The algorithm has a max and min value to: - guarantee responsiveness to changes - to limit CPU resource consumption Parameters to influence the KSM scan advisor =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D The respective parameters are: - ksm_advisor_mode 0: None (default), 1: scan time advisor - ksm_advisor_target_scan_time how many seconds a scan should of all candidate pages take - ksm_advisor_max_cpu upper limit for the cpu usage in percent of the ksmd background thread The initial value and the max value for the pages_to_scan parameter can be limited with: - ksm_advisor_min_pages_to_scan minimum value for pages_to_scan per batch - ksm_advisor_max_pages_to_scan maximum value for pages_to_scan per batch The default settings for the above two parameters should be suitable for most workloads. The parameters are exposed as knobs in /sys/kernel/mm/ksm. By default the scan time advisor is disabled. Currently there are two advisors: - none and - scan-time. Resource savings =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Tests with various workloads have shown considerable CPU savings. Most of the workloads I have investigated have more candidate pages during startup. Once the workload is stable in terms of memory, the number of candidate pages is reduced. Without the advisor, the pages_to_scan needs to be sized for the maximum number of candidate pages. So having this advisor definitely helps in reducing CPU consumption. For the instagram workload, the advisor achieves a 25% CPU reduction. Once the memory is stable, the pages_to_scan parameter gets reduced to about 40% of its max value. The new advisor works especially well if the smart scan feature is also enabled. How is defining a target scan time better? =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D For an administrator it is more logical to set a target scan time.. The administrator can determine how many pages are scanned on each scan. Therefore setting a target scan time makes more sense. In addition the administrator might have a good idea about the memory sizing of its respective workloads. Setting cpu limits is easier than setting The pages_to_scan parameter. Th= e pages_to_scan parameter is per batch. For the administrator it is difficu= lt to set the pages_to_scan parameter. Tracing =3D=3D=3D=3D=3D=3D=3D A new tracing event has been added for the scan time advisor. The new trace event is called ksm_advisor. It reports the scan time, the new pages_to_scan setting and the cpu usage of the ksmd background thread. Other approaches =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Approach 1: Adapt pages_to_scan after processing each batch. If KSM merges pages, increase the scan rate, if less KSM pages, reduce the the pages_to_scan rate. This doesn't work too well. While it increases the pages_to_scan for a short period, but generally it ends up with a too low pages_to_scan rate. Approach 2: Adapt pages_to_scan after each scan. The problem with that approach is that the calculated scan rate tends to be high. The more aggressive KSM scans, the more pages it can de-duplicate. There have been earlier attempts at an advisor: propose auto-run mode of ksm and its tests (https://marc.info/?l=3Dlinux-mm&m=3D166029880214485&w=3D2) Changes: =3D=3D=3D=3D=3D=3D=3D=3D V4:=20 - rename ksm_advisor_min_pages to ksm_advisor_min_pages_to_scan - rename ksm_advisor_max_pages to ksm_advisor_max_pages_to_scan - folded init_advisor() into set_advisor_defaults() - moved set_advisor_defaults() to second patch - Fixed long division for 32 bit platforms in scan_time_advisor() - folded stop_advisor_scan() into scan_time_advisor() - renamed run_advisor() to stop_advisor_scan() - Fixed typo - Added documentation for min and max cpu and how they are used in the scan time advisor calculation V3: - Use string parameters for advisor mode - Removed min cpu load sysfs knob - dropped unused enums in ksm_advisor_type - renamed KSM_ADVISOR_LAST to KSM_ADVISOR_COUNT - init_advisor() is needed but changed how it is initialized - don't allow to change pages_to_scan parameter when scan-time advisor is enabled - add ksm_advisor_start_scan() and ksm_advisor_stop_scan() functions to calculate scan time - removed scan time parameter to scan_time_advisor() function V2: - Use functions for long long calculations to support 32 bit platforms - Use cpu min and cpu max settings for the advisor instead of the pages min and max parameters. - pages min and max values are now used for the initial and max values. Generally they are not required to be changed. - Add cpu percent usage value to tracepoint definition - Update documentation for cpu min and cpu max values=20 - Update commit messages for the above changes *** BLURB HERE *** Stefan Roesch (4): mm/ksm: add ksm advisor mm/ksm: add sysfs knobs for advisor mm/ksm: add tracepoint for ksm advisor mm/ksm: document ksm advisor and its sysfs knobs Documentation/admin-guide/mm/ksm.rst | 55 +++++ include/trace/events/ksm.h | 33 +++ mm/ksm.c | 298 ++++++++++++++++++++++++++- 3 files changed, 385 insertions(+), 1 deletion(-) base-commit: 12d04a7bf0da67321229d2bc8b1a7074d65415a9 --=20 2.39.3