From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3945C4332F for ; Wed, 13 Dec 2023 15:36:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 650126B0369; Wed, 13 Dec 2023 10:36:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FFD16B036B; Wed, 13 Dec 2023 10:36:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C9CB6B036D; Wed, 13 Dec 2023 10:36:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 31D346B0369 for ; Wed, 13 Dec 2023 10:36:43 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0C3C3C0230 for ; Wed, 13 Dec 2023 15:36:43 +0000 (UTC) X-FDA: 81562197486.05.E58F9E3 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf28.hostedemail.com (Postfix) with ESMTP id 0ED29C001D for ; Wed, 13 Dec 2023 15:36:40 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702481801; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L9ZvII9M6hnWJRLP96avcWW/62EFqY3egNAUyLswK8w=; b=1kVsFJlaE/YviAFlf+85M0r/FsgxfGAq1xceSniUcrgpRi9jpRDTCORG36zlnp9At22Y8r 7gm2uO94bWopJmx93S3wAEwNHjXEjlMlQo1a+SSsLzGMXdqmE2rkpKVvrwnIqvy3LrWouZ 8NDNHzMeAmLhpXOF/zCkLmNHTLtL1BM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702481801; a=rsa-sha256; cv=none; b=QgFS337G1OoZNG9dQ6EE29XODGVACYKN2GTI3GDdTzqZ2r1/ZI+kF2ePospvAbNHCLIURW wTmvTzt+TkSHGvVlMVTx0XmpclMC3PneJiCVt62lfelzPxA+HF4HCIAhS0T9GAc/UKOAKk icIm4SpZ9P3nbunukQWSxyiHLd+KeSU= Received: by verein.lst.de (Postfix, from userid 2407) id 51F5368C7B; Wed, 13 Dec 2023 16:36:35 +0100 (CET) Date: Wed, 13 Dec 2023 16:36:34 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: "Kasireddy, Vivek" , David Hildenbrand , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , Christoph Hellwig , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Gerd Hoffmann , "Kim, Dongwon" , "Chang, Junxiao" , Christoph Hellwig Subject: Re: [PATCH v7 3/6] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios (v7) Message-ID: <20231213153634.GA7301@lst.de> References: <20231212073803.3233055-1-vivek.kasireddy@intel.com> <20231212073803.3233055-4-vivek.kasireddy@intel.com> <00c84f06-66b9-484c-8a2c-e820c7d21c9d@redhat.com> <20231213123155.GQ3014157@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231213123155.GQ3014157@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Stat-Signature: u4ejoh4z3j17qi6g151z9rewu3qj64zw X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0ED29C001D X-HE-Tag: 1702481800-68296 X-HE-Meta: U2FsdGVkX1+hOB81KrqkwEUbsFi6TIhpdiVUy0f5optKZ81Ui6Efv+hIo+b5nn75t9XKY0b4ZgubzwO2arHn8fYJaEnzfc2ygEdjRIM3qfE/WMn3uK6GLNHOuyxZXa+bIPOODv7Eh5yaWvEyQ0NLE7y2iGxItfEvJrHBoX8dQZjP3BlGdRYhgYPDB2ZpSIoa7iBRv0ucvTPcX9zBcLyvzkUP71u/MRH201JSmQdQVeEI7ZTCUauX7Lo1zQhobBgAtiv8jQA2YBpBYXXmR56IjEnX46u+MMrmDdERfw/rJrzgBOBUDCoicXfvWlkWrMlzcKcdTmLxcFRDRRzgUE47N3I3u6/rKyuiV0CPvDyd0lGoiSbaCrPQ0RU/fpItuACJtkxoUVNEvCJf+6liq5GjKpm71PYPEzJ5ObLuc4N88RJjhQNsW49Dea5wn3YY6Ys4/HEMLXE/Wzd1Mp3d/U0mmDOhxcj7ZvUH0XO7EZ5Hh5IWDTeWHDqM6BZ0jQY0TJeY476Qp2oU+EoeP+5+oNASVuj82iTcOLoqEj/6BHagWG6dgHK/KHL5CJ+tJtzY9jzCuC2elUY/wYJy0Y3qDzFZd98oP1Be3WdpaZv3avuoNcdSe/r+5aCqVQpQrjwb6gFOpEaDEAo8YaUNcYS9dxnZ46b0NSf6yllg/VNMjQzODxtdMu/bLBqEgtEthMTw3Lfq8g/PZu16+YmxenV19FGCjVEdZlVCFjFRiYPhdCMfLalr/YXIR/brYS2eQC9z3y2/mCysDyWdBKyiWe/+mmaaJXCK0BH1Vsbq4wX6fqzS+VxA2ymetbm4K8IkrK51DsAl9rkEnkyRcG08HMFRfwaV8Opok8L3PKUp9NwH+BFwggK/FIhPded6z0syRNExrKpMsoVTyHwmx2YHfeF8i+DZKQLmCR9fbiYTvRSVm7vFTvmrRUEIHos9Cw55AcTiGs5YKvLHlQxH/oxTtcv69R1 q+RExqhT Z4pjVnnqvpBJE/BUVdk3sBlBe9ZhCOa7uYQsrrQtowoY3O70ufz9I/JBg2oCtzEEItKvRv4gv0J1hxbRxcUxaF7TxstBTGL8HTPhT0qWThWeJrVPQWMw5zl8FhY67kVir7bCx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 13, 2023 at 08:31:55AM -0400, Jason Gunthorpe wrote: > > That is, populate a scatterlist with ubuf->pagecount number of entries, > > where each segment if of size PAGE_SIZE, in order to be consistent and > > support a wide variety of DMA importers that may not probably handle > > segments that are larger than PAGE_SIZE. > > No! This is totally wrong, sg lists must aggregate up to the limits > specified in the struct device. We have importer helpers that do this > aggregation. > > If some driver is working with a sglist and can't handle this it is > simply broken. Do not mess up core code to accomodate such things. Well.. There's no single driver that is broken, it's more the whole dmabuf philosophy that wants things to be mappable by multiple devices without knowing their limits beforehand. So you'll get this cargo culting.