From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2D7BC4332F for ; Wed, 13 Dec 2023 13:50:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69A656B0154; Wed, 13 Dec 2023 08:50:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 64B0D6B0321; Wed, 13 Dec 2023 08:50:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EB6F6B0323; Wed, 13 Dec 2023 08:50:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3D0B46B0154 for ; Wed, 13 Dec 2023 08:50:40 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 03B51C0274 for ; Wed, 13 Dec 2023 13:50:39 +0000 (UTC) X-FDA: 81561930240.17.D261321 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf03.hostedemail.com (Postfix) with ESMTP id E1CEB2000D for ; Wed, 13 Dec 2023 13:50:37 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=Zh2JIwjN; spf=pass (imf03.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702475438; a=rsa-sha256; cv=none; b=RzZolYwebXOd068gc9/zSDU4jxEADdwYypBu7twQN1j/psVkpJ+aGTL8HvQ6RFKzD8Zj3v j5lT56YUaS8aniJ+GIbhn4xOnzWD/v7IX/WV/E0DI0S9GJdALvbYxkDlXlcO/XeRbWrXE0 lHCKbBMYgytBlIVc8Tv2Xm0wSF/1gP0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=Zh2JIwjN; spf=pass (imf03.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702475438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aPSRuKMITa7Cc04zdSSoRjDp8M/sOyV9isILVL2dpxM=; b=Ajq0/vSRHaou5/6qB9JSo8AjWgqJdc3U8QfLMxQUVk55hh9TuOce2vsAfT4uy5JVAybbBW GQqZLXS9qoR55UbXgOV0jvj3zwta76vJp3F6D5mZHQaawSl8nuxwKkefs+LvTtCKNa3HsA Hsmzn7tI8Spgoiez6xCHW8RgFZsikPk= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id A2C0A40E018F; Wed, 13 Dec 2023 13:50:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id i88IOi2JMIP8; Wed, 13 Dec 2023 13:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1702475432; bh=aPSRuKMITa7Cc04zdSSoRjDp8M/sOyV9isILVL2dpxM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zh2JIwjNhEuU6UNW4jpj1WcsJZSLPxOaFicta9Psufsx9qAiE0r5LUQti9ME31hhC DE15ssH/tHgk+EjXOIL69aAwLvIztbuMyvEm/xhcCfkitMa7YX48EPIzHcjgG8SXKJ djNpCWRKKecB+7Y+QTTBu5xNHqGC5N4mEr1NHKgK67j8G4+Ymn/r4ZBBkT/dXYbg/y u1SQ6sTGYqL1JDig8iSogrNe/1VsiOOYtlDAr5nqpZCtiDvbXCPcA4z00t21bnYBB+ aYR3DVTGd5+cUWArW12JZW4yWJYKu8pgzQ7lNMFxHH/cucbIBcH8VHShFO6MtJcpC5 tsqnEeBcr/wvld/PiLufaUCx/qxIotPqY2VXm7Im3S+7naD1gtzxu2BaiWiOIKM+71 EmQeXG9lqA/cBXyxM61wdxf58GPsmR26zgrSY4y1yuuwBCdA0cTB1PqN9+U4mZ9NvX bt6veq/0RGM3aTeL8+8YD/b5UeM2flqSFQdEZa3vAmVlFU5Jek5IqkrGevhLbLwmPU A3GN0fLzLPuLG3D+gq0mwgS5YJeusNaY5u0MUSJkV9TUh2Xc+GeLNuRDHk8cBR6DDT Sh9aGpsuBJ4YVla14l5AMsD/LOj+e78E/nMoo5Nk14yUfMr3dZu/Jm0QrUhHXxIjAO R5+IdtjclU4WcsUHLSOjuC/g= Received: from zn.tnic (pd95304da.dip0.t-ipconnect.de [217.83.4.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D2C5140E00CD; Wed, 13 Dec 2023 13:49:50 +0000 (UTC) Date: Wed, 13 Dec 2023 14:49:45 +0100 From: Borislav Petkov To: Paolo Bonzini Cc: Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh , Jarkko Sakkinen Subject: Re: [PATCH v10 04/50] x86/cpufeatures: Add SEV-SNP CPU feature Message-ID: <20231213134945.GFZXm2eTkd+IfdsjVE@fat_crate.local> References: <20231016132819.1002933-1-michael.roth@amd.com> <20231016132819.1002933-5-michael.roth@amd.com> <0b2eb374-356c-46c6-9c4a-9512fbfece7a@redhat.com> <20231213131324.GDZXmt9LsMmJZyzCJw@fat_crate.local> <40915dc3-4083-4b9f-bc64-7542833566e1@redhat.com> <20231213133628.GEZXmzXFwA1p+crH/5@fat_crate.local> <9ac2311c-9ccc-4468-9b26-6cb0872e207f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9ac2311c-9ccc-4468-9b26-6cb0872e207f@redhat.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E1CEB2000D X-Stat-Signature: dz8ckwkfn8abqgn399jjbxym9ndfcoi5 X-Rspam-User: X-HE-Tag: 1702475437-992606 X-HE-Meta: U2FsdGVkX1/zI5rvv1Bs007ECOi+xH/FVJsRalRQNA2SC97+dM7kxWt7Dzr33NuMFKYKrZn/y7foWTroPtfa9SfS7ijzZiugBuGTOUx9bi2bKOju9hAQwnfFh1vKeR1ZD8e4WZzD6zSTszAdxh6p/gKztiObdqdohZykdLYqOklTvhcCZG3gObEux4tzNmf0DjgvTbW0RjsPsSyLI+OQ9UP6QFwad+eb+MKfD+Ntrms+aOkMHIX4Si6nJehPxxoYyPY4Numm/006mACltaZ1l7c1uPlHw3++zvA9hiAbzoMcpfTZa6LFyHHPACexzJx0DABKO3PSXb0IsXj4ecHi8sHSxMf1AQxDOKfmQEAIpQU+oqQCaPyurXzUQbPdMr2MJ5qWLy/w99Rp2kWiwHpN4TrWGkVAD1D4Qd9eKukFv2EMiSVQdzobzzfEIYllCZ7hGKa9dOXAzpLcTia2nr7eL9PUFvk5pANBDMK06xIngIvJ3xmUWSHMKwcLSoEJtHimKr6MReRk0PeKXXDGqMeBtN7LtFxfyL+he+AJkc4FXOzyd3TNpUJq+zimtWwakgUD6pxcaIovo9i6ygEjmNHCjHMiESNQnV6HXMMJS0skADAZp9bhD3M1gM5rjEvPudUqzUMDwOB3EXfdJH0g1mKlTIKydgPOdF7Naxm/inHFvlmKG5Ok2o5UKnP06E+WEyVT58hWO/EQCAP6SlFgIQfUZSzZiDvyT9DR8X0j+EQjbmjjwfjM7aJB2X/DqupQ5N4E9DK/AK9lW02nFEglceDsbvaE/Q7yWc3GDkLKXIHozeNzuAgSGqAffV8UQl0QV4nvAehL4eMCgus/qqUOy5X8ogVTbX8D4BzAhOqakO8n4mD7ghUd6cnXhDBsfuYwUJvin8ClxhS4LX8ujB8axxIlT4bC84frwfKraJQC96DCZSV58xbWthhffpS3mLqb/fb4M4qzy2KwyUpGz1qFNOx Yms2Bga/ Xu5YutXsvH/H2pAkQRGNFdq9IxZd3EroWcyofy2zF5qRC1UKQv/TlXCgCPOi8t3aAEhWaH/xJ06JkpKeUua+GhZL99zmWR8TjigYuSLlTLAz+8idS7dk3TGE0XhSq1c4ZPTsnt0Z+bIY3F+DvUts3QaLLWJM1TdbgTjDfAARmONx1gZqe3fdYBLMxVKVWJ+sEU+jwwBqCoKUwiOA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 13, 2023 at 02:40:24PM +0100, Paolo Bonzini wrote: > Why are they dead code? X86_FEATURE_SEV_SNP is set automatically based on > CPUID, therefore patch 5 is a performance improvement on all processors that > support SEV-SNP. This is independent of whether KVM can create SEV-SNP > guests or not. No, it is not. This CPUID bit means: "RMP table can be enabled to protect memory even from hypervisor." Without the SNP host patches, it is dead code. And regardless, arch/x86/kvm/ patches go through the kvm tree. The rest of arch/x86/ through the tip tree. We've been over this a bunch of times already. If you don't agree with this split, let's discuss it offlist with all tip and kvm maintainers, reach an agreement who picks up what and to put an end to this nonsense. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette