From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B029C4332F for ; Wed, 13 Dec 2023 09:09:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D66CF6B0482; Wed, 13 Dec 2023 04:09:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D17666B0483; Wed, 13 Dec 2023 04:09:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB81F6B0484; Wed, 13 Dec 2023 04:09:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A3C576B0482 for ; Wed, 13 Dec 2023 04:09:18 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 77BD580ECC for ; Wed, 13 Dec 2023 09:09:18 +0000 (UTC) X-FDA: 81561221196.12.3E296AE Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by imf01.hostedemail.com (Postfix) with ESMTP id C3C4940019 for ; Wed, 13 Dec 2023 09:09:16 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=T3qfGnoU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of haokexin@gmail.com designates 209.85.167.173 as permitted sender) smtp.mailfrom=haokexin@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702458556; a=rsa-sha256; cv=none; b=nAD9Az360JYPBcyDauUFb4UfG91dvtnjlE7UtrdzokNe/Q+kC497bmx6Q6JwC312jgEL/I dzWlvui0XhZKNi20F7gkv45UKz0C0hpiJ2NUpyNBT1ILZZmbgTVFwmCheRHJgV+u74grOS npGkUUxayCRM15rdVucMWCMW3buC1bg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=T3qfGnoU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of haokexin@gmail.com designates 209.85.167.173 as permitted sender) smtp.mailfrom=haokexin@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702458556; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=z5nPKyU68fvaavmueS8zDjxevBUCgt13Z1Fi1bObU0g=; b=NZNjGJjWFa04fIprRIbCF9jAK5gHRFwIRMVpybfDTnczWN6ip4tzE5No9qjO6FOM9VmUjC 6IraxVQW88zQ4wWtPPCT+DKzso3h6lp1lQblPeL3UGMwEEbwJ7r8io3XHDuhF1x68HIGhv e2QiGSW/emHD54RdXgqHk/MuiAa6V0A= Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3b9efed2e6fso3885580b6e.0 for ; Wed, 13 Dec 2023 01:09:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702458555; x=1703063355; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=z5nPKyU68fvaavmueS8zDjxevBUCgt13Z1Fi1bObU0g=; b=T3qfGnoUbsgxMWbXO+ONZblUMWusNZAVmElN+5JBGtEV84jFnsbJvAgnholLtuAEdW 38HSq4snHIIfvsXYtS0TpwtmGRXPHOF/7N6GmtmvSRJ74YRPjK9b+ktJCKvMD8j784dl CDxp1owUKWLAaS1G7RjyquadNJbyTWsRG8IOs/YRE/YEX9SK3MpOoGBQnKFdkJghw996 42f6Z6AXBud9qNFY3ssgsjUX1FKixqImdOoEN0lAyBzyGm6rmEaJAkS3uQkU8lelX/MT zGBG2D+SFn2XNcffQQtDYQV0lMKqNgFMBwIKgQBpho4yWcm5mRibz1lfqR8hD/GXYg0r i5NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702458555; x=1703063355; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z5nPKyU68fvaavmueS8zDjxevBUCgt13Z1Fi1bObU0g=; b=Z+MQUXw05hzDQZW5Wp5PUFu8juTXYRWfazbWYt87EzMv9HOxitdQ9TZITSrTqBw3cn pL9gls7Y7WQjp2aLZMQefKKNvbxpLf2wNEhwQfvPHLUM/22DxHWWzufvW52xPoQeWl2l AtNp4OeQI0UFB5eVriy3+5Q7UmLRoDE5m40M/NEJu+HtOKu4Su5Z4Kf+GDwAy2YdU/3m b3G1vw02pprA9ajFMSJGs+rQx5ObIIbWgtwrM0bO0NfHXEDlmJs9QtqT/e6srqOejprE r5Z2mGc+xNWglat6iueaIj0wXshfxx9kb1pCq3SRvOh69d/rIGC6UAA487/2wKPZYWI3 PZkA== X-Gm-Message-State: AOJu0Yy9xAsKxPeUA46GU5eOlnPol9AyjNjZWCae3/XQtf5lxd9zdll6 fCv//B7g3cMtO1wH9HZSSb2dgh5n/LkhZw== X-Google-Smtp-Source: AGHT+IEPwIffAM8HhUXE4tS9NZl1kJNMyp5NHy7zCc/oIqysiwnDZPvUO/1/gWVM6GUIq2Xt7PGXxw== X-Received: by 2002:a05:6808:f09:b0:3b9:e626:d714 with SMTP id m9-20020a0568080f0900b003b9e626d714mr9192037oiw.37.1702458554903; Wed, 13 Dec 2023 01:09:14 -0800 (PST) Received: from pek-lpggp6.wrs.com (unknown-105-121.windriver.com. [147.11.105.121]) by smtp.gmail.com with ESMTPSA id y20-20020a056a00191400b006cbadbf20ddsm9456722pfi.187.2023.12.13.01.09.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 01:09:14 -0800 (PST) From: Kevin Hao To: linux-mm@kvack.org Cc: Andrea Arcangeli , Andrew Morton , "Rafael J. Wysocki" , Pavel Machek Subject: [PATCH] mm: ksm: Remove unnecessary try_to_freeze() Date: Wed, 13 Dec 2023 17:09:06 +0800 Message-Id: <20231213090906.1070985-1-haokexin@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C3C4940019 X-Stat-Signature: wc6q8tacaxcruzyrjhccrjn8eubde6g5 X-HE-Tag: 1702458556-249659 X-HE-Meta: U2FsdGVkX19SiQBjohtntWNvVlWZxP1XN6kQYaK+t2kGcRLPdenl8Ef4cMofioN+bu6CrBMQfyKV6Mpu8cSBmRcR5GxIZpRBxuUVXlgfz2FtM20wDYlRQDYG14LOUDK7luWqCThc3GewmW5rWGfuy4IDyVfAgWiuvaiDt+TjstdK71wvkvTQt+nH8QnqqzmmVF0twXgLHLizBNdbvJpnNRK11Ln0JtxwMb6ndk4Ua3uf1i/i2cylNHy9/xyc9Lywy86kWvU9xk7Q99775CtrgryYnBQ+3KTq61D9bV4Te3ll5JnJN3hH7x+tNQo/TarcfGFffC4Dmw5Mo2rRGuJUVdWJZddwMO0Euu5D9NdOnVdx8ZtE0PgVrVRWcw9KmsKyGkwSrW1IG6PUlFi3SIJ8pF5nVg3tm5hWttss7bgAN3Ux/idR8OmseMuWFpoZUF1l6CfIjY2B1rMSj6GTmPZUn1R6hgtM8Z2FhimqduHZ8uAKLt59mnaXVaaNipiVPGsgEMaGx0MVcsZi1KPABKKMwkjHuORjRoZ6ELHNc2heM0xK9sGQSD/GMwxmOPqQa+PVJ988ZC8YkIAoxfQkx5NLUj3rCfArKwTcX7HXaraUEYp8IVHYJ1s+kFDNis1ya1D3DRCmogvZamB7KrxxMw9+yNQg/++pZ5SHIMY7z6SDUOmj+RmApaIu/l8SQ71GeIjoCVKP6gkWD/iQuDsrIV3QYXegB9TYqoPDgOD31SAcX4d3hi5ByEr9a6JYxLeIlG58uMBf18BFfD9vsWKltvuPphpNxhv1puSznui2WwwSEapSzTr3QdjvhsFs3HT99N9wQpubufM5gkRIUUDYBmJqWg3ITbB5Q2bH5RuOV0XHz0E2hkhH9GxzdossSONgQhLOrrQPUfj5WOMNWPgLBYlNz9LNfDSeMk/XTbj16RyGKJFkK2rNKMzL87X8Q4gtqJ7k/1Fw6vJiITBjhm9eu5u FLvgVxoP KCBdu3iLbuur00VDo0hPWQ7eKqyI5yqY1rHYoN357Rt1R5aAiDcqBDmTXuYhgks+SR0eRi2ZVP8jV1LL41R/kV+6tybtXQLn+IySIh0i3fcT1/ul3iPJ//ieWa3VudgSJoPW6oerVNPFG40MZQLZ9+YzpK0hbQLp8hWZS+/XOdGsTCTTp+o5MHHaoCY0zdhWhYWT6DfuuZqz3kLa0fPzeYjHXCpsGaBPrOoi8ttLrWKNoC5tSOy5DsXjh/r9uvnkflih6ucpaajsuCocrz1DRD+VG9b2COweHCndY24Ok72+MPKw85bEwjWeduTqln+eT37a2+Sv0eYkhlBmxzTNdgtOHM/WIiWN/nENJJKqIulHfgN5VxqE6XtwV10xE353EZiwzt9IPQ3ZyNBzHX5dW6oSKuXZ4HG7k9uW4TW4KMhyJl2d+6SKSA52ZYgU4gbBVF0OwRVf/r/i+3iUjrp3SQXZrhAJAn6NOYqluJBOhVw6tdhbZL/2wC1TOGDr7OcSvljkbi11/fht0EsWI1Oq9zDyl/bnwl2yqtHFdMqVocJHY+DxFcKtO/Xgb02kiXpkJDFkwX2l59JipXTTaJRX5Q9X7qzCuEDQqgAQbHBv2xiZW7FtFK9n09t1obIVPEYFJWX2W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: A freezable kernel thread can enter frozen state during freezing by either calling try_to_freeze() or using wait_event_freezable() and its variants. However, there is no need to use both methods simultaneously. Signed-off-by: Kevin Hao Cc: Andrea Arcangeli Cc: Andrew Morton Cc: "Rafael J. Wysocki" Cc: Pavel Machek --- mm/ksm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/ksm.c b/mm/ksm.c index 16532fa85a46..e2ce850c2739 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -2604,11 +2604,9 @@ static int ksm_scan_thread(void *nothing) ksm_do_scan(ksm_thread_pages_to_scan); mutex_unlock(&ksm_thread_mutex); - try_to_freeze(); - if (ksmd_should_run()) { sleep_ms = READ_ONCE(ksm_thread_sleep_millisecs); - wait_event_interruptible_timeout(ksm_iter_wait, + wait_event_freezable_timeout(ksm_iter_wait, sleep_ms != READ_ONCE(ksm_thread_sleep_millisecs), msecs_to_jiffies(sleep_ms)); } else { -- 2.39.2