From: Chengming Zhou <zhouchengming@bytedance.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Nhat Pham <nphamcs@gmail.com>, Chris Li <chriscli@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Seth Jennings <sjenning@redhat.com>,
Dan Streetman <ddstreet@ieee.org>,
Vitaly Wool <vitaly.wool@konsulko.com>,
Yosry Ahmed <yosryahmed@google.com>
Cc: Nhat Pham <nphamcs@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Chengming Zhou <zhouchengming@bytedance.com>
Subject: [PATCH 2/5] mm/zswap: change dstmem size to one page
Date: Wed, 13 Dec 2023 04:17:59 +0000 [thread overview]
Message-ID: <20231213-zswap-dstmem-v1-2-896763369d04@bytedance.com> (raw)
In-Reply-To: <20231213-zswap-dstmem-v1-0-896763369d04@bytedance.com>
Change the dstmem size from 2 * PAGE_SIZE to only one page since
we only need at most one page when compress, and the "dlen" is also
PAGE_SIZE in acomp_request_set_params(). If the output size > PAGE_SIZE
we don't wanna store the output in zswap anyway.
So change it to one page, and delete the stale comment.
Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
---
mm/zswap.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/mm/zswap.c b/mm/zswap.c
index edb8b45ed5a1..fa186945010d 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -707,7 +707,7 @@ static int zswap_dstmem_prepare(unsigned int cpu)
struct mutex *mutex;
u8 *dst;
- dst = kmalloc_node(PAGE_SIZE * 2, GFP_KERNEL, cpu_to_node(cpu));
+ dst = kmalloc_node(PAGE_SIZE, GFP_KERNEL, cpu_to_node(cpu));
if (!dst)
return -ENOMEM;
@@ -1662,8 +1662,7 @@ bool zswap_store(struct folio *folio)
sg_init_table(&input, 1);
sg_set_page(&input, page, PAGE_SIZE, 0);
- /* zswap_dstmem is of size (PAGE_SIZE * 2). Reflect same in sg_list */
- sg_init_one(&output, dst, PAGE_SIZE * 2);
+ sg_init_one(&output, dst, PAGE_SIZE);
acomp_request_set_params(acomp_ctx->req, &input, &output, PAGE_SIZE, dlen);
/*
* it maybe looks a little bit silly that we send an asynchronous request,
--
b4 0.10.1
next prev parent reply other threads:[~2023-12-13 4:18 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 4:17 [PATCH 0/5] mm/zswap: dstmem reuse optimizations and cleanups Chengming Zhou
2023-12-13 4:17 ` [PATCH 1/5] mm/zswap: reuse dstmem when decompress Chengming Zhou
2023-12-13 23:24 ` Yosry Ahmed
2023-12-14 13:29 ` Chengming Zhou
2023-12-14 13:32 ` Yosry Ahmed
2023-12-14 14:42 ` Chengming Zhou
2023-12-14 18:24 ` Yosry Ahmed
2023-12-18 8:06 ` Chengming Zhou
2023-12-14 17:59 ` Chris Li
2023-12-14 18:26 ` Yosry Ahmed
2023-12-14 22:02 ` Chris Li
2023-12-14 20:33 ` Nhat Pham
2023-12-13 4:17 ` Chengming Zhou [this message]
2023-12-13 23:34 ` [PATCH 2/5] mm/zswap: change dstmem size to one page Yosry Ahmed
2023-12-14 0:18 ` Nhat Pham
2023-12-14 13:33 ` Chengming Zhou
2023-12-14 13:37 ` Yosry Ahmed
2023-12-14 13:57 ` Chengming Zhou
2023-12-14 15:03 ` Chengming Zhou
2023-12-14 18:34 ` Yosry Ahmed
2023-12-14 18:30 ` Yosry Ahmed
2023-12-14 20:29 ` Nhat Pham
2023-12-13 4:18 ` [PATCH 3/5] mm/zswap: refactor out __zswap_load() Chengming Zhou
2023-12-13 23:37 ` Yosry Ahmed
2023-12-14 0:52 ` Yosry Ahmed
2023-12-14 14:45 ` Chengming Zhou
2023-12-18 8:15 ` Chengming Zhou
2023-12-18 9:38 ` Yosry Ahmed
2023-12-13 4:18 ` [PATCH 4/5] mm/zswap: cleanup zswap_load() Chengming Zhou
2023-12-14 0:56 ` Yosry Ahmed
2023-12-13 4:18 ` [PATCH 5/5] mm/zswap: cleanup zswap_reclaim_entry() Chengming Zhou
2023-12-13 23:27 ` Nhat Pham
2023-12-14 1:02 ` Yosry Ahmed
2023-12-14 22:23 ` Andrew Morton
2023-12-14 22:41 ` Yosry Ahmed
2023-12-18 14:03 ` Johannes Weiner
2023-12-18 14:39 ` Yosry Ahmed
2023-12-18 14:58 ` Johannes Weiner
2023-12-18 20:52 ` Yosry Ahmed
2023-12-19 12:16 ` Chengming Zhou
2023-12-20 4:30 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213-zswap-dstmem-v1-2-896763369d04@bytedance.com \
--to=zhouchengming@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=chriscli@google.com \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox