From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE94C4332F for ; Tue, 12 Dec 2023 20:47:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A77AF6B0388; Tue, 12 Dec 2023 15:47:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A27C16B038A; Tue, 12 Dec 2023 15:47:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 805206B038B; Tue, 12 Dec 2023 15:47:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6B9FD6B0388 for ; Tue, 12 Dec 2023 15:47:36 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4E5331C13EE for ; Tue, 12 Dec 2023 20:47:36 +0000 (UTC) X-FDA: 81559352112.06.617EEA5 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) by imf12.hostedemail.com (Postfix) with ESMTP id 83D3E4001E for ; Tue, 12 Dec 2023 20:47:34 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=MZOdsNgh; spf=pass (imf12.hostedemail.com: domain of 35cZ4ZQUKCIg4msu4s00sxq.o0yxuz69-yyw7mow.03s@flex--sagis.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=35cZ4ZQUKCIg4msu4s00sxq.o0yxuz69-yyw7mow.03s@flex--sagis.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702414054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zFFcB69i+m00s0TO+Fs1znX5Nq1xcr5cHosByTfFHVM=; b=qd5iDDbkH43GG5tzc7R4mbYIBXwQD+KHgPata+v5Gt9L1XDiki2C9yX/Tl3tolqZyUmtHa MLsWCcFOg4QSB7ECIou4cuYau0JSXtE+Mg92G7CEx9HxwPIQkTxELqDnboxk3Q0jnltee/ jiyZKSU1WWuP2fFD4DcjUeK6vdcRerg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702414054; a=rsa-sha256; cv=none; b=qZ/uUoGC4dEHTf3odFSf7xTLza/BVGLsRYh4oyHMjTnxQ/mw2J5I7aCtl3SeUBXqPbWJMX hg7u5WHFteHg6imm7+1p/AFoFwv2xzXkaMgW4TZDhSbf3L8JZTXGXBfnizaZwlJjef4qWt kmO5NXl9rjhfw33rdOOKMZsA1U+UQ6I= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=MZOdsNgh; spf=pass (imf12.hostedemail.com: domain of 35cZ4ZQUKCIg4msu4s00sxq.o0yxuz69-yyw7mow.03s@flex--sagis.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=35cZ4ZQUKCIg4msu4s00sxq.o0yxuz69-yyw7mow.03s@flex--sagis.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-1d34b1ea914so696015ad.1 for ; Tue, 12 Dec 2023 12:47:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702414053; x=1703018853; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=zFFcB69i+m00s0TO+Fs1znX5Nq1xcr5cHosByTfFHVM=; b=MZOdsNgh3zClyvSjY8fz/e6Y9CYdLO247otyVBqbWkndhBXiCS1/cHiLdrKXCwuxPX WeGRULZWXs1tgEFTB5SVq4gaBoQC95xe7QvbMGM0juSfqZ0vFXgkslmKU9FUfLPW8sSr R9QBmO9WKXBZuuLugGfvSLiaLsv82Z927jTEPw+eXvXtovAjw1v7H3jNbZFUl1VkwlQB E1rJBoQIcvOHPVSG/usfQlYTz1hwGbbnNm9CYq0krm0qSpHMVzUMhQNazKtEkFonRFiH VtefemH9Gg2jvoNhGTfxgwW8Bjs9/yOLyYXsAPFdpd1TnOjSsAyA2llegPWrXYkLHW3d EQ9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702414053; x=1703018853; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zFFcB69i+m00s0TO+Fs1znX5Nq1xcr5cHosByTfFHVM=; b=rmcwI8i2SfkuhEPwCtykTP2bv0fn7SYSVftIu/lEWmQPUIYmaiLkAL1TkHNueJCcvn zy7UsdKk75oDiRlS85dcJtNKyPqlSMqpwvZHn39ASv4LTq9tvp7AEkICUUYBMAvfWtLV yoKiqtGDuEgs2cIoQABXKQ/aG9iJWNZHDcEiJK/mLjM2B/t/xgDnQy0BZfepGPMDC0xi lzHjhJd3KPbm2CsbD0ciMemZThvJHSRB0ZDnHPHJWk0SXWtPucXOMzxrP2y9N/e6wYcQ JW4VHJtHtxrJdSEuGymJukF+44YrwqD+duLYbgIxXyllF3xS2dKnZnRW7RICB0ICuRYR 6Aqw== X-Gm-Message-State: AOJu0YyzgHN8hPzUjU97dp1X4nVuiBZS0MiBiV+6rTsk9tJn04MdGLrS 32EO1uzadP2o/yBMWgT6r58MJL/ZXQ== X-Google-Smtp-Source: AGHT+IEC508mWXKx6m7CJH79a+MfJPBjUzdcb0UDWwXb5fHS7hJ9IPvZVzBed8Sg2EZ6RDjBh2TTTwxBZg== X-Received: from sagi.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:241b]) (user=sagis job=sendgmr) by 2002:a17:902:f54a:b0:1d0:5d31:4672 with SMTP id h10-20020a170902f54a00b001d05d314672mr54883plf.5.1702414053405; Tue, 12 Dec 2023 12:47:33 -0800 (PST) Date: Tue, 12 Dec 2023 12:46:34 -0800 In-Reply-To: <20231212204647.2170650-1-sagis@google.com> Mime-Version: 1.0 References: <20231212204647.2170650-1-sagis@google.com> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog Message-ID: <20231212204647.2170650-20-sagis@google.com> Subject: [RFC PATCH v5 19/29] KVM: selftests: TDX: Add TDX CPUID TDVMCALL test From: Sagi Shahar To: linux-kselftest@vger.kernel.org, Ackerley Tng , Ryan Afranji , Erdem Aktas , Sagi Shahar , Isaku Yamahata Cc: Sean Christopherson , Paolo Bonzini , Shuah Khan , Peter Gonda , Haibo Xu , Chao Peng , Vishal Annapurve , Roger Wang , Vipin Sharma , jmattson@google.com, dmatlack@google.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 83D3E4001E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: zdr13ppofscitxewxym5pc68wr4omqnc X-HE-Tag: 1702414054-2227 X-HE-Meta: U2FsdGVkX180155dG2iKhUJGHmwFBbuCPjbDgkhN6shuaZLi0fX71tf+5nC0HlmiZs7ZQVYNY7OKkqDlTpBIk10B1JJxZz8vxm6Dt8fm5Bl8xy3zwgDXy/clNGhMXVbt5H0c+0xC34xdod1jL1YUG0IdhLNhmEyw32zTKLf2eMm8e2rrw6fCI9eh6Dm6UUUKAeYG2pq0O3K/AmgYCTUGrY5r/e29l98iB3/g+Ohlhnfq+GaQI7FvH1O+bfCcvIaNylFv7YbCeMhAC6/NzeltziG3mjrpsSpW/IgK9+xF2KKy2NpIEObFp3rSt9EwsCCvCyEtoNlE0u1se/jAnXiGMs6eSCXrHeoq1zoUEdKHfbCOAkbKf+iIJljw4m6SdUtMvk+a/cmiVYZ71c1aoNYhaQGUKsEOqQd/Q7tnL3VK9pbN5bAvxcMxD3X2JdWxh5k+9xodksGU/r9ogJqcjws0a4Jku0Tl3Mt5s995dfcZpUU2MN0S7orvI0cQmlY1u7XmLxzwqKXNFp1rYY9aRYkDc095JfuwxCV2owPj9RQ98EP3QYTdXoyFjkPfozO7sR13Hp9VUZUcGLSMWKXfojwJm6zeUMSP4xVkfzaVPxDHzF+OlKBp5V+eA2feimi8esssxsQYFPCeaRVXL++986YaoXa7dhzWqEwxC3BFW98CEe6UuibnqwF4spBinMXBDutCknjrqOv86cGs3WBQwqx6QoSXrzFdkipACZZ/RUBRn6C/HWafQLRrdooOymaKiCD/pL0Oe8EpX4lkzVoq7v/H4aYiTUXPHZuE1LeL0IqR4SGhTb9luSBk6+StCf9sbUvAnw/r/Xg42JMArD+YUb17Z4qLuY37//gIKs23SwinQYSLSdy9+/Q+wFjQSCwdBpaUJb6LtlVelomWuoZRw4Kuhgpq9FCNYhom/6TcmITXwgniSyF2fFzWuop3/LZ2fnUg8AnRoeAgZx7JG4d8cfG dMDCgWm3 VpO8kuC+L/aDehqBBS8QZlUW0l34ScaNjSnWHD2rDNmOKz4fAH/Ih2J6AKu6bWLcvfZCNDq/44FY2AFbNagKTzZbHHnq2jcDH6RatOidYsK/5XZnZ6gkaKJ72Y13WedGRxptVtA+cWJ7ip6DrT3ZVjG/xLTIS02k0MfiOjDIV3NRjwJb4rAFTH3jdutD7MlJZUlgl3AiGMguXk1ciYwTWhk61uSYdbyFBsPdUih3itsVVJG0sc/DMAanfKRTkKWWQw+Wo49oKhTSun5MnB8YAsxh1zTMd6Ja1drb5plmVz6STpAsHgi0vnGcZm0PUUvnAhY1tMEjH1YzchhwI2DrZtxu01SoekLg6y3z6X5v2BsIYTVM5Bw417DgFE9U9AJP2QiBkxVcymFj5TJoD8MOmziA6zPdUVVSCir39+uDeKc67pAZip3NHVe7VAIHJxLrX4Wx37cKWd1d6q++X5ziOC08WMgSyeiL/yDPMFVBbIDDEitH3iOncUuhf7DR1qjbfelmOz4BPpmwEPaYB8pX8xFtY07C+TS8qb58qO9MOt9k72HfBOaSya23iXMXTUKgrw3J+Ba/YKu8yIodyqqubsvoaCWhhP8Dhqi7p X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This test issues a CPUID TDVMCALL from inside the guest to get the CPUID values as seen by KVM. Signed-off-by: Sagi Shahar Signed-off-by: Ackerley Tng Signed-off-by: Ryan Afranji --- .../selftests/kvm/include/x86_64/tdx/tdx.h | 4 + .../selftests/kvm/lib/x86_64/tdx/tdx.c | 26 +++++ .../selftests/kvm/x86_64/tdx_vm_tests.c | 94 +++++++++++++++++++ 3 files changed, 124 insertions(+) diff --git a/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h b/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h index 502b670ea699..b13a533234fd 100644 --- a/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h +++ b/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h @@ -8,6 +8,7 @@ #define TDG_VP_VMCALL_GET_TD_VM_CALL_INFO 0x10000 #define TDG_VP_VMCALL_REPORT_FATAL_ERROR 0x10003 +#define TDG_VP_VMCALL_INSTRUCTION_CPUID 10 #define TDG_VP_VMCALL_INSTRUCTION_HLT 12 #define TDG_VP_VMCALL_INSTRUCTION_IO 30 #define TDG_VP_VMCALL_INSTRUCTION_RDMSR 31 @@ -27,5 +28,8 @@ uint64_t tdg_vp_vmcall_ve_request_mmio_read(uint64_t address, uint64_t size, uint64_t *data_out); uint64_t tdg_vp_vmcall_ve_request_mmio_write(uint64_t address, uint64_t size, uint64_t data_in); +uint64_t tdg_vp_vmcall_instruction_cpuid(uint32_t eax, uint32_t ecx, + uint32_t *ret_eax, uint32_t *ret_ebx, + uint32_t *ret_ecx, uint32_t *ret_edx); #endif // SELFTEST_TDX_TDX_H diff --git a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c index f4afa09f7e3d..a45e2ceb6eda 100644 --- a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c +++ b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c @@ -157,3 +157,29 @@ uint64_t tdg_vp_vmcall_ve_request_mmio_write(uint64_t address, uint64_t size, return __tdx_hypercall(&args, 0); } + +uint64_t tdg_vp_vmcall_instruction_cpuid(uint32_t eax, uint32_t ecx, + uint32_t *ret_eax, uint32_t *ret_ebx, + uint32_t *ret_ecx, uint32_t *ret_edx) +{ + uint64_t ret; + struct tdx_hypercall_args args = { + .r11 = TDG_VP_VMCALL_INSTRUCTION_CPUID, + .r12 = eax, + .r13 = ecx, + }; + + + ret = __tdx_hypercall(&args, TDX_HCALL_HAS_OUTPUT); + + if (ret_eax) + *ret_eax = args.r12; + if (ret_ebx) + *ret_ebx = args.r13; + if (ret_ecx) + *ret_ecx = args.r14; + if (ret_edx) + *ret_edx = args.r15; + + return ret; +} diff --git a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c index 5e28ba828a92..6935604d768b 100644 --- a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c +++ b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c @@ -969,6 +969,99 @@ void verify_mmio_writes(void) printf("\t ... PASSED\n"); } +/* + * Verifies CPUID TDVMCALL functionality. + * The guest will then send the values to userspace using an IO write to be + * checked against the expected values. + */ +void guest_code_cpuid_tdcall(void) +{ + uint64_t err; + uint32_t eax, ebx, ecx, edx; + + // Read CPUID leaf 0x1 from host. + err = tdg_vp_vmcall_instruction_cpuid(/*eax=*/1, /*ecx=*/0, + &eax, &ebx, &ecx, &edx); + if (err) + tdx_test_fatal(err); + + err = tdx_test_report_to_user_space(eax); + if (err) + tdx_test_fatal(err); + + err = tdx_test_report_to_user_space(ebx); + if (err) + tdx_test_fatal(err); + + err = tdx_test_report_to_user_space(ecx); + if (err) + tdx_test_fatal(err); + + err = tdx_test_report_to_user_space(edx); + if (err) + tdx_test_fatal(err); + + tdx_test_success(); +} + +void verify_td_cpuid_tdcall(void) +{ + struct kvm_vm *vm; + struct kvm_vcpu *vcpu; + + uint32_t eax, ebx, ecx, edx; + const struct kvm_cpuid_entry2 *cpuid_entry; + + vm = td_create(); + td_initialize(vm, VM_MEM_SRC_ANONYMOUS, 0); + vcpu = td_vcpu_add(vm, 0, guest_code_cpuid_tdcall); + td_finalize(vm); + + printf("Verifying TD CPUID TDVMCALL:\n"); + + /* Wait for guest to report CPUID values */ + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + TDX_TEST_ASSERT_IO(vcpu, TDX_TEST_REPORT_PORT, 4, + TDG_VP_VMCALL_INSTRUCTION_IO_WRITE); + eax = *(uint32_t *)((void *)vcpu->run + vcpu->run->io.data_offset); + + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + TDX_TEST_ASSERT_IO(vcpu, TDX_TEST_REPORT_PORT, 4, + TDG_VP_VMCALL_INSTRUCTION_IO_WRITE); + ebx = *(uint32_t *)((void *)vcpu->run + vcpu->run->io.data_offset); + + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + TDX_TEST_ASSERT_IO(vcpu, TDX_TEST_REPORT_PORT, 4, + TDG_VP_VMCALL_INSTRUCTION_IO_WRITE); + ecx = *(uint32_t *)((void *)vcpu->run + vcpu->run->io.data_offset); + + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + TDX_TEST_ASSERT_IO(vcpu, TDX_TEST_REPORT_PORT, 4, + TDG_VP_VMCALL_INSTRUCTION_IO_WRITE); + edx = *(uint32_t *)((void *)vcpu->run + vcpu->run->io.data_offset); + + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + TDX_TEST_ASSERT_SUCCESS(vcpu); + + /* Get KVM CPUIDs for reference */ + cpuid_entry = get_cpuid_entry(kvm_get_supported_cpuid(), 1, 0); + TEST_ASSERT(cpuid_entry, "CPUID entry missing\n"); + + TEST_ASSERT_EQ(cpuid_entry->eax, eax); + // Mask lapic ID when comparing ebx. + TEST_ASSERT_EQ(cpuid_entry->ebx & ~0xFF000000, ebx & ~0xFF000000); + TEST_ASSERT_EQ(cpuid_entry->ecx, ecx); + TEST_ASSERT_EQ(cpuid_entry->edx, edx); + + kvm_vm_free(vm); + printf("\t ... PASSED\n"); +} + int main(int argc, char **argv) { setbuf(stdout, NULL); @@ -990,6 +1083,7 @@ int main(int argc, char **argv) run_in_new_process(&verify_guest_hlt); run_in_new_process(&verify_mmio_reads); run_in_new_process(&verify_mmio_writes); + run_in_new_process(&verify_td_cpuid_tdcall); return 0; } -- 2.43.0.472.g3155946c3a-goog