From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 626B5C4167B for ; Tue, 12 Dec 2023 20:47:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA5906B0384; Tue, 12 Dec 2023 15:47:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E47FB6B0386; Tue, 12 Dec 2023 15:47:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4BF56B0387; Tue, 12 Dec 2023 15:47:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AABAF6B0384 for ; Tue, 12 Dec 2023 15:47:32 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8516F1C12C3 for ; Tue, 12 Dec 2023 20:47:32 +0000 (UTC) X-FDA: 81559351944.12.B8422D0 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf24.hostedemail.com (Postfix) with ESMTP id BE524180025 for ; Tue, 12 Dec 2023 20:47:30 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=oAkd2d0P; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of 34cZ4ZQUKCIQ0ioq0owwotm.kwutqv25-uus3iks.wzo@flex--sagis.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=34cZ4ZQUKCIQ0ioq0owwotm.kwutqv25-uus3iks.wzo@flex--sagis.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702414050; a=rsa-sha256; cv=none; b=EOSYdhpcJOYgFgOEzdZKPLcgqQvispRaV360kPaX9d9ciIXe4Utcmk6eg6emWCHlJ0D9Ci t7Nn3nzt+zj9ixSCQJ5UkNCjeUQd5fnWdD9uMUDmKbxUIl3HTjRtyssgX8ewaSuhRdW9ky sOySRKmwD5Fqhb7oTpqm8OcbsgKFmUo= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=oAkd2d0P; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of 34cZ4ZQUKCIQ0ioq0owwotm.kwutqv25-uus3iks.wzo@flex--sagis.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=34cZ4ZQUKCIQ0ioq0owwotm.kwutqv25-uus3iks.wzo@flex--sagis.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702414050; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4egsLMzPG6RqT1HiF2arhOZ1FLT3WKNE+n1ktHUZWdA=; b=IRpdnUo721P0MMEeT1LEQy0DpLuLbooXebRDW7EnhnyKAAQftDMsjkXc74owgsvu54Mlje hc40SuntWSOzDKM1MZISjz0UArIVQ/Af8Y4ICDnDDVClfsF/3zpeAT/qwbe6kGoidlUqAD Meiv5sZgJPiOzMo7/6eqpSpDuI/rHZc= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dbc1f00dc35so6913416276.3 for ; Tue, 12 Dec 2023 12:47:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702414050; x=1703018850; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=4egsLMzPG6RqT1HiF2arhOZ1FLT3WKNE+n1ktHUZWdA=; b=oAkd2d0PBxMZybAdBk/8ANDFL/GleQM04UxcEkUpzWGNMiR/1wfVmelcwUHMRKy3kW MbJ3GIJPx91v3/aCrSKw5DnYTnTL2TBExi1ScD14CP2JeiieyCIQHJJ6IIxGBJr1PMFX 1dAGj/HvmAzXC1B8FtCZtaTd47ySYOtWX3bmny3Key0DwmGbOMeHfuW+TP7DtW03/vrT d3xbK3RCJvJh0WTJtzpwvsFZ9c3hET4jWKkPDOiKlzorDuewtIu1lN42ISPD44qGT9+w PSR6W4waRG+gFwJq8WhCBEQoVPefnmkdKEhFfQeblO7r2BhWGTII1AXQh3SCBy05IR5u ogMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702414050; x=1703018850; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4egsLMzPG6RqT1HiF2arhOZ1FLT3WKNE+n1ktHUZWdA=; b=F1hyco0n2Kspp7SHwulHc49i3v68SPLVjV2Lk9mhDZB8pJqDQ87Zxf6gwESAAKxwlt wH9x4r9USKd6p14lw3r02Ii1YcswxEcf+TF4TWYGlt/Hs5pMsTY5WiWfwFvtDEOpKRmO ZdyjQGEkGZaLdIGfFiqcu06hZEYcaDkekPgnx97q6xya83CDGPoNnCaHLvvRR2FxpNQe A82XZXKmlZZwdrg9ECE+WWYu18xSdb67YnvZEE3egZLnLi2t9w2IP5tOHbWctXjofQP2 0uK1u/2HiHJI5hJ9vJTVfZffvD8+noiymlAivLdoyNm6NszAD4MMP6g5wETuZP9c6/u/ p7Ag== X-Gm-Message-State: AOJu0Yx+JhxvJeoJocO4Cr3hRwz2wMmFC8q1ttHYWOf8JdSrEryVLlTO Ogw5ku46+RldiOPem1gDLw612JaX7Q== X-Google-Smtp-Source: AGHT+IEgSqjVHuiiVhdZc1iYV7vk5vqbcM2p752JGuC/23gRP3Ry7yqtntV2qKviMwrvaZ+PKfnTQNi2Lg== X-Received: from sagi.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:241b]) (user=sagis job=sendgmr) by 2002:a05:6902:185:b0:dbc:c7f0:7c2e with SMTP id t5-20020a056902018500b00dbcc7f07c2emr6240ybh.2.1702414049815; Tue, 12 Dec 2023 12:47:29 -0800 (PST) Date: Tue, 12 Dec 2023 12:46:32 -0800 In-Reply-To: <20231212204647.2170650-1-sagis@google.com> Mime-Version: 1.0 References: <20231212204647.2170650-1-sagis@google.com> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog Message-ID: <20231212204647.2170650-18-sagis@google.com> Subject: [RFC PATCH v5 17/29] KVM: selftests: TDX: Add TDX MMIO reads test From: Sagi Shahar To: linux-kselftest@vger.kernel.org, Ackerley Tng , Ryan Afranji , Erdem Aktas , Sagi Shahar , Isaku Yamahata Cc: Sean Christopherson , Paolo Bonzini , Shuah Khan , Peter Gonda , Haibo Xu , Chao Peng , Vishal Annapurve , Roger Wang , Vipin Sharma , jmattson@google.com, dmatlack@google.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BE524180025 X-Stat-Signature: typrka4zkeyqso44q7mq4kq48sydf17q X-HE-Tag: 1702414050-70347 X-HE-Meta: U2FsdGVkX1+T44ItlbnOF0+WDLIoLB/MONwteXmjX8aVFci/lERoAN/VUkbl+rt1pEh+RCAFjZBKTobxhJwce4+cT3hqyj14zNI3VdBtU7qfrReVByCvsc6pkSaVAR23jkSPaQgV4T714d5lxNM3NOc862WbtUq0EOda3LsB7oPMrQrSA4cx5ar/7JKCj5qb3mPrRjH4f3Vb2I8poiapwbh1R44Zq6gvESB6q+JegbGs/63Nc1ariM+Ce9rd4W48Ml6A6IOksL0DbMTVoQMSR1ihq4OHmzyJXkQebSU8hmYbQBcfjLEyjG0LO99gXzXYRr+Q/06m91OcJTmm4Kd3YxwIav8VpmSxOal4PKvCFm8ethYrtU9o0vIHwzBY4dD0tJyEMClrOyp+NiGQDv0sJd/pvRagtyLnybXuDSkAh2jPdFuAgyXs8NLiXU0uExsusQwktBeJa37mcIusiX4xEeBnz8KRcVLfHWVPqLo8ojUXi6AVPcfkzC2BfLNobk0aUqXMIQ/8siX2+3omzN+Mtp5hqPnrQlRGVa8y2bU2hh0r1Pw8hWYbAKNA5YyBVKS0sR1X86nvmVTqv19PFAnuhL7+65JPEH78gLmP/fDZQTkaRG2CCg1gcTdD/aTfw1YPr+ozHl6XSL9NmaynaOptC61/sN3ogg+/SPybq6OaKcPVA4q7Nsh4diwZMPcTlIP3F2s5TGbLtoY5v39/kLaUNY7EhjD122/t0MOha5gIVCjAokNxBYUpbBmzozuK/KQZxKW1Dord7By+Su74NXw4qsNK3Aa2vMwUCiHUEKpGufhK0M6fUek/d0Emtdv9Qq8HmLyp1gDUtKHqR4OsMicF0vlwph0H6VVGvlQmFU/GK0R5Hc1y+bBWAAYGR55ay89QqgRMKyhBUeKaM8FO/W6nkf7cKA1IZIiZ8PvTRqyDqxdLwhtIoYJRtODRY+t1talNTt/gHW8BlZ7BJ6t2AQF J2kl/upx EGVdJ3zyzPjZK9OuTUowmtd8G6DoS+wa+csJAEWRi2x8O096mlSnE13I54qFAAoPmuZzjslwyxrKBwJ8RveWD04Y6C9CM02xxI5Bo/vPZIPHLtT7k+yvmxwcaQ1aBmT1Ing2wdF/bCYecHZp5qX++nWy+ZdyvVYIX+CIs/0lVZ9zHo1u8Ae1IbJhBKiPuAYujLEpv7+sRbkSjy0Zhy016PNjSqWKMshVGInJ5FuYAv12Nz5oUx+VMXPxXQ/3ZmPVFUmuNfxjGLnwPseddCMyMK58j6HEBccOO01KZVFvojY6R0WdwkVzclXRaKYatpOBrmRgv82TZXQdQYtRBL27lnpZqLaTvEtFUMDWmqPki74oWqlrMMYJzHg4ca0pP/hd9gfjMgJ42xjH3nXB0VQVfSmcGjIcgUPjTevfHgRaMYA6hwCkpSYCTXzUPWrPAvsUMoHkJLZEhI8rCANrHuK86UPKFQOaNW0vfKvoUw78LQHZ3Q75KJ6BRPRPYQBtkdi0cO4m5VxIzIenPW2f/G1iI45RLcFmnne0IGhTB/+F0KNbrFJGw/fgerb6RAcq+qUQQ8lNposHVSovuUWSit2gA305ybg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The test verifies MMIO reads of various sizes from the host to the guest. Signed-off-by: Sagi Shahar Signed-off-by: Ackerley Tng Signed-off-by: Ryan Afranji --- .../selftests/kvm/include/x86_64/tdx/tdcall.h | 2 + .../selftests/kvm/include/x86_64/tdx/tdx.h | 3 + .../kvm/include/x86_64/tdx/test_util.h | 23 +++++ .../selftests/kvm/lib/x86_64/tdx/tdx.c | 19 ++++ .../selftests/kvm/x86_64/tdx_vm_tests.c | 87 +++++++++++++++++++ 5 files changed, 134 insertions(+) diff --git a/tools/testing/selftests/kvm/include/x86_64/tdx/tdcall.h b/tools/testing/selftests/kvm/include/x86_64/tdx/tdcall.h index b5e94b7c48fa..95fcdbd8404e 100644 --- a/tools/testing/selftests/kvm/include/x86_64/tdx/tdcall.h +++ b/tools/testing/selftests/kvm/include/x86_64/tdx/tdcall.h @@ -9,6 +9,8 @@ #define TDG_VP_VMCALL_INSTRUCTION_IO_READ 0 #define TDG_VP_VMCALL_INSTRUCTION_IO_WRITE 1 +#define TDG_VP_VMCALL_VE_REQUEST_MMIO_READ 0 +#define TDG_VP_VMCALL_VE_REQUEST_MMIO_WRITE 1 #define TDG_VP_VMCALL_SUCCESS 0x0000000000000000 #define TDG_VP_VMCALL_INVALID_OPERAND 0x8000000000000000 diff --git a/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h b/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h index b18e39d20498..13ce60df5684 100644 --- a/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h +++ b/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h @@ -12,6 +12,7 @@ #define TDG_VP_VMCALL_INSTRUCTION_IO 30 #define TDG_VP_VMCALL_INSTRUCTION_RDMSR 31 #define TDG_VP_VMCALL_INSTRUCTION_WRMSR 32 +#define TDG_VP_VMCALL_VE_REQUEST_MMIO 48 void handle_userspace_tdg_vp_vmcall_exit(struct kvm_vcpu *vcpu); uint64_t tdg_vp_vmcall_instruction_io(uint64_t port, uint64_t size, @@ -22,5 +23,7 @@ uint64_t tdg_vp_vmcall_get_td_vmcall_info(uint64_t *r11, uint64_t *r12, uint64_t tdg_vp_vmcall_instruction_rdmsr(uint64_t index, uint64_t *ret_value); uint64_t tdg_vp_vmcall_instruction_wrmsr(uint64_t index, uint64_t value); uint64_t tdg_vp_vmcall_instruction_hlt(uint64_t interrupt_blocked_flag); +uint64_t tdg_vp_vmcall_ve_request_mmio_read(uint64_t address, uint64_t size, + uint64_t *data_out); #endif // SELFTEST_TDX_TDX_H diff --git a/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h b/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h index 8a9b6a1bec3e..af412b764604 100644 --- a/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h +++ b/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h @@ -35,6 +35,29 @@ (VCPU)->run->io.direction); \ } while (0) + +/** + * Assert that some MMIO operation involving TDG.VP.VMCALL <#VERequestMMIO> was + * called in the guest. + */ +#define TDX_TEST_ASSERT_MMIO(VCPU, ADDR, SIZE, DIR) \ + do { \ + TEST_ASSERT((VCPU)->run->exit_reason == KVM_EXIT_MMIO, \ + "Got exit_reason other than KVM_EXIT_MMIO: %u (%s)\n", \ + (VCPU)->run->exit_reason, \ + exit_reason_str((VCPU)->run->exit_reason)); \ + \ + TEST_ASSERT(((VCPU)->run->exit_reason == KVM_EXIT_MMIO) && \ + ((VCPU)->run->mmio.phys_addr == (ADDR)) && \ + ((VCPU)->run->mmio.len == (SIZE)) && \ + ((VCPU)->run->mmio.is_write == (DIR)), \ + "Got an unexpected MMIO exit values: %u (%s) %llu %d %d\n", \ + (VCPU)->run->exit_reason, \ + exit_reason_str((VCPU)->run->exit_reason), \ + (VCPU)->run->mmio.phys_addr, (VCPU)->run->mmio.len, \ + (VCPU)->run->mmio.is_write); \ + } while (0) + /** * Check and report if there was some failure in the guest, either an exception * like a triple fault, or if a tdx_test_fatal() was hit. diff --git a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c index 9485bafedc38..b19f07ebc0e7 100644 --- a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c +++ b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c @@ -124,3 +124,22 @@ uint64_t tdg_vp_vmcall_instruction_hlt(uint64_t interrupt_blocked_flag) return __tdx_hypercall(&args, 0); } + +uint64_t tdg_vp_vmcall_ve_request_mmio_read(uint64_t address, uint64_t size, + uint64_t *data_out) +{ + uint64_t ret; + struct tdx_hypercall_args args = { + .r11 = TDG_VP_VMCALL_VE_REQUEST_MMIO, + .r12 = size, + .r13 = TDG_VP_VMCALL_VE_REQUEST_MMIO_READ, + .r14 = address, + }; + + ret = __tdx_hypercall(&args, TDX_HCALL_HAS_OUTPUT); + + if (data_out) + *data_out = args.r11; + + return ret; +} diff --git a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c index 5fae4c6e5f95..48902b69d13e 100644 --- a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c +++ b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c @@ -799,6 +799,92 @@ void verify_guest_hlt(void) _verify_guest_hlt(0); } +/* Pick any address that was not mapped into the guest to test MMIO */ +#define TDX_MMIO_TEST_ADDR 0x200000000 + +void guest_mmio_reads(void) +{ + uint64_t data; + uint64_t ret; + + ret = tdg_vp_vmcall_ve_request_mmio_read(TDX_MMIO_TEST_ADDR, 1, &data); + if (ret) + tdx_test_fatal(ret); + if (data != 0x12) + tdx_test_fatal(1); + + ret = tdg_vp_vmcall_ve_request_mmio_read(TDX_MMIO_TEST_ADDR, 2, &data); + if (ret) + tdx_test_fatal(ret); + if (data != 0x1234) + tdx_test_fatal(2); + + ret = tdg_vp_vmcall_ve_request_mmio_read(TDX_MMIO_TEST_ADDR, 4, &data); + if (ret) + tdx_test_fatal(ret); + if (data != 0x12345678) + tdx_test_fatal(4); + + ret = tdg_vp_vmcall_ve_request_mmio_read(TDX_MMIO_TEST_ADDR, 8, &data); + if (ret) + tdx_test_fatal(ret); + if (data != 0x1234567890ABCDEF) + tdx_test_fatal(8); + + // Read an invalid number of bytes. + ret = tdg_vp_vmcall_ve_request_mmio_read(TDX_MMIO_TEST_ADDR, 10, &data); + if (ret) + tdx_test_fatal(ret); + + tdx_test_success(); +} + +/* + * Varifies guest MMIO reads. + */ +void verify_mmio_reads(void) +{ + struct kvm_vm *vm; + struct kvm_vcpu *vcpu; + + vm = td_create(); + td_initialize(vm, VM_MEM_SRC_ANONYMOUS, 0); + vcpu = td_vcpu_add(vm, 0, guest_mmio_reads); + td_finalize(vm); + + printf("Verifying TD MMIO reads:\n"); + + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + TDX_TEST_ASSERT_MMIO(vcpu, TDX_MMIO_TEST_ADDR, 1, TDG_VP_VMCALL_VE_REQUEST_MMIO_READ); + *(uint8_t *)vcpu->run->mmio.data = 0x12; + + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + TDX_TEST_ASSERT_MMIO(vcpu, TDX_MMIO_TEST_ADDR, 2, TDG_VP_VMCALL_VE_REQUEST_MMIO_READ); + *(uint16_t *)vcpu->run->mmio.data = 0x1234; + + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + TDX_TEST_ASSERT_MMIO(vcpu, TDX_MMIO_TEST_ADDR, 4, TDG_VP_VMCALL_VE_REQUEST_MMIO_READ); + *(uint32_t *)vcpu->run->mmio.data = 0x12345678; + + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + TDX_TEST_ASSERT_MMIO(vcpu, TDX_MMIO_TEST_ADDR, 8, TDG_VP_VMCALL_VE_REQUEST_MMIO_READ); + *(uint64_t *)vcpu->run->mmio.data = 0x1234567890ABCDEF; + + td_vcpu_run(vcpu); + TEST_ASSERT_EQ(vcpu->run->exit_reason, KVM_EXIT_SYSTEM_EVENT); + TEST_ASSERT_EQ(vcpu->run->system_event.data[1], TDG_VP_VMCALL_INVALID_OPERAND); + + td_vcpu_run(vcpu); + TDX_TEST_ASSERT_SUCCESS(vcpu); + + kvm_vm_free(vm); + printf("\t ... PASSED\n"); +} + int main(int argc, char **argv) { setbuf(stdout, NULL); @@ -818,6 +904,7 @@ int main(int argc, char **argv) run_in_new_process(&verify_guest_msr_writes); run_in_new_process(&verify_guest_msr_reads); run_in_new_process(&verify_guest_hlt); + run_in_new_process(&verify_mmio_reads); return 0; } -- 2.43.0.472.g3155946c3a-goog