From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9811C4332F for ; Tue, 12 Dec 2023 20:47:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 799C16B037A; Tue, 12 Dec 2023 15:47:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F38C6B037C; Tue, 12 Dec 2023 15:47:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 545E86B037D; Tue, 12 Dec 2023 15:47:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 445E26B037A for ; Tue, 12 Dec 2023 15:47:24 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0FEAC12030E for ; Tue, 12 Dec 2023 20:47:24 +0000 (UTC) X-FDA: 81559351608.08.B4C20FE Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) by imf30.hostedemail.com (Postfix) with ESMTP id 277FF8001A for ; Tue, 12 Dec 2023 20:47:21 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Mel+0xis; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 32MZ4ZQUKCHsrZfhrfnnfkd.bnlkhmtw-lljuZbj.nqf@flex--sagis.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=32MZ4ZQUKCHsrZfhrfnnfkd.bnlkhmtw-lljuZbj.nqf@flex--sagis.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702414042; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QmMEuN8SsdugGRuBIQYyKlPPcc9Vaoj0O+wuwT+Ut3w=; b=4RZxqr9xrhdNdN1POiITYiJsMv8F0miHDF77QMEwRiOQEGQPkQYWy9pOfViuyXNfnD9S7d iqzz4WkpotX8UMZ9y0iWOniv/2898f0WUQrJu+PDht+wjxAMafWHWauUtPKXysVUumWH2d bjJZnnRECDlcrdtet2kZAjuPNgrhQqE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Mel+0xis; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 32MZ4ZQUKCHsrZfhrfnnfkd.bnlkhmtw-lljuZbj.nqf@flex--sagis.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=32MZ4ZQUKCHsrZfhrfnnfkd.bnlkhmtw-lljuZbj.nqf@flex--sagis.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702414042; a=rsa-sha256; cv=none; b=aKwFILNyFwD8dbpRv47UMLOD5MRNL5sxFcd7lYYsq+uHJaEqDiESgbrUSX1aUZDQ7JBCNb Ppc+nXIE5LjXVeSKcPmbLGM4ua8sPNkEDlLeaNW29VOCncGDWTi6FDk0R5JNzu5Gd1rpe9 9cfFmuU4RXv/MhZZIESNQBTlC8GS0fM= Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-1d339f898a0so4511375ad.3 for ; Tue, 12 Dec 2023 12:47:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702414041; x=1703018841; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QmMEuN8SsdugGRuBIQYyKlPPcc9Vaoj0O+wuwT+Ut3w=; b=Mel+0xisVNDza2x4AQ3nhk/Bq/KYeOTwfRZ775/HAYJtbs0lojfbzzsCG6goBbZFJG 9SU/9wZfyFtfP50++YE1Riys2t2hZXs2IIixUQ/Ec0r1iA4zY/sJBMGc2zub6mOOVVqg H1XjDwbE6HcgCnR+HcaHhfs+5hqfnckSd/2jguubv7QBMEq98Hwbw/79KgRV8PqKWV6d 1bC3Mh7LgGKUcaZSwuCmY1zg1Atop4FfkcOOUErDDSk2kL/+ZavXAKQ8low3SbZ4oNnz DIX6ugavKjfWDq1WrHWUsulQzKXYrUA/daohOzs1MA/Etv6l5b+44SDDesxOy3PutBQc aGDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702414041; x=1703018841; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QmMEuN8SsdugGRuBIQYyKlPPcc9Vaoj0O+wuwT+Ut3w=; b=ZAZdpGcTacykzcJNCmnAAV582GvjvWzKPWa2B9/kU4zdc1HJ/ukcBGViKmNYXwLBKi B9z5BHvLluAHxQJsfaSmaHCW8AX10jD/CSTbeeHp26lKpXBByMPowj+ghcza17vjvJQV O0oGkJY7opaQlYRwPWGYeQaI0foiRr6q0HrQuYu4QG/nkJQZ5ezsqMbC6id4831c27hq iNEmum8J4gTRT0smd00Q/V6Fv201p0qRNQYDS0Ls+Ngd6Q1ssX8EYbcReu1FaNnw/OZ3 9Ogwx+iV1ZKfaPb3CMnqVwfteFIQ9k4snHP7y8lbvTQLXz4yUFVymM/tHpsz0FtgQDzt BxiQ== X-Gm-Message-State: AOJu0YwwIuDNkE6lb8Q3hAA5FQ0Fur9yAJQXj8EIK2vA5+o4cadMuLAd ctKqCuUAVC64MAmkvwgCow5cNh5qgQ== X-Google-Smtp-Source: AGHT+IFy2C6taXUGKUls3Pr3kqLUzkOO+fURcZtqBDqd2uoLbbxMihbyeQkPdCeSO4KqCcZOJ/XoDMTusQ== X-Received: from sagi.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:241b]) (user=sagis job=sendgmr) by 2002:a17:903:41cd:b0:1d2:ebcd:2341 with SMTP id u13-20020a17090341cd00b001d2ebcd2341mr54766ple.9.1702414040823; Tue, 12 Dec 2023 12:47:20 -0800 (PST) Date: Tue, 12 Dec 2023 12:46:27 -0800 In-Reply-To: <20231212204647.2170650-1-sagis@google.com> Mime-Version: 1.0 References: <20231212204647.2170650-1-sagis@google.com> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog Message-ID: <20231212204647.2170650-13-sagis@google.com> Subject: [RFC PATCH v5 12/29] KVM: selftests: TDX: Add basic get_td_vmcall_info test From: Sagi Shahar To: linux-kselftest@vger.kernel.org, Ackerley Tng , Ryan Afranji , Erdem Aktas , Sagi Shahar , Isaku Yamahata Cc: Sean Christopherson , Paolo Bonzini , Shuah Khan , Peter Gonda , Haibo Xu , Chao Peng , Vishal Annapurve , Roger Wang , Vipin Sharma , jmattson@google.com, dmatlack@google.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 277FF8001A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: gs1yb7goihrf7nhjpkgg41jmmggm3wac X-HE-Tag: 1702414041-945103 X-HE-Meta: U2FsdGVkX1/QYf+pAJ07CxOtOnGu2AUZB0k9sghNxBpScCKFRH7GfhzGiRz0rYis3Mg1db920C9BJT/5F5yzahVG87gHaONJHGmGIlUiq0OtHk49ZQSfCSyqHqCOzRaAzEk1GGZTyOJKv449Q740+O4dNP7chWoA5W393uh+3MB80a4juKkqFkKB1boWpg8V90BD4lRL6kcTy1nXTtSMTUryJEv2e0NTX4ol7lAogP6Ko/bj54KtoVmSyJZJ2LMEM1qKyuuyNdE26EkegVDNSlE1KcbJt5oWoZH6nVpZJCIzxdz85nwlzzduBZte96NpuLPMKoF6rql+QUxMb1aXYx2SD1wVDe956uFc19naJkWbhin4+sfJPmj3CbMCLAUpfzXMppB0DJL8r/r6OKeYoa+4mgHUdqYLAj6JfD2ZQgan8RHmOyYX/uW+aorTB0Vztg5tvfe3mwFjZSpCQbDc5801Wq5nEa7aHnTYGcDaJ+45R8lgcYwb3p5GqWVKoyqRCQXbnmfOkLLsXzfsWOG9JjTQ/cTzlxsBtBiD7oOfMgsoZ8tZIEf/0+4/bUeMNudOAoUwza6Lqgl7fM6YJrcU80zmycO5EVKHnyVN9XSAy5FYDRV72rLnFZG3/XACZaM67nZvlPXWe6NtSQkd0pXNhNx/bxnEpa41LBi/pberDDIYanDUwywq9kNRu6ZZ7bDXHD5vif5M2k6Nz5+TGnpHNBq1I1NNOd2MuVS1IeJBr5u8TGyWRkCH2qO7dUI/1z0CtOHnkUaFCNookgpiFp7PQvEOywMtJZ/mmHntRZkVJvKVyIzLSlYkfyP4jnfhv/BeQAURFeIpfqS9Duq4qQlX1m5z7W8l/rNZWt3ubEC9blUFCvEYb1LuGzHOQuxfNPx+NGkvQ0A60nMyLm6GXI91efk7YQ/FcW5+8yRxeyi+KDXsJSTcKkz3SFq0QwXNzzbSJHAeu2SlMufdwFHFNJo ScckuCdd aWLHDVapQ92WEKm+aQwBtolSUDGPuQoVcEd0+tj25sZ2IXI2w7HSaHEOHs6PsZVtJPH702GoAJrfpOppSukWWhwlFdQqoQ5HtDo8PqFmPo48KRpCjHJJilJx4K5u2dhfUiNaTt/f0lNr55bMqay3tg21C4HFAUGBOW3m/PlX8+++Z3EGCzpIVwmYkVNtEHRgKG6G1dD1QQiuf3/6BgMqTUqrowqvE4GH3vF3MJbcjPOhUneC78j2flC6+IWRb/0wJ+gRxW6PlO3h5cbKwCCR71NzXSCDwEKNaLXVN/9FZpSDY3zmSCKhvy5+JAW3K/78wRWFPvFALTZECt/n5ALe9Ek3UVIoeFvRk5WMPeUYyqcXg9xCQuEmFHxdWmQFGHVkNdBKTSJNXEO/Z0p88tTmHFl3NlEQu6kdXG4XXvx1FDp3E6WKcBYJsbOPsv5BUZ1rp05yHsaIEbvA2TavdUbhxlSbWyGte7+96votZU/Rs1/sXGa+Gctsg3z/qKDq8EKr1tqiWxnH7AtsJO+k/Ea+YhpGQU/AOvM6gRzydpq+eDQ8g7bFqxhmmM2hhKrdR3bTHvuSCJIcmTqM0Rw2CqzlgUfjmhTPZGXFf/INwOC3Newis4kK9WRZAr2fqzdmZ5AWAQFLmnW/031vwsRb2Jl5vm1Qm8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The test calls get_td_vmcall_info from the guest and verifies the expected returned values. Signed-off-by: Sagi Shahar Signed-off-by: Ackerley Tng Signed-off-by: Ryan Afranji --- .../selftests/kvm/include/x86_64/tdx/tdx.h | 3 + .../kvm/include/x86_64/tdx/test_util.h | 27 +++++++ .../selftests/kvm/lib/x86_64/tdx/tdx.c | 23 ++++++ .../selftests/kvm/lib/x86_64/tdx/test_util.c | 46 +++++++++++ .../selftests/kvm/x86_64/tdx_vm_tests.c | 80 +++++++++++++++++++ 5 files changed, 179 insertions(+) diff --git a/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h b/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h index 1340c1070002..63788012bf94 100644 --- a/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h +++ b/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h @@ -5,6 +5,7 @@ #include #include "kvm_util_base.h" +#define TDG_VP_VMCALL_GET_TD_VM_CALL_INFO 0x10000 #define TDG_VP_VMCALL_REPORT_FATAL_ERROR 0x10003 #define TDG_VP_VMCALL_INSTRUCTION_IO 30 @@ -12,5 +13,7 @@ void handle_userspace_tdg_vp_vmcall_exit(struct kvm_vcpu *vcpu); uint64_t tdg_vp_vmcall_instruction_io(uint64_t port, uint64_t size, uint64_t write, uint64_t *data); void tdg_vp_vmcall_report_fatal_error(uint64_t error_code, uint64_t data_gpa); +uint64_t tdg_vp_vmcall_get_td_vmcall_info(uint64_t *r11, uint64_t *r12, + uint64_t *r13, uint64_t *r14); #endif // SELFTEST_TDX_TDX_H diff --git a/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h b/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h index af0ddbfe8d71..8a9b6a1bec3e 100644 --- a/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h +++ b/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h @@ -4,6 +4,7 @@ #include +#include "kvm_util_base.h" #include "tdcall.h" #define TDX_TEST_SUCCESS_PORT 0x30 @@ -111,4 +112,30 @@ void tdx_test_fatal_with_data(uint64_t error_code, uint64_t data_gpa); */ uint64_t tdx_test_report_to_user_space(uint32_t data); +/** + * Report a 64 bit value from the guest to user space using TDG.VP.VMCALL + * call. + * + * Data is sent to host in 2 calls. LSB is sent (and needs to be read) first. + */ +uint64_t tdx_test_send_64bit(uint64_t port, uint64_t data); + +/** + * Report a 64 bit value from the guest to user space using TDG.VP.VMCALL + * call. Data is reported on port TDX_TEST_REPORT_PORT. + */ +uint64_t tdx_test_report_64bit_to_user_space(uint64_t data); + +/** + * Read a 64 bit value from the guest in user space, sent using + * tdx_test_send_64bit(). + */ +uint64_t tdx_test_read_64bit(struct kvm_vcpu *vcpu, uint64_t port); + +/** + * Read a 64 bit value from the guest in user space, sent using + * tdx_test_report_64bit_to_user_space. + */ +uint64_t tdx_test_read_64bit_report_from_guest(struct kvm_vcpu *vcpu); + #endif // SELFTEST_TDX_TEST_UTIL_H diff --git a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c index b854c3aa34ff..e5a9e13c62e2 100644 --- a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c +++ b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c @@ -64,3 +64,26 @@ void tdg_vp_vmcall_report_fatal_error(uint64_t error_code, uint64_t data_gpa) __tdx_hypercall(&args, 0); } + +uint64_t tdg_vp_vmcall_get_td_vmcall_info(uint64_t *r11, uint64_t *r12, + uint64_t *r13, uint64_t *r14) +{ + uint64_t ret; + struct tdx_hypercall_args args = { + .r11 = TDG_VP_VMCALL_GET_TD_VM_CALL_INFO, + .r12 = 0, + }; + + ret = __tdx_hypercall(&args, TDX_HCALL_HAS_OUTPUT); + + if (r11) + *r11 = args.r11; + if (r12) + *r12 = args.r12; + if (r13) + *r13 = args.r13; + if (r14) + *r14 = args.r14; + + return ret; +} diff --git a/tools/testing/selftests/kvm/lib/x86_64/tdx/test_util.c b/tools/testing/selftests/kvm/lib/x86_64/tdx/test_util.c index 55c5a1e634df..3ae651cd5fac 100644 --- a/tools/testing/selftests/kvm/lib/x86_64/tdx/test_util.c +++ b/tools/testing/selftests/kvm/lib/x86_64/tdx/test_util.c @@ -7,6 +7,7 @@ #include #include "kvm_util_base.h" +#include "tdx/tdcall.h" #include "tdx/tdx.h" #include "tdx/test_util.h" @@ -53,3 +54,48 @@ uint64_t tdx_test_report_to_user_space(uint32_t data) TDG_VP_VMCALL_INSTRUCTION_IO_WRITE, &data_64); } + +uint64_t tdx_test_send_64bit(uint64_t port, uint64_t data) +{ + uint64_t err; + uint64_t data_lo = data & 0xFFFFFFFF; + uint64_t data_hi = (data >> 32) & 0xFFFFFFFF; + + err = tdg_vp_vmcall_instruction_io(port, 4, + TDG_VP_VMCALL_INSTRUCTION_IO_WRITE, + &data_lo); + if (err) + return err; + + return tdg_vp_vmcall_instruction_io(port, 4, + TDG_VP_VMCALL_INSTRUCTION_IO_WRITE, + &data_hi); +} + +uint64_t tdx_test_report_64bit_to_user_space(uint64_t data) +{ + return tdx_test_send_64bit(TDX_TEST_REPORT_PORT, data); +} + +uint64_t tdx_test_read_64bit(struct kvm_vcpu *vcpu, uint64_t port) +{ + uint32_t lo, hi; + uint64_t res; + + TDX_TEST_ASSERT_IO(vcpu, port, 4, TDG_VP_VMCALL_INSTRUCTION_IO_WRITE); + lo = *(uint32_t *)((void *)vcpu->run + vcpu->run->io.data_offset); + + vcpu_run(vcpu); + + TDX_TEST_ASSERT_IO(vcpu, port, 4, TDG_VP_VMCALL_INSTRUCTION_IO_WRITE); + hi = *(uint32_t *)((void *)vcpu->run + vcpu->run->io.data_offset); + + res = hi; + res = (res << 32) | lo; + return res; +} + +uint64_t tdx_test_read_64bit_report_from_guest(struct kvm_vcpu *vcpu) +{ + return tdx_test_read_64bit(vcpu, TDX_TEST_REPORT_PORT); +} diff --git a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c index 1b30e6f5a569..569c8fb0a59f 100644 --- a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c +++ b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c @@ -260,6 +260,85 @@ void verify_td_cpuid(void) printf("\t ... PASSED\n"); } +/* + * Verifies get_td_vmcall_info functionality. + */ +void guest_code_get_td_vmcall_info(void) +{ + uint64_t err; + uint64_t r11, r12, r13, r14; + + err = tdg_vp_vmcall_get_td_vmcall_info(&r11, &r12, &r13, &r14); + if (err) + tdx_test_fatal(err); + + err = tdx_test_report_64bit_to_user_space(r11); + if (err) + tdx_test_fatal(err); + + err = tdx_test_report_64bit_to_user_space(r12); + if (err) + tdx_test_fatal(err); + + err = tdx_test_report_64bit_to_user_space(r13); + if (err) + tdx_test_fatal(err); + + err = tdx_test_report_64bit_to_user_space(r14); + if (err) + tdx_test_fatal(err); + + tdx_test_success(); +} + +void verify_get_td_vmcall_info(void) +{ + struct kvm_vm *vm; + struct kvm_vcpu *vcpu; + + uint64_t r11, r12, r13, r14; + + vm = td_create(); + td_initialize(vm, VM_MEM_SRC_ANONYMOUS, 0); + vcpu = td_vcpu_add(vm, 0, guest_code_get_td_vmcall_info); + td_finalize(vm); + + printf("Verifying TD get vmcall info:\n"); + + /* Wait for guest to report r11 value */ + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + r11 = tdx_test_read_64bit_report_from_guest(vcpu); + + /* Wait for guest to report r12 value */ + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + r12 = tdx_test_read_64bit_report_from_guest(vcpu); + + /* Wait for guest to report r13 value */ + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + r13 = tdx_test_read_64bit_report_from_guest(vcpu); + + /* Wait for guest to report r14 value */ + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + r14 = tdx_test_read_64bit_report_from_guest(vcpu); + + TEST_ASSERT_EQ(r11, 0); + TEST_ASSERT_EQ(r12, 0); + TEST_ASSERT_EQ(r13, 0); + TEST_ASSERT_EQ(r14, 0); + + /* Wait for guest to complete execution */ + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + TDX_TEST_ASSERT_SUCCESS(vcpu); + + kvm_vm_free(vm); + printf("\t ... PASSED\n"); +} + int main(int argc, char **argv) { setbuf(stdout, NULL); @@ -273,6 +352,7 @@ int main(int argc, char **argv) run_in_new_process(&verify_report_fatal_error); run_in_new_process(&verify_td_ioexit); run_in_new_process(&verify_td_cpuid); + run_in_new_process(&verify_get_td_vmcall_info); return 0; } -- 2.43.0.472.g3155946c3a-goog