From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48DE1C4332F for ; Tue, 12 Dec 2023 20:47:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A53866B0376; Tue, 12 Dec 2023 15:47:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B2486B0378; Tue, 12 Dec 2023 15:47:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76A3F6B0379; Tue, 12 Dec 2023 15:47:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5FF6A6B0376 for ; Tue, 12 Dec 2023 15:47:18 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3AE9A1C13F8 for ; Tue, 12 Dec 2023 20:47:18 +0000 (UTC) X-FDA: 81559351356.09.E8934A4 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) by imf30.hostedemail.com (Postfix) with ESMTP id 6D68F80008 for ; Tue, 12 Dec 2023 20:47:16 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=K2ZCtPcc; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 308Z4ZQUKCHYmUacmaiiafY.Wigfchor-ggepUWe.ila@flex--sagis.bounces.google.com designates 209.85.215.201 as permitted sender) smtp.mailfrom=308Z4ZQUKCHYmUacmaiiafY.Wigfchor-ggepUWe.ila@flex--sagis.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702414036; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XMXRsZ7PnaagoSZjHTHBbcv9aekrkY1R/86PgELFK84=; b=UAIOKs2YMcpIDJADifjKUPu7nJP+Ate9NlRY5KQ2Fx6S87iXxE2i02Ivgq3Df6DFurUNEv 9Wp8HPn6jIumV9RtoT67bYDMBd3735L+qkcYFPaakGYkx00G7GJOMXwG7XQopqYd3EcmA2 7GVvWY1UMpd7pNk/dCRwEhG+5Wh2w0E= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=K2ZCtPcc; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 308Z4ZQUKCHYmUacmaiiafY.Wigfchor-ggepUWe.ila@flex--sagis.bounces.google.com designates 209.85.215.201 as permitted sender) smtp.mailfrom=308Z4ZQUKCHYmUacmaiiafY.Wigfchor-ggepUWe.ila@flex--sagis.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702414036; a=rsa-sha256; cv=none; b=U08pjVDQ1yzbSS1MsF+xBorXyvVemwAUXhNXveA0Ai8Qdj+XhdR7/9zoX48q5ijHzv7l4L HBOQZuWb7675S8mu3ITWqavNr76in/fgSfrO7A5TJ+WxkarvLxjOntF5A4HvefWrf0LnOZ nQsGHDamev16QZLCqtawfzM/Spx4fFU= Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-5c68fc4928fso2272649a12.2 for ; Tue, 12 Dec 2023 12:47:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702414035; x=1703018835; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=XMXRsZ7PnaagoSZjHTHBbcv9aekrkY1R/86PgELFK84=; b=K2ZCtPccawQNO/0HNXkBNZCopb8le9HzmfJNuzzaejdOYQxVdaB4diGPf5slMOC2Yq 8LQNut8DSnrPmWQsH4B7aeOA6dm66s43A2xxHXVvvKC9io9yiQwS7kRCGuPMGi6+Qvy+ 0Nhj0qW4ku5PAfhnMYdX1rdOmDSQ61GrHYJf3QHnJ6FsjiZwc4sPimZCTCAg+jNC7NQN 5fjz9eoaanLsNHZymX/iZ+ZHnHx/rUmo0PHbwWceyPJ0nxj+8B3MbxKpTKy2DHabDtv2 2yg9aTr+Fkd5mM6JE27bv3jnGa1y0e5zQ8lu2bHEWqMTov8lGPiXsrLpBJGGeaZiW+Dm 1ZyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702414035; x=1703018835; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XMXRsZ7PnaagoSZjHTHBbcv9aekrkY1R/86PgELFK84=; b=lg8GpNyxadHzRV3kqkmUqDRamJ6JA0SgiAHMWBCuk77koBnz+I6ZqoQVQfWpgxVfXt 4i8EyMwpoCE+OJ6HgR7/aBRONkVuESsaSV0E+oAniOj5zfC3OMxxq+NZKKzRxIscDrm0 kH6L/C4nmHgVM/RSS+9AF1dZKqn/2smWn1xxr0LpejbfntTSGKsl11Hm2RM7lr4ppbwq DhuapXNMhiQv8Qo48MBE6vdfJ6d3wo6gFPM0gO44ID3Fk+3p8frU1xP5VFp5FW9A9Bc5 gV8vCdC7cS/WVgmZY/TsaNpxMR7XKnIJswYGOulFJvnDyb7CyD0OS4xhcV7zjbIjHf7T w9Ug== X-Gm-Message-State: AOJu0YwoXSlvuMWCgkiCSrg4qtF0zDFpLkOQDfXolvlINP/syArYWgs3 Q6dPqE0BhKsJz97exRnW4FB+TpmIBg== X-Google-Smtp-Source: AGHT+IHRkwh7i3P/QAayIGr2a6aSSDzf6EOuyWh3BnBScYojp+3pztVUIS4d/fPqpVG0Y7OF2YfMIgAv0Q== X-Received: from sagi.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:241b]) (user=sagis job=sendgmr) by 2002:a17:902:b712:b0:1d3:46f4:7f1e with SMTP id d18-20020a170902b71200b001d346f47f1emr4985pls.1.1702414035248; Tue, 12 Dec 2023 12:47:15 -0800 (PST) Date: Tue, 12 Dec 2023 12:46:25 -0800 In-Reply-To: <20231212204647.2170650-1-sagis@google.com> Mime-Version: 1.0 References: <20231212204647.2170650-1-sagis@google.com> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog Message-ID: <20231212204647.2170650-11-sagis@google.com> Subject: [RFC PATCH v5 10/29] KVM: selftests: TDX: Adding test case for TDX port IO From: Sagi Shahar To: linux-kselftest@vger.kernel.org, Ackerley Tng , Ryan Afranji , Erdem Aktas , Sagi Shahar , Isaku Yamahata Cc: Sean Christopherson , Paolo Bonzini , Shuah Khan , Peter Gonda , Haibo Xu , Chao Peng , Vishal Annapurve , Roger Wang , Vipin Sharma , jmattson@google.com, dmatlack@google.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6D68F80008 X-Stat-Signature: tf7phcgp84je4qm8px4jifan93ksg7a1 X-HE-Tag: 1702414036-138878 X-HE-Meta: U2FsdGVkX19LI0OcEuFWirJGr1p5mAsfx5uPkHgM0KBwMgq+O6wIegcTOGV5UlFfUDKMSqJ7q0wpj9kxbhexDeBjIKZKs1u6g3Om8znJnN1Bj9P1Rg62Uj4r/i4M2S3zx7GAl652gHFJnzRBL7+3+LZ9haZsnzHTxdtAMFB1RmRSYg9txk2JdWEkWjq0O3RIbT7D52Illz3vmPNtQ5X+qnZ+Swt3FxTeqqswZiwIfyxY148Q/UygQ3A++0F7Y1PhbbvmqxNi1Yb2XytfS/XPh5ebhvShedHAnTn6HEi375sGq9a14IKcXsycbm0DGJwRsVcmFwjWat8YOfTVy/9XcrGFNwKuyXQ35fh9Q3V9Zqn4gOMOrt4w5mdyuKEl6JgfD1aRRk8xc3QoORAdqYraN33bbhtXUsGWs1E1lVEZho/joA3GocgPvZfLekodPCtkdoPDvWZD0HuawsEHMvz76cnGElhSqSONAWHaouSi6o9dOctVQYxr8HFOCd/jqrkqHf0kqTSgtcxHmUHMgGF3lpadZwlrhgQjs1rZUQ6sMYl444a3K6mMGj/KO6XhHlFQZxDzGYa0xfiUVbsEGrpmx1g2msERFFXCUXR0k3XDKqdZgo/j3vAA5j7RImZ3qRWbTpmpiS89xZdHeN8rGRGA7zL30EyPEAAf//5FSf4jgZ7NPcltTrIHgLcuDIQNA5FK0OqMULUvTAMyoMLzQUHxYGl746GYSDHkKj76nDKROzWkagyp8zVgcokJblz7aBEQaaw11tXOx6Wo5xVMo3EeKsh3wHeBGVsBIU5WPwWI6gN1tyLS8C0X856mTOWF1+Z1IlloL03ar5qPYRo5PtrgvWYq3Ge2sifJHT2hhWD2veCAhBG86z8qEVxSr/AQam5rwm+gKBy4zymbG6gM0G4A/o9t8pn3yFZSfnBjkbL0Ms4s8WmXKeoGARBce7BhCidj4iDAlOjMjXgVOgIlPEJ MG1Shpxf icRoTLqLYZ/kmqPmxnv91r8Azitv7hPUtwpdZyjBoWcvcjbuxjAYALP4ODuuWS31wSWH5cXaRZZ7uuX4rBW4aB0s29K86MXzzLL4aWwG8LWIqVhY7KwGfuHQxBbM4+UJhK8ozCGU6XeTgAJOp5Olg1BQe6h3tL3U73eGudkDd5H65ss+Wdj6Pya8PO1VfXxUuYaNy3sFQ3hRmSlm7v7WL/oyYilcZNHVY7v5TglBiGeOn2u4kzSReJrrNXb4EOPmmu/2suAKlqAoMsWkY2wULFO4Jdl5esSvsjF+fzErazLyzy9DTXJ2DPoLF84Zl30WoZ3BOPvCT1qyBphB7/swUAkspBWfBghZr4Ken0FNGeUh22NbqQhsSPhq1k0xdciaJJCdMm72wEKZnFes/9vRiNy2x1JLsvbAhE0Mc5KOwVjxHZvYq12bxE+ylIvd91HSz6VUMWaXEwT+1qkVvIsqhMUGiu89n0z+gAyooYbDJxlajpiF9k1EId7TEdHnq+CNuM+T6aeL0v3cbSkd4426oYUAhTUBWavobYYw3wBoTKnfEydCgtUaBA5Dhv0oxHDYivt08biF96XbmXJM3DdZO5jNtmFU9c6AVH3eCF8WXr2xpVeUxUH1/7znyve+YLheko8Tm2wpL+xFEtRpiK7YGvPlu80X9MoSrakm6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000065, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Erdem Aktas Verifies TDVMCALL READ and WRITE operations. Signed-off-by: Erdem Aktas Signed-off-by: Sagi Shahar Signed-off-by: Ackerley Tng Signed-off-by: Ryan Afranji --- .../kvm/include/x86_64/tdx/test_util.h | 34 ++++++++ .../selftests/kvm/x86_64/tdx_vm_tests.c | 82 +++++++++++++++++++ 2 files changed, 116 insertions(+) diff --git a/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h b/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h index 6d69921136bd..95a5d5be7f0b 100644 --- a/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h +++ b/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h @@ -9,6 +9,40 @@ #define TDX_TEST_SUCCESS_PORT 0x30 #define TDX_TEST_SUCCESS_SIZE 4 +/** + * Assert that some IO operation involving tdg_vp_vmcall_instruction_io() was + * called in the guest. + */ +#define TDX_TEST_ASSERT_IO(VCPU, PORT, SIZE, DIR) \ + do { \ + TEST_ASSERT((VCPU)->run->exit_reason == KVM_EXIT_IO, \ + "Got exit_reason other than KVM_EXIT_IO: %u (%s)\n", \ + (VCPU)->run->exit_reason, \ + exit_reason_str((VCPU)->run->exit_reason)); \ + \ + TEST_ASSERT(((VCPU)->run->exit_reason == KVM_EXIT_IO) && \ + ((VCPU)->run->io.port == (PORT)) && \ + ((VCPU)->run->io.size == (SIZE)) && \ + ((VCPU)->run->io.direction == (DIR)), \ + "Got unexpected IO exit values: %u (%s) %d %d %d\n", \ + (VCPU)->run->exit_reason, \ + exit_reason_str((VCPU)->run->exit_reason), \ + (VCPU)->run->io.port, (VCPU)->run->io.size, \ + (VCPU)->run->io.direction); \ + } while (0) + +/** + * Check and report if there was some failure in the guest, either an exception + * like a triple fault, or if a tdx_test_fatal() was hit. + */ +#define TDX_TEST_CHECK_GUEST_FAILURE(VCPU) \ + do { \ + if ((VCPU)->run->exit_reason == KVM_EXIT_SYSTEM_EVENT) \ + TEST_FAIL("Guest reported error. error code: %lld (0x%llx)\n", \ + (VCPU)->run->system_event.data[1], \ + (VCPU)->run->system_event.data[1]); \ + } while (0) + /** * Assert that tdx_test_success() was called in the guest. */ diff --git a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c index 8638c7bbedaa..75467c407ca7 100644 --- a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c +++ b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c @@ -2,6 +2,7 @@ #include #include "kvm_util_base.h" +#include "tdx/tdcall.h" #include "tdx/tdx.h" #include "tdx/tdx_util.h" #include "tdx/test_util.h" @@ -74,6 +75,86 @@ void verify_report_fatal_error(void) printf("\t ... PASSED\n"); } +#define TDX_IOEXIT_TEST_PORT 0x50 + +/* + * Verifies IO functionality by writing a |value| to a predefined port. + * Verifies that the read value is |value| + 1 from the same port. + * If all the tests are passed then write a value to port TDX_TEST_PORT + */ +void guest_ioexit(void) +{ + uint64_t data_out, data_in, delta; + uint64_t ret; + + data_out = 0xAB; + ret = tdg_vp_vmcall_instruction_io(TDX_IOEXIT_TEST_PORT, 1, + TDG_VP_VMCALL_INSTRUCTION_IO_WRITE, + &data_out); + if (ret) + tdx_test_fatal(ret); + + ret = tdg_vp_vmcall_instruction_io(TDX_IOEXIT_TEST_PORT, 1, + TDG_VP_VMCALL_INSTRUCTION_IO_READ, + &data_in); + if (ret) + tdx_test_fatal(ret); + + delta = data_in - data_out; + if (delta != 1) + tdx_test_fatal(ret); + + tdx_test_success(); +} + +void verify_td_ioexit(void) +{ + struct kvm_vm *vm; + struct kvm_vcpu *vcpu; + + uint32_t port_data; + + vm = td_create(); + td_initialize(vm, VM_MEM_SRC_ANONYMOUS, 0); + vcpu = td_vcpu_add(vm, 0, guest_ioexit); + td_finalize(vm); + + printf("Verifying TD IO Exit:\n"); + + /* Wait for guest to do a IO write */ + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + TDX_TEST_ASSERT_IO(vcpu, TDX_IOEXIT_TEST_PORT, 1, + TDG_VP_VMCALL_INSTRUCTION_IO_WRITE); + port_data = *(uint8_t *)((void *)vcpu->run + vcpu->run->io.data_offset); + + printf("\t ... IO WRITE: OK\n"); + + /* + * Wait for the guest to do a IO read. Provide the previous written data + * + 1 back to the guest + */ + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + TDX_TEST_ASSERT_IO(vcpu, TDX_IOEXIT_TEST_PORT, 1, + TDG_VP_VMCALL_INSTRUCTION_IO_READ); + *(uint8_t *)((void *)vcpu->run + vcpu->run->io.data_offset) = port_data + 1; + + printf("\t ... IO READ: OK\n"); + + /* + * Wait for the guest to complete execution successfully. The read + * value is checked within the guest. + */ + td_vcpu_run(vcpu); + TDX_TEST_CHECK_GUEST_FAILURE(vcpu); + TDX_TEST_ASSERT_SUCCESS(vcpu); + + printf("\t ... IO verify read/write values: OK\n"); + kvm_vm_free(vm); + printf("\t ... PASSED\n"); +} + int main(int argc, char **argv) { setbuf(stdout, NULL); @@ -85,6 +166,7 @@ int main(int argc, char **argv) run_in_new_process(&verify_td_lifecycle); run_in_new_process(&verify_report_fatal_error); + run_in_new_process(&verify_td_ioexit); return 0; } -- 2.43.0.472.g3155946c3a-goog