From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA298C4332F for ; Tue, 12 Dec 2023 20:57:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63AD36B038B; Tue, 12 Dec 2023 15:57:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E9136B038F; Tue, 12 Dec 2023 15:57:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B1D46B038B; Tue, 12 Dec 2023 15:57:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 31B776B0387 for ; Tue, 12 Dec 2023 15:57:34 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F253EC0AA6 for ; Tue, 12 Dec 2023 20:57:33 +0000 (UTC) X-FDA: 81559377186.12.8911FEE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 38B0940009 for ; Tue, 12 Dec 2023 20:57:30 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=e7knbxJn; dmarc=none; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702414651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dZJyZJLfQ6WgMHyGRVy4d5YLSkHOLPELn3w4IYaCN+Q=; b=rvqmc9gpAMcB6yRQ/GR8giBLXlGi/WpA450SU95y9S+5x6O7Bsff7qQX5shWo53rCx96GN YVEWFnZfw6TabTOhhrSuzIwx1mEXc/6oC534/8nVEaMbQYfMKkDnFjbcOAcnUs56tf7lcP Ttrp3E3pZLklEIfIc5bH3NpyVexZ0AY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=e7knbxJn; dmarc=none; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702414651; a=rsa-sha256; cv=none; b=7aMkY2E9YE1oW9P0TCZ7QJnRlV8ycNGwtLlnJY9amaHq4vx6pudVco0dC0hETiu6EokFHA ZHMaJ6eQB9mq1E5x36wydvN+PndfU69p+RH/PzFDJaeisCw793n6tAeZBBBIppn8jX0aTi CdBUgVDk9YaMdPpXBW3kQYpbZQnZTjk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 33297619BF; Tue, 12 Dec 2023 20:57:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98A61C433D9; Tue, 12 Dec 2023 20:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1702414650; bh=KLAi6edpD/jz7hYCHpCfsvUM9M3DmKv0l7/YKtSRRC8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=e7knbxJnlbITSwa0iGhG6i91+F3Jm8V7PLb0TQb8ioXWTpV/yQ8N1WUZXMKgYjljy 4OhppAYwgmv3NVXgay3I68ggS+37mBJobmt6vwEYHk4L+hghB7SgpxKdl3Gbkr1VAn MKYL8GId9UIgPJH6AhB77js/cfv15K7trRI6WVPU= Date: Tue, 12 Dec 2023 12:57:28 -0800 From: Andrew Morton To: Marco Elver Cc: andrey.konovalov@linux.dev, Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Tetsuo Handa , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH mm 1/4] lib/stackdepot: add printk_deferred_enter/exit guards Message-Id: <20231212125728.1a275e704db4a5f5ca30e15c@linux-foundation.org> In-Reply-To: References: <6c38c31e304a55449f76f60b6f72e35f992cad99.1702339432.git.andreyknvl@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 38B0940009 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: dh75ikjm1tcpb9dk9krhm1bbbfkq4dia X-HE-Tag: 1702414650-2972 X-HE-Meta: U2FsdGVkX1/OzljwCMF4Azn5KtL7vsr4x1zPnIRFrsyQ1Q6IBhgNiKYmp5mLdFqq+Xv2gTWCWxNM2M40xwaCce05OaBrP7O2gAzcql/EdOCeFcpzpdOODrzP+qCdHlGqSqKWohZxaydvY0J0nVe6FrNtlALaNdPi33dp2cviFgQtYhmkZ7vG5Sv574C48wj+i+vmQUVIzmzwcTczR4J8l5uUklhTSo2iGoPkCLgwHyz3HytvyukoAldmWBq+RhCytW4kcsUBjmRzEhojoabRIjrlBUjJFPBm/DGhUYi8s1YroOSGaft2yb+38PqSWuE6kJXNJRUyr+Pvwv9FIQJjZLMBQkx87lxDDNkuZ/txv1+DysoMz0pZVZO0BzpdhhJmMb2g1bq2ztdTbJg5PgBonI3ZmhdRn2GVvQDhPBVTwt4yY1JU9aS7u58/WafLr4Sd8xRuq/8Tse94LumJCSUlj9yklcWOqvpdqhVNAqgqLRR9AmpvsyNXDecI58lS7CGwn+abcg7394Ap6k4IrBoZ1lpCI7rApc1d+K2nkna/Ny/ZnsZDSQdqzXrU3Nae5NErIiORvL2zlbgvY6CJfc6vG6NcRFNzGKZ6q+vRSQGETFOCt0q4oAMzbC0M7RTw+0fqf6sdSo7uvLQ7pDgrA8nGwl39NT3Fs4edrsiBP877E0MFuab95ICQBwYuktuWOqqTsxuGgDKlv/xGCGSgJvPgtXRCyE8C/Q3WHGjnWmWBSktYDQb6oVQUUih6ZQNgUxb4NJ8zQ3cGUAjsAGo1OjWFtyDnVwkfpSHPqkbhq+bjZVVo2/14J/KsZfqsFS5y6DtGg2wAmIy5bF0voNb6ittqs6pM8T0t7Lc+htuzCjmjA4Yfj2EjENxTBgNYizjjNMmOFrYedju9yolXshbJ7FQ9SeHLdKHK35PzyFVpFYkRVDXSA3HUYs7BcO5S/DIaIFI3UmxAnV/tFfE9GhEn15i BP87pnrB Q1jCMdI9RK9alu+/0YKvehNWdW33M4evwBrVjaGE/X9VHrlJ8h2QvD2ur2V8BGfZVm89ltH+X2QVAZWGkQXz9JKCWp/PQ9+dyatN2fxDVeekJn8aO4ClSInomi9ZaFxqXjmQwnda1Si3Y3rb7gGku6o3yuU5Da5nn/apUj5L1tucD0V+hvXGtOpZi8z+JCC0dYz5+rKSWbA4GnHNlWBrkL9xcEBgZxXTXCVXIvr5EwN2KcVe8zoaeuO6p2v8ZeYJ3cPuR5yd1qd3pS9H+WY9TwFr2RnDzxnvCoCHo/kOhqniXfM61NWd2jZQmc79lnDXajcj/BabaEjZoYuinEgtcSc1gPg+AKr960EaU7k4tEoKapz4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 12 Dec 2023 19:59:29 +0100 Marco Elver wrote: > On Tue, 12 Dec 2023 at 01:14, wrote: > > > > From: Andrey Konovalov > > > > Stack depot functions can be called from various contexts that do > > allocations, including with console locks taken. At the same time, stack > > depot functions might print WARNING's or refcount-related failures. > > > > This can cause a deadlock on console locks. > > > > Add printk_deferred_enter/exit guards to stack depot to avoid this. > > > > Reported-by: Tetsuo Handa > > Closes: https://lore.kernel.org/all/000000000000f56750060b9ad216@google.com/ > > Signed-off-by: Andrey Konovalov > > Reviewed-by: Marco Elver > > Doesn't need Fixes, because the series is not yet in mainline, right? I've moved the series "stackdepot: allow evicting stack traces, v4" (please, not "the stack depot eviction series") into mm-nonmm-stable. Which is allegedly non-rebasing. So yes please, provide Fixes: on each patch.