From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BD50C4167D for ; Tue, 12 Dec 2023 16:27:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78E036B0125; Tue, 12 Dec 2023 11:27:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 73DCF6B015D; Tue, 12 Dec 2023 11:27:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62C716B02D5; Tue, 12 Dec 2023 11:27:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 543886B0125 for ; Tue, 12 Dec 2023 11:27:29 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 277B0809E5 for ; Tue, 12 Dec 2023 16:27:29 +0000 (UTC) X-FDA: 81558696618.28.15D8448 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf14.hostedemail.com (Postfix) with ESMTP id 53328100019 for ; Tue, 12 Dec 2023 16:27:26 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=FmrX47b7; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702398446; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5vQVypmTK3SX10qp0Gi50SAmu7tfZcwgkQfn1qWA4g8=; b=07u0iQnWxcCORmL9y4eypHJER27qvj85OzPXce7PDGcnhXsKuuJFjA/WiT0jdlFgH7TTbU EN2e1fS/+NFHhy3IAhc0bCNMETcMXdVY22kaCyPR/Ibc2VJioQfjyyV4eQ9nSdgpvb5Pre LKUd3TRHLfTvAdz/o9q5qcCLlX8H05o= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=FmrX47b7; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702398446; a=rsa-sha256; cv=none; b=75TDOVTzWMnlTtIPWNnFschchs7NUk9zX9Qzwr8ThNOv3sXcRQ2qg+CgZaclAf8CrfnQPv psa/JNbTku1gdXbBpKMavVuJpu7lJcfd5CuqgBHveV523B2LZ1qxNKXZA6hdWKn7/V+eUH mtHswklgFAbSKmA4UTmalk/TLL/7Dy0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 7BB49B81339; Tue, 12 Dec 2023 16:27:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D207C433C7; Tue, 12 Dec 2023 16:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1702398443; bh=t3KKiYi0IdU2y9j91oE71YEklgKddavq7ESsXn9uET4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FmrX47b7FO9QssAD09a7oHhvNJ1/DSXBvjQ4RvCYchuZ6/sTAh9XBDG970mIzERJp TTo902Q+yAcmPS1hPuve25ZZ4rI0Mz6S66LXqWrUYSqaoCxBkx6XcimchzuR06NnkM fS3Q/VztSu9++JBc+V14I/GMbW9RQyg439T3PihA= Date: Tue, 12 Dec 2023 08:27:22 -0800 From: Andrew Morton To: Ryan Roberts Cc: David Hildenbrand , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Alistair Popple , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Barry Song Subject: Re: [PATCH v9 03/10] mm: thp: Introduce multi-size THP sysfs interface Message-Id: <20231212082722.13e857daf589bd49d5e877d9@linux-foundation.org> In-Reply-To: References: <20231207161211.2374093-1-ryan.roberts@arm.com> <20231207161211.2374093-4-ryan.roberts@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 53328100019 X-Stat-Signature: jxk1sgzpuu71s5dqzb7wmms3op5be4ab X-HE-Tag: 1702398446-608515 X-HE-Meta: U2FsdGVkX18J2aYDnEr6XS86qB/mdrzxUmugT7A/ULTZRBOkok/oMGFuBf0nxaf9a0uyVesCdwoXzI3tOv+/Ugh3u7tFSh+5mFLy3u/Z60Pw/XTJRtcmxueuitX5/TJWFP4QY8oiEtsRCdd2N1NyPTBGMgfDXUeGzAVYDb4wkVIysTb0ev9BZjh4nXDGV8fCVlKuc0bzk1X9+i96WjdWE+b767F4cmEbfvHGQuZ7af5khbyS4U4FczWpW7JY5IWB+WUEbVcdK/bJesvRsduiyb2JWqj7bq7in1ERAtHbvHogyjjcQl5zl1HBFYippXjv74HzRKrbvhZl9x1Zd18ckD1iw6keM1zmX5ZueBs3D2Fa1cUSJ4Le8aNABJ77ePaxtTq21pwyg8Z3BviUcF+3UzoNOCs6GUNBCeHtQI4pQe45s7DOhv2WKFdp8k3K0VNOlgitVfPwlcVVF8E1xZwfzrtdf44qzvae4DhQZsLWPUwQMOcBGx+1XECmZDBb6W6gsAULPRPGV3v4teyeyHPkgK3BKXo0741jWkHaFrTedrKCpa54gQs740Gso6Eh05NiV4YwJKsdJqNe0y3U0tSp5ueGrZp6UJbWZr/ekAIdIsjtHojNxJGYISKxIzS5CZ11zmI0rmYFeMmLQLJwCZFVr8QPHHSW0KoZJ26V9+hwyYH3HT9Hv5FMcnu6kVUJ42lAJfi31JgTUYT9g+0RAJ5TAjMEmE5lQsoWMW/qqPdJlK1bZzM6TehVL3eeGmxuVmMrebZPMD3772E6eVCmDFLj24hoHFE6guRlqEh0cHtWOFnWM2DPOxxC8CX1ZMZPROzxs777X+Gognisrd48DOKwy75iNM2DT4Ggvh3IebepLYdqKhcHbE9eXxV911cLv2h+Er/AqZ2drD6QllbVz65UmzICIG66okQmKKbUPZxnNXdZ5Ay9rE8fHrPsDLhVk2RRXwreuORDV8bnvEqEsFa 1XZNAkBq ITu/XAk5kjAacwPYhByC0jzB0D8bzGxeDrjFCI9A7UO/aKuiyr72ADvCOpMdSQHXcaSWrfQGdQmlqdwr+y/wwh2Ax7JYEs4Ca3OrZz4FuvoM8E+NOeCVSnC+jr4QmSwQJ4M4Igtb/v74Oqhix9hwBrFbfqhtgsBu6iKT22gMFob+x0/t/4HCnVtnaP37G//rBR4B+MWMyheH/MREpGM18bQgUNoxwYOYmZu2NvnQWEKMCaBkEPpcjsFsTmrf4FGC53Rh/k8xPHWFrnDY9m5UkjTC7Zd6tlP/upvUaUUwaLE1e8q2zk8DM/2DFsqGk5cIkIx6lBMteEkbmPdf3UqMSvEpPxVbw3vmIrQhaXQN32TrtSNtMQA0y6l/oAv+Il5etjpY+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 12 Dec 2023 15:32:29 +0000 Ryan Roberts wrote: > > Why not perform lock/unlock only once in surrounding code? :) > > I was nervous that sysfs_streq() may be unhappy in atomic context... Unfounded? > Yes, unfounded.