From: Liang Chen <liangchen.linux@gmail.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, hawk@kernel.org, ilias.apalodimas@linaro.org,
linyunsheng@huawei.com
Cc: netdev@vger.kernel.org, linux-mm@kvack.org, jasowang@redhat.com,
almasrymina@google.com, liangchen.linux@gmail.com
Subject: [PATCH net-next v9 2/4] page_pool: halve BIAS_MAX for multiple user references of a fragment
Date: Tue, 12 Dec 2023 12:46:12 +0800 [thread overview]
Message-ID: <20231212044614.42733-3-liangchen.linux@gmail.com> (raw)
In-Reply-To: <20231212044614.42733-1-liangchen.linux@gmail.com>
Referring to patch [1], in order to support multiple users referencing the
same fragment and prevent overflow from pp_ref_count growing, the initial
value of pp_ref_count is halved, leaving room for pp_ref_count to increment
before the page is drained.
[1]
https://lore.kernel.org/all/20211009093724.10539-3-linyunsheng@huawei.com/
Signed-off-by: Liang Chen <liangchen.linux@gmail.com>
Reviewed-by: Yunsheng Lin <linyunsheng@huawei.com>
---
net/core/page_pool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/page_pool.c b/net/core/page_pool.c
index 106220b1f89c..436f7ffea7b4 100644
--- a/net/core/page_pool.c
+++ b/net/core/page_pool.c
@@ -26,7 +26,7 @@
#define DEFER_TIME (msecs_to_jiffies(1000))
#define DEFER_WARN_INTERVAL (60 * HZ)
-#define BIAS_MAX LONG_MAX
+#define BIAS_MAX (LONG_MAX >> 1)
#ifdef CONFIG_PAGE_POOL_STATS
/* alloc_stat_inc is intended to be used in softirq context */
--
2.31.1
next prev parent reply other threads:[~2023-12-12 4:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 4:46 [PATCH net-next v9 0/4] skbuff: Optimize SKB coalescing for page pool Liang Chen
2023-12-12 4:46 ` [PATCH net-next v9 1/4] page_pool: transition to reference count management after page draining Liang Chen
2023-12-13 1:53 ` Mina Almasry
2023-12-12 4:46 ` Liang Chen [this message]
2023-12-13 1:51 ` [PATCH net-next v9 2/4] page_pool: halve BIAS_MAX for multiple user references of a fragment Mina Almasry
2023-12-13 11:38 ` Ilias Apalodimas
2023-12-14 3:42 ` Liang Chen
2023-12-12 4:46 ` [PATCH net-next v9 3/4] skbuff: Add a function to check if a page belongs to page_pool Liang Chen
2023-12-13 1:50 ` Mina Almasry
2023-12-12 4:46 ` [PATCH net-next v9 4/4] skbuff: Optimization of SKB coalescing for page pool Liang Chen
2023-12-13 1:49 ` Mina Almasry
2023-12-13 2:37 ` Liang Chen
2023-12-13 2:49 ` Mina Almasry
2023-12-14 3:00 ` [PATCH net-next v9 0/4] skbuff: Optimize " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212044614.42733-3-liangchen.linux@gmail.com \
--to=liangchen.linux@gmail.com \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-mm@kvack.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox