From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF84CC4167B for ; Tue, 12 Dec 2023 15:21:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7866A6B02FA; Tue, 12 Dec 2023 10:21:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 736716B02FB; Tue, 12 Dec 2023 10:21:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FE466B02FC; Tue, 12 Dec 2023 10:21:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5210F6B02FA for ; Tue, 12 Dec 2023 10:21:15 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 246571C136C for ; Tue, 12 Dec 2023 15:21:15 +0000 (UTC) X-FDA: 81558529710.08.1C0470D Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf26.hostedemail.com (Postfix) with ESMTP id B9437140039 for ; Tue, 12 Dec 2023 15:21:11 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pEfIG+fp; spf=pass (imf26.hostedemail.com: domain of conor@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=conor@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702394471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hHW/iFE0PiLLewwhQTTtdfgyjhDaIiX3hvrM5kDum/A=; b=S7Psl6/Jg85cUlA6M9gsHmW4CjN3jtDRm+Yt9DJk4ONY09yrafyenV/Pe/Ih6x2DGB65Cw aWaDlMjUrsLnR9dQoLkDYoHXMC0MDUHRTQBaouKmCQs4JE5Tj0x/MMUasgYzvgXxo0HOYQ +cS6DXTjYokdNcuiDov3aZ+BVvbh7ik= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pEfIG+fp; spf=pass (imf26.hostedemail.com: domain of conor@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=conor@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702394471; a=rsa-sha256; cv=none; b=o0O0Fp3IVN+wz9/IPY8tkfzkRoRPteEH6LoPxbeeuR8Fk8GIrdn1j//FrUrgSDaDDVk/jv 9rE24+7VAiOL/FxaOPZF6X7iILtGfvzCsYanMkrRj3Pph9RAUD00lR6mWF6sxxisuHKd7O YphfaH4tmd916rDxIdte82qC/EfYvOY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id BC4FFB81736; Tue, 12 Dec 2023 15:21:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 413F7C433CD; Tue, 12 Dec 2023 15:21:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702394469; bh=fPuUDXbvyQcdlGJVGtxadUQq7xMHYvrITxb/nuVFpzc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pEfIG+fp3V3eVe8VWoQtmtv+FXpOuNu3/MG6SEfZZ+KyCRN04C+P7+erYFvaQTgu9 eFPz0FROSykUvwNHpaprw6hk/xBHZSUxxTMeNeeFuGVg9fqOVwA6eRSAzr5D0ez7lS 3LKTuyn3OiGjvvCai7cPIr+AvhERotkqxzy2y8duCmo1F2SyuVevlyU/SdcrJBs+y+ fB1SptobaXSXxZ9of5YqHPKZW5qEA8zl+nnvZ6Yo1pmfdRArJx7NpFLopx40DOXhrf 24VPA4wdHtUwSiwBWsw5lljmlcASYmQSa71ZEL2gZ69mu+LMtwe0MPIT4VTGOETttN ZEnEiZkxpELPA== Date: Tue, 12 Dec 2023 15:21:04 +0000 From: Conor Dooley To: =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= Cc: Alexandre Ghiti , lkp@intel.com, linux-mm@kvack.org, linux@weissschuh.net, llvm@lists.linux.dev, mcgrof@kernel.org, oe-kbuild-all@lists.linux.dev, linux-riscv@lists.infradead.org Subject: Re: [PATCH -next] drivers: perf: Fix build error by adding const to ctl_table argument of handler Message-ID: <20231212-garage-pellet-c6a2bd34854c@spud> References: <202312062242.RFPPozG9-lkp@intel.com> <20231207083512.51792-1-alexghiti@rivosinc.com> <877cljsbes.fsf@all.your.base.are.belong.to.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="u+TMTYDuzJdAB5mY" Content-Disposition: inline In-Reply-To: <877cljsbes.fsf@all.your.base.are.belong.to.us> X-Rspamd-Queue-Id: B9437140039 X-Rspam-User: X-Stat-Signature: 6rkebm3hng6h8qfyakxff48xmnhi54x4 X-Rspamd-Server: rspam01 X-HE-Tag: 1702394471-748877 X-HE-Meta: U2FsdGVkX1+VssvNajydPDktSCfhwpLvG6zPBHyiCa2awWxeobh16dO5OmzhM4hjnJHKDs32fruKr7yPdjOOtZRZNo51q4yBf2lblxGi3YKKKL00AKdcTdzhV4JKPnzVCZkO1JsKNRq1swMStI+b7WtHLupYROvH7PbmpJMW2l7tmW1FwfEF4n+0jM/NZ18tgJ18JBxIjBpCQwozTwixeTOwtiwQ1JR+crxMIBMDCNpc/e8kQM2UsJmS5RfK7BWRZZuTDn6nq+TEkuXOIxqvkvzp/2MUL/BYK8kE+hS+/6BQyq8GMOz2DoQfa9vwOZkrYWMrGV2JGB2+0S92+UfN6wR3EtgC8FpJjyXz/WroFpdwVdFmtNtw+2vbxH5t0ll0/t1Um4NSRNTjpp7DqnPafo09w0O2HpNr1zXkqIgshAs6D4jgHS0HnBPc3meouVwtRo2dk51STE8AYSg8AuCVMs/qDDbU97gc4dQgX5QfcFN+t6mqBOiX65N1gK0sdJvRVz+7xoaB3k5JdEur2Q0cDcoO0FVJAA6SN2jMGOByMjDZnXnb53Sbq6WeMLDqq9go2cIvKZQGSTML2AXHV2ZgZQ0A12Wftel2LRjpxk0L5xTC6l3Uh39G+qClMlaKEtUmCEZlE61dhT+DNvhfXkmmMHEHnB+1muDwd1/wlq8W0g8CQnvwSMR1RZLp6d/irjJP8xeTrSp/zLOsLBuBpxAwCvQ5kZ9NTNO7mBPJVWbdaeFqLwwOTFQpS3X+e01loz9HAe2QOVlhfVpFHgbR2pOtnk9A1EdLYV8i9+gGOaXOhXfA6qObTl9G+P3mf2YT7CHj1fvchX8XjZuue6G/SYYl1L9iMPyk0XV/5QWN8wsJcJpq4JXsXTCTuL9BpfDSkwCpfaaDzsAgdMdXlACIjcKLSKG8c1MHjI4ZI7/qGyPmAv9pOnBHdZfh3QdJIbw4I4aih8fnmEWxRE6HLw1lHOj UFYdQPMH MpqKQEsB/yy3MhO93pp6HACG9WyY+nZHhYMNsSxtBSmKNSAZe1JOb7BE0VorHa+JGbFfpfHTTYQIX4CyUo0d9qZs6j9TslIumyMblavWCPCAFiOLi8ddhT3zdogPxnwlavO9udJQgV2O9dTcr4n+2lgo773w3oD40rpAE34uor/sFZjf2yh6ZyzD7JA9Lcy32j7DR71D3RJh/ugl7Z1iNvyxyz2kk8zSUWlu1NsEsMNHEIVNRtoUNzLnFcIdzElC1OjYabmmZcgOOIR42azPGkHyDX1szxZip9lS6JwW/CyX9A5UPdyjoRtx1NGySCp7Pj15H4jwLkBjRe0DnXXjnxFLZkrvcOA2bpM4mHuxFGhaUkaDA9FpvtBFlTfqHxqY7Iu8pPDMffcphZfdHyHg28AkHI1LGeoSL1aHc3MWYxrLaPVb/UkIT+XTtZkQcgvn+u8ZkEOPyZBMVJ62tt/BiAZempN5Y5msWdJUXGmSI/oNLx1oMgB/Z2sbFig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --u+TMTYDuzJdAB5mY Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 12, 2023 at 04:11:55PM +0100, Bj=F6rn T=F6pel wrote: > Alexandre Ghiti writes: >=20 > > The ctl_table argument of the proc_handler field was constified treewide > > but somehow missed the occurrence in the riscv pmu sbi driver, so add t= he > > const to fix the build error. > > > > Reported-by: kernel test robot > > Closes: https://lore.kernel.org/oe-kbuild-all/202312062242.RFPPozG9-lkp= @intel.com/ > > Fixes: c8be9e66ca1e ("sysctl: treewide: constify the ctl_table argument= of handlers") > > Signed-off-by: Alexandre Ghiti > > --- > > drivers/perf/riscv_pmu_sbi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/perf/riscv_pmu_sbi.c b/drivers/perf/riscv_pmu_sbi.c > > index 16acd4dcdb96..97e345f7d25d 100644 > > --- a/drivers/perf/riscv_pmu_sbi.c > > +++ b/drivers/perf/riscv_pmu_sbi.c > > @@ -986,7 +986,7 @@ static void riscv_pmu_update_counter_access(void *i= nfo) > > csr_write(CSR_SCOUNTEREN, 0x2); > > } > > =20 > > -static int riscv_pmu_proc_user_access_handler(struct ctl_table *table, > > +static int riscv_pmu_proc_user_access_handler(const struct ctl_table *= table, > > int write, void *buffer, > > size_t *lenp, loff_t *ppos) >=20 > Adding linux-riscv. >=20 > Reviewed-by: Bj=F6rn T=F6pel There's already a patch for this: https://lore.kernel.org/linux-riscv/20231206084642.802053-1-m.szyprowski@sa= msung.com/ The maintainer of the tree with the broken patch (Luis) has not deigned to pick it up yet unfortunately. It can't go into Palmer's tree cos it will break the build if applied there. Cheers, Conor. --u+TMTYDuzJdAB5mY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZXh6YAAKCRB4tDGHoIJi 0rA3AP45hqW77ceWdDa3OBX5lwstdHr3WTXrkkHheKfXIwqn3QEAnEtNdsZN1rp1 dMhZ39fGppXobCP3M3OQjxQjrt3cjQs= =f5mp -----END PGP SIGNATURE----- --u+TMTYDuzJdAB5mY--