From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22A25C4167B for ; Fri, 8 Dec 2023 20:31:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA57A6B0085; Fri, 8 Dec 2023 15:31:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A557F6B0087; Fri, 8 Dec 2023 15:31:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91DA26B0088; Fri, 8 Dec 2023 15:31:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7E16F6B0085 for ; Fri, 8 Dec 2023 15:31:33 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3BC4DC0368 for ; Fri, 8 Dec 2023 20:31:33 +0000 (UTC) X-FDA: 81544796466.27.E411C58 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by imf02.hostedemail.com (Postfix) with ESMTP id 68D0E80002 for ; Fri, 8 Dec 2023 20:31:31 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of robherring2@gmail.com designates 209.85.210.47 as permitted sender) smtp.mailfrom=robherring2@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702067491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v/vkRtHrUIhvNc94dHT+mJMxUllgbpAsI47gfQ/WkWg=; b=KC3Eq+PtwsInCQYer5SVIDjSydeLaa3+SfO7JPrk/yhSVp4O/eXzw3qbf7bc6fTk3IAmrz MAZzT5VulaiV6bqzrwwsGLm73MLddVqZ/2CARIeoP3+hlu6g53geiGALklJZiJgLwClDD8 B8g3PBiNuZGlesZFedQ7mumVmx33GKY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702067491; a=rsa-sha256; cv=none; b=aeOpHkvYpEcaa3/WGtAN3hOgCouX7bBP+KYv8h5tubbATyngJe+4EkJNttzH/W+nTKsiE9 SZC72LK38vA4Ks+mpA+1PGCyqTxMcTVxBs3AYom+qk+ulqMRarO91+/qb/pOyBcLaq0c8r 9XQ64RnHYMxlBieSY0/1Ws9B8w5Etc8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of robherring2@gmail.com designates 209.85.210.47 as permitted sender) smtp.mailfrom=robherring2@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-6d9f9fbfd11so131768a34.2 for ; Fri, 08 Dec 2023 12:31:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702067490; x=1702672290; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v/vkRtHrUIhvNc94dHT+mJMxUllgbpAsI47gfQ/WkWg=; b=TAptDCRv3m+Be2iR7Lbz3mlcZzynRTawQALPG8Khl/V8IE9gEq2KtPKlcPJirphm+f rRmo2m6NFNscoTM2mNkjcTkJnX9PzvXhpqQmawzKYHnlQeDefYU4eWmdyojRxr13m66+ q6yx8biffQTTYCMpffpRjvX4909FWJ1sBhx75LG5Z7vOjyc7pgW0ic28sksZMlt0P6G8 d4q2hIETRxh1C6l8Nr0fAQr8qw06PqzBQl54FcrmDbh1elu29naYwK6k15VbmtPGWkPk CJLJyHkCL5eRsJjVOIjcA0SKom+dM81D2IE0FdjGf4LpRMg8KJVmP6oADrkmlbNHvfvH L88g== X-Gm-Message-State: AOJu0YzMzxXRCTKSl71++ahf/8cacsDIEpmgjjagw1Roz5Jo0IY475kC vZwxaPeXOvbSEZuFvO8mdg== X-Google-Smtp-Source: AGHT+IGdbIgqxhhBryWL51enlE+vHu8xlkBOQlHT46ZUQRPrYupw+SdR5iu5LYZkdMIkEC4J7Fmh0g== X-Received: by 2002:a05:6830:1093:b0:6d9:d689:cd18 with SMTP id y19-20020a056830109300b006d9d689cd18mr635893oto.36.1702067490639; Fri, 08 Dec 2023 12:31:30 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c9-20020a056830000900b006d87b167c41sm432894otp.8.2023.12.08.12.31.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 12:31:30 -0800 (PST) Received: (nullmailer pid 2653738 invoked by uid 1000); Fri, 08 Dec 2023 20:31:28 -0000 Date: Fri, 8 Dec 2023 14:31:28 -0600 From: Rob Herring To: Pintu Kumar Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, frowand.list@gmail.com, devicetree@vger.kernel.org, pintu.ping@gmail.com Subject: Re: [PATCH] of: reserved_mem: fix error log for reserved mem init failure Message-ID: <20231208203128.GA2646347-robh@kernel.org> References: <20231206151600.26833-1-quic_pintu@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231206151600.26833-1-quic_pintu@quicinc.com> X-Rspamd-Queue-Id: 68D0E80002 X-Rspam-User: X-Stat-Signature: uh46ye3ghxxbrjzrnwuunruxgxfg1m41 X-Rspamd-Server: rspam03 X-HE-Tag: 1702067491-541154 X-HE-Meta: U2FsdGVkX1+4zTX2fJbvf0ElTCneb4Dms+UAN/cpqIDUfN5+Po9Bc9440nxNaLxLAHn4lmuhCVzQHpKdd0d/RNQivp+R0oXqjQ4B05Vyv+txLbSH/pEtIevE90/y/kelZjVDgIqrm6Pt9KnBeWFAVpwtY2SdKjJozcLCjybVD+nKwvnWWKblpCcC5cWGfg5ET77+Se0WWGevqNLcADw2Fs6W01UbMK5SyTYAMz0ujFb3T0WCElm9tA3R2YAZyFmBfhtiU/cJT9yIaKjBFDe2P3tDrBJHcjqytpDVzf6nGk9BJUiz1twDy70XwMdhr4wk4a5V+EXfSJauCZ1wAOq7Wyc2KelswGS78xEcdcJGm+i+nsDny+HPyPWwrUdqAfK6NA3pK8dvPnwXG6dvatijKsjp5eXfQ+527SR3n2yJT2tJVtFhkOCrKxrJP0OM1eL3h+u08tIm5H8dDMx6FM31x1uTVB6pW/teHc/V1xWnaZLLKC+f9/Wz5nAgetgUJZhB8LMNkZPxiqoh0Mg6EhJSxb+c6V75LXgQliibmGniHXCI6D/qaV8IPY1vGzVwLuZYsjsz1ux9Hwx5CWpfOW2NLip5YH1oCAolUvo1ds9hBkGN7BXCnGm5nNT0gCdjWdC4wi5gRWFVFZ0LDfzeznyxV/sKGjH6j995jnf8dXJw6plllS4vLXKW5zFeY9HEVYBDM5RkdLPg+jQ4Ht998ia6YVa59rG38/57uNAO/JgQ/F5NM+Yoo4WsIpstvTCRZpoPPVsXPscfOOLLD/bgs2uYX6QJMDCL981I5Vy6MSnqkMVqGe7qlduIDXLHEdnYEHo6zXFnimbvfQNZjDHRajnYsqrXm9OpTgqM72j/3k2bJ3Kzd8bZH2fpMFswWvfT7zkNrBAYPyw2qC8x0flS/F7kIIaD30+qSYWvngM+OST+zbvQQJSqilxIrmkuWeLPr/6ffpxFvUKZeIIcHSL1Wwn bMJdLxxQ H06c23E3e1JXe2vZbtFqyREuejAnI747dYLU1DHgUbYBxWs7I4UScHM7tC52HNDZNf/KPCBKQojU4UO4oDT9+h3OVKB8zBpMsI+uvIsmrorjtLQhIaY3hYduStYgawaMBE80PIWm+Tl/RPDwQ1ms7a4GsDrAcCQmiQPeDElCsDRqDO8EPPqM3GEOol9NaPse6hWSwga3UI7XjkNXiqGzjRjSV05zFv6x0vA5yrt0CkZmofTce+kEa4zLgEU6UTEmUFEogk/GLgsWMEGNYNh+Z393SyEei/QtDkWXHxGuU9ZVMH0gKgJJ2YN0MbbCsKklvRnR9bFfGOMm5WXIUyCc3CYXM6DtFKkt1u8vhWObjUg7KFdLEJ7sbeUxa41AAJabGPT/VPz3FHGKjFg5EVWXvTmI+ay9+fAL5Q2iuRY3ea/Ic/NIeL1uL8XpXlxvLeJipKmUQMz/ap4p1BNE4lGaHtIOcy2wQF54jgbBDKYCd2AJpvnMOn3X2gNp73TEwrKzcDwnJeXCQQ4sTm8KohQnAoNN+wg1AZeSIcVX/j7iCRV4s1x1TUpEXrYsp0tvxSg/LTRg1vywYBnKte5uYT6RkwwHCDcLEfDlrzx4dcs2FdYMC5FNrbmd4coEYlfvZDaNbwPFD X-Bogosity: Ham, tests=bogofilter, spamicity=0.045043, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 06, 2023 at 08:46:00PM +0530, Pintu Kumar wrote: > During fdt_init_reserved_mem() when __reserved_mem_init_node() > fail we are using pr_info to print error. > > So, if we change the loglevel to 4 (or below), this error > message will be missed. > > Thus, change the pr_info to pr_err for fail case. > > Signed-off-by: Pintu Kumar > --- > drivers/of/of_reserved_mem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c > index 7ec94cfcbddb..473665e76b6f 100644 > --- a/drivers/of/of_reserved_mem.c > +++ b/drivers/of/of_reserved_mem.c > @@ -334,7 +334,7 @@ void __init fdt_init_reserved_mem(void) > if (err == 0) { > err = __reserved_mem_init_node(rmem); > if (err != 0 && err != -ENOENT) { > - pr_info("node %s compatible matching fail\n", > + pr_err("node %s compatible matching fail\n", Isn't the message just wrong. If compatible match fails, we return ENOENT. The failure here would be from the init function. > rmem->name); > if (nomap) > memblock_clear_nomap(rmem->base, rmem->size); > -- > 2.17.1 >