From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39E4DC4167B for ; Fri, 8 Dec 2023 15:14:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76F466B0085; Fri, 8 Dec 2023 10:14:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 71E1F6B0088; Fri, 8 Dec 2023 10:14:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60D266B0096; Fri, 8 Dec 2023 10:14:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4BAC66B0085 for ; Fri, 8 Dec 2023 10:14:16 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 17C6D160212 for ; Fri, 8 Dec 2023 15:14:16 +0000 (UTC) X-FDA: 81543996912.15.27C9360 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf22.hostedemail.com (Postfix) with ESMTP id BFDE0C0027 for ; Fri, 8 Dec 2023 15:14:12 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b="Urb7F/kI"; dmarc=none; spf=none (imf22.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702048453; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R35glQOGU4B0yR33HDpJFKOjzNBBa5sMO4yfY0YOJxs=; b=5eNo8j6h3NdjmAS22nyRsDbZBf/MSmCyfWSPSGMB4SAspIThyRoird2s/R+kj5a51+y0sY M87vvWd3/LTqAufx1hz+JqhMDZgH1pBx7rgK1ELiQnunTBtxjXlfd3rFuNgNtSS/QnHXlK ZkYW/7jaDuFREhjta6ePgDmP8dLvn90= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b="Urb7F/kI"; dmarc=none; spf=none (imf22.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702048453; a=rsa-sha256; cv=none; b=gB/Nb0YJNi5zwLdj0exQEYBTFmz7yS3LxB7GX+cpOAcCr+78hfKE5mqIRIL0a13bCxiWGN oiZs0wAkdyCQ+tqjzBLJvQ00aHUA359vfzqvCaHqRqkC0yaPQXl3apkAaAt/BlL61xiPOw /f1LaEquKuSlJE8Uu7zR9yTsz58kSwo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=R35glQOGU4B0yR33HDpJFKOjzNBBa5sMO4yfY0YOJxs=; b=Urb7F/kIqU3YnTZAoccPn2bO2+ q2hbXOFx8mmv+dghxtqjzkSNZ2c12hs35s+7mvojrvbNE/3pDv36aUANNXyvU58M23xhkCzJUS1FR S7jxMn6ur/edEUljTKC6sOLqLIEsENqT6RljN36xWH3STUpTeMWnhQV6UcPLmFuzGLQiBqCraPXVp cbDPPlTXGQrnUvSonVWM5h1ZgU3d18O3WJtOk6R6Ozv4Dv0zeCv3BNG5kCaJLoo5e3rsA12YjxwRN 9T1zqbN1AZYAQfGZ3zb5sntIy9H2P0QV75N8HpgEdtm73hrcjk5klcnltx0GGEPxnyd4HOIK3vXvd 3ykyfbMA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rBcYE-006cfM-3B; Fri, 08 Dec 2023 15:14:03 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id E36073003F0; Fri, 8 Dec 2023 16:14:01 +0100 (CET) Date: Fri, 8 Dec 2023 16:14:01 +0100 From: Peter Zijlstra To: David Hildenbrand Cc: John Hubbard , Linus Torvalds , Andrew Morton , Peter Xu , Shuah Khan , Nathan Chancellor , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML , Muhammad Usama Anjum , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built Message-ID: <20231208151401.GG28727@noisy.programming.kicks-ass.net> References: <20230606071637.267103-1-jhubbard@nvidia.com> <20230606071637.267103-12-jhubbard@nvidia.com> <20231103121652.GA6217@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: BFDE0C0027 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 39xsgj7k4o8mpuw4m3oe8pi4ta9ho1pj X-HE-Tag: 1702048452-430650 X-HE-Meta: U2FsdGVkX1+NrYcF/VgHVfHKqVcY+1+vGCvhz75CAkBBon1lnKPk5ZYB5o0/6pIoCuFKyg0NtIv0OJgknkQX8C4p8baODzocWFk8Tr47KGXBRSDllkBZWnwyD+iuAvUbfvkf3cdI6S5ugJaVBL/fPHN1hlr9UKZmJoYNMI70e4yFgMgRCLSxlxznEig/rEOBSGU8dqJIJxEueW4XvIBsOao3eU2PuxyJ9I1+OkQPBTGfXSRltmPJQSBvYQQUCJzQ9ycVJmJALHUHszzfiO2/X7Cgr8pkVQMy56Wph1E+R2fusKIaqx1OG0e80OP9z9bYsoY6VLftlGRtMBlrOuIAEk2yM3pqGZvyyxcsp559X72pZoN82SXHMcA4xl7dyDOP5D0q1kAT46il0I3Py1yUTr0MBJOfwALME1JPdn9BA8/KjrbqrarTuLiMIFfyzmjvY3olpenFqYzBW9/frUxKYt2VuJuOo+VkBnJt2udVbzu9hXh1vbq18vjAh8Q0W+jT5ef7n2nQlw1fWHJPDeXFjs+EzLc+9Fyfl6xBv9Nkg3odHo99iuK9tmRZa0NCh39Epi0a0F0qSbA/Qiws6e7zB12v/y4QLwIAI6dS4Dxs+MyPkd730uSnXEfx6GXgyTWO9XO+qpkC7YyQJpTdjk7u38GQptXNWhmTTFZ7vJdznHIK8kaNrX89MgHrGwLjQpE3LpoqMSwyia8SPiV1/CjvINnNu4nYNXJqrdK4p+1LS0Pv++BC6cIUvuGlNxATSmpzKySJgeE5Xodtsza+oJXPwCHZEsba81IItqIP0Afy7ac2N6kVSCsRgwWv5MoKZBpoiNGrrNh5t6LZv6dMUG7sqDBUmnibjfBOhV+NDDTJK69FodchHihORzr/s2PwQNPZvy0peCxdG8PXXO9I/Iwe90ixulSgmoyN3Rsbnrci4L0n+NrGKfEvG2cwb2HdH4DJDL6ZcStN9jgw6Nk8PTn MEqbYvCn TMkcixBWmkWrSH+AE7hbVc7yCxxRwrylar4YteTg6AzC6dm/GKBa0SGYKWOo8dPhYgHPt5w43//Xa153ybS58PUlGBOM6rWtivMWvUbT8z75XEO68NNi6drhxOcQi0PqK6IxV2RdE5sG+vEE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 03, 2023 at 01:22:54PM +0100, David Hildenbrand wrote: > On 03.11.23 13:16, Peter Zijlstra wrote: > > On Tue, Jun 06, 2023 at 12:16:37AM -0700, John Hubbard wrote: > > > As per a discussion with Muhammad Usama Anjum [1], the following is how > > > one is supposed to build selftests: > > > > > > make headers && make -C tools/testing/selftests/mm > > > > > > Change the selftest build system's lib.mk to fail out with a helpful > > > message if that prerequisite "make headers" has not been done yet. > > > > > > > NAK NAK NAK > > > > This now means I can no longer run selftests, I thank you very much! :-/ > > > > root@spr:/usr/src/linux-2.6# make O=defconfig-build/ -j64 > > make[1]: Entering directory '/usr/src/linux-2.6/defconfig-build' > > *** > > *** The source tree is not clean, please run 'make mrproper' > > *** in /usr/src/linux-2.6 > > > > > > I've always done: > > > > cd tools/testing/selftests/x86; make > > > > and that has always worked > > > > Now I can't bloody well build *any* selftest or risk not being able to > > do builds. > > This change landed in 6.5, no? And 6.6 was just released. Just curious why > you notice that now. And I hit it again (different box etc..) Can we please get this garbage fixed already?