From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1571CC10DCE for ; Fri, 8 Dec 2023 09:35:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77E3D6B0072; Fri, 8 Dec 2023 04:35:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72E936B0075; Fri, 8 Dec 2023 04:35:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61E4F6B0078; Fri, 8 Dec 2023 04:35:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4EE076B0072 for ; Fri, 8 Dec 2023 04:35:32 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 26685403C3 for ; Fri, 8 Dec 2023 09:35:32 +0000 (UTC) X-FDA: 81543143304.10.3742304 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf15.hostedemail.com (Postfix) with ESMTP id 5FFC7A001B for ; Fri, 8 Dec 2023 09:35:29 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gG6QeilF; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702028129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B7J8ysymYw3KT+JkAqH5YAJqqTMDimCNhUjELEuxrfE=; b=GQ+m+K/NvEe4kDMYqCEi4NGc766q5zMHbJXr90O/3NwZIVCuis/HkMFQAKEi/6jAOubw3d ppjfs84m07qHxNNwxo/xTU1Z3O3oHPnDI/VyOSPMEATVBp/Gdan8xVVNuhDFRHrdRIfVk2 9IKph+6wLXUNQB3Ax3g6ijtFmudeomM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gG6QeilF; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702028129; a=rsa-sha256; cv=none; b=RF1uTzttAQbjJs6vPgAs20pmPvnK4MC/vSE8OLYnHZbfy3nB6Qoa3l0iwp3CryAaLOpAOJ pQNZFs9jxwVueY65H6VvxNILRdmMN9uChsOuKHLjTkViAFZQnySXgiFRx4evyTxdCMCaKR XOr2ON8zMMe4oMVszAbrW6op+pW72SE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id DEE23B82BAD; Fri, 8 Dec 2023 09:35:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA98DC433C7; Fri, 8 Dec 2023 09:35:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702028127; bh=2RDEVzmuLhz2tEm7RLeEBtH8w/GArNTHcFtmWcAE6Dw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gG6QeilFYtk+3SeDmXLLfGh0A6HyGUgUpd5hmq6w/s5pgLCQkrKjWgIfIQft4McJe WlmdLj9+Jyr32y6T3eHIiztaLmtMany7q4LdUdUKkXx15Wj2t7dMl0r4botTKelIps agKXjuKrN6tajgXFSssjAfmoQYh+YwfDvF5aiOWuqO90Q3FTihlyKfH4JgzTRgsd1g XTsH4MDMYn+gHG5dQlMZVP7pazHmBSfqdfMujoRoxYjbbjuiUgP9S1ul6VErL6gN5L qC2qdzHk2FxSKjo+o/OsGQtyoFgpro7bE2S+xvgse6zdAf1bYk4nM1ezKI0lD9HG1q Q0FYSd6sk04Ag== Date: Fri, 8 Dec 2023 11:35:16 +0200 From: Mike Rapoport To: Yuntao Wang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH] memblock: Return NUMA_NO_NODE instead of -1 to improve code readability Message-ID: <20231208093515.GN636165@kernel.org> References: <20231207131001.224914-1-ytcoode@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231207131001.224914-1-ytcoode@gmail.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5FFC7A001B X-Stat-Signature: eeb1nnm1sc9xme81tcrm36ieoyot7rmn X-Rspam-User: X-HE-Tag: 1702028129-719345 X-HE-Meta: U2FsdGVkX18S7F7A731wkRZmyQIpY4bO2OxMVEUAaI5Vaq+x/2LgLpMCflp2IIs/WCI0l9Z5ahrlO7FGi5cmo8yYiDy9WVMxwDG3tFj2Rawd6P0cpkQ/umnJU0BjRLxw57IayKH+bC+a/2h1R+9jMuOoyHQbYsGp63deJ05pw1rpQd1WbeosimC/R6uuafLgUSLIs5BRJJHmTOWTKM8GRnGoZG5czMnYFEmchsjADKzJ+iUqXaMrvvWUufWDQJ16y+Mh7oOTkX1re/8sQS6/k+U7MGSZ9r3LgEPG9rNa7Pkrw1dXo5nmRl6Q6RgWI6TmGUYA9FRj9K/yAQaoWDueQ6afaa9yCHEM3INIpx2/XFtPE5UPneOxzQ2mwKS3CTKnhntgbxtOrZgcyuCZ4smE4VvKNz9n1hsrUGWwVe9rdFwdxJTvxpD2fCkttsFLJc9dUEMtAYkGvtGdymynatZMlzLGqiZ8LgJCZS7G2M1TdU2Ge/czxhpRgLjbdzpRiXzDxEzcxND2MDRmwo89s7UmsP/Az8YGOXd91916WZonqVs2yroj416wV8tUG8WLQmrrPcX/5kfVqUzyXfL3A+hi5TKKwIATlHd42I1gfc4k7lxcbva4tqOSs+vKfNaxZ9skjFhWOYVnVeTv0+Ye28U+E5NCGndKpEk+RoKqie97Z2CuNu4fUo/jigFPDmoH3AfYA/IX5TCWVAJ0pfmVXIWYXZVn9bnF4dDQmNyzdxMFd+R2ZCbouGM/X06OonmT6/y7TYQMgYjoJPU1AzEjVNMg4kOxKHgkJwanexwRrN8k6rC32VaAZScBpoZiS7C59lRwLcYFcG747wDR2Vt/PaZwREI4mbsqp57kR10OstnvfYBfNdPUZ8nODGqSbijp3O5TUyWiAnMNQZVzFwe128hreXFuwIwEs/aW+GI6vyZYqtYchIyV9U3UL4mgRsu7wazwgwkbmQ36ffqqSITUcd9 RAyrH8gF ZUowTJblOYvpTBtDmu+4u8m3FONBGx8eRD58Wb5BIvtljWf4hIAhJoYYVzteDhuhf4FMX6kPQZWcrUkkb14k7EJvzVSubmRB2QdB8AEYvaL2tQ9j790bw95lw4fWmbm4OE841zeXPxjqIEy/bTPCkWYvvrvxn8OTPutj6093+G1etrresWq50DWZmozi0AXs6bWPXVj1f1oAi77dAP6qKO3rT/QIzqOjvjk4Nm0uh+cMX7em7F/ruc3bPh/N1vjHEHQfG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 07, 2023 at 09:10:01PM +0800, Yuntao Wang wrote: > When no corresponding memory region is found for the given pfn, return > NUMA_NO_NODE instead of -1. This improves code readability and aligns with > the existing logic of the memblock_search_pfn_nid() function's user. > > Signed-off-by: Yuntao Wang Applied, thanks! > --- > mm/memblock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 5a88d6d24d79..c1f579c23396 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1851,7 +1851,7 @@ int __init_memblock memblock_search_pfn_nid(unsigned long pfn, > int mid = memblock_search(type, PFN_PHYS(pfn)); > > if (mid == -1) > - return -1; > + return NUMA_NO_NODE; > > *start_pfn = PFN_DOWN(type->regions[mid].base); > *end_pfn = PFN_DOWN(type->regions[mid].base + type->regions[mid].size); > -- > 2.43.0 > -- Sincerely yours, Mike.