From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C8C6C10DCE for ; Wed, 6 Dec 2023 03:12:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08A956B0081; Tue, 5 Dec 2023 22:12:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03AF66B0082; Tue, 5 Dec 2023 22:12:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E45426B0083; Tue, 5 Dec 2023 22:12:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D5AE36B0081 for ; Tue, 5 Dec 2023 22:12:21 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id ACBDC80385 for ; Wed, 6 Dec 2023 03:12:21 +0000 (UTC) X-FDA: 81534920082.21.B69F08C Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf02.hostedemail.com (Postfix) with ESMTP id D3AFC80002 for ; Wed, 6 Dec 2023 03:12:19 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=nsk8LGL8; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf02.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701832340; a=rsa-sha256; cv=none; b=sQy0q+H3faG7Z+BCNxH95f1nofa7V6kBvGEqQcW2Yz11QXT00TeLFLHelvDbq5BAf6O6WY vBASSiE/cspKojXniF0hgh66VuJEKijY/H/DyHuVlU6pqzGNC2phGi+NJDwmkN562gahYJ 06xcPeaQtV/M1gsxNa5IEziirkMfvMw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=nsk8LGL8; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf02.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701832340; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N36n/8mtCSjRu5BgneJZqUoAl90A9Tg3KPRbwmmqr4s=; b=TOQdULjz14mYkH1KuJfFg1J3NTuXbK6AG4eeHcew6yWyfS0U91+9rcdTpg8+ieeFPqqsJ6 hLC8/NCL6BFWCKBclzBulCAk2Xpe89XS3D1h4xDLk2bXVenk15+FOK7UvR2QjAfUcI676M FV9Dqbu7kUZc5Y/+ZpHAiu01HApWN+I= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 93C2AB81D14; Wed, 6 Dec 2023 03:12:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 755B4C433C7; Wed, 6 Dec 2023 03:12:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1701832336; bh=lTHpF9Bti1w65vYiC1cnqYOAb09SPxfwZH3wTHGdKGs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nsk8LGL8rZUevibrNp9VycS3Ts/i/qovwSjTyj0lZGoABYFWLf3hXOiM6HQjb/Zj8 9jxgRJSZLWBW+UEsmX+Ef6P/mO5LqHc26jy5VolPFDzhf3Vc2tZfmENkW53VKWssaq pKi/rWLanfouDImA9l3BctRWwYxJ0Ns20wABdfRM= Date: Wed, 6 Dec 2023 12:12:10 +0900 From: Greg KH To: Pasha Tatashin Cc: Sourav Panda , corbet@lwn.net, rafael@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, rppt@kernel.org, david@redhat.com, rdunlap@infradead.org, chenlinxuan@uniontech.com, yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com, bhelgaas@google.com, ivan@cloudflare.com, yosryahmed@google.com, hannes@cmpxchg.org, shakeelb@google.com, kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com, adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com, surenb@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, weixugc@google.com Subject: Re: [PATCH v6 0/1] mm: report per-page metadata information Message-ID: <2023120645-survey-puppet-4ae0@gregkh> References: <20231205223118.3575485-1-souravpanda@google.com> <2023120648-droplet-slit-0e31@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D3AFC80002 X-Stat-Signature: hn8er819x3pknyaassofr8xegim8ij8n X-HE-Tag: 1701832339-313605 X-HE-Meta: U2FsdGVkX1+K9iVd96e94nMQ1GnQczFpP/bFfTjdoxO4CqSf4ZVPec7a57JNIe7WajqBPXxmUJ8AKs2wEZIv/TMvKAdkAfdJLWdXyK/ZpWtJGtsY07GjwhreeGrraWzf7IgmG9xxR+Z3xWkP1WL1KJfGmSZIqYgZifL5kYdhfaTu3bgUkEdF0aTBDDcYe53rTD1Bj1L/KOX7XcSUzN+40RSraynh5lG4YoHbbD+5yyHRPXbPSv1IZlUtqklUwvnImVq8kRRu3fBZr+u5mtijqJGan30BIoS4xlatM7cE4Vi25JX1IlsMNYM4YKlde2sJ+zJfUTgd+1ox85ZrO/uG/fZcaRLJVldG8INfrIpTq258v96q8vizj+rSeAlpTEK3E9VLTh9Z5WCTP91GR8KwmHgt3ZQHN7oVAd7Y2RF8amsVoYAGMeONy5mubtZkzrwGyauN2SFF2AhkW0j7ILNllFKaWclHSiMQmVsMnIo1GR9gs+leAjpaC4n7m4zzElNDF6SKb6cvuMVaLl1CNy9cHSy8bYimGTNzXwuhn+6+PBkQItJOeABDp0fpWlq3KGl4pcZ5m1Uhlqq8owQGtrnZrAtf0s2ISJ0CjVItZ3TJ6PnqirJV+hZ3qcCpbbTUwqA0eRflCYPk+uWr8whV58pag/KizuDQZHFyHMhJ3Qp5N+sKmLl8hrZ0GEDk492dwjqB50zOms/sKtsuy2piBX6iNldRU8Z4jEQTxW822Js8vTUwekZOxVoZaY/qQGm5P9sqjh89cxHcr22/VNsFqOVLcdzXGL+XYYACW+vYj/qNPwBtXQnPA0sZSTPCWS5TmY1XIic7GmiZVFfEYmf1m3ZlCMcKXiSqVR1lcm0JLK0dvzwiyVl7o6haYjjpMZp9j+vO1l/YY1EWsqHZrH52xI0ChW3pteoKwTcKXShuZRBpDkmFac8txV2+iv69HREL1aX7W+DDdYAmRJ3pq9UnFeQ JgLdQspT kcGQKSpBlKpdef7zNrCdX5GHQ/A2hnw5JVxD7gokV2G9/EpTI/zvxFcDZ5JdHyvxcRhpReexhX+92AOeiQ0X/wbtcXR13htO+wd/Nha/qr9dpaFf+W3oL9WOHrSAO4MBoohPf1JZEkvzxDGkeB0EpnGvH9x7B4Wpk6s5e5s1kcdpwT/1va9ehogxoQoZj07a07bqrc7Rd5Y8GXoEdm9W8tTuNivYN3uhLTjFR3GQBrf/1ZcWvBKpAiA4aPyMcFjSiJStQJ98hplS/6vxfKm6oPL8CVk/cu/K4zKT1ev5MAIHKPorJld+CTmXGiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 05, 2023 at 09:57:36PM -0500, Pasha Tatashin wrote: > Hi Greg, > > Sourav removed the new field from sys/device../nodeN/meminfo as you > requested; however, in nodeN/vmstat fields still get appended, as > there is code that displays every item in zone_stat_item, > node_stat_item without option to opt-out. I mentioned it to you at > LPC. Sorry, I thought that was a proc file, not a sysfs file. Don't grow that file please, it should not be that way and adding to it will just cause others to also want to add to it and we end up with the whole proc file mess... > In my IOMMU [1] series, there are also fields that are added to > node_stat_item that as result are appended to nodeN/vmstat. I missed that, that too shouldn't be done please. Again, sysfs is "one value per file" for a reason, don't abuse the fact that we missed this abuse of the rules for that file by adding more things to it. thanks, greg k-h