From: Greg KH <gregkh@linuxfoundation.org>
To: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Sourav Panda <souravpanda@google.com>,
corbet@lwn.net, rafael@kernel.org, akpm@linux-foundation.org,
mike.kravetz@oracle.com, muchun.song@linux.dev, rppt@kernel.org,
david@redhat.com, rdunlap@infradead.org,
chenlinxuan@uniontech.com, yang.yang29@zte.com.cn,
tomas.mudrunka@gmail.com, bhelgaas@google.com,
ivan@cloudflare.com, yosryahmed@google.com, hannes@cmpxchg.org,
shakeelb@google.com, kirill.shutemov@linux.intel.com,
wangkefeng.wang@huawei.com, adobriyan@gmail.com, vbabka@suse.cz,
Liam.Howlett@oracle.com, surenb@google.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-mm@kvack.org,
willy@infradead.org, weixugc@google.com
Subject: Re: [PATCH v6 0/1] mm: report per-page metadata information
Date: Wed, 6 Dec 2023 12:12:10 +0900 [thread overview]
Message-ID: <2023120645-survey-puppet-4ae0@gregkh> (raw)
In-Reply-To: <CA+CK2bARjZgnMBL9bOD7p1u=02-fGgWwfiGvsFVpsJWL-VR2ng@mail.gmail.com>
On Tue, Dec 05, 2023 at 09:57:36PM -0500, Pasha Tatashin wrote:
> Hi Greg,
>
> Sourav removed the new field from sys/device../nodeN/meminfo as you
> requested; however, in nodeN/vmstat fields still get appended, as
> there is code that displays every item in zone_stat_item,
> node_stat_item without option to opt-out. I mentioned it to you at
> LPC.
Sorry, I thought that was a proc file, not a sysfs file. Don't grow
that file please, it should not be that way and adding to it will just
cause others to also want to add to it and we end up with the whole proc
file mess...
> In my IOMMU [1] series, there are also fields that are added to
> node_stat_item that as result are appended to nodeN/vmstat.
I missed that, that too shouldn't be done please.
Again, sysfs is "one value per file" for a reason, don't abuse the fact
that we missed this abuse of the rules for that file by adding more
things to it.
thanks,
greg k-h
next prev parent reply other threads:[~2023-12-06 3:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 22:31 Sourav Panda
2023-12-05 22:31 ` [PATCH v6 1/1] " Sourav Panda
2024-01-05 18:34 ` Pasha Tatashin
2024-01-05 22:19 ` David Rientjes
2024-01-06 0:38 ` David Rientjes
2024-01-09 21:57 ` Sourav Panda
2023-12-06 2:36 ` [PATCH v6 0/1] " Greg KH
2023-12-06 2:57 ` Pasha Tatashin
2023-12-06 3:12 ` Greg KH [this message]
2023-12-06 15:59 ` Andrew Morton
2023-12-07 7:31 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023120645-survey-puppet-4ae0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=chenlinxuan@uniontech.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=ivan@cloudflare.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=pasha.tatashin@soleen.com \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=shakeelb@google.com \
--cc=souravpanda@google.com \
--cc=surenb@google.com \
--cc=tomas.mudrunka@gmail.com \
--cc=vbabka@suse.cz \
--cc=wangkefeng.wang@huawei.com \
--cc=weixugc@google.com \
--cc=willy@infradead.org \
--cc=yang.yang29@zte.com.cn \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox