From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ACD6C10F04 for ; Thu, 7 Dec 2023 02:10:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE62E6B0089; Wed, 6 Dec 2023 21:10:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B96406B008C; Wed, 6 Dec 2023 21:10:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A860E6B0092; Wed, 6 Dec 2023 21:10:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 999746B0089 for ; Wed, 6 Dec 2023 21:10:01 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 74C6F1A0300 for ; Thu, 7 Dec 2023 02:10:01 +0000 (UTC) X-FDA: 81538391802.14.BE8CCAD Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf28.hostedemail.com (Postfix) with ESMTP id B47F2C0015 for ; Thu, 7 Dec 2023 02:09:59 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of "SRS0=4B2K=HS=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=4B2K=HS=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701914999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EiHR44p+y7VKzpd8BQSqBfj02kzr1W8mykM4tcDsv6g=; b=F0bgJnaT5LcfX/efiY/3BT6VWONCX+y93DYSLySve6RK0ZSzmQqLbiEzjAh1XiglqSw4Zc gvqsXpsOKNiflIWwI6AhwQaKvooCURKrD+rX4kl3sWkKNEewurK7hP/ngo7i6PNc72ObmU 2zgSnyFXnR+Ozby+42vj5BdMX6q4G00= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of "SRS0=4B2K=HS=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=4B2K=HS=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701914999; a=rsa-sha256; cv=none; b=5TRpAQQZpC27/Q/IFsuR9UEmjesLOTTFSZX/pM5mSKn1Oq1eN0FRH2AXble51ZDW+ojSwW 8HhpY+VaH9+63NHH0lgPm5Nygqub44ORr7KtmbyqmjYD0KzZiqjffgJJZEFokoMkV1ecjO FbWwLvwgzW/tFw7kKjpV77pXOS6hJxI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id D4E93B824D6; Thu, 7 Dec 2023 02:09:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A20C3C433C8; Thu, 7 Dec 2023 02:09:53 +0000 (UTC) Date: Wed, 6 Dec 2023 21:10:22 -0500 From: Steven Rostedt To: Ankur Arora Cc: paulmck@kernel.org, Thomas Gleixner , linux-kernel@vger.kernel.org, peterz@infradead.org, torvalds@linux-foundation.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, David.Laight@aculab.com, richard@nod.at, mjguzik@gmail.com Subject: Re: [RFC PATCH 48/86] rcu: handle quiescent states for PREEMPT_RCU=n Message-ID: <20231206211022.710ada02@gandalf.local.home> In-Reply-To: <87zfymn6h9.fsf@oracle.com> References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231107215742.363031-49-ankur.a.arora@oracle.com> <2027da00-273d-41cf-b9e7-460776181083@paulmck-laptop> <87v89lzu5a.ffs@tglx> <209f0e89-7ebd-4759-9883-21d842d0d26c@paulmck-laptop> <87zfymn6h9.fsf@oracle.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B47F2C0015 X-Stat-Signature: odokpf9b6hckhjchi7xdgbyswzb3sknt X-HE-Tag: 1701914999-488780 X-HE-Meta: U2FsdGVkX1/tPzJctFnpGmgjMg0BxGgBr5n87b+zr6IUQ6kSGmyOBrMdduM7KoIsUzPGxhyQq1WI91vKU2wIGj45KwPvCFkuMF/uLfpUOLE8JtHnUmU46Uon3hkADtBus0RWmsEaoum7Rdsk8cWFho6hKmQ2cbH7J437WyJlFFbxjUwm/TCLd2W4VCuKVy8CEDuOvY3Xnv+JadZnFnjkS2uZdeBQCqy6csuVAFsWpbvt6W9B9szsyGYbZrqg6rM5VLSfpCIh8EUu4Q8GSJmfX+Iu5nP6gYaik2ohgEHqoRE0VNFYUBT6ek3mWqm34NTZzuSUaTp4TEA73Fz1R09vqW7g0WqExrKFg1TSO0j3SWGaKfUoXTNy5M3UwxgKwb2lNo3+idGPSvNAMvJwbjlJ26Y9AT+FHRWfv3Em1bHBOJGL2PrXjWoXdu1uKn1qFFdOyQTBWK4o11lhIKJVvk4JmrTl4CPKJ9MR7fSpx5CuuTOGfuYcYL/9PfjPL9qJuEQhGyFovnkxQnRbBM31SOwXYoBjYT/eE5ddv02K+GArxjd7M/Wt7+vikZ7xQ7uyLCpaWzqYzSUS3QKEK2g3v/88RkvVa+mUTLoXnXS1UB00j2gz3gEvUtH6ti1O+Z6A9J8uhB1HmIFLNS/DaEw8dI1UojAa2qZAmcU0QhiM1XBBxxzxeHNBLwgMF/y+3B6E5p+1k5w8Ate2315whptSQGK+zVVpKMFHanHD8A4gtxUS9KeokkrXDnGsq6w8MrT+XgkGVYT799CqjYkB0L92NANSSjz/Zt8RdLHLD4At8wJPKRzhOuAW+a3bENH1cgrI4+IRNfrWdNVOoEWSe9OLeumQnBWl+Tu8ysky+D/o6Ce1Gms2Fl4dlpXn+Aop+rJg9/4hmUECe/hBak5SzFWajq65Kyd7+239IPcyPhcp9dilU9zeQ7/uZuHxypG9/DEXojp+NVTEOssDsQZO0ubTIgC 7vxFdIXo W1s4wed2HNszzkS2rvD8VCd9N6I8KyZauydKUiXaJw3NHcFjhzScr3lg3SnoywxAynMTCS7iohUq+O9D7+2LEvRVhd1kIMbbmSvEZ+6c5oxPxv73PfU/EXuMmgA49wsAIDReUsgl3O7WwkahIOncPNVk968Ffq9NxSAA2sG5FFao4T9caLO3BnHsmUr1/yaCfWxI+XllxpDqsYPITgroAa+t9xlQHgAduItnIyno4ZCmJ8PtDxwEFCH/jUR8JY1bN8fOa/rDgV5As2YM9ySP//BWRb3vDp8Ou+CDR46tLgz8D15wzLGnXeRLKRlbPnEQFWhxS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 06 Dec 2023 17:31:30 -0800 Ankur Arora wrote: > --- > diff --git a/include/linux/preempt.h b/include/linux/preempt.h > index 9aa6358a1a16..d8139cda8814 100644 > --- a/include/linux/preempt.h > +++ b/include/linux/preempt.h > @@ -226,9 +226,11 @@ do { \ > #ifdef CONFIG_PREEMPTION > #define preempt_enable() \ > do { \ > barrier(); \ > if (unlikely(preempt_count_dec_and_test())) \ > __preempt_schedule(); \ > + else if (unlikely(raw_cpu_read(rcu_data.rcu_urgent_qs))) \ Shouldn't this still have the: else if (!IS_ENABLED(CONFIG_PREEMPT_RCU) && \ That is, is it needed when PREEMPT_RCU is set? -- Steve > + rcu_all_qs_check(); > } while (0) > > #define preempt_enable_notrace() \