From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F6CEC4167B for ; Wed, 6 Dec 2023 20:43:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD9416B0098; Wed, 6 Dec 2023 15:43:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B3ADC6B0099; Wed, 6 Dec 2023 15:43:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B53F6B009A; Wed, 6 Dec 2023 15:43:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7F53A6B0098 for ; Wed, 6 Dec 2023 15:43:53 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5B306140295 for ; Wed, 6 Dec 2023 20:43:53 +0000 (UTC) X-FDA: 81537569946.06.AE10A59 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf12.hostedemail.com (Postfix) with ESMTP id 494EF40003 for ; Wed, 6 Dec 2023 20:43:51 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b="LM4o/RoK"; spf=pass (imf12.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701895431; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j+6bz83E2E5dhWoENXiIOXBWe60E3WSbl+pDFm9fzsk=; b=FCoLuuSH7XOwKQl72hc6Fj+cQBBPNhRqOdOa5ZIo7WwEbf6IHc84QvGmVa5sX+BLXz9mcw UKnHt0U5BwbE1IqbOWSJtKuhD7dVEVbkQ5KP5h6LJHDE+DFscWaWR1BJqqxxsIUXp2QODl ZtNZwaB47RTj1soYMOUZvJyUf7plV+Q= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b="LM4o/RoK"; spf=pass (imf12.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701895431; a=rsa-sha256; cv=none; b=8Ob1Hbm1HA+ZHm4O5YOkrZEcAPmqr4MqvkohIMgto5vY1st0WgtWPHszXTM1Mtiwrnjvz9 O819yFW9MP2/1trLc0yBueR/Sw6PcyY5WYD+WRpONnfWUYwBkl7QmiStMZ1GlWBj7sYV+O 97o3opuXTkDe33O8QNV9/RXOZdwbGdE= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 12D1D40E00C6; Wed, 6 Dec 2023 20:43:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id m30YgIGcggVv; Wed, 6 Dec 2023 20:43:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1701895427; bh=j+6bz83E2E5dhWoENXiIOXBWe60E3WSbl+pDFm9fzsk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LM4o/RoKTlfqVTgEMpR9zOTLNvLJSmCPkEQiJwkww8JbI83wwN5V1leOR33s2LgB0 IU5UQFrwXGoLHoJ8/+d+j12OSsYdb3l1KUbbsF/NEjw+ltB6CZA6PSR5j2nAhbjn1i 2iVk2ROUEoSSBFksKlMqB58zTz18ZxfJkzzgHKw62hNfTLJdpoX4z3CKmJ2D5s8tae LZz2McpBMV/ZlwUp9cVWZCHsc58tozR9Kyk/klayj60ydKVjVCbifDiCL/F8U65UQi 4QxoJ5pKprtxf+6vPkIMceEb5HzuEGJYlVfNwZXw0XLOcJi0B/bAgPl9/AGg8d+Bog wTb1Qf7l4fR/J+U00gEoJhy/X+3cpef8CGimOKNh/cJAQbSaVL/z4HtcMGZa7qejQx eC0a9M+U8BsqnQu+6FPBop4xtCBDBuTt1qse4X9kYLHj2Iqk5tzPVjuW5EHoCf3sDF EJV0X72LClA8Hm4Zj9XdLr+xnrJoCAfObfBSsZnu7Nrhw/JYIkn8W4XMgTSEjzg7UM keG9P4keiRiFWlaA3QLnQlLwdz/0W05YiwTyynjqX1YbucPuiqrTDz4TulS/xxBS0J Za98XTVjJWzRDVLVrZAa53J8/kiAXZQZ9WjMslOeyclszZw2YjSll9AeqHMSKrVHWG z0QlPr2KYAJDJyHGCcJhlq0s= Received: from zn.tnic (pd95304da.dip0.t-ipconnect.de [217.83.4.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 952EE40E00A9; Wed, 6 Dec 2023 20:43:07 +0000 (UTC) Date: Wed, 6 Dec 2023 21:42:55 +0100 From: Borislav Petkov To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com Subject: Re: [PATCH v10 16/50] x86/sev: Introduce snp leaked pages list Message-ID: <20231206204255.GEZXDcz9yfyMiyYQ1H@fat_crate.local> References: <20231016132819.1002933-1-michael.roth@amd.com> <20231016132819.1002933-17-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231016132819.1002933-17-michael.roth@amd.com> X-Rspamd-Queue-Id: 494EF40003 X-Rspam-User: X-Stat-Signature: eext1ymzndwt6go6d6oh1yypy4fh8enb X-Rspamd-Server: rspam01 X-HE-Tag: 1701895431-657283 X-HE-Meta: U2FsdGVkX19vsxByf0h94zuzGXblLgW3MafucoqmROqoo/250BW5mDe7e0BfnAryxNB2W+luxrqeRLi28M9DdEhfT4zTDcVVLd+KRiuehlhYsaNsz3Lpy9IVJiVdFhHQW84deCBNmqAP3e284ybJcFUtKUPTa/UxA36IeR8BPIEBLAlwWjJBeX8imbhPLqJjx3C97Utvdih6k4rcU0vaU1IRlP/MbluobfKI9Ekiny6w07brgZ/6kRPYlQcZDteI4MqLHjaODg1muw8QfmDMtcF0JxhZTg9PYCRrQzuBhKjPE6tOepdtuQ1kRCwJqqN1tESg/RK6tHt/krNusWNDm1oVNc20STmR6aei8KPXVseFdygJ/xYTi91lnVsnhKEbnvvjhAaadnGxb9P+nd9pPCtMmMUwI82//W5N72tk9NKFdaDqtL+OHdesITcknMZFNdIJ0HewH4i9nU9RTRp44ZM6yQ3gioel3XYtSro95oleKOznlaxQ3pShs4+gk9saigxuFvgQX4MimeULwL2X0gAnj9hmL79hEid0u5PpkzR7cUeBHJywR/OgPEW2+7Jvbr9RVTEMCLMnB+QPN6KCR27Ko4WSb2NF5oQha1rxNztDzwRpUADbB2wPSTN1sqW1418OjEmlL19g57SpCoqAqsEWqBpcJBvWoAW3Dxf9CUJ2K5K61CoQw8pIhYolAajv2yZ221ZZzVwPiEjxMzDYTGA5bZCMW4kBiRMW2llI6WTXL4RPf4HjFpdpscDReTq5waRPiRv/dhxjk0aSM8KJEGqUR32oin8AhC0/SF+5r4WxFwWtyN9Zp0cm8hDEPw7xvXgut2enxsE6r8NsD1G5rS8sZ+tKpgcReAxowfMq91oOqIheFiyaUdAQQdqTE8jQHPMRPF1CCZWutxcqxEHPko6l/GMlv8diEGTG4Gcz78qipZ3UMUz6WWADDzOnC0JN0pPp1k2VYn6z/FUt6XG dTzhc1hF Oq7AXcDNYzJBnfyhp6DeaYe7xM9ASfMkykzIt5tYauwnSB12ia1NK4ZCxg7seEMHXA/lmt0djeBat7IxjlllFBpyRx7xleR6hR0pT/L6NI5RLrxaQ9AGZbF/+7VpBdPLYNa6+sHI6ZL+FMIJrgnmael41F9duP4y2zT8G00cpAiBm0pgRTaRUn+nRpXe7iRi9UgcqcvU74up6N9fXJQ3fC2e55Qb7EJ78P2Rt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 16, 2023 at 08:27:45AM -0500, Michael Roth wrote: > + spin_lock(&snp_leaked_pages_list_lock); > + while (npages--) { > + /* > + * Reuse the page's buddy list for chaining into the leaked > + * pages list. This page should not be on a free list currently > + * and is also unsafe to be added to a free list. > + */ > + list_add_tail(&page->buddy_list, &snp_leaked_pages_list); > + sev_dump_rmpentry(pfn); > + pfn++; > + } > + spin_unlock(&snp_leaked_pages_list_lock); > + atomic_long_inc(&snp_nr_leaked_pages); How is this supposed to count? You're leaking @npages as the function's parameter but are incrementing snp_nr_leaked_pages only once? Just make it a bog-normal unsigned long and increment it inside the locked section. Or do at the beginning of the function: atomic_long_add(npages, &snp_nr_leaked_pages); -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette