From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44D91C10DC1 for ; Thu, 7 Dec 2023 03:15:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D55E36B0078; Wed, 6 Dec 2023 22:15:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D067F6B007E; Wed, 6 Dec 2023 22:15:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCDA26B0089; Wed, 6 Dec 2023 22:15:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AC5B06B0078 for ; Wed, 6 Dec 2023 22:15:49 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 82E41A0331 for ; Thu, 7 Dec 2023 03:15:49 +0000 (UTC) X-FDA: 81538557618.08.F63AD5F Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf20.hostedemail.com (Postfix) with ESMTP id 736531C001E for ; Thu, 7 Dec 2023 03:15:47 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aSLju+4e; spf=pass (imf20.hostedemail.com: domain of kuba@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701918947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SRAZz73xZ/wQzq9LmH5D7EgARdnZgItIkeFCCGRI57E=; b=r+AAoCNOaHwhkbk3+5DDfRK3lCPBKD0xLsbsT0X9/x8CovYD3r6JhTpDGC0J3jfvKUVvXc 4ujW/PrnNJ4QuHVAhCFGrvp55rMfgGOR2xbiaWjKCEvGUif3152itOrc1pNZDKjsTnXY7K eyy/vV5iW4f4qUuNJhWXtCYA1Wa53A4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701918947; a=rsa-sha256; cv=none; b=lUCiioyt4ZuQnmZi5ZROMlKiADP3x2gT4UYBaA+bIYbKQdPAtNGCKHOy2p0sq++uoFM8rH X1BAsQXt+HrYTOrqhlCFq6czJcozA4M30MoA9hxatlSrvVb/sPQKuSLOlsT3DHsNuIAQr0 1/r9iZg6RaLUiPaFCC2hUi49HPM22XY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aSLju+4e; spf=pass (imf20.hostedemail.com: domain of kuba@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5FF06CE21C0; Thu, 7 Dec 2023 03:15:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10411C433C8; Thu, 7 Dec 2023 03:15:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701918942; bh=SRAZz73xZ/wQzq9LmH5D7EgARdnZgItIkeFCCGRI57E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aSLju+4eEJeIUkqF6JDwTQfuLhzmDJ3EawX3T13ddxPpFum1+fPbsj9nN606wV3Mq i9fFZsr1jJtPLFJNEBZz4TSt7+0iMaPrlnhPsLXKTaMRuk17aZaO+Xjbh0r7MKa/F4 PiIH69Ri+ANuMK62qJSvqZjqDCCS9PtCMGtT8zcdxxb20oB1v5wc/DBO0yiVpeXBst TLQIuVhMPSr0RjbRX8EWaqJCX4ZR0hYyOXcBq2USAcsHg5Nhm8CKxAe04C5MAIt5zP JKlDkDFzKEPewUkcECvkdDBN0H/53XREjVLSBABKEG/VUThI5J8G349GXQk+Z7+6Ce ixELhIZx2p/cw== Date: Wed, 6 Dec 2023 19:15:39 -0800 From: Jakub Kicinski To: Yunsheng Lin Cc: , , , , Alexander Duyck , "Michael S. Tsirkin" , Jason Wang , Andrew Morton , Eric Dumazet , , , Subject: Re: [PATCH net-next 2/6] page_frag: unify gfp bit for order 3 page allocation Message-ID: <20231206191539.06d955f3@kernel.org> In-Reply-To: <20231205113444.63015-3-linyunsheng@huawei.com> References: <20231205113444.63015-1-linyunsheng@huawei.com> <20231205113444.63015-3-linyunsheng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 736531C001E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 1npr3jyw4pe73rtbyrfjnj7smpwp96no X-HE-Tag: 1701918947-680254 X-HE-Meta: U2FsdGVkX1+1+8J6sropaQeCn/PpPKpVdOM+6u/bcGtka9F5m1couPiV8N/P1iVHXfah4Z0EoPSawAi1XoeeT8+eIdH/mK4XD+llu9j2ObRdB8jrtE+rh4o9xDY05Mo2dP/puXVzfGPRMxWJaeSiYfUNUa9iDPBEWCgh1ML59KCdUYT+i3BoftaMRCzkPTG5w5qXoqGe2fWLAY3S4yVV+5VeD/cqSMTc+xQ/Soz9E9k+7EpD7ZpDHUTVjBXn4KWwOR0QjNSgiRZi+tVrqcBE15YHQEE7n60jXBc84IkYVVAjAwwaOkomUNs9EHOu8gdl4yViCxiZ+vUZde1217QBB13pa/CKLPUkRFwtoKvj4qA/eeHT/7FHglNW/23Esax6Q5i/RGQyofertq4+px11yKynnf5miXNWcqLQB4Nc2Z0j1W6iXZQr7LeIgaSc7PkUkj2QQtY+cpoWVfcRvX5PrJM5+gdVo/pSK4HZzl0XzI5euq4UIGjCZl9lDCVzytuz/upsFaKFSQ0hRpN+t6zZRSCthnpL0iwLc/9HgJS4EzGj8zceqokxvjsMZW1vkoTO8LO8NxCGtaeilDB8RztG4o73ZcSuj9uwFbBIT0z13+5KLHhsnSZ1DZn0m2mCAYQd59Uy6BjHStJu559iMY4DiO8HpBZqv1oqDJ2uhslzTGOfMx3YFCZ6LiP+iUvHxXJZcFWB11+0jv0vd7qHkS9mLwua8QVZjPDoignbKA+fI6ve1MSRaPsl20qB67FynRI4+O0C4+T4Y5IrdUZJtRQPwM7AHfAdMZFOjYD05s+EPjLhwU1PjgRwaM9wJoGPoEe7mnfxnj4OhAcCK4Ogv0ge1phFMDWCy3RVE9ewf+Co8ycK+kaKHCaxiop1iL6gaSrqFsE2FJyQ/7kxW+icSTPGoZTpCyjNsEmzpsmAhFHpURTCTrNHcOmlWXf4bd4jd+JvjJfCTs7DebUY4CkMV9E qSpx73ps n41tBJ0KDxw/lvCxA2mls7cNIBkiYAOvJJjc2RssxqqtiTfK6g/xY8wr5REl3Zdr2UkLZju9S0i7UeSOycEFTetFmeNYSE+g05HGQmPqxXjyhfXMLt8t2YfcBRSHD0+DZk3DemBJjq+QekTI6+vp+dFmcbx+Jv9bciQ+KhXYUXFHhK7hK+dJRRyw+DVEwVZln5nHLVbCVwnjQ9ODK3+Rk5Y56JGDk+5Pkd3HuLqeSBo/POaZlZ7+uiwuYJhOd10XEJPKIzeOe13Bu/QAV3zbmXy2Gfe6b69h0WD7yMNKDI/kRquq1KrdGr/8Vhok1/Q5VlhcJcUOVo8jsSSs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 5 Dec 2023 19:34:40 +0800 Yunsheng Lin wrote: > __GFP_DIRECT_RECLAIM is xor'd to avoid > direct reclaim in skb_page_frag_refill(), but it is not > xor'd in __page_frag_cache_refill(). xor is not the same thing as masking a bit off. The patch itself LGTM.