From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8976C4167B for ; Wed, 6 Dec 2023 19:13:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 184D16B0071; Wed, 6 Dec 2023 14:13:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 10EBF6B0075; Wed, 6 Dec 2023 14:13:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F168E6B0078; Wed, 6 Dec 2023 14:13:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DDA0F6B0071 for ; Wed, 6 Dec 2023 14:13:57 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8B122140236 for ; Wed, 6 Dec 2023 19:13:57 +0000 (UTC) X-FDA: 81537343314.10.0FF83C7 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by imf22.hostedemail.com (Postfix) with ESMTP id 7F07CC001A for ; Wed, 6 Dec 2023 19:13:55 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=BNDnEkV+; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701890035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aQlIzioB/NXQ5qBnXhi85XEv3cm+9ys274pnHM2/1Jg=; b=3p+uiXqPLEgcyqvqwHKmFVBADcdEShjxddyhw82KDHIA533U3hmOsXDWM3mmRAyXmccQuq jtvPtm7BaK5/vVo4tp+GoVqhKd/NNuPXWhGCmK8UbBIuefO5Bq2AEKoEJX6LySny/pmK6w NQs16ZD4DhOT1w3bc+meL4fdbiLG/YU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=BNDnEkV+; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701890035; a=rsa-sha256; cv=none; b=Nnm8cxzY6xcLsg5UJuwXcuQPaSxXujAH+e8e7hjXTkypUc2EnppZxz3YyFemII9mvy4aBl JonXi09ftK+emjtc3NWNlfc4Y9ac/1Py4UI4uYUf9MvaTkpb8yoWavZf5lu7aEaHDNaxi9 YN4Rewpnj21WwqnC1UMX80KyNd8YZjc= Date: Wed, 6 Dec 2023 14:13:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1701890033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aQlIzioB/NXQ5qBnXhi85XEv3cm+9ys274pnHM2/1Jg=; b=BNDnEkV+1sMya0F/B4bmg/yD0HnFaLSKKcZDsYMka3CyS5M9ffOsfxIo8H2/Bd1mtJVTXk IOm9asmccJ+vXO7OqdIo9cwX/02GM9D398nfToOX0/c17JhWRjK2MgwuD08EtQKCEgzgmf ez8Q6G0jtQnSoL9WKK3vQ3zKZx7K7yc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Dave Chinner Cc: Roman Gushchin , Qi Zheng , Michal Hocko , Muchun Song , Linux-MM , linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH 2/7] mm: shrinker: Add a .to_text() method for shrinkers Message-ID: <20231206191349.x52nm3ercxelh3dx@moria.home.lan> References: <20231129231147.7msiocerq7phxnyu@moria.home.lan> <04f63966-af72-43ef-a65c-ff927064a3e4@bytedance.com> <20231130032149.ynap4ai47dj62fy3@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7F07CC001A X-Stat-Signature: 8rowjeb5bxr8thhou44wn4ti8ck1w53x X-Rspam-User: X-HE-Tag: 1701890035-903706 X-HE-Meta: U2FsdGVkX1/0uxvbqzF8pzsYC14B5joNy4zHKLCVdRsB+Gc2iacNyZ9OeVtZU0tb8jcTxrQE7ZcB4QT6fzPB2jhJcUON/lb3lKaDBj+iBj7dmeHNyhnm/Z1tzZDTDh0EqYzeLjzUJCnrCrqLXeE43fuijbB49hNdynufAHLk9xlK6NVm0TILyUO4khEV3pM8E6P+2vHWMRV2udUtgdy+YL+jCLU2ZEabfuGEXBZe7cut4tRfGwdMTafluBe8jgxTiXQXwKG+Nl7Qco5snLQxfn6ayqfKLtjjq57WpvOCLDT5J7gR0R+l22OxnUCO2CILMmzCwuRVL6R/91nk3fntq+IV6k52iLb2wqUMjCQNT+bPBGfNTMZigd/fIySUzwGE4VlmnMEmx4AlRakevXO/H+TWmQg6IRqcm/jD2ggPFzTh1A0rTiN0DILUE9+LwOZEL0WpcsKHfWuzkNXzcV72IhaEF1N+oVh2UtmEQFrNMIA93ii3JsngNiP3AQP+fMLaaqIJhz52KPFLLUzT/dsxJHuDN2ti+/7abxmdGe0bOKTRsNyhF/gmT14cxXjrFUtNTAbI86L1SaSTDgF5g5g0Cm1tMp2p3Ol7yjXXwjQtk+fYVijW7Cz10lZyKFTa/nP8uhsdujetyxyWrjM7I/SXl0PKwcpYzOXH5kVNm0sU/r40ZD0whq7GnYOAxg2K+/FqvWcLLFNV6Msfvw+EjcinWmI/GgmrnI6FyRC/w5m6hRX9B9b2UtGb/MqLiYpF4pomLcCxwnvrgNA3mZWm2rvKSZp1UDf5PQ072s9BL44BmNyUw8wUzcnsRr98UZQh98aISY7ysNpBwHbyee0h+x7vhBP9VBK1iY0VyxJdbfN3Wj6k2W7H6aRJShh3hHKei03Fl00oXademkpsNArhYTuDs3r6PEI1NMtsvFTUYh5KG0UjEeYxy7FGqSWHPlP8NHCjA6S9jJO838HJ4dS8QC3 vbdJ/in4 dYqiHQ2EyzRPQsGpg9tpe+RSWNnZ2uL8EUWtrfG+5V2buLo8u7liUngGlWsoRpi7qVRTW4AxK4WfKPGFX3GsUnqzwJ3uupAGwWdKH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 06, 2023 at 07:16:04PM +1100, Dave Chinner wrote: > On Fri, Dec 01, 2023 at 12:01:33PM -0800, Roman Gushchin wrote: > > What would be the proper solution to this problem from your point of view? > > What functionality/API mm can provide to make the life of fs developers > > better here? > > What can we do better? > > The first thing we can do better that comes to mind is to merge > Kent's patches that allow the shrinker owner to output debug > information when requested by the infrastructure. > > Then we - the shrinker implementers - have some control of our own > destiny. We can add whatever we need to solve shrinker and OOM > problems realted to our shrinkers not doing the right thing. > > But without that callout from the infrastructure and the > infrastructure to drive it at appropriate times, we will make zero > progress improving the situation. > > Yes, the code may not be perfect and, yes, it may not be useful to > mm developers, but for the people who have to debug shrinker related > problems in production systems we need all the help we can get. We > certainly don't care if it isn't perfect, just having something we > can partially tailor to our iindividual needs is far, far better > than the current situation of nothing at all... Of course if mm people don't want it I've got better things to do than fight uphill battles just to get some reviewed-by tags. Real high quality review feedback in this thread.